github-actions[bot] merged PR #2388:
URL: https://github.com/apache/logging-log4j2/pull/2388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
fluffynuts commented on PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#issuecomment-2003723969
lgtm, tho I'm no docker expert, so as long as it works, which I assume it
does (I'm nowhere near a PC rn), then I give it 👍👍
--
This is an automated message from the Apache Git
jengebr commented on PR #2330:
URL: https://github.com/apache/logging-log4j2/pull/2330#issuecomment-2003953702
Thank you for your encouragement! I hope this helps other as much as it'll
help us.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
FreeAndNil commented on code in PR #126:
URL: https://github.com/apache/logging-log4net/pull/126#discussion_r1528410182
##
src/log4net/Core/LoggingEvent.cs:
##
@@ -840,44 +800,41 @@ private string TryGetCurrentUserName()
}
}
-private string _cachedWindowsIdenti
rocketraman commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004426105
> Again, I don't understand. ScopedContext IS a builder.
Its a builder for the context. I was talking about a builder for the logger.
The thread that @ppkarwasz s
rgoers commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004436472
OK. Personally, I see little value in adding context data to a logger. That
simply wouldn't fit with any use cases I work with. However, it might if
Logger names were more
rocketraman commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004452537
> OK. Personally, I see little value in adding context data to a logger.
That simply wouldn't fit with any use cases I work with. However, it might if
Logger names were
rgoers commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004657515
@rocketraman I understand your example but I am not sure how it works in
practice. I have to presume that the Connection class can operate on multiple
Connection instances.
rocketraman commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004683273
> I understand your example but I am not sure how it works in practice. I
have to presume that the Connection class can operate on multiple Connection
instances. A Logg
FreeAndNil commented on code in PR #126:
URL: https://github.com/apache/logging-log4net/pull/126#discussion_r1529138434
##
src/log4net/Core/LoggingEvent.cs:
##
@@ -826,11 +825,10 @@ private static string TryReadWindowsIdentityUserName()
{
try
{
-
FreeAndNil commented on PR #126:
URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2004768377
> Also note that to avoid a double-indirection it would be ideal to change
both to structs.
@erikmav can you explain how you would implement this? Maybe as separate
issue?
erikmav commented on PR #126:
URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2005755352
Could be done under another issue. The change is to change from class to
struct (or readonly struct, depending) for ReadOnlyPropertiesDictionary, then
derive PropertiesDictionary fr
garydgregory commented on PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#issuecomment-2006051680
Hi all,
The "where" API name is a terrible IMO. The Javadoc stays that the method
"Adds ..." so why not call it that? The method delegates to an "add..." method.
The pa
tonycody opened a new issue, #2389:
URL: https://github.com/apache/logging-log4j2/issues/2389
org.apache.logging.log4j.core.appender.nosql.NoSqlConnection#createObject
This interface method, currently does not pass down the LogEvent from
NoSqlDatabaseManager, and in practice, certain
grobmeier closed issue #1954: [MS9] Schema and documentation generation from
source code
URL: https://github.com/apache/logging-log4j2/issues/1954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
grobmeier commented on issue #1954:
URL:
https://github.com/apache/logging-log4j2/issues/1954#issuecomment-2006326517
Looks good to me, thanks for all the hard work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vy opened a new issue, #139:
URL: https://github.com/apache/logging-parent/issues/139
Currently, reusable workflows upload the distribution to ``
folder. This is problematic when a project wants to do multiple releases
simultaneously, e.g., Log4j 2 and Log4j 3. Upload the distribution to
`
ppkarwasz opened a new issue, #140:
URL: https://github.com/apache/logging-parent/issues/140
While we don't check test coverage very often, it is sometimes useful to
generate a coverage report, when evaluating PRs.
--
This is an automated message from the Apache Git Service.
To respond to
ppkarwasz opened a new pull request, #141:
URL: https://github.com/apache/logging-parent/pull/141
We add a `coverage` Maven profile that can be used whenever we need test
coverage data.
**Remark**: Due to the somehow strange order of the ``
children, I reordered it alphabetically.
vy commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530070505
##
package.json:
##
Review Comment:
Doesn't `repository.url` need to be updated in this file?
##
Dockerfile:
##
@@ -0,0 +1,35 @@
+# Licensed to
dependabot[bot] opened a new pull request, #142:
URL: https://github.com/apache/logging-parent/pull/142
Bumps [github/codeql-action](https://github.com/github/codeql-action) from
3.24.7 to 3.24.8.
Changelog
Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md
github-actions[bot] merged PR #142:
URL: https://github.com/apache/logging-parent/pull/142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
tonycody opened a new pull request, #2391:
URL: https://github.com/apache/logging-log4j2/pull/2391
[A clear and concise description of what the pull request is for along with
a reference to the associated issue IDs, if they exist.]
## Checklist
* Base your changes on `2.x` bran
garydgregory commented on PR #2391:
URL: https://github.com/apache/logging-log4j2/pull/2391#issuecomment-2006805175
Hello @tonycody
This PR is missing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
tonycody commented on PR #2391:
URL: https://github.com/apache/logging-log4j2/pull/2391#issuecomment-2006810557
> Hello @tonycody This PR is missing unit tests.
Okay, I'll fill it in later.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
tonycody commented on PR #2391:
URL: https://github.com/apache/logging-log4j2/pull/2391#issuecomment-2006852184
@garydgregory Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
FreeAndNil commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530151594
##
package.json:
##
Review Comment:
Good point. Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
FreeAndNil commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530152161
##
Dockerfile:
##
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE fil
github-actions[bot] merged PR #2390:
URL: https://github.com/apache/logging-log4j2/pull/2390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
ppkarwasz commented on code in PR #2374:
URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1530265806
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java:
##
@@ -20,39 +20,135 @@
import java.net.URL;
import java.util.Properties;
import org.
ppkarwasz commented on code in PR #2374:
URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1530267750
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java:
##
@@ -97,127 +217,266 @@ public String getVersions() {
/**
* Gets the prio
ppkarwasz commented on code in PR #2374:
URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1530270173
##
log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java:
##
@@ -163,6 +172,88 @@ static void lazyInit() {
}
}
+/**
+
ppkarwasz opened a new pull request, #2392:
URL: https://github.com/apache/logging-log4j2/pull/2392
We move some features found in the `main` branch of `log4j-api` back to
`2.x`:
- It adds a `ServiceLoaderUtil#safeStream` method that takes an instance of
`ServiceLoader` as a paramete
ppkarwasz commented on PR #2392:
URL: https://github.com/apache/logging-log4j2/pull/2392#issuecomment-2007217633
As a curiosity, when working with GraalVM and either `log4j-to-jul` or
`log4j-to-slf4j` (i.e. **without** Log4j Core) I get this nice warning from
GraalVM:
```
Warning: The
SeasonPanPan opened a new pull request, #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393
Fix issue #2380: Log messages with insufficient parameters should not throw
exception.
In this PR, I modified the class
`org.apache.logging.log4j.message.ParameterFormatter`.
I d
ppkarwasz commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1530679565
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java:
##
@@ -240,14 +240,6 @@ static void formatMessage(
return;
ppkarwasz commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1530679565
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java:
##
@@ -240,14 +240,6 @@ static void formatMessage(
return;
dependabot[bot] opened a new pull request, #131:
URL: https://github.com/apache/logging-log4j-audit/pull/131
Bumps io.swagger:swagger-annotations from 1.6.13 to 1.6.14.
[ cannot convert `{@link
Encoder Encoder}` Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message
vy commented on issue #2383:
URL:
https://github.com/apache/logging-log4j2/issues/2383#issuecomment-2009086859
I would be in favor of creating a new `log4j-config-xml` module. A very big
part of our users use `log4j2.yaml` and `log4j2.properties`. When they migrate
to Log4j 3, they will di
leaner1000 opened a new issue, #2395:
URL: https://github.com/apache/logging-log4j2/issues/2395
## Description
The open flag of the log file changes after log dumping, because the
"append" parameter in the code is fixed to false instead of the actual
configuration value, which may ca
github-actions[bot] merged PR #2394:
URL: https://github.com/apache/logging-log4j2/pull/2394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
ppkarwasz closed issue #2395: The log file opening flag changed after the log
was rotated.
URL: https://github.com/apache/logging-log4j2/issues/2395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ppkarwasz commented on issue #2395:
URL:
https://github.com/apache/logging-log4j2/issues/2395#issuecomment-2009487454
@leaner1000,
Log4j 1.2 has reached end-of-life in 2015 (see
[announcement](https://news.apache.org/foundation/entry/apache_logging_services_project_announces)).
vy commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1531758006
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
vy commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009704798
@tonycody, the request sounds legit to me. Would you mind providing a bit
more context, please?
1. Which Log4j version are you using?
2. Which appender are you using? (If it
ppkarwasz merged PR #2366:
URL: https://github.com/apache/logging-log4j2/pull/2366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz commented on PR #2366:
URL: https://github.com/apache/logging-log4j2/pull/2366#issuecomment-2009724271
@jvz,
I am closing this as "partially reviewed", but I am waiting patiently to
replace the 3 fully-fledged and configured `InstanceFactory`s with a nifty use
of scopes.
vy commented on code in PR #2391:
URL: https://github.com/apache/logging-log4j2/pull/2391#discussion_r1532199636
##
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/nosql/NoSqlDatabaseManagerTest.java:
##
@@ -143,6 +143,7 @@ public void testWriteInternal01()
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009739402
> @tonycody, the request sounds legit to me. Would you mind providing a bit
more context, please?
>
> 1. Which Log4j version are you using?
> 2. Which appender are
SeasonPanPan commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1532212085
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java:
##
@@ -240,14 +240,6 @@ static void formatMessage(
return;
vy commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009763272
> I'm implementing a NoSqlConnection where the received data is written to
Redis. I need the original thrown object so that I can use
java.lang.Throwable#printStackTrace(java.io.P
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009772986
> > I'm implementing a NoSqlConnection where the received data is written to
Redis. I need the original thrown object so that I can use
java.lang.Throwable#printStackTrace(j
vy commented on code in PR #2392:
URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1532245841
##
log4j-api/pom.xml:
##
@@ -36,6 +36,10 @@
true
org.apache.logging.log4j
+
+
+ !sun.reflect
+
Review Comment:
Has this problem
vy commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009826857
I am not keen on adding new methods based on speculative functionality.
Could you give a more concrete example demonstrating without a new
`insertObject(LogEvent,Entity)`, it is r
vy commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1532298634
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java:
##
@@ -240,14 +240,6 @@ static void formatMessage(
return;
FreeAndNil merged PR #126:
URL: https://github.com/apache/logging-log4net/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
erikmav opened a new pull request, #129:
URL: https://github.com/apache/logging-log4net/pull/129
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
erikmav commented on PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#issuecomment-200492
For #124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011260228
> I am not keen on adding new methods based on speculative functionality.
Could you give a more concrete example demonstrating without a new
`insertObject(LogEvent,Entity)`,
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011270792
@vy
e.g.
```java
@Override
public void insertObject(LogEvent event, NoSqlObject> object) {
LogMetaData logMeta=
LogMapper.INSTANCE.mapping(build
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533310760
##
log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java:
##
@@ -0,0 +1,264 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011325316
@vy I looked at the log4j redis Appender mentioned above, and it's actually
a different scenario. The implementation mentioned above is based on Appender,
which also uses Lo
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
ppkarwasz commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011610932
@tonycody,
I think we hit an [XY problem](https://en.wikipedia.org/wiki/XY_problem) in
this discussion. Could you explain plainly (without technical details) what are
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011629770
> @tonycody,
>
> I think we hit an [XY problem](https://en.wikipedia.org/wiki/XY_problem)
in this discussion. Could you explain plainly (without technical details) wha
ppkarwasz commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011689567
> My scenario is to write the stack information resolved by the method
java.lang.Throwable#lockedPrintStackTrace to the NoSql data source. Therefore,
I need to get the Thro
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011722823
> > My scenario is to write the stack information resolved by the method
java.lang.Throwable#lockedPrintStackTrace to the NoSql data source. Therefore,
I need to get the Thr
ppkarwasz commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011855640
> We have considered this scenario, but this scenario means that the user
must use a custom Layout! Essentially, adding LogEvent to an interface or
NoSqlObject to be passed
ppkarwasz commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533621077
##
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
vy commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533763183
##
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
}
-
vy commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533763183
##
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
}
-
SeasonPanPan commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533870019
##
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
FreeAndNil commented on code in PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1532722957
##
src/log4net/Appender/AppenderCollection.cs:
##
@@ -292,8 +234,11 @@ public virtual void Clear()
/// A new with a shallow copy of
the collection data.
jvz commented on PR #2366:
URL: https://github.com/apache/logging-log4j2/pull/2366#issuecomment-2013112488
Sounds good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
erikmav commented on code in PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534403615
##
src/log4net/Appender/BufferingAppenderSkeleton.cs:
##
@@ -459,59 +411,59 @@ protected override void Append(LoggingEvent loggingEvent)
// sent immediatel
erikmav commented on code in PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534412278
##
src/log4net/Core/LogImpl.cs:
##
@@ -247,7 +241,7 @@ public virtual void DebugFormat(string format, object arg0)
{
if (IsDebugEnabled)
{
-
erikmav commented on code in PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534448073
##
src/log4net/DateFormatter/AbsoluteTimeDateFormatter.cs:
##
@@ -95,78 +87,52 @@ protected virtual void FormatDateWithoutMillis(DateTime
dateToFormat, StringBui
dependabot[bot] opened a new pull request, #27:
URL: https://github.com/apache/logging-chainsaw/pull/27
Bumps org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1.
[