dependabot[bot] closed pull request #435:
URL: https://github.com/apache/logging-log4j2/pull/435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] commented on pull request #435:
URL: https://github.com/apache/logging-log4j2/pull/435#issuecomment-727726518
Superseded by #439.
This is an automated message from the Apache Git Service.
To respond to the mes
vy commented on pull request #438:
URL: https://github.com/apache/logging-log4j2/pull/438#issuecomment-728330749
I agree with @garydgregory here. @annakukliansky, would you share your use
case, please? If you elaborate on what you are trying to achieve, maybe we can
point to a better alter
pm-cfs opened a new pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43
# Summary
Previously we either ACCEPTed or DENYed any log when this filter was
present. This configuration prevented proper filter chaining.
# Changes
* Update mapfilter to return NEUTR
valfirst opened a new pull request #440:
URL: https://github.com/apache/logging-log4j2/pull/440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
vy opened a new pull request #441:
URL: https://github.com/apache/logging-log4j2/pull/441
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rm5248 commented on pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729248642
This looks good to me. I'll merge shortly unless @ams-tschoening has any
comments?
Unrelated note: would you be able to create some documentation on how to use
the fi
pm-cfs commented on pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729249354
Certainly. I was thinking about that too. I'll have a look at similar
documentation, but if you know of anything similar off the top of your
head, please feel free to dir
rm5248 commented on pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729254947
The Log4j2 documentation would probably be the best place to start:
http://logging.apache.org/log4j/2.x/manual/filters.html
-
dependabot[bot] closed pull request #432:
URL: https://github.com/apache/logging-log4j2/pull/432
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] commented on pull request #432:
URL: https://github.com/apache/logging-log4j2/pull/432#issuecomment-729392409
Superseded by #442.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] opened a new pull request #442:
URL: https://github.com/apache/logging-log4j2/pull/442
Bumps tomcat-catalina from 8.5.20 to 9.0.40.
[,
some `filters.md` there might be a good idea. OTOH, depen
rm5248 merged pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rm5248 opened a new pull request #44:
URL: https://github.com/apache/logging-log4cxx/pull/44
Fix the github actions to work
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rm5248 merged pull request #44:
URL: https://github.com/apache/logging-log4cxx/pull/44
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
carterkozak commented on a change in pull request #441:
URL: https://github.com/apache/logging-log4j2/pull/441#discussion_r527706889
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/ReadOnlyStringMapResolver.java
##
rschmitt commented on pull request #392:
URL: https://github.com/apache/logging-log4j2/pull/392#issuecomment-731450681
Pinging this.
This is an automated message from the Apache Git Service.
To respond to the message, please
vy commented on a change in pull request #441:
URL: https://github.com/apache/logging-log4j2/pull/441#discussion_r529608968
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/ReadOnlyStringMapResolver.java
##
@@ -0,0 +
vy merged pull request #441:
URL: https://github.com/apache/logging-log4j2/pull/441
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sullis opened a new pull request #4:
URL: https://github.com/apache/logging-log4j-scala/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
carterkozak opened a new pull request #443:
URL: https://github.com/apache/logging-log4j2/pull/443
When messages don't contain enough parameters, index-based lookups
result in a JSON null token rather than failing to produce a log event.
This change also modifies behavior of non-in
carterkozak commented on pull request #443:
URL: https://github.com/apache/logging-log4j2/pull/443#issuecomment-735411858
@vy I'd appreciate your review on this at your convenience :-)
This is an automated message from the Ap
carterkozak opened a new pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444
09e1bae: Avoids allocating new string objects when parameters are formatted,
preferring to use the existing StringBuilder instance.
38b9650: Remove JsonWriter.formattableBuffer in favor
carterkozak commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532231594
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMessage.java
##
@@ -302,6 +302,10 @@ public static String de
carterkozak commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532231767
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/util/JsonWriter.java
##
@@ -572,6 +565,10 @
carterkozak commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532231934
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/util/JsonWriter.java
##
@@ -513,18 +509,15
carterkozak commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532232183
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/ReadOnlyStringMapResolver.java
##
vy merged pull request #443:
URL: https://github.com/apache/logging-log4j2/pull/443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy commented on pull request #443:
URL: https://github.com/apache/logging-log4j2/pull/443#issuecomment-735649229
@carterkozak Great catch with a complete fix! Thanks so much for sparing
time!
This is an automated message fro
vy commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532441454
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMessage.java
##
@@ -302,6 +302,10 @@ public static String deepToStrin
vy commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532463534
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/util/JsonWriter.java
##
@@ -493,18 +492,15 @@ public
vy commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532463858
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/util/JsonWriter.java
##
@@ -513,18 +509,15 @@ public
vy commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532469418
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/util/JsonWriter.java
##
@@ -572,6 +565,10 @@ public
vy commented on pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#issuecomment-735686828
First and foremost, thanks so much @carterkozak for reviewing the changes
and thinking along for improvements. I have really appreciated them.
`ParameterizedMessage.deepTo
carterkozak commented on pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#issuecomment-735789644
> Even though I was the one who started using
ParameterizedMessage.deepToString(), thinking about it again, I am not happy
with the end result. This breaks the self-con
carterkozak commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532609807
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/util/JsonWriter.java
##
@@ -493,18 +492,15
carterkozak commented on a change in pull request #444:
URL: https://github.com/apache/logging-log4j2/pull/444#discussion_r532612187
##
File path:
log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/util/JsonWriter.java
##
@@ -572,6 +565,10 @
rm5248 opened a new pull request #45:
URL: https://github.com/apache/logging-log4cxx/pull/45
…ories
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ams-tschoening commented on a change in pull request #45:
URL: https://github.com/apache/logging-log4cxx/pull/45#discussion_r533962761
##
File path: src/main/cpp/rollingfileappender.cpp
##
@@ -340,11 +340,13 @@ bool RollingFileAppenderSkeleton::rollover(Pool& p)
rm5248 merged pull request #45:
URL: https://github.com/apache/logging-log4cxx/pull/45
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sullis opened a new pull request #445:
URL: https://github.com/apache/logging-log4j2/pull/445
slf4j 1.7.30 was released in December 2019
https://github.com/qos-ch/slf4j/releases
This is an automated message from th
sullis opened a new pull request #446:
URL: https://github.com/apache/logging-log4j2/pull/446
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rgoers commented on pull request #445:
URL: https://github.com/apache/logging-log4j2/pull/445#issuecomment-739534428
Updating the parent pom version is insufficient. Log4j-slf4j-impl provides
support for the EventData object that was removed in SLF4J 1.7.25.
Log4j-slf4j-impl also specifies
NicholasNoise opened a new pull request #71:
URL: https://github.com/apache/logging-log4net/pull/71
Using npgsql on netfx and mono I've encountered this error on an applicaiton
startup:
```
log4net:ERROR [CustomAdoNetAppender] ErrorCode: GenericFailure. Exception
while writing to dat
NicholasNoise commented on pull request #71:
URL: https://github.com/apache/logging-log4net/pull/71#issuecomment-739967799
@fluffynuts
At a look please.
This is an automated message from the Apache Git Service.
To respond
carterkozak opened a new pull request #447:
URL: https://github.com/apache/logging-log4j2/pull/447
```
"jul-logger" Id=23 RUNNABLE
at
app//com.lmax.disruptor.dsl.ExceptionHandlerWrapper.(ExceptionHandlerWrapper.java:8)
at app//com.lmax.disruptor.dsl.Disruptor.(Disruptor.j
fluffynuts commented on a change in pull request #71:
URL: https://github.com/apache/logging-log4net/pull/71#discussion_r538061769
##
File path: src/log4net/Appender/AdoNetAppender.cs
##
@@ -553,8 +553,17 @@ protected virtual void SendBuffer(IDbTransaction dbTran,
LoggingEvent
NicholasNoise commented on a change in pull request #71:
URL: https://github.com/apache/logging-log4net/pull/71#discussion_r538174819
##
File path: src/log4net/Appender/AdoNetAppender.cs
##
@@ -553,8 +553,17 @@ protected virtual void SendBuffer(IDbTransaction dbTran,
LoggingEv
fluffynuts merged pull request #71:
URL: https://github.com/apache/logging-log4net/pull/71
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dependabot[bot] commented on pull request #442:
URL: https://github.com/apache/logging-log4j2/pull/442#issuecomment-741514826
Superseded by #448.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] opened a new pull request #448:
URL: https://github.com/apache/logging-log4j2/pull/448
Bumps tomcat-catalina from 8.5.20 to 10.0.0.
[
rgoers commented on pull request #10:
URL: https://github.com/apache/logging-log4php/pull/10#issuecomment-748415268
Closing since this is very old, there are conflicts, and project is now
dormant.
This is an automated messag
rgoers closed pull request #10:
URL: https://github.com/apache/logging-log4php/pull/10
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers closed pull request #15:
URL: https://github.com/apache/logging-log4php/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers commented on pull request #15:
URL: https://github.com/apache/logging-log4php/pull/15#issuecomment-748415436
Closing due to previous comments, conflicts, and the fact that this project
is now dormant.
This is an autom
mikaello opened a new pull request #14:
URL: https://github.com/apache/logging-log4j-kotlin/pull/14
I am using this library in my application, but it prevents me from upgrading
to v1.4 since this library includes Kotlin 1.3.72. I can force my application
to use Kotlin stdlib 1.3, but then
mikaello commented on a change in pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#discussion_r546624688
##
File path:
log4j-api-kotlin/src/test/kotlin/org.apache.logging.log4j.kotlin/LoggerTest.kt
##
@@ -173,7 +173,8 @@ class LoggerTest {
fun
mikaello commented on a change in pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#discussion_r546624688
##
File path:
log4j-api-kotlin/src/test/kotlin/org.apache.logging.log4j.kotlin/LoggerTest.kt
##
@@ -173,7 +173,8 @@ class LoggerTest {
fun
rocketraman commented on a change in pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#discussion_r546721176
##
File path:
log4j-api-kotlin/src/test/kotlin/org.apache.logging.log4j.kotlin/LoggerTest.kt
##
@@ -173,7 +173,8 @@ class LoggerTest {
f
dependabot[bot] opened a new pull request #449:
URL: https://github.com/apache/logging-log4j2/pull/449
Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.6.2 to 2.8.2.
Release notes
Sourced from https://github.com/xmlunit/xmlunit/releases";>xmlunit-core's
releases.
dependabot[bot] commented on pull request #439:
URL: https://github.com/apache/logging-log4j2/pull/439#issuecomment-749328184
Superseded by #449.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] closed pull request #439:
URL: https://github.com/apache/logging-log4j2/pull/439
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mikaello commented on pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#issuecomment-749392389
@rocketraman Thanks a lot for the thorough answer. And sorry for my comment
on missing issue tracker, you even had a separate section about it in the
Readme, my bad.
rocketraman commented on pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#issuecomment-749624621
> I think your summary indicating that this project should be on 1.3 and
instead avoid distributing stdlib as a transitive dependency sounds like a
reasonable solu
quaff opened a new pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450
It's worth to add a section in manual, I've struggled this problem.
This is an automated message from the Apache Git Service.
To res
garydgregory commented on a change in pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450#discussion_r548530023
##
File path: src/site/asciidoc/manual/configuration.adoc
##
@@ -1146,6 +1146,13 @@ included, such as ``${main:\--file:-app.properties}`.
This
garydgregory commented on a change in pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450#discussion_r548530325
##
File path: src/site/asciidoc/manual/configuration.adoc
##
@@ -1146,6 +1146,13 @@ included, such as ``${main:\--file:-app.properties}`.
This
garydgregory commented on a change in pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450#discussion_r548530654
##
File path: src/site/asciidoc/manual/configuration.adoc
##
@@ -1146,6 +1146,13 @@ included, such as ``${main:\--file:-app.properties}`.
This
quaff commented on a change in pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450#discussion_r548769465
##
File path: src/site/asciidoc/manual/configuration.adoc
##
@@ -1146,6 +1146,13 @@ included, such as ``${main:\--file:-app.properties}`.
This would u
rm5248 opened a new pull request #46:
URL: https://github.com/apache/logging-log4cxx/pull/46
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Marcono1234 opened a new pull request #451:
URL: https://github.com/apache/logging-log4j2/pull/451
Commit 2e9fdc135545eee435cad14ee9d74101c93694be added the unbound return
type to allow easier usage with `MessageFactory2`. However, an unbound return
type causes loss of type safety: You cou
garydgregory commented on pull request #451:
URL: https://github.com/apache/logging-log4j2/pull/451#issuecomment-751418152
This will break source compatibility though.
This is an automated message from the Apache Git Service.
ams-tschoening commented on a change in pull request #46:
URL: https://github.com/apache/logging-log4cxx/pull/46#discussion_r549115000
##
File path: src/main/include/log4cxx/net/syslogappender.h
##
@@ -136,6 +148,16 @@ class LOG4CXX_EXPORT SyslogAppender : public
AppenderSkele
Marcono1234 commented on pull request #451:
URL: https://github.com/apache/logging-log4j2/pull/451#issuecomment-751478321
Hm, yes you are right. Do you think this might be acceptable, or is that not
worth it?
I have
[commented](https://issues.apache.org/jira/browse/LOG4J2-1418?focus
garydgregory commented on pull request #451:
URL: https://github.com/apache/logging-log4j2/pull/451#issuecomment-751484571
IMO I'm not sure it's worth mentioning because this is actually a Java
feature and can you can say that any method is 'not type-safe' if it is
declared in the patten `
rm5248 commented on a change in pull request #46:
URL: https://github.com/apache/logging-log4cxx/pull/46#discussion_r549130252
##
File path: src/main/include/log4cxx/net/syslogappender.h
##
@@ -136,6 +148,16 @@ class LOG4CXX_EXPORT SyslogAppender : public
AppenderSkeleton
Marcono1234 commented on pull request #451:
URL: https://github.com/apache/logging-log4j2/pull/451#issuecomment-751490879
> and you can say that any method is 'not type-safe' if it is declared in
the patten ` T foo()`.
And I will say this 😄
Though to clarify, the issue I am having
Marcono1234 edited a comment on pull request #451:
URL: https://github.com/apache/logging-log4j2/pull/451#issuecomment-751490879
> and you can say that any method is 'not type-safe' if it is declared in
the patten ` T foo()`.
And I will say this 😄
Though to clarify, the issue I am
rm5248 merged pull request #46:
URL: https://github.com/apache/logging-log4cxx/pull/46
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers commented on pull request #451:
URL: https://github.com/apache/logging-log4j2/pull/451#issuecomment-751842131
This is a patch against master (what will be Log4j 2 3.0.0). MessageFactory2
really should be removed from master since it is no longer needed. I don't have
a problem with c
vy opened a new pull request #452:
URL: https://github.com/apache/logging-log4j2/pull/452
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rm5248 opened a new pull request #47:
URL: https://github.com/apache/logging-log4cxx/pull/47
Missed a build failure on Windows
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rm5248 opened a new pull request #48:
URL: https://github.com/apache/logging-log4cxx/pull/48
Fixed Github actions after ASF policy change on 2020-12-27
This is an automated message from the Apache Git Service.
To respond to t
ronosaurus opened a new pull request #453:
URL: https://github.com/apache/logging-log4j2/pull/453
My first pull request to log4j2 to fix an outdated PatternLayout.create*
method in a code example for LOG4J2-2977
Pull request is against _master_ because _release-2.x_'s
logging-log4j2
rgoers commented on pull request #453:
URL: https://github.com/apache/logging-log4j2/pull/453#issuecomment-751965548
The website documentation all comes from release-2.x. Most of the manual in
2.x is in markdown. It was converted to asciidoc for 3.0, although some had to
be left in markdow
remkop commented on pull request #453:
URL: https://github.com/apache/logging-log4j2/pull/453#issuecomment-751966476
Really? Interesting, I thought AsciiDoc had (a lot) more features than
Markdown.
This is an automated mess
rm5248 merged pull request #47:
URL: https://github.com/apache/logging-log4cxx/pull/47
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ronosaurus commented on pull request #453:
URL: https://github.com/apache/logging-log4j2/pull/453#issuecomment-752150330
I found a customconfig file in the release-2.x branch:
-
https://github.com/apache/logging-log4j2/blob/release-2.x/src/site/xdoc/manual/customconfig.xml#L270
-
carterkozak commented on pull request #452:
URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-752151311
I think the only way this can happen is if someone calls
[Thread.stop()](https://docs.oracle.com/javase/8/docs/api/java/lang/Thread.html#stop--),
so we must consider th
rm5248 merged pull request #48:
URL: https://github.com/apache/logging-log4cxx/pull/48
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vy commented on pull request #452:
URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-752224064
> I think the only way this can happen is if someone calls
[Thread.stop()](https://docs.oracle.com/javase/8/docs/api/java/lang/Thread.html#stop--),
so we must consider the inten
carterkozak commented on pull request #452:
URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-752246841
> The major improvement this change set brings is that there are no smart
whitelist of failures that are subject to handling.
The downside is when an error is rai
vy opened a new pull request #454:
URL: https://github.com/apache/logging-log4j2/pull/454
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vy commented on pull request #452:
URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-752257307
> The downside is when an error is raised, we pay the full cost of thread
creation and context switching rather than catching and continuing.
Correct. Though note that thi
carterkozak commented on pull request #452:
URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-752268188
> Then the hell broke loose.
I don't think it's that bad! We fixed a problem for some users, and caused
an issue for others. I'd consider the behavior in 2.14 an
801 - 900 of 7264 matches
Mail list logo
