ffontaine commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-698737347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
wuqian0808 commented on pull request #426:
URL: https://github.com/apache/logging-log4j2/pull/426#issuecomment-698701854
During reconfigure, LoggerContext will start new configuration and stop
previous configuration. The firstime, prev is DefaultConfiguration, new
configuration is eg: XmlC
gengyuanzhe commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-698385158
I tried your case, and you are right, the KafkaAppender do have the problem
of thead leak. But **close when startup** is not the correct way to solve this
problem. Try
wuqian0808 closed pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
rm5248 commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-698666494
Shouldn't this also #ifdef out the function signature in the .h file? Or
would it make more sense to have the method implementation be just a stub? I'm
thinking that you co
wuqian0808 commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-698675698
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ams-tschoening commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-698767348
How does keeping `encode` as a no-op make sense here? Either it's called,
then making it a no-op breaks on runtime only or it's not, then itself should
be `#ifdef`ed
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-699035185
> There is no problem at all, I've saw insides of how-to-release-project -
is not that simple as it looks.
yeah, I need to update that too, because quite a bit of h
rm5248 edited a comment on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-699201041
> How does keeping `encode` as a no-op make sense here? Either it's called,
then making it a no-op breaks on runtime only or it's not, then itself should
be `#ifdef`ed
rm5248 commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-699201041
> How does keeping `encode` as a no-op make sense here? Either it's called,
then making it a no-op breaks on runtime only or it's not, then itself should
be `#ifdef`ed in my
diepet commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-699548443
Hi, I am aware of this development after open this Jira issue:
[LOG4J2-2936](https://issues.apache.org/jira/browse/LOG4J2-2936)
Please, could you tell me:
1) Wh
diepet edited a comment on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-699548443
Hi, I was aware of this new exciting feature only after open this Jira
issue: [LOG4J2-2936](https://issues.apache.org/jira/browse/LOG4J2-2936)
Please, could you
diepet edited a comment on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-699548443
Hi, I was aware of this new exciting feature only after open this Jira
issue: [LOG4J2-2936](https://issues.apache.org/jira/browse/LOG4J2-2936)
Please, could you
rm5248 merged pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pengweiqhca closed pull request #26:
URL: https://github.com/apache/logging-log4net/pull/26
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
pengweiqhca opened a new pull request #26:
URL: https://github.com/apache/logging-log4net/pull/26
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
wuqian0808 opened a new pull request #427:
URL: https://github.com/apache/logging-log4j2/pull/427
Add logic to detect kafka broker is valid or not during app startup.
User should be noticed with kafka broker available or not.
Mark kafka appenders as not disabled if kafka broker not ava
wuqian0808 closed pull request #426:
URL: https://github.com/apache/logging-log4j2/pull/426
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
wuqian0808 commented on pull request #426:
URL: https://github.com/apache/logging-log4j2/pull/426#issuecomment-699884253
open another request with testcase
This is an automated message from the Apache Git Service.
To respond
wuqian0808 opened a new pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428
During reconfigure, LoggerContext will start new configuration and stop
previous configuration. The firstime, prev is DefaultConfiguration, new
configuration is eg: XmlConfiguration. Then the
wuqian0808 commented on pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-699886938
Testcase added. Is there anything else I can do?
This is an automated message from the Apache Git Servic
vy commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-699891074
Let me try to answer your questions @diepet:
> 1. When will be the `JsonTemplateLayout` released?
Next Log4j 2.x release (2.14.0?) will contain the `JsonTemplateLayo
wuqian0808 closed pull request #427:
URL: https://github.com/apache/logging-log4j2/pull/427
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
wuqian0808 commented on pull request #427:
URL: https://github.com/apache/logging-log4j2/pull/427#issuecomment-699901961
open with antoher pull request
This is an automated message from the Apache Git Service.
To respond to t
wuqian0808 opened a new pull request #429:
URL: https://github.com/apache/logging-log4j2/pull/429
Add logic to detect kafka broker is valid or not during app startup.
User should be noticed with kafka broker available or not.
Mark kafka appenders as not disabled if kafka broker not ava
diepet commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-699937784
Thanks @vy for the feedbacks!
Ok, so let's move the discussions for the point 2 in the Jira issue.
Could be possible, in the future, to plan a new
`` boolean at
Vizehase commented on pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-699955962
We support this pull request. Without this bugfix, the layout does not work
on Win .NET Core 3.1 platform (nothing is actually logged any more), so we had
to take this bugf
gengyuanzhe commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-700624599
@jvz Hi Matt, it has been two weeks. When will this PR be merged?
This is an automated message from th
13thirteen opened a new pull request #69:
URL: https://github.com/apache/logging-log4net/pull/69
Running the .NET Standard 2.0 version on Linux throws
`PlatformNotSupportedException`
See https://issues.apache.org/jira/browse/LOG4NET-652
-
jvz commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-700790163
I was on vacation the past two weeks actually ;)
I'll be merging this within a day or two. Definitely before the next release.
--
gengyuanzhe commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-700817139
OK, I see. I've been wondering why you didn't commit any codes these days.
:rofl:
This is an automate
fluffynuts commented on a change in pull request #69:
URL: https://github.com/apache/logging-log4net/pull/69#discussion_r496985080
##
File path: src/log4net/Core/LoggingEvent.cs
##
@@ -895,7 +895,7 @@ public string UserName
{
fluffynuts commented on a change in pull request #69:
URL: https://github.com/apache/logging-log4net/pull/69#discussion_r496985598
##
File path: src/log4net/Core/LoggingEvent.cs
##
@@ -895,7 +895,7 @@ public string UserName
{
jvz merged pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jvz merged pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
SiegfriedTobias1 opened a new pull request #430:
URL: https://github.com/apache/logging-log4j2/pull/430
PR for https://issues.apache.org/jira/browse/LOG4J2-2939
Accomodate for the fact that MDC.getCopyOfContextMap() may return null.
--
carterkozak commented on pull request #430:
URL: https://github.com/apache/logging-log4j2/pull/430#issuecomment-703748778
Thanks! I'll handle the merge and cherry-pick to relevant release branches.
This is an automated messag
SiegfriedTobias1 commented on pull request #430:
URL: https://github.com/apache/logging-log4j2/pull/430#issuecomment-703748839
Thanks for the review. I added a test, as requested.
This is an automated message from the Apache
SiegfriedTobias1 edited a comment on pull request #430:
URL: https://github.com/apache/logging-log4j2/pull/430#issuecomment-703748839
Thank you very much!
This is an automated message from the Apache Git Service.
To respond t
garydgregory commented on a change in pull request #430:
URL: https://github.com/apache/logging-log4j2/pull/430#discussion_r499833116
##
File path: log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
##
@@ -165,5 +166,12 @@ public void mdc() {
assertT
garydgregory commented on a change in pull request #430:
URL: https://github.com/apache/logging-log4j2/pull/430#discussion_r499833503
##
File path: log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
##
@@ -165,5 +166,12 @@ public void mdc() {
assertT
SiegfriedTobias1 commented on a change in pull request #430:
URL: https://github.com/apache/logging-log4j2/pull/430#discussion_r500188677
##
File path: log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
##
@@ -165,5 +166,12 @@ public void mdc() {
ass
carterkozak merged pull request #430:
URL: https://github.com/apache/logging-log4j2/pull/430
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
carterkozak opened a new pull request #431:
URL: https://github.com/apache/logging-log4j2/pull/431
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
carterkozak commented on pull request #431:
URL: https://github.com/apache/logging-log4j2/pull/431#issuecomment-704380110
Running here to trigger CI before committing to the release branch.
This is an automated message from t
carterkozak closed pull request #431:
URL: https://github.com/apache/logging-log4j2/pull/431
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vy commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-705785985
_[Sorry for the late reply, I am pretty much swamped with my day job
nowadays.]_
@diepet, I have deliberately left out _blank value elimination_ in
`JsonTemplateLayout` (
diepet commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-706130571
Ehy @vy, better a late reply than a null reply!
Thanks, your points are clear and understandable.
I am looking forward to using the message parameters resolver
diepet commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-706130571
Ehy @vy, better a late reply than a null reply!
Thanks, your points are clear and understandable.
I am looking forward to using the message parameters resolver
vy commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-705785985
_[Sorry for the late reply, I am pretty much swamped with my day job
nowadays.]_
@diepet, I have deliberately left out _blank value elimination_ in
`JsonTemplateLayout` (
vy commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-706217689
Thanks for the feedback @diepet, keep 'em coming!
This is an automated message from the Apache Git Service.
To r
atomsmith opened a new pull request #70:
URL: https://github.com/apache/logging-log4net/pull/70
This PR resolves the .NET Standard non-Windows username query issue in a
different way: instead of trapping the PlatformNotSupportedException, it
proactively queries whether a Windows or non-Win
dependabot[bot] commented on pull request #421:
URL: https://github.com/apache/logging-log4j2/pull/421#issuecomment-706848536
Superseded by #432.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] opened a new pull request #432:
URL: https://github.com/apache/logging-log4j2/pull/432
Bumps tomcat-catalina from 8.5.20 to 9.0.39.
[ from 4.13 to 4.13.1.
Release notes
Sourced from https://github.com/junit-team/junit4/releases";>junit's
releases.
JUnit
fluffynuts closed pull request #70:
URL: https://github.com/apache/logging-log4net/pull/70
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fluffynuts commented on pull request #70:
URL: https://github.com/apache/logging-log4net/pull/70#issuecomment-711256205
Thanks for the contribution. This has been resolved in master and I have a
release pending a vote on the dev lists for 2.0.12.
--
fluffynuts commented on pull request #69:
URL: https://github.com/apache/logging-log4net/pull/69#issuecomment-711256987
Thanks for the contribution. This has been resolved in master and I have a
release pending a vote on the dev lists for 2.0.12. I'm closing this out as
people are looking
fluffynuts closed pull request #69:
URL: https://github.com/apache/logging-log4net/pull/69
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rschmitt commented on pull request #392:
URL: https://github.com/apache/logging-log4j2/pull/392#issuecomment-713071523
Sorry for the delay, I've made the requested changes.
This is an automated message from the Apache Git Ser
rgoers commented on pull request #392:
URL: https://github.com/apache/logging-log4j2/pull/392#issuecomment-716101478
I tried to apply the patch but when I run the tests 2 tests in log4j-api now
fail:
```
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed:
0.00
rocketraman commented on pull request #12:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/12#issuecomment-719040833
@jvz poke
This is an automated message from the Apache Git Service.
To respond to the message, ple
henryptung opened a new pull request #434:
URL: https://github.com/apache/logging-log4j2/pull/434
Make sure the returned Cancellable handler contains a strong
reference to the callback, so that it is not garbage-collected
prematurely. Add Javadoc note about collection semantics.
wuqian0808 commented on pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-720878961
@jvz kindly help to advise
This is an automated message from the Apache Git Service.
To respond to the
Falseclock commented on pull request #25:
URL: https://github.com/apache/logging-log4php/pull/25#issuecomment-720283468
@jvz Done. Unfortunately had to add PHP version check cause composer's
compatibility is >= 5.2.7 while Closures available since 5.3.0
---
jvz commented on pull request #25:
URL: https://github.com/apache/logging-log4php/pull/25#issuecomment-720568872
Thanks for the PR!
This is an automated message from the Apache Git Service.
To respond to the message, please l
carterkozak commented on pull request #434:
URL: https://github.com/apache/logging-log4j2/pull/434#issuecomment-720538814
I think the difference between the first and second commit on this PR is
whether or not the JeroMqManager class (and related context classes) should be
allowed to be un
jvz merged pull request #25:
URL: https://github.com/apache/logging-log4php/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
carterkozak commented on pull request #434:
URL: https://github.com/apache/logging-log4j2/pull/434#issuecomment-721158932
I think the approach in the first commit is less risky, so I'm going to
merge that after I verify tests pass locally to ensure this makes the 2.14.0
release.
carterkozak commented on a change in pull request #434:
URL: https://github.com/apache/logging-log4j2/pull/434#discussion_r516721169
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/DefaultShutdownCallbackRegistry.java
##
@@ -87,42 +92,41 @@ public voi
carterkozak commented on a change in pull request #434:
URL: https://github.com/apache/logging-log4j2/pull/434#discussion_r516721169
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/DefaultShutdownCallbackRegistry.java
##
@@ -87,42 +92,41 @@ public voi
vy merged pull request #433:
URL: https://github.com/apache/logging-log4j2/pull/433
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jvz commented on pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-723272662
@wuqian0808 could you fix the filename of the test file? Without the .java
extension, I'm pretty sure the compiler or Maven will complain.
wuqian0808 commented on pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-723548897
> @wuqian0808 could you fix the filename of the test file? Without the .java
extension, I'm pretty sure the compiler or Maven will complain.
File name changed
--
sandeepbarnwal opened a new pull request #436:
URL: https://github.com/apache/logging-log4j2/pull/436
newMessage method in LocalizedMessageFactory uses incorrect constructor. it
creates the new message with baseName as messagePattern. I have changed it to
point to the appropriate construct
wuqian0808 commented on pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-723732760
@rgoers Could u help to advise? Or is there anything else should I do?
This is an automated message from
vy commented on pull request #436:
URL: https://github.com/apache/logging-log4j2/pull/436#issuecomment-724676679
Thanks so much @sandeepbarnwal! Would you mind updating
`/src/changes/changes.xml` and adding a simple test (to
`LocalizedMessageTest`?) as well, please?
-
roedll opened a new pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13
We are using the Log4J Kotlin API in an OSGi environment. One pitfall is the
missing manifest headers that would enable the direct usage as OSGi bundle. We
are currently working with a workara
rocketraman commented on pull request #13:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-724861595
Thanks for this. I'd like to see the `bnd` definition file in a subdirectory
rather than at the root e.g. `bnd/log4j-kotlin-api.bnd`
```
b
roedll commented on pull request #13:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-724917908
No problem - Done
This is an automated message from the Apache Git Service.
To respond to the message,
roedll commented on pull request #13:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725226670
The standard path for bnd metadata seems to be the "/bnd.bnd" (like
defined here https://bnd.bndtools.org/md/805-instructions.html in section
"Headers")
I've now
roedll edited a comment on pull request #13:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725226670
The standard path for bnd metadata seems to be the "\/bnd.bnd" (like
defined here https://bnd.bndtools.org/md/805-instructions.html in section
"Headers")
ilam-natarajan opened a new pull request #437:
URL: https://github.com/apache/logging-log4j2/pull/437
backporting [LOG4J2-2025](https://issues.apache.org/jira/browse/LOG4J2-2025)
from 3.x (master) to 2.x
This change allows redirecting JUL from a webapp without impacting
container's
rocketraman commented on pull request #13:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725447578
@jvz This PR LGTM. Are there any hoops we need to jump through before
merging?
This is an automat
jvz commented on pull request #13:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/13#issuecomment-725460166
Nah, go ahead. There might be some OSGi bugs in Log4j itself, but those
would be handled separately.
On Wed, Nov 11, 2020 at 08:16 Raman Gupta wrote:
> @jv
sandeepbarnwal commented on pull request #436:
URL: https://github.com/apache/logging-log4j2/pull/436#issuecomment-725508202
> Thanks so much @sandeepbarnwal! Would you mind updating
`/src/changes/changes.xml` and adding a simple test (to
`LocalizedMessageTest`?) as well, please?
Su
sandeepbarnwal edited a comment on pull request #436:
URL: https://github.com/apache/logging-log4j2/pull/436#issuecomment-725508202
> Thanks so much @sandeepbarnwal! Would you mind updating
`/src/changes/changes.xml` and adding a simple test (to
`LocalizedMessageTest`?) as well, please?
wuqian0808hundsun commented on pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-725793729
@vy Could u help to advise if there is anything else should I do before
merging?
This is an aut
rocketraman merged pull request #13:
URL: https://github.com/apache/logging-log4j-kotlin/pull/13
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ilam-natarajan commented on pull request #437:
URL: https://github.com/apache/logging-log4j2/pull/437#issuecomment-726029598
@rgoers thanks for the review. should I do anything to get this merged?
sorry I am not very familiar with the process as this is my first time
vy commented on a change in pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428#discussion_r522189283
##
File path:
log4j-kafka/src/test/java/org/apache/logging/log4j/kafka/appender/KafkaThreadTest.java
##
@@ -0,0 +1,33 @@
+package org.apache.logging.log4
vy merged pull request #436:
URL: https://github.com/apache/logging-log4j2/pull/436
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jvz commented on pull request #437:
URL: https://github.com/apache/logging-log4j2/pull/437#issuecomment-726163770
If you add an entry to `src/changes/changes.xml`, I think that's the only
remaining thing. Otherwise, a volunteer from the project will merge this when
they get some time to do
ilam-natarajan commented on pull request #437:
URL: https://github.com/apache/logging-log4j2/pull/437#issuecomment-726195646
thanks, @jvz thats done now.
This is an automated message from the Apache Git Service.
To respond t
vy closed pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy commented on pull request #428:
URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-726199650
Nevermind, applied your changes manually. Will backport it to 2.x too.
Thanks so much!
This is an automated mes
annakukliansky opened a new pull request #438:
URL: https://github.com/apache/logging-log4j2/pull/438
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
garydgregory commented on pull request #438:
URL: https://github.com/apache/logging-log4j2/pull/438#issuecomment-727617945
I'm personally not a fan of opening up the guts of these classes for public
consumption, it just handcuffs us to provide binary compatibility.
I'd think it is b
dependabot[bot] opened a new pull request #439:
URL: https://github.com/apache/logging-log4j2/pull/439
Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.6.2 to 2.8.1.
Release notes
Sourced from https://github.com/xmlunit/xmlunit/releases";>xmlunit-core's
releases.
701 - 800 of 7264 matches
Mail list logo
