NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
jvz merged pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dependabot[bot] commented on pull request #382:
URL: https://github.com/apache/logging-log4j2/pull/382#issuecomment-690860228
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691513310
@NicholasNoise the vote passed, package 2.0.10 is up at nuget.org; the site
should hopefully be updated when someone with the required permissions to
publish has s
NicholasNoise edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273
@fluffynuts thanks!
I'll test it in live environment and come back with a feedback.
btw, this release is a bit messed up
([1](https://github.com/apache
rm5248 merged pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691705746
btw, turned out _I_ have the required permissions... still new here
:flushed: anyhoo, the more we do this, the better we get, right? At least,
that's the plan (:
--
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691710323
>
>
> the more we do this, the better we get, right? At least, that's the plan (:
This is the way...
If it turns sideways we change plan (:
-
gengyuanzhe opened a new pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419
HtmlLayout support datePattern and timezone
Submitted by: gengyuanzhe
This is an automated message from the Apache Git Ser
gengyuanzhe commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-691847601
@jvz Please help review and merge this pr. Solve
[LOG4J2-2889](https://issues.apache.org/jira/browse/LOG4J2-2889) and
[LOG4J2-2714](https://issues.apache.org/jira/brows
NicholasNoise opened a new pull request #68:
URL: https://github.com/apache/logging-log4net/pull/68
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rgoers commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-692148308
Yes, if there are new options then the Layout page should be updated
accordingly. You should provide at least one example of using the options.
Marcono1234 opened a new pull request #420:
URL: https://github.com/apache/logging-log4j2/pull/420
Fixes two typos in the manual.
This is an automated message from the Apache Git Service.
To respond to the message, please log
cremor commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-692483473
> btw, this release is a bit messed up
([1](https://github.com/apache/logging-log4net/blob/master/src/log4net/AssemblyInfo.cs#L57),
[2](https://github.com/apache/logging-log4
gengyuanzhe commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-692845402
@rgoers @jvz
Documentation is updated, and fix a timezone bug of
DatePatternConverterTest. Please review and merge.
---
gengyuanzhe edited a comment on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-692845402
@rgoers @jvz
Documentation is updated, and fix a timezone bug of
DatePatternConverterTest. Please help review and merge, thank you
-
dependabot[bot] opened a new pull request #421:
URL: https://github.com/apache/logging-log4j2/pull/421
Bumps tomcat-catalina from 8.5.20 to 9.0.38.
[ from
2.1.4.RELEASE to 3.0.10.RELEASE.
Commits
https://github.com/spring-projects/spring-ws/commit/4d4124e
dependabot[bot] closed pull request #411:
URL: https://github.com/apache/logging-log4j2/pull/411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
NicholasNoise commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-693265610
@fluffynuts last Thursday or this one? =)
This is an automated message from the Apache Git Service.
To
fluffynuts commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-693971008
Sorry, been a bit mad -- the day off turned into a mission (:
anyway, LGTM, merging.
This is an au
fluffynuts merged pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fluffynuts merged pull request #68:
URL: https://github.com/apache/logging-log4net/pull/68
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-693981771
@NicholasNoise I'm all for trying to up code quality; this adds a _ton_ of
noise though. For me, warnings are a thing that should not be seen -- all
warnings should be at
fluffynuts commented on a change in pull request #56:
URL: https://github.com/apache/logging-log4net/pull/56#discussion_r490007841
##
File path: src/Appender/RestServiceAppender.cs
##
@@ -0,0 +1,473 @@
+#region Apache License
+//
+// Licensed to the Apache Software Foundation
fluffynuts closed pull request #56:
URL: https://github.com/apache/logging-log4net/pull/56
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694069775
@fluffynuts Every warning you see may be (or should be) turned off by
ruleset: some warning are essential and should be attended to, others are not
and just ignore the
NicholasNoise edited a comment on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694069775
@fluffynuts Every warning you see may be (or should be) turned off by
ruleset: some warning are essential and should be attended to, others are not
and just ign
NicholasNoise edited a comment on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694069775
@fluffynuts Every warning you see may be (or should be) turned off by
ruleset: some warning are essential and should be attended to, others are not
and just ign
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694094932
That sounds like a good plan 👍
This is an automated message from the Apache Git Service.
To respond to th
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694097316
btw, I don't have anything against FxCop, and I expect rules would have to
be established, just like for SonarQube; I guess I'm just remembering how
successful SonarQube
NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694165275
>
>
> That sounds like a good plan 👍
Done!
> I don't know enough about FxCop to be sure, but I'd expect that we could
perhaps enable rule processi
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694206130
> Build-in tools are preferable, an external tool makes it harder for new
contributor to join. But in the same time used tools should be effective by all
means.
> I'm
fluffynuts edited a comment on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694206130
> Build-in tools are preferable, an external tool makes it harder for new
contributor to join. But in the same time used tools should be effective by all
means.
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694207456
@NicholasNoise I need to ask you for one more change before merging: the
style of the project has been to use spaces for indentation. I noticed some
whitespace changes on
NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694248929
> the style of the project has been to use spaces for indentation.
One more reason to use something like StyleCop to prevent from happening.
Actually the style
NicholasNoise edited a comment on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694248929
> the style of the project has been to use spaces for indentation.
One more reason to use something like StyleCop to prevent from happening.
Actually th
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694708069
hm, I don't mind, really, what style is adopted -- in the file where I saw
whitespace changes, it looked like the original code was spaces and your
changes were tabs. Now
fluffynuts merged pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694750050
I prefer spaces too by its _looks-the-same-everywhere_ feature.
> StyleCop isn't enough
StyleCop and FxCop grant a build validation with right ruleset (SA1
NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694766793
@fluffynuts
Is 2.0.11 planned to release any time soon?
This is an automated message from the
jvz commented on a change in pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491213545
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java
##
@@ -345,14 +355,17 @@ public static HtmlLayout createLayo
jvz commented on pull request #420:
URL: https://github.com/apache/logging-log4j2/pull/420#issuecomment-695107002
Thanks for the PR!
This is an automated message from the Apache Git Service.
To respond to the message, please
jvz merged pull request #420:
URL: https://github.com/apache/logging-log4j2/pull/420
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jvz commented on a change in pull request #392:
URL: https://github.com/apache/logging-log4j2/pull/392#discussion_r491215215
##
File path:
log4j-api/src/test/java/org/apache/logging/log4j/util/LoaderUtilTest.java
##
@@ -55,4 +63,53 @@ public void systemClassLoader() {
jvz commented on a change in pull request #392:
URL: https://github.com/apache/logging-log4j2/pull/392#discussion_r491215413
##
File path:
log4j-api/src/test/java/org/apache/logging/log4j/util/LoaderUtilTest.java
##
@@ -55,4 +63,53 @@ public void systemClassLoader() {
gengyuanzhe commented on a change in pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491272078
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java
##
@@ -345,14 +355,17 @@ public static HtmlLayout cr
gengyuanzhe commented on a change in pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491272078
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java
##
@@ -345,14 +355,17 @@ public static HtmlLayout cr
gengyuanzhe commented on a change in pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491272078
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java
##
@@ -345,14 +355,17 @@ public static HtmlLayout cr
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-695349836
I've started a vote, have one +1, so waiting on 2 more.
This is an automated message from the Apache Git
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-695350068
> > StyleCop isn't enough
>
> StyleCop and FxCop grant a build validation with right ruleset (SA1027 set
to Error), so it is IDE independent.
What I mean is
fluffynuts edited a comment on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-695350068
> > StyleCop isn't enough
>
> StyleCop and FxCop grant a build validation with right ruleset (SA1027 set
to Error), so it is IDE independent.
What I m
fluffynuts edited a comment on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-695350068
> > StyleCop isn't enough
>
> StyleCop and FxCop grant a build validation with right ruleset (SA1027 set
to Error), so it is IDE independent.
What I m
fluffynuts edited a comment on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-695350068
> > StyleCop isn't enough
>
> StyleCop and FxCop grant a build validation with right ruleset (SA1027 set
to Error), so it is IDE independent.
What I m
jvz commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695353407
By the way, if you'd like this feature in 2.x and not just 3.x, can you file
a PR to the `release-2.x` branch?
gengyuanzhe commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695747057
> By the way, if you'd like this feature in 2.x and not just 3.x, can you
file a PR to the `release-2.x` branch?
Hi, I'm trying to apply these changes to `release
gengyuanzhe edited a comment on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695747057
> By the way, if you'd like this feature in 2.x and not just 3.x, can you
file a PR to the `release-2.x` branch?
Hi, I'm trying to apply these changes to `
gengyuanzhe edited a comment on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695747057
> By the way, if you'd like this feature in 2.x and not just 3.x, can you
file a PR to the `release-2.x` branch?
Hi, I'm trying to apply these changes to `
rm5248 opened a new pull request #41:
URL: https://github.com/apache/logging-log4cxx/pull/41
When generated files are removed on clean, the build will
fail because log4cxx.h is not found, and cmake must be run
again. The files still get regenrated anyway.
---
gengyuanzhe opened a new pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gengyuanzhe commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695798876
@jvz
All of the changes have been handled for branch `release-2.x` with
https://github.com/apache/logging-log4j2/pull/423.
gengyuanzhe edited a comment on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695798876
@jvz
All of the changes have been applied to branch `release-2.x` with
https://github.com/apache/logging-log4j2/pull/423.
--
gengyuanzhe commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695801712
@jvz
In addition, I would like to know why your commit step is a success but mine
is a failure for step `Maven/Build (Ubuntu-latest)`
-
Marcono1234 opened a new pull request #424:
URL: https://github.com/apache/logging-log4j2/pull/424
`{@link ...}` already formats the link text as code (unlike `{@linkplain
...}`) and additionally does not support nested Javadoc tags, so currently the
HTML output is `{@code Supplier}`.
--
jvz commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695817855
The failed tests are flaky from before and unrelated to this PR.
This is an automated message from the Apache G
gengyuanzhe commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695820947
@jvz Thanks for reply. Is there anything else I need to do, or just wait for
other members to review my code?
-
jvz commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695821455
Nothing left for you as far as I can tell. We can see if anyone else wants
to review before merging. I'm currently working on some build-related
fixes/improvements before I mer
gengyuanzhe commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695823514
Ok, I am not particularly familiar with the whole PR process, so I asked a
lot of questions. Anyway, thank you for your patient repl.
-
rm5248 merged pull request #41:
URL: https://github.com/apache/logging-log4cxx/pull/41
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wuqian0808 opened a new pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425
Avoid kafka thread leak during loggercontext reconfigure multiple times.
This is an automated message from the Apache Git Servi
wuqian0808 commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696016546
Configure kafkaappender in log4j2.xml, then call below steps serveral times.
The kafka thread will increase.
LoggerContext.getContext(false).reconfigure();
gengyuanzhe commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623
In my opition,
`org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close
the kafka producer when `reconfigure()`. The `close()` should not be invok
gengyuanzhe edited a comment on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623
In my opition,
`org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close
the kafka producer when `reconfigure()`. The `close()` should not b
gengyuanzhe edited a comment on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623
In my opition,
`org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close
the kafka producer when `reconfigure()`. The `close()` should not b
gengyuanzhe commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695820947
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
wuqian0808 commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696016546
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
jvz commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695821455
Nothing left for you as far as I can tell. We can see if anyone else wants
to review before merging. I'm currently working on some build-related
fixes/improvements before I mer
gengyuanzhe edited a comment on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695747057
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rm5248 merged pull request #41:
URL: https://github.com/apache/logging-log4cxx/pull/41
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jvz commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695817855
The failed tests are flaky from before and unrelated to this PR.
This is an automated message from the Apache G
gengyuanzhe commented on pull request #419:
URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695798876
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
gengyuanzhe commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623
In my opition,
`org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close
the kafka producer when `reconfigure()`. The `close()` should not be invok
wuqian0808 commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696485108
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-697159824
@NicholasNoise 2.0.11 is out with these changes. Things take a little while
because:
1. I hadn't had my gpg key accepted into the apache KEYS file yet
2. The process
fluffynuts commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-697160161
@NicholasNoise if you're interested in (3), let me know how to contact you.
Your GitHub profile has no contact info ):
--
NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-697184642
> 2.0.11 is out with these changes.
Thanks!
> Things take a little while
There is no problem at all, I've saw insides of how-to-release-project - i
gengyuanzhe commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-698385158
I tried your case, and you are right, the KafkaAppender do have the problem
of thead leak. But **close when startup** is not the correct way to solve this
problem. Try
ffontaine opened a new pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42
Disable wencode without wchar or the build will fail on:
```
odbcappender.cpp: In static member function 'static void
log4cxx::db::ODBCAppender::encode(wchar_t**, const LogString&,
log
rm5248 commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-698666494
Shouldn't this also #ifdef out the function signature in the .h file? Or
would it make more sense to have the method implementation be just a stub? I'm
thinking that you co
wuqian0808 commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-698675698
> I tried your case, and you are right, the KafkaAppender do have the
problem of thead leak. But **close when startup** is not the correct way to
solve this problem. Try
wuqian0808 commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-698699334
> I tried your case, and you are right, the KafkaAppender do have the
problem of thead leak. But **close when startup** is not the correct way to
solve this problem. Try
wuqian0808 closed pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
wuqian0808 opened a new pull request #426:
URL: https://github.com/apache/logging-log4j2/pull/426
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
wuqian0808 commented on pull request #426:
URL: https://github.com/apache/logging-log4j2/pull/426#issuecomment-698701854
During reconfigure, LoggerContext will start new configuration and stop
previous configuration. The firstime, prev is DefaultConfiguration, new
configuration is eg: XmlC
ffontaine commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-698737347
I updated the PR to keep the `ODBCAppender::encode` function which won't do
anything if `Transcoder::wencode` is not available.
--
ams-tschoening commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-698767348
How does keeping `encode` as a no-op make sense here? Either it's called,
then making it a no-op breaks on runtime only or it's not, then itself should
be `#ifdef`ed
ffontaine commented on pull request #42:
URL: https://github.com/apache/logging-log4cxx/pull/42#issuecomment-698769494
I updated the PR following the second suggestion of @rm5248 but perhaps I
misunderstood it. I'll update the PR again to ifdef `ODBCAppender::encode`.
601 - 700 of 7264 matches
Mail list logo
