[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830335776 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830338691 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830338691 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830338691 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830331326 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

carterkozak commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830357475 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(fin

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

carterkozak commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830364137 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(fin

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

rgoers commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830447038 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +139,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

rgoers commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830447038 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +139,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

rgoers commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830447038 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +139,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

rgoers commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830447038 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +139,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] rgoers commented on pull request #799: Update CustomConfiguration.java

rgoers commented on pull request #799: URL: https://github.com/apache/logging-log4j2/pull/799#issuecomment-1072953796 This change would cause our RAT check to fail, would not match ASF guidelines documented at https://www.apache.org/legal/src-headers.html, and as Gary noted the URL is inva

[GitHub] [logging-log4j2] rgoers closed pull request #799: Update CustomConfiguration.java

rgoers closed pull request #799: URL: https://github.com/apache/logging-log4j2/pull/799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers commented on pull request #770: Initial support for detached markers in SLF4J binding

rgoers commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072954499 @dfa1 In your comment above you said you do have a use case (one would hope so for you to be implementing this) but you didn't explain your use case. All you really said is

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830449257 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] dfa1 edited a comment on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 edited a comment on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072958711 @rgoers yes, of course :-) Let me try to explain clearly: in https://www.six-group.com/ there is an internal requirement to use a structured logging format (called un

[GitHub] [logging-log4j2] dfa1 commented on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072958711 @rgoers yes, of course :-) Let me try to explain clearly: at @SIX-Group we have an internal requirement to use a structured logging format (called unified log event) for all

[GitHub] [logging-log4j2] dfa1 edited a comment on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 edited a comment on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072958711 @rgoers yes, of course :-) Let me try to explain clearly: in https://www.six-group.com/ there is an internal requirement to use a structured logging format (called un

[GitHub] [logging-log4j2] dfa1 edited a comment on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 edited a comment on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072958711 @rgoers yes, of course :-) Let me try to explain clearly: in https://www.six-group.com/ there is an internal requirement to use a structured logging format (called un

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830456338 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830456338 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830457264 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(final Stri

[GitHub] [logging-log4j2] rgoers commented on pull request #770: Initial support for detached markers in SLF4J binding

rgoers commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072974525 Ok. So your big mistake here is trying to do this with the SLF4J API. It wasn't designed to support structured event logging. I fought for that years ago and gave up and th

[GitHub] [logging-log4j2] rgoers edited a comment on pull request #770: Initial support for detached markers in SLF4J binding

rgoers edited a comment on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072974525 Ok. So your big mistake here is trying to do this with the SLF4J API. It wasn't designed to support structured event logging. I fought for that years ago and gave up

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830463798 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +139,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] rgoers edited a comment on pull request #770: Initial support for detached markers in SLF4J binding

rgoers edited a comment on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072974525 Ok. So your big mistake here is trying to do this with the SLF4J API. It wasn't designed to support structured event logging. I fought for that years ago and gave up

[GitHub] [logging-log4j2] garydgregory commented on pull request #770: Initial support for detached markers in SLF4J binding

garydgregory commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1072998257 I have a product at work that does almost exactly what @rgoers describes, it works great, it's clean, and easy enough to understand. I encourage you as well to move t

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

carterkozak commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830479861 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -113,26 +125,18 @@ public boolean exists(fin

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

rgoers commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830502914 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +139,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

rgoers commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r830502914 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +139,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] dfa1 commented on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073047035 @rgoers @garydgregory thank you for the feedback ;) Actually we already have a lot of internal libraries and frameworks written against `slf4j-api`, and we do the actua

[GitHub] [logging-log4j2] dfa1 commented on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073049642 @rgoers @carterkozak @garydgregory *Current state* - this PR is implementing the SLF4J's contract is a reasonable way (my humble opinion) - test coverage is

[GitHub] [logging-log4j2] dfa1 edited a comment on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 edited a comment on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073049642 @rgoers @carterkozak @garydgregory *Current state* - this PR is implementing the SLF4J's contract in a reasonable way (my humble opinion) - test cove

[GitHub] [logging-log4j2] rgoers commented on pull request #770: Initial support for detached markers in SLF4J binding

rgoers commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073168934 @dfa1 I do understand your dilemma. You already have existing code that has implemented this in the only way possible using SLF4J, which is a hack, However, I have a real p

[GitHub] [logging-log4j2] rgoers edited a comment on pull request #770: Initial support for detached markers in SLF4J binding

rgoers edited a comment on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073168934 @dfa1 I do understand your dilemma. You already have existing code that has implemented this in the only way possible using SLF4J, which is a hack, However, I have a

[GitHub] [logging-log4j2] dfa1 commented on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073193347 @rgoers thanks for yours the honest feedback! :) Maintaining my own fork(s) of SLF4J is what I wanted to avoid by proposing this PR! After this long discussion, I reali

[GitHub] [logging-log4j2] dfa1 edited a comment on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 edited a comment on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073193347 @rgoers thanks for yours the honest feedback! :) Maintaining my own fork(s) of SLF4J is what I wanted to avoid by proposing this PR... I don't want to go there!

[GitHub] [logging-log4j2] rgoers commented on pull request #770: Initial support for detached markers in SLF4J binding

rgoers commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073201000 That would be back to the same thing. Now you would have getMarker returning a detached marker. If I thought detached markers were a good idea then detachedMarker would be

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

ppkarwasz commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830645307 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -36,9 +38,11 @@ private static final Logg

[GitHub] [logging-log4j2] dfa1 commented on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073293922 @rgoers I'm already using public ctor in `Log4jMarker`: but in order to do that I need to "override" the code coming from log4j binding and now my application are sensitive t

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830646927 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -36,9 +38,11 @@ private static final Logger LO

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830646927 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -36,9 +38,11 @@ private static final Logger LO

[GitHub] [logging-log4j2] dfa1 commented on a change in pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on a change in pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830646927 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java ## @@ -36,9 +38,11 @@ private static final Logger LO

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #806: [LOG4J2-3439] Corrects default SSL configuration

ppkarwasz opened a new pull request #806: URL: https://github.com/apache/logging-log4j2/pull/806 Replaces an invalid `SSLContext` algorithm name with Log4j's default and adds unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [logging-log4j2] jvz merged pull request #744: [LOG4J2-2803] Create standardized dependency injection API

jvz merged pull request #744: URL: https://github.com/apache/logging-log4j2/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #806: [LOG4J2-3439] Corrects default SSL configuration

garydgregory commented on a change in pull request #806: URL: https://github.com/apache/logging-log4j2/pull/806#discussion_r830679706 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/ssl/AbstractKeyStoreConfiguration.java ## @@ -33,6 +33,8 @@ * Config

[GitHub] [logging-log4j2] garydgregory commented on pull request #806: [LOG4J2-3439] Corrects default SSL configuration

garydgregory commented on pull request #806: URL: https://github.com/apache/logging-log4j2/pull/806#issuecomment-1073371162 Hi @ppkarwasz Do we want to test that we are creating a TLS connection instead of some older protocol version? -- This is an automated message from the Apache G

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #806: [LOG4J2-3439] Corrects default SSL configuration

ppkarwasz commented on pull request #806: URL: https://github.com/apache/logging-log4j2/pull/806#issuecomment-1073376320 @garydgregory: that test could fail, since the allowed protocols depend upon the `java.security` configuration file of the JVM. Setting `jdk.tls.disabledAlgorithms` to a

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #806: [LOG4J2-3439] Corrects default SSL configuration

ppkarwasz edited a comment on pull request #806: URL: https://github.com/apache/logging-log4j2/pull/806#issuecomment-1073376320 @garydgregory: that test could fail, since the allowed protocols depend upon the `java.security` configuration file of the JVM. Setting `jdk.tls.disabledAlgorithm

[GitHub] [logging-log4j2] vy commented on a change in pull request #797: LOG4J2-3393 Improve JsonTemplateLayout performance.

vy commented on a change in pull request #797: URL: https://github.com/apache/logging-log4j2/pull/797#discussion_r830901725 ## File path: log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/MessageResolver.java ## @@ -134,7 +134,10 @

[GitHub] [logging-log4j2] vy commented on a change in pull request #797: LOG4J2-3393 Improve JsonTemplateLayout performance.

vy commented on a change in pull request #797: URL: https://github.com/apache/logging-log4j2/pull/797#discussion_r830911702 ## File path: log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/MessageResolver.java ## @@ -134,7 +134,10 @

[GitHub] [logging-log4j2] vy merged pull request #797: LOG4J2-3393 Improve JsonTemplateLayout performance.

vy merged pull request #797: URL: https://github.com/apache/logging-log4j2/pull/797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #805: ternary operator condition needs to be updated

vy commented on pull request #805: URL: https://github.com/apache/logging-log4j2/pull/805#issuecomment-1073770054 Thanks for the heads up @Suji04! I've applied your changes in 6f282e6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r831575308 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +78,73 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4cxx] rm5248 commented on pull request #108: LOGCXX-550 The thread name should now be able to be logged

rm5248 commented on pull request #108: URL: https://github.com/apache/logging-log4cxx/pull/108#issuecomment-1074482366 > For some reason `timebasedrollingtest` failed once for me, but not on subsequent 5 executions. So things seem to be fine. That is likely due to how that test works

[GitHub] [logging-log4cxx] rm5248 merged pull request #108: LOGCXX-550 The thread name should now be able to be logged

rm5248 merged pull request #108: URL: https://github.com/apache/logging-log4cxx/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r831826513 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/util/ServiceLoaderUtilTest.java ## @@ -86,42 +85,4 @@ public void testBrokenService

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

ppkarwasz commented on a change in pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#discussion_r831830675 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/ServiceLoaderUtil.java ## @@ -110,28 +135,64 @@ private ServiceLoaderUtil() {

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

ppkarwasz commented on pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#issuecomment-1074844988 After several fixes, this should work now. A summary of changes: - I removed `LoaderServiceUtil#getService` that I introduced in a previous commit, since it's logi

[GitHub] [logging-log4j2] ppkarwasz merged pull request #806: [LOG4J2-3439] Corrects default SSL configuration

ppkarwasz merged pull request #806: URL: https://github.com/apache/logging-log4j2/pull/806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4j2] jvz commented on pull request #804: [LOG4J2-3427] Replace ServiceLoader calls with ServiceLoaderUtil

jvz commented on pull request #804: URL: https://github.com/apache/logging-log4j2/pull/804#issuecomment-1075350519 > * OSGI support was also removed from `LoaderServiceUtil`, because it uses an artifact (`osgi-resource-locator`) that seems to be abandoned (it is still supported by JAXB API

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #807: [LOG4J2-3359] Adds Log4j 1.x specific syslog layout

ppkarwasz opened a new pull request #807: URL: https://github.com/apache/logging-log4j2/pull/807 Log4j 1.x always used the BSD syslog layout, but allowed for an internal layout to specify the _MESSAGE_ format. This PR adds a variant of the Log4j 2.x `SyslogLayout`, that emulates Log4

[GitHub] [logging-log4j2] dfa1 commented on pull request #770: Initial support for detached markers in SLF4J binding

dfa1 commented on pull request #770: URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1079376882 @rgoers tried also your last suggestion too: > You are free to use ServiceLoader to locate the SLF4J Service Provider and get the Marker factory and then create Markers

[GitHub] [logging-log4j2] jvz opened a new pull request #808: Make ConfigurationFactory injectable

jvz opened a new pull request #808: URL: https://github.com/apache/logging-log4j2/pull/808 This allows for a ConfigurationFactory binding to be registered as well as generally participate in dependency injection. Signed-off-by: Matt Sicker -- This is an automated message from the

[GitHub] [logging-log4j2] jvz commented on a change in pull request #808: Make ConfigurationFactory injectable

jvz commented on a change in pull request #808: URL: https://github.com/apache/logging-log4j2/pull/808#discussion_r835695608 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java ## @@ -137,71 +119,15 @@ public ConfigurationFacto

[GitHub] [logging-log4j-kotlin] grobmeier merged pull request #23: LOG4J2-3400 Add page about Maven, Ivy and Gradle artifacts

grobmeier merged pull request #23: URL: https://github.com/apache/logging-log4j-kotlin/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[GitHub] [logging-log4j2] jvz merged pull request #808: Make ConfigurationFactory injectable

jvz merged pull request #808: URL: https://github.com/apache/logging-log4j2/pull/808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [logging-log4j2] jvz commented on pull request #775: [LOG4J2-3415] Support JSON configuration using embedded JSON parser

jvz commented on pull request #775: URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1080106923 I'm going to merge this as-is. We can figure out how to integrate JSON parsing with PropertiesUtil later. -- This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4j2] jvz merged pull request #775: [LOG4J2-3415] Support JSON configuration using embedded JSON parser

jvz merged pull request #775: URL: https://github.com/apache/logging-log4j2/pull/775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [logging-log4j2] vy commented on a change in pull request #775: [LOG4J2-3415] Support JSON configuration using embedded JSON parser

vy commented on a change in pull request #775: URL: https://github.com/apache/logging-log4j2/pull/775#discussion_r836108757 ## File path: log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/JsonReaderTest.java ## @@ -375,6 +376,11 @@ public void test_nesting() {

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

garydgregory commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836407990 ## File path: log4j-core/revapi.json ## @@ -128,6 +128,25 @@ "annotation": "@org.apache.logging.log4j.core.config.plugins.PluginFactor

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836438381 ## File path: log4j-core/revapi.json ## @@ -128,6 +128,25 @@ "annotation": "@org.apache.logging.log4j.core.config.plugins.PluginFactory"

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836438381 ## File path: log4j-core/revapi.json ## @@ -128,6 +128,25 @@ "annotation": "@org.apache.logging.log4j.core.config.plugins.PluginFactory"

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

garydgregory commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836761436 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -393,7 +408,8 @@ protected SyslogAppend

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

garydgregory commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r836762447 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java ## @@ -627,7 +608,8 @@ public static Rfc5424Layo

[GitHub] [logging-log4j2] garydgregory commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

garydgregory commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1081036428 Hello @atulpendse In general, you want to avoid breaking binary compatibility, so that means not editing public and protected type names and method signatures. Th

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r837103493 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -393,7 +408,8 @@ protected SyslogAppender

[GitHub] [logging-log4j2] astappiev commented on pull request #745: [LOG4J2-3362] Adds a SmtpManager compatible with Jakarta EE 9

astappiev commented on pull request #745: URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1081915601 Any progress on this or release date? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [logging-log4j2] stefanvodita opened a new pull request #809: LOG4J2-3452: Fix race condition in FileUtils.mkdir()

stefanvodita opened a new pull request #809: URL: https://github.com/apache/logging-log4j2/pull/809 A race condition could appear when 2 threads were trying to create the same directory. Both would check that the directory did not exist, then one would create the directory and the othe

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #809: LOG4J2-3452: Fix race condition in FileUtils.mkdir()

ppkarwasz commented on a change in pull request #809: URL: https://github.com/apache/logging-log4j2/pull/809#discussion_r837669556 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/util/FileUtilsTest.java ## @@ -78,4 +86,56 @@ public void testFileFromUriWit

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

ppkarwasz commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r837730815 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java ## @@ -92,11 +97,12 @@ */ public static

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

ppkarwasz commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r837730815 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java ## @@ -92,11 +97,12 @@ */ public static

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #745: [LOG4J2-3362] Adds a SmtpManager compatible with Jakarta EE 9

ppkarwasz commented on pull request #745: URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1082395718 @astappiev, As far as I am concerned, this could end up in the next release. You can check if it works for you. -- This is an automated message from the Apache Git

[GitHub] [logging-log4j2] jvz commented on a change in pull request #775: [LOG4J2-3415] Support JSON configuration using embedded JSON parser

jvz commented on a change in pull request #775: URL: https://github.com/apache/logging-log4j2/pull/775#discussion_r838011000 ## File path: log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/JsonReaderTest.java ## @@ -375,6 +376,11 @@ public void test_nesting() {

[GitHub] [logging-log4j2] stefanvodita commented on a change in pull request #809: LOG4J2-3452: Fix race condition in FileUtils.mkdir()

stefanvodita commented on a change in pull request #809: URL: https://github.com/apache/logging-log4j2/pull/809#discussion_r838804651 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/util/FileUtilsTest.java ## @@ -78,4 +86,56 @@ public void testFileFromUri

[GitHub] [logging-log4j2] ppkarwasz merged pull request #809: LOG4J2-3452: Fix race condition in FileUtils.mkdir()

ppkarwasz merged pull request #809: URL: https://github.com/apache/logging-log4j2/pull/809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #809: LOG4J2-3452: Fix race condition in FileUtils.mkdir()

ppkarwasz commented on pull request #809: URL: https://github.com/apache/logging-log4j2/pull/809#issuecomment-1083632089 @stefanvodita, Thank you for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [logging-log4j2] garydgregory commented on pull request #807: [LOG4J2-3359] Adds Log4j 1.x specific syslog layout

garydgregory commented on pull request #807: URL: https://github.com/apache/logging-log4j2/pull/807#issuecomment-1084406409 @rgoers Ping: Does this look good to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #807: [LOG4J2-3359] Adds Log4j 1.x specific syslog layout

ppkarwasz commented on pull request #807: URL: https://github.com/apache/logging-log4j2/pull/807#issuecomment-1084513836 I added a third parameter to `DatePatternConverter`, so that I can use it with a fixed English locale. I am not documenting it in the manual, because for now it does not

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #807: [LOG4J2-3359] Adds Log4j 1.x specific syslog layout

ppkarwasz edited a comment on pull request #807: URL: https://github.com/apache/logging-log4j2/pull/807#issuecomment-1084513836 I added a third parameter to `DatePatternConverter`, so that I can use it with a fixed English locale. I am not documenting it in the manual, because for now it d

[GitHub] [logging-log4j2] loganaden opened a new pull request #810: Update Spring to 5.3.18 which fixes CVE-2022-22965 aka "Spring4shell".

loganaden opened a new pull request #810: URL: https://github.com/apache/logging-log4j2/pull/810 See details: https://tanzu.vmware.com/security/cve-2022-22965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [logging-log4j2] garydgregory commented on pull request #810: Update Spring to 5.3.18 which fixes CVE-2022-22965 aka "Spring4shell".

garydgregory commented on pull request #810: URL: https://github.com/apache/logging-log4j2/pull/810#issuecomment-1084927755 Dependabot takes care of this for us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [logging-log4j2] ppkarwasz merged pull request #807: [LOG4J2-3359] Adds Log4j 1.x specific syslog layout

ppkarwasz merged pull request #807: URL: https://github.com/apache/logging-log4j2/pull/807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4j2] controllerface opened a new pull request #811: fix typo in method name getRequesteApiVersion()

controllerface opened a new pull request #811: URL: https://github.com/apache/logging-log4j2/pull/811 SLF4JServiceProvider defines the `getRequestedApiVersion()` method, but this class has a typo, the method is incorrectly named `getRequesteApiVersion()` which causes the following error me

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #811: fix typo in method name getRequesteApiVersion()

ppkarwasz commented on pull request #811: URL: https://github.com/apache/logging-log4j2/pull/811#issuecomment-1085806732 Hello @controllerface, That is not a typo, it is the method name SLF4J 1.8.x uses: see [LOG4J2-3370](https://issues.apache.org/jira/browse/LOG4J2-3370). -- This is

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #811: fix typo in method name getRequesteApiVersion()

ppkarwasz edited a comment on pull request #811: URL: https://github.com/apache/logging-log4j2/pull/811#issuecomment-1085806732 Hello @controllerface, That is not a typo, it is the method name SLF4J 1.8.x uses: see [LOG4J2-3370](https://issues.apache.org/jira/browse/LOG4J2-3370) You a

[GitHub] [logging-log4j2] controllerface commented on pull request #811: fix typo in method name getRequesteApiVersion()

controllerface commented on pull request #811: URL: https://github.com/apache/logging-log4j2/pull/811#issuecomment-1085826047 ok. wow. that's just... really confusing. I will close the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [logging-log4j2] controllerface closed pull request #811: fix typo in method name getRequesteApiVersion()

controllerface closed pull request #811: URL: https://github.com/apache/logging-log4j2/pull/811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: no

[GitHub] [logging-log4j2] clara0 opened a new pull request #812: [LOG4J2-3462] Duplicate dependency in pom.xml

clara0 opened a new pull request #812: URL: https://github.com/apache/logging-log4j2/pull/812 https://issues.apache.org/jira/browse/LOG4J2-3462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #813: [LOG4J2-3440] Synchronize Log4j 1.x and Log4j 2.x appenders

ppkarwasz opened a new pull request #813: URL: https://github.com/apache/logging-log4j2/pull/813 Forwards the `addAppender`, `callAppenders`, `getAllAppenders` and `getAppender` calls the the corresponding Log4j 2.x objects if Log4j 2.x Core is present. The `getAllAppenders` method

<    48   49   50   51   52   53   54   55   56   57   >