garydgregory commented on a change in pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r812876417
##
File path:
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java
##
@@ -36,9 +38,11 @@
private static final L
dfa1 commented on a change in pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r812896243
##
File path:
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java
##
@@ -36,9 +38,11 @@
private static final Logger LO
dfa1 commented on a change in pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r812896243
##
File path:
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java
##
@@ -36,9 +38,11 @@
private static final Logger LO
dependabot[bot] opened a new pull request #772:
URL: https://github.com/apache/logging-log4j2/pull/772
Bumps `logbackVersion` from 1.2.3 to 1.2.10.
Updates `logback-core` from 1.2.3 to 1.2.10
Updates `logback-classic` from 1.2.3 to 1.2.10
Dependabot will resolve any conf
dfa1 commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1050199009
@garydgregory is there something that you would like to change/improve in
this PR? please let me know :-)
--
This is an automated message from the Apache Git Service.
To
garydgregory commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1050256000
I'm going to be quite busy for a couple of days but I will try to take a
look. It might be only next week though. Thank you for your patience! That
should not prevent
dependabot[bot] opened a new pull request #773:
URL: https://github.com/apache/logging-log4j2/pull/773
Bumps [lightcouch](https://github.com/lightcouch/LightCouch) from 0.0.6 to
0.2.0.
Commits
https://github.com/lightcouch/LightCouch/commit/ada96111f87ffaf063439504d22959d932d4
ppkarwasz opened a new pull request #774:
URL: https://github.com/apache/logging-log4j2/pull/774
For properties that does not start with `log4j` or
`org.apache.logging.log4j` the loosed token-based lookup should not be
applied. There are a couple of exceptions to this rule: the propertie
jvz opened a new pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775
* Moves `JsonReader` from log4j-layout-json-template to log4j-api.
* Adds support for comments in parsing JSON for compatibility with existing
Jackson usage.
* Adds new default `JsonConfiguratio
ppkarwasz commented on pull request #774:
URL: https://github.com/apache/logging-log4j2/pull/774#issuecomment-1051598903
Yes, I thought JIRA would link the PR automatically, but apparently it only
checks the title provided at submission time.
--
This is an automated message from the Apac
ppkarwasz commented on a change in pull request #774:
URL: https://github.com/apache/logging-log4j2/pull/774#discussion_r815276131
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertySource.java
##
@@ -100,9 +101,19 @@ public int compare(final PropertyS
garydgregory commented on pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1052020598
Why does any parser need to be in the API module when all configurations
take place in the Core module? I don't think we should fatten up the API
with parsers.
Razahack commented on pull request #80:
URL: https://github.com/apache/logging-log4net/pull/80#issuecomment-1052379655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Razahack removed a comment on pull request #80:
URL: https://github.com/apache/logging-log4net/pull/80#issuecomment-1052379655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
jvz commented on pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1052556920
For convenience with the PropertiesUtil enhancements Ralph proposed.
Otherwise, it can certainly go in core instead.
--
This is an automated message from the Apache Git Serv
garydgregory commented on pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1052572720
> For convenience with the PropertiesUtil enhancements Ralph proposed.
Otherwise, it can certainly go in core instead.
It seems like a bad idea to me to put a p
jvz commented on pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1052593270
That's a good point. The `PropertiesUtil` enhancement will likely need some
additional inversion of control or something to avoid having the JSON parsing
done at that level. I
jvz commented on pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1052652676
Oh, I see that parsing is done weirdly for JSON and YAML for duplicate keys
rather than duplicating the keys. When you want to use more than one plugin of
the same kind, you m
jvz merged pull request #774:
URL: https://github.com/apache/logging-log4j2/pull/774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
jvz commented on a change in pull request #771:
URL: https://github.com/apache/logging-log4j2/pull/771#discussion_r815359633
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/Builder.java
##
@@ -42,4 +44,17 @@
* object.
*/
T build();
+
ppkarwasz commented on a change in pull request #771:
URL: https://github.com/apache/logging-log4j2/pull/771#discussion_r815362157
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/Builder.java
##
@@ -42,4 +44,17 @@
* object.
*/
T build
ppkarwasz commented on a change in pull request #771:
URL: https://github.com/apache/logging-log4j2/pull/771#discussion_r815362327
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/validation/validators/NotBlankValidator.java
##
@@ -0,0 +1,51
dependabot[bot] opened a new pull request #776:
URL: https://github.com/apache/logging-log4j2/pull/776
Bumps `slf4jVersion` from 1.7.35 to 1.7.36.
Updates `slf4j-api` from 1.7.35 to 1.7.36
Commits
https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a5
rgoers commented on pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1053916356
@jvz You are correct. Accomplishing what I want to with Properties will be
much simpler if the JsonReader is a utility class in the api module. I will
absolutely need JSON
ppkarwasz opened a new pull request #777:
URL: https://github.com/apache/logging-log4j2/pull/777
This PR adds support for the `spring.factories` registration method of the
`Log4j2CloudConfigLoggingSystem` to replace the old Java system properties
injection method.
A Log4j 2.x `log4j
ppkarwasz commented on pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1054014736
@rgoers: isn't the properties format enough for your properties enhancement?
`log4j-core` just needs to provide a `PropertySource` for the JSON format.
IMHO `Prope
jvz commented on pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1054492286
I think one possibility would be to add an interface in log4j-api for
loading properties and the general LoggerContext-specific properties. Then we
can move the parsing logic
dependabot[bot] opened a new pull request #778:
URL: https://github.com/apache/logging-log4j2/pull/778
Bumps [maven-scm-plugin](https://github.com/apache/maven-scm) from 1.9.5 to
1.12.2.
Commits
https://github.com/apache/maven-scm/commit/09c31eca8132a45552870e4a6e080f6d156e857
dependabot[bot] opened a new pull request #779:
URL: https://github.com/apache/logging-log4j2/pull/779
Bumps
[maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin)
from 2.9 to 3.2.2.
Commits
https://github.com/apache/maven-project-inf
sovikstepan opened a new pull request #781:
URL: https://github.com/apache/logging-log4j2/pull/781
https://issues.apache.org/jira/browse/LOG4J2-3421
Some typo fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
atulpendse commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1057728562
Just FYI.. I was able to build it successfully on my Mac. Last time
@garydgregory tried to submit build with this PR, it failed on Mac, not sure
why.
--
This is an a
garydgregory commented on pull request #782:
URL: https://github.com/apache/logging-log4j2/pull/782#issuecomment-1057957470
I don't see why we don't log the exception, @rgoers ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
turesheim commented on pull request #782:
URL: https://github.com/apache/logging-log4j2/pull/782#issuecomment-1058086473
I did at first simply logg the exception – but it got eaten by some Wildfly
stuff where I was testing this, hence adding the Exception message to the log
message.
--
carterkozak opened a new pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783
This fixes handling of properties in .properties configurations
as well as those defined using ``
which are parsed slightly differently from those which use the
`value` syntax.
--
T
carterkozak commented on a change in pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783#discussion_r819221798
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/Property.java
##
@@ -118,15 +119,36 @@ public static Property create
carterkozak commented on pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783#issuecomment-1058805314
planning to clean this up and fix revapi tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rtlusty closed pull request #780:
URL: https://github.com/apache/logging-log4j2/pull/780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
rtlusty commented on pull request #780:
URL: https://github.com/apache/logging-log4j2/pull/780#issuecomment-1058887365
Better option for the fix has been provided. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garydgregory commented on a change in pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783#discussion_r819689059
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/Property.java
##
@@ -118,15 +119,38 @@ public static Property creat
carterkozak commented on a change in pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783#discussion_r819703318
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/Property.java
##
@@ -118,15 +119,38 @@ public static Property create
ppkarwasz opened a new pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784
Refactors the code to minimize the number of calls to `URLConnection`
methods.
This should protect all code paths against dangling file descriptors and
temporary files left by the standa
ppkarwasz commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819780850
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java
##
@@ -355,28 +348,9 @@ static String extrac
ppkarwasz commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819781930
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationSource.java
##
@@ -339,17 +339,9 @@ public static Configu
ppkarwasz commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819783961
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationSource.java
##
@@ -370,21 +362,8 @@ public static Configu
ppkarwasz commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819783961
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationSource.java
##
@@ -370,21 +362,8 @@ public static Configu
ppkarwasz merged pull request #767:
URL: https://github.com/apache/logging-log4j2/pull/767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
carterkozak opened a new pull request #785:
URL: https://github.com/apache/logging-log4j2/pull/785
We should enable it again, however at the moment it's causing
all builds to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
garydgregory commented on pull request #785:
URL: https://github.com/apache/logging-log4j2/pull/785#issuecomment-1059479950
FWIW, over at Apache Commons, we use JApiCmp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rm5248 merged pull request #11:
URL: https://github.com/apache/logging-chainsaw/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
carterkozak commented on pull request #785:
URL: https://github.com/apache/logging-log4j2/pull/785#issuecomment-1059493292
I'll check it out :-)
Not planning to block this commit on investigating other options, hoping to
get builds green to unblock bugfixes in the interim
--
This is a
garydgregory commented on pull request #785:
URL: https://github.com/apache/logging-log4j2/pull/785#issuecomment-1059511327
Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
carterkozak merged pull request #785:
URL: https://github.com/apache/logging-log4j2/pull/785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
ppkarwasz merged pull request #768:
URL: https://github.com/apache/logging-log4j2/pull/768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
ppkarwasz merged pull request #771:
URL: https://github.com/apache/logging-log4j2/pull/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
carterkozak closed pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783#issuecomment-1059558347
Merged + changelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ppkarwasz closed pull request #731:
URL: https://github.com/apache/logging-log4j2/pull/731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819961953
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##
@@ -30,4 +40,22 @@ public void test
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819962777
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##
@@ -30,4 +40,22 @@ public void test
rm5248 merged pull request #102:
URL: https://github.com/apache/logging-log4cxx/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
ppkarwasz commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819963145
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##
@@ -30,4 +40,22 @@ public void testJir
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819963513
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/util/NetUtilsTest.java
##
@@ -17,24 +17,41 @@
package org.apache.loggin
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819964926
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##
@@ -30,4 +40,22 @@ public void test
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r819964926
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##
@@ -30,4 +40,22 @@ public void test
jvz commented on pull request #744:
URL: https://github.com/apache/logging-log4j2/pull/744#issuecomment-1059662150
@rgoers you can have a look now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rm5248 merged pull request #13:
URL: https://github.com/apache/logging-chainsaw/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
jvz commented on a change in pull request #744:
URL: https://github.com/apache/logging-log4j2/pull/744#discussion_r820151542
##
File path:
log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/di/ReflectiveCallerContext.java
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the
ppkarwasz opened a new pull request #786:
URL: https://github.com/apache/logging-log4j2/pull/786
Refactors the wrapping logic into single `wrap` or `adapt` methods to be
sure we always perform the correct logic.
--
This is an automated message from the Apache Git Service.
To respond to t
ppkarwasz commented on a change in pull request #786:
URL: https://github.com/apache/logging-log4j2/pull/786#discussion_r820201779
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/FileAppenderBuilder.java
##
@@ -125,21 +125,16 @@ public Appender par
ppkarwasz commented on a change in pull request #786:
URL: https://github.com/apache/logging-log4j2/pull/786#discussion_r820202030
##
File path: log4j-1.2-api/src/main/java/org/apache/log4j/Category.java
##
@@ -376,7 +376,7 @@ public Appender getAppender(final String name) {
ppkarwasz opened a new pull request #787:
URL: https://github.com/apache/logging-log4j2/pull/787
This adds a `ServiceLoader` which:
* automatically discards service classes, which can not be instantiated
(e.g. classes in the server's classloader of a servlet container), from the
li
andrei-ivanov commented on a change in pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#discussion_r820284822
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java
##
@@ -39,14 +39,15 @@
public class SmtpManager
jvz commented on a change in pull request #744:
URL: https://github.com/apache/logging-log4j2/pull/744#discussion_r820151542
##
File path:
log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/di/ReflectiveCallerContext.java
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the
pooja-achievement commented on pull request #786:
URL: https://github.com/apache/logging-log4j2/pull/786#issuecomment-1060245397
@ppkarwasz,
Hi Piotr,
I am not building log4j2 1.x bridge jars but downloading the jar. I wanted
to test with this Pull Request changes, is it possi
jochenw commented on pull request #787:
URL: https://github.com/apache/logging-log4j2/pull/787#issuecomment-1060283020
Shouldn't the dependency junit-pioneer have test scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
ppkarwasz commented on pull request #787:
URL: https://github.com/apache/logging-log4j2/pull/787#issuecomment-1060304477
@jochenw, yes and it has a `test` scope.
The scope of dependencies is inherited from the parent POM.
--
This is an automated message from the Apache Git Service.
To
ppkarwasz commented on pull request #786:
URL: https://github.com/apache/logging-log4j2/pull/786#issuecomment-1060427664
Hi @pooja-achievement ,
I am waiting for a second opinion on these changes: there is not much sense
in testing something that will not end up in the next release. If e
garydgregory commented on pull request #754:
URL: https://github.com/apache/logging-log4j2/pull/754#issuecomment-1060703907
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
garydgregory commented on pull request #778:
URL: https://github.com/apache/logging-log4j2/pull/778#issuecomment-1060704144
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r820722891
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##
@@ -30,4 +40,29 @@ public void test
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784#discussion_r820722891
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/ConfigurationSourceTest.java
##
@@ -30,4 +40,29 @@ public void test
garydgregory commented on a change in pull request #786:
URL: https://github.com/apache/logging-log4j2/pull/786#discussion_r820738169
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/bridge/FilterWrapper.java
##
@@ -27,6 +27,16 @@
private final org.apache.logg
ppkarwasz merged pull request #786:
URL: https://github.com/apache/logging-log4j2/pull/786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
ppkarwasz commented on pull request #776:
URL: https://github.com/apache/logging-log4j2/pull/776#issuecomment-1061241867
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
jvz commented on pull request #744:
URL: https://github.com/apache/logging-log4j2/pull/744#issuecomment-1061403755
I'd like to merge this sometime within the next couple weeks unless there
are some issues raised.
--
This is an automated message from the Apache Git Service.
To respond to
phreed opened a new pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788
Documentation corrections an updates as mentioned in
https://issues.apache.org/jira/b…rowse/LOG4J2-3429
Corrected typo in builder method 'withtFilter' -> 'withFilter'
--
This is an automated
membersound commented on pull request #777:
URL: https://github.com/apache/logging-log4j2/pull/777#issuecomment-1062647691
Could you add documentation how to activate this feature in future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ppkarwasz opened a new pull request #789:
URL: https://github.com/apache/logging-log4j2/pull/789
Adds support for custom Log4j 1.x levels in the form `level_name#class_name`.
Levels defined directly in Log4j 2.x can be used in the bridge using the
form `level_name#org.apache.logging.
garydgregory commented on a change in pull request #789:
URL: https://github.com/apache/logging-log4j2/pull/789#discussion_r822971298
##
File path: log4j-1.2-api/src/main/java/org/apache/log4j/Priority.java
##
@@ -96,6 +96,7 @@
transient int level;
transient String le
ppkarwasz commented on pull request #777:
URL: https://github.com/apache/logging-log4j2/pull/777#issuecomment-1063246235
> Could you add documentation how to activate this feature in future?
The behavior of the artifact does not change: you add it to the classpath
and Spring Boot det
ppkarwasz commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r822975410
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##
@@ -214,7 +214,7 @@ public Filter getFilter() {
ppkarwasz merged pull request #787:
URL: https://github.com/apache/logging-log4j2/pull/787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
phreed commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r823025534
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##
@@ -214,7 +214,7 @@ public Filter getFilter() {
ppkarwasz commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r823034883
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##
@@ -884,7 +893,7 @@ public Filter getFilter() {
phreed commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r823038591
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##
@@ -214,7 +214,7 @@ public Filter getFilter() {
phreed commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r823038591
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##
@@ -214,7 +214,7 @@ public Filter getFilter() {
ppkarwasz merged pull request #777:
URL: https://github.com/apache/logging-log4j2/pull/777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
ppkarwasz merged pull request #784:
URL: https://github.com/apache/logging-log4j2/pull/784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
garydgregory commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r823216495
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##
@@ -214,7 +214,7 @@ public Filter getFilter()
garydgregory commented on pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#issuecomment-1063505013
The "with" style is old, the "set" style is new. We already deprecated a
bunch of "with" methods in favor of "set" methods.
--
This is an automated message from the
5001 - 5100 of 7264 matches
Mail list logo
