cremor commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685717421
> Also I've dropped `net35-client` and `net40-client` as target frameworks,
because unable to compile against. Should we bring them back and test somehow
or deprecate and dro
cremor edited a comment on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-685715057
@fluffynuts Thanks for the pointer to #63 and for the precompiled NuGet
package from that PR! I just tested it and it indeed fixes all of the points I
mentioned above.
cremor commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685723562
I'm not sure if this belongs to the changes made in this PR, but
https://logging.apache.org/log4net/ (with is the top Google result if you
search for "log4net") currently lea
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685726181
>
>
> I'd be very careful about dropping target frameworks. This is a breaking
change. All projects using that framework will no longer be able to use the
newe
jazpearson commented on pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-685875512
Would be great to see this merged as this is blocking us,
This is an automated message from the Apache Gi
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685935299
> Reflecting my previous experience adding or dropping targets are rarely
considered as breaking\major change, minor at best.
it's breaking for people who depend on it;
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685935299
> Reflecting my previous experience adding or dropping targets are rarely
considered as breaking\major change, minor at best.
it's breaking for people who de
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685935299
> Reflecting my previous experience adding or dropping targets are rarely
considered as breaking\major change, minor at best.
it's breaking for people who de
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685935299
> Reflecting my previous experience adding or dropping targets are rarely
considered as breaking\major change, minor at best.
it's breaking for people who de
fluffynuts commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685937486
@cremor thanks for reporting; logging sites are in a bit of a state of
upheaval right now (as far as I understand). Good people are On It.
--
rgoers commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685945845
Please try it again.
This is an automated message from the Apache Git Service.
To respond to the message, ple
rgoers commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685947511
FWIW, the documentation for publishing the web site is at
https://cwiki.apache.org/confluence/display/LOGGING/Managing+the+Git+Hosted+Web+Site.
So you would run your build to
fluffynuts commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685954452
Thanks for sorting it out @rgoers. I'll try to be better prepared next time.
This is an automated message
cremor commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-686260395
@rgoers Now the link https://logging.apache.org/log4net/ works, but the link
which is on https://logging.apache.org, which is
https://logging.apache.org/log4net/2.x/index.htm
rgoers commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-686268036
Thanks. Those should be fixed now.
This is an automated message from the Apache Git Service.
To respond to th
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-686364191
>
> Yes, it's a PITA to get the environment required to build all targets
(I've not only done it more than once, but struggled to find off-premise CI to
do so!) --
NicholasNoise edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-686364191
>
> Yes, it's a PITA to get the environment required to build all targets
(I've not only done it more than once, but struggled to find off-premise CI to
do
NicholasNoise commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-686386567
> Ok, the breaking change for the removed `ImmediateFlush` property in .NET
Standard 1.3 is not fixed. But I think that's ok since it was not functional
anyway.
cremor commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-686390781
I'm using the `DebugAppender` to get my logs to the Visual Studio output
window. This works fine for me (both with the old .NET Standard 1.3 log4net
assembly and with the new
triumlabs opened a new pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65
However netstandard contains cross-process Mutex, Android and iOS platform
does not support it.
Therefore, current implementation of RollingFileAppender cannot be used on
these platforms.
rm5248 merged pull request #35:
URL: https://github.com/apache/logging-log4cxx/pull/35
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-686943609
@NicholasNoise please have a look over the changes I've made to see that
you're happy with them.
Also, since I know building for the older targets can be a mission,
NicholasNoise commented on pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-687041804
Is there any way to test this behavior?
This is an automated message from the Apache Git Service.
To r
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-687048905
>
>
> @NicholasNoise please have a look over the changes I've made to see that
you're happy with them.
>
> Also, since I know building for the older targ
rm5248 opened a new pull request #39:
URL: https://github.com/apache/logging-log4cxx/pull/39
Fixes for building with Visual Studio 2019.
Also added new parameter LOG4CXX_TEST_PROGRAM_PATH to add a directory to
your PATH for tests.
---
fluffynuts merged pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-687820219
@NicholasNoise btw, I'd just like to update the build system in master to
produce the sha512 sigs at build time, sign artifacts from appveyer, update the
site and then I'
rgoers commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-687820716
I would suggest the next release include the fix for the open CVE as it is
confusing users as they are expecting it. My understanding is the the fix is on
the develop branch
rm5248 merged pull request #39:
URL: https://github.com/apache/logging-log4cxx/pull/39
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-687850791
@rgoers good idea. It's in a commit on develop and I'm not sure what else is
in there, so I'd like to simply cherry-pick that commit. I'll do so now.
---
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-687859915
>
>
> @NicholasNoise btw, I'd just like to update the build system in master to
produce the sha512 sigs at build time, sign artifacts from appveyer, update the
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-687882632
I've started the vote process, so it's pretty-much up to the rest of the
list and how much I've managed to mess up on this release (it's only my second,
but the first cou
SymbioticKilla closed pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
SymbioticKilla commented on pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-688103870
Commit wa merged to master branch.
This is an automated message from the Apache Git Service.
To respo
gengyuanzhe opened a new pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416
Call ReliabilityStrategy's beforeStopAppenders() method before stopping
AsyncAppender
to avoid errors caused by logging with AsyncAppender while system is
reconfiguring
Submitted by: g
rm5248 opened a new pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40
Add github actions to build automatically, as well as fix an error on OSX
with regards to a stream destructor.
This is an automated
gengyuanzhe commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688581496
@rgoers Can you help me review my pr?
This is an automated message from the Apache Git Service.
To res
gengyuanzhe edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688581496
@rgoers Can you help me review my pr? And maven test failed, does it
matter? I build the code without my commit and get the same test error.
--
gengyuanzhe edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688581496
@rgoers Can you help me review my pr? And CI maven build failed, does it
matter? I build the code **without my commit** and get the same test error.
--
ams-tschoening commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r484703370
##
File path: .gitattributes
##
@@ -0,0 +1 @@
+* text eol=lf
Review comment:
Looking at the docs, this setting doesn't support the spec
NicholasNoise opened a new pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66
NicholasNoise opened a new pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67
Fix CA2000, CA2237, CA3075
This is an automated message from the Apache Git Service.
To respond to the message, please log on
NicholasNoise commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688829374
@fluffynuts
This is an automated message from the Apache Git Service.
To respond to the message, plea
NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-688829338
@fluffynuts
This is an automated message from the Apache Git Service.
To respond to the message, plea
NicholasNoise commented on a change in pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#discussion_r484872716
##
File path: src/log4net/Appender/FileAppender.cs
##
@@ -1409,7 +1429,10 @@ virtual protected void OpenFile(string fileName, bool
append)
cremor commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688832079
Not directly related to this PR, but since you are modifying the
preprocessor symbols (constants) here I thought I should mention this:
SDK style projects already define va
NicholasNoise commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688843984
> @cremor
>
> Some of those are the same as are now manually defined in the
log4net.csproj and some are different. This might be confusing for developers
who d
gengyuanzhe edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688581496
@rgoers @jvz Can you help me review my pr? And CI maven build failed, does
it matter? I build the code **without my commit** and get the same test error.
-
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688978041
Right, those test failures are caused by a commit I made yesterday or two
days ago that I need to revert (haven't had a chance to do so yet). As long as
your PR isn't introduci
gengyuanzhe edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688581496
@rgoers @jvz Can you help me review my PR? And CI maven build failed, does
it matter? I build the code **without my commit** and get the same test error.
-
gengyuanzhe commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689044288
@jvz Truly appreciate your reply. I'm newer for this project. I wonder what
should I do next for this PR or issue?
--
fluffynuts commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-689052738
LGTM; when I have a moment, I'd like to pull down to my machine & build
again to double-check; I'm taking a day off from work tomorrow, so perhaps
Thursday (:
-
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689067307
If you're able to write a unit test that would fail without your PR and
passes with your PR, that would help a lot in preventing regressions.
Otherwise, one or more of the comm
gengyuanzhe commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689484275
@jvz This PR is about a concurrent problem. As we all know, concurrency
problems always require some kind of execution order. I cannot write a
standard unit test for t
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689613155
I usually use
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html
for chaining together asynchronous things (particularly in unit tests) where
y
jvz edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689613155
I usually use
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html
for chaining together asynchronous things (particularly in unit tests) w
gengyuanzhe commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689625878
@jvz I have described the reproduction step in great detail in [LOG4J2-2919
of Jira](https://issues.apache.org/jira/browse/LOG4J2-2919), and draw a picture
to illustrat
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689633564
Just the one Jira is fine, thanks!
This is an automated message from the Apache Git Service.
To respond to the
gengyuanzhe commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689637735
> Just the one Jira is fine, thanks!
Ok, it seems that you just open my Jira link a minute ago :joy:. Any way,
it's a big step forward. If you have question about
gengyuanzhe edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689625878
@jvz I have described the reproduction step in great detail in [LOG4J2-2919
of Jira](https://issues.apache.org/jira/browse/LOG4J2-2919), and draw a picture
to il
rm5248 commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r485957409
##
File path: .gitattributes
##
@@ -0,0 +1 @@
+* text eol=lf
Review comment:
It doesn't look like it, but we could perhaps be a bit more specif
rm5248 commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r485958746
##
File path: src/cmake/FindAPR-Util.cmake
##
@@ -29,7 +29,7 @@ endmacro(_apu_invoke)
find_program(APR_UTIL_CONFIG_EXECUTABLE
apu-1-config
-
rm5248 commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r485959173
##
File path: .gitignore
##
@@ -19,11 +19,15 @@ pom.xml.releaseBackup
release.properties
autom4te.cache/
+src/.vs
+src/**/__history
Review comment
dependabot[bot] commented on pull request #409:
URL: https://github.com/apache/logging-log4j2/pull/409#issuecomment-689966551
Superseded by #417.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] closed pull request #409:
URL: https://github.com/apache/logging-log4j2/pull/409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] opened a new pull request #417:
URL: https://github.com/apache/logging-log4j2/pull/417
Bumps [disruptor](https://github.com/conversant/disruptor) from 1.2.15 to
1.2.19.
Release notes
Sourced from https://github.com/conversant/disruptor/releases";>disruptor's
relea
ams-tschoening commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r486130766
##
File path: .gitattributes
##
@@ -0,0 +1 @@
+* text eol=lf
Review comment:
If we agree that `input` is not supported, keep things as
ams-tschoening commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r486131765
##
File path: .gitignore
##
@@ -19,11 +19,15 @@ pom.xml.releaseBackup
release.properties
autom4te.cache/
+src/.vs
+src/**/__history
Review
ams-tschoening commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r48617
##
File path: src/cmake/FindAPR-Util.cmake
##
@@ -29,7 +29,7 @@ endmacro(_apu_invoke)
find_program(APR_UTIL_CONFIG_EXECUTABLE
apu-1-con
stephen-webb commented on pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#issuecomment-690069314
Yes, using the environment variable would be better, although there is not
any standard place to look for libraries in Windows AFAIK.
I copied those hints from
rgoers commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-690532163
None of this was your fault. All these issues were related to me moving the
site from the ASF CMS system to GitHub.
Ralph
> On Sep 10, 2020, at 9:50 AM, Davyd Mc
dependabot[bot] commented on pull request #382:
URL: https://github.com/apache/logging-log4j2/pull/382#issuecomment-690860228
Superseded by #418.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] opened a new pull request #418:
URL: https://github.com/apache/logging-log4j2/pull/418
Bumps [wiremock](https://github.com/tomakehurst/wiremock) from 2.19.0 to
2.27.2.
Commits
https://github.com/tomakehurst/wiremock/commit/56d7a087a3d28685c8d797636e8e5e263fbfcf
dependabot[bot] closed pull request #382:
URL: https://github.com/apache/logging-log4j2/pull/382
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ams-tschoening commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r487390714
##
File path: src/cmake/FindAPR-Util.cmake
##
@@ -29,7 +29,7 @@ endmacro(_apu_invoke)
find_program(APR_UTIL_CONFIG_EXECUTABLE
apu-1-con
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-691507743
Ooh yeah, this is going to be an interesting test to write. This will likely
require some test-specific refactoring. Let me see if I can figure this out! :)
--
fluffynuts commented on pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-691513183
Thanks, this fix is now in master & should be available in release 2.0.10
This is an automated message fr
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691513310
@NicholasNoise the vote passed, package 2.0.10 is up at nuget.org; the site
should hopefully be updated when someone with the required permissions has some
time.
--
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691513310
@NicholasNoise the vote passed, package 2.0.10 is up at nuget.org; the site
should hopefully be updated when someone with the required permissions to
publish has s
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-691520808
Turns out this didn't really need any concurrency primitives as I found an
appropriate extension point to assert behavior upon.
---
jvz merged pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273
@fluffynuts thanks!
I'll test it in live environment and come back with a feedback.
btw, this release is a bit messed up
([1](https://github.com/apache/loggin
ams-tschoening commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r487390714
##
File path: src/cmake/FindAPR-Util.cmake
##
@@ -29,7 +29,7 @@ endmacro(_apu_invoke)
find_program(APR_UTIL_CONFIG_EXECUTABLE
apu-1-con
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273
@fluffynuts thanks!
I'll test it in live environment and come back with a feedback.
btw, this release is a bit messed up
([1](https://github.com/apache/loggin
jvz merged pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] commented on pull request #382:
URL: https://github.com/apache/logging-log4j2/pull/382#issuecomment-690860228
Superseded by #418.
This is an automated message from the Apache Git Service.
To respond to the mes
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691513310
@NicholasNoise the vote passed, package 2.0.10 is up at nuget.org; the site
should hopefully be updated when someone with the required permissions to
publish has s
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-691507743
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
fluffynuts commented on pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-691513183
Thanks, this fix is now in master & should be available in release 2.0.10
This is an automated message fr
dependabot[bot] closed pull request #382:
URL: https://github.com/apache/logging-log4j2/pull/382
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691513310
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691525273
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
jvz merged pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dependabot[bot] commented on pull request #382:
URL: https://github.com/apache/logging-log4j2/pull/382#issuecomment-690860228
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691513310
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-691507743
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
fluffynuts commented on pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-691513183
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dependabot[bot] closed pull request #382:
URL: https://github.com/apache/logging-log4j2/pull/382
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-691513310
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
ams-tschoening commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r487390714
##
File path: src/cmake/FindAPR-Util.cmake
##
@@ -29,7 +29,7 @@ endmacro(_apu_invoke)
find_program(APR_UTIL_CONFIG_EXECUTABLE
apu-1-con
501 - 600 of 7264 matches
Mail list logo
