vy merged pull request #415:
URL: https://github.com/apache/logging-log4j2/pull/415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy merged pull request #660:
URL: https://github.com/apache/logging-log4j2/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #660:
URL: https://github.com/apache/logging-log4j2/pull/660#issuecomment-1029752144
Thanks @KristjanESPERANTO!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
sman-81 commented on pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-1029773783
Hi there @carterkozak now `String#split` is gone. I have also squashed
commits into one. Please take a look.
--
This is an automated message from the Apache Git Service.
garydgregory merged pull request #737:
URL: https://github.com/apache/logging-log4j2/pull/737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
garydgregory commented on a change in pull request #737:
URL: https://github.com/apache/logging-log4j2/pull/737#discussion_r799819579
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
##
@@ -107,6 +110,24 @@ public Appende
carterkozak closed pull request #722:
URL: https://github.com/apache/logging-log4j2/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on pull request #722:
URL: https://github.com/apache/logging-log4j2/pull/722#issuecomment-1030406105
Closing in favor of #732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
carterkozak commented on pull request #732:
URL: https://github.com/apache/logging-log4j2/pull/732#issuecomment-1030409561
I've added a bit of code to unescape escaped lookups, which will allow
existing properties to work as expected. Rather than `value.replace("$${",
"${")`, I'm using a `
ppkarwasz commented on a change in pull request #737:
URL: https://github.com/apache/logging-log4j2/pull/737#discussion_r800038422
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
##
@@ -107,6 +110,24 @@ public Appender p
ppkarwasz opened a new pull request #742:
URL: https://github.com/apache/logging-log4j2/pull/742
This PR fixes the order of the property sources to:
1. Spring Boot properties with lowest numerical priority (overrides all
others). In a Spring Boot application with `log4j-spring` prese
ppkarwasz commented on pull request #711:
URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1030910407
Since the change `XmlLayout` -> `Log4j1XmlLayout` has been included in
commit
[5858f048](https://github.com/apache/logging-log4j2/commit/5858f0483de5fb93a8b80a5d46abe3cd
ppkarwasz commented on pull request #742:
URL: https://github.com/apache/logging-log4j2/pull/742#issuecomment-1030915802
This PR should also solve the problem of PR #601.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
dependabot[bot] opened a new pull request #743:
URL: https://github.com/apache/logging-log4j2/pull/743
Bumps
[maven-assembly-plugin](https://github.com/apache/maven-assembly-plugin) from
3.1.0 to 3.3.0.
Commits
https://github.com/apache/maven-assembly-plugin/commit/5a48193bc2
vy merged pull request #743:
URL: https://github.com/apache/logging-log4j2/pull/743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
carterkozak commented on a change in pull request #732:
URL: https://github.com/apache/logging-log4j2/pull/732#discussion_r801118459
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/PropertiesPlugin.java
##
@@ -45,15 +47,62 @@ private PropertiesPlugi
jvz opened a new pull request #744:
URL: https://github.com/apache/logging-log4j2/pull/744
This replaces the previous attempt at unifying dependency injection and
configuration from a CDI-like API to an API more like javax.inject used
by libraries like Feather and Guice.
https:
jvz commented on a change in pull request #744:
URL: https://github.com/apache/logging-log4j2/pull/744#discussion_r801247382
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/convert/CoreTypeConverters.java
##
@@ -73,17 +73,6 @@ public BigInte
ppkarwasz commented on a change in pull request #742:
URL: https://github.com/apache/logging-log4j2/pull/742#discussion_r801299292
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
##
@@ -435,17 +452,18 @@ private Environment(final Propert
ppkarwasz commented on a change in pull request #742:
URL: https://github.com/apache/logging-log4j2/pull/742#discussion_r801300914
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
##
@@ -454,28 +472,36 @@ private synchronized void reload(
ppkarwasz commented on a change in pull request #742:
URL: https://github.com/apache/logging-log4j2/pull/742#discussion_r801301570
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertySource.java
##
@@ -34,7 +38,7 @@
/**
* Returns the order
vy commented on pull request #720:
URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1032514375
Thanks so much @avandeursen! Changes look good to me, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vy merged pull request #720:
URL: https://github.com/apache/logging-log4j2/pull/720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
garydgregory commented on a change in pull request #742:
URL: https://github.com/apache/logging-log4j2/pull/742#discussion_r801556257
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
##
@@ -435,17 +452,18 @@ private Environment(final Prop
Kay-kay2019 commented on pull request #720:
URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1032534236
>Thank you 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Kay-kay2019 commented on a change in pull request #742:
URL: https://github.com/apache/logging-log4j2/pull/742#discussion_r801560830
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
##
@@ -435,17 +452,18 @@ private Environment(final Prope
ppkarwasz commented on a change in pull request #742:
URL: https://github.com/apache/logging-log4j2/pull/742#discussion_r801615031
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
##
@@ -435,17 +452,18 @@ private Environment(final Propert
tobylo commented on pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-1032698509
I'm going to assume this change is the reason we no longer get XML logs for
our .NET framework services after upgrading from 2.0.12 to 2.0.14. Works for
netcoreapp, net5 and
tobylo edited a comment on pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-1032698509
I suspect this change is the reason we no longer get XML logs for our .NET
framework services after upgrading from 2.0.12 to 2.0.14. Works for netcoreapp,
net5 and ne
gubasza commented on pull request #744:
URL: https://github.com/apache/logging-log4j2/pull/744#issuecomment-1032933311
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
gubasza removed a comment on pull request #744:
URL: https://github.com/apache/logging-log4j2/pull/744#issuecomment-1032933311
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
carterkozak merged pull request #732:
URL: https://github.com/apache/logging-log4j2/pull/732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
ppkarwasz opened a new pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745
Since `javax.mail` and `jakarta.mail` use different package names, as single
`SmtpAppender` can use both through different managers.
Unfortunately the implementations `com.sun.mail:javax.
ppkarwasz commented on a change in pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#discussion_r802110065
##
File path: pom.xml
##
@@ -687,10 +691,43 @@
true
+
+javax.mail
+javax.mail-api
+${javax.m
ppkarwasz commented on a change in pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#discussion_r802111545
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java
##
@@ -39,14 +39,15 @@
public class SmtpManagerTest
garydgregory commented on pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1033126921
IMO, anything new that depends on other dependencies should be in a new
Maven module.
--
This is an automated message from the Apache Git Service.
To respond to the
ppkarwasz commented on pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1033157134
@garydgregory: I think of this as a nice application of the separation
between appenders and managers, which mitigates the problems of the
jakartification.
Howeve
jvz commented on pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1033294601
> However I see you point: the `SmtpAppender` and `JmsAppender` probably
should be moved out of `log4j-core` and a jakartified version should be
provided separately.
Al
dependabot[bot] opened a new pull request #746:
URL: https://github.com/apache/logging-log4j2/pull/746
Bumps
[de.flapdoodle.embed.mongo](https://github.com/flapdoodle-oss/embedmongo.flapdoodle.de)
from 3.2.8 to 3.3.1.
Changelog
Sourced from https://github.com/flapdoodle-oss/de.fl
dependabot[bot] opened a new pull request #747:
URL: https://github.com/apache/logging-log4j2/pull/747
Bumps [json-unit](https://github.com/lukas-krecan/JsonUnit) from 2.28.0 to
2.31.0.
Commits
https://github.com/lukas-krecan/JsonUnit/commit/2f6a580d03babc4c6f2536d6e47571447a7
ppkarwasz edited a comment on pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1033157134
@garydgregory: I think of this as a nice application of the separation
between appenders and managers, which mitigates the problems of the
jakartification.
ppkarwasz commented on pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1034024340
@jvz: is there any sense in using `javax.*` in the 3.0 release? Spring Boot
6.0 with a baseline of Java 17 and Jakarta EE 9 is due at the end of this year.
--
This is
ppkarwasz edited a comment on pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1034024340
@jvz: is there any sense in using `javax.*` in the 3.0 release? Spring Boot
6.0 with a baseline of Java 17 and Jakarta EE 9 is due at the end of this year.
How ma
jvz commented on pull request #745:
URL: https://github.com/apache/logging-log4j2/pull/745#issuecomment-1034062599
I think as long as the maintenance burden is low enough, we can keep support
for the old APIs indefinitely. Our Java baseline there is 11, so not as
aggressive as Spring's bas
dependabot[bot] opened a new pull request #748:
URL: https://github.com/apache/logging-log4j2/pull/748
Bumps
[docker-maven-plugin](https://github.com/fabric8io/docker-maven-plugin) from
0.33.0 to 0.39.0.
Release notes
Sourced from https://github.com/fabric8io/docker-maven-plugin/
mneundorfer opened a new pull request #749:
URL: https://github.com/apache/logging-log4j2/pull/749
…5424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
mneundorfer closed pull request #749:
URL: https://github.com/apache/logging-log4j2/pull/749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
dependabot[bot] opened a new pull request #750:
URL: https://github.com/apache/logging-log4j2/pull/750
Bumps [liquibase-core](https://github.com/liquibase/liquibase) from 3.5.5 to
3.10.3.
Release notes
Sourced from https://github.com/liquibase/liquibase/releases";>liquibase-core's
fluffynuts commented on pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-1035938068
@tobylo I've been looking into this as part of another issue - there's a
similar situation in the "non-log4j" variant which I had to update for the test
app I wrote to w
tobylo edited a comment on pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-1035993131
@fluffynuts We haven't noticed being affected by the other issues that we're
fixed in the .13 and .14 releases, so from our point of view, better roll
forward with a
tobylo commented on pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-1035993131
We haven't noticed being affected by the other issues that we're fixed in
the .13 and .14 releases, so from our point of view, better roll forward with a
proper fix when you
tobylo edited a comment on pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-1035993131
@fluffynuts We haven't noticed being affected by the other issues that were
fixed in the .13 and .14 releases, so from our point of view, better roll
forward with a p
vy merged pull request #748:
URL: https://github.com/apache/logging-log4j2/pull/748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
garydgregory commented on pull request #751:
URL: https://github.com/apache/logging-log4j2/pull/751#issuecomment-1036431239
Needs a test, otherwise the behavior can be reverted. When can this happen?
See
https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Method.html#getName--
--
breun opened a new pull request #22:
URL: https://github.com/apache/logging-log4j-kotlin/pull/22
Closes LOG4J-3401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
rocketraman commented on pull request #22:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/22#issuecomment-1036623091
Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rocketraman merged pull request #22:
URL: https://github.com/apache/logging-log4j-kotlin/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
rocketraman commented on pull request #22:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/22#issuecomment-1036624072
@jvz I don't have rights to close the issue in JIRA:
https://issues.apache.org/jira/browse/LOG4J2-3401.
--
This is an automated message from the Apache Git Serv
jvz commented on pull request #22:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/22#issuecomment-1037552802
I resolved the issue. You should have permissions on Jira to edit issues.
Did you log in with your LDAP account?
--
This is an automated message from the Apache Git Ser
rgoers commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1037900620
@carterkozak Does the PR you merged make this PR obsolete? My understanding
is that recursion isn't allowed anywhere now.
--
This is an automated message from the Apache
gomezabajo closed pull request #751:
URL: https://github.com/apache/logging-log4j2/pull/751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifi
carterkozak commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1038248519
Yes, this is obsolete. We have much stricter controls over where recursion
is and is not allowed.
--
This is an automated message from the Apache Git Service.
To res
srdo closed pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1038251524
Sounds good, I'll close this then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1038251524
Sounds good, I'll close this then.
For reference, the commit in question is
https://github.com/apache/logging-log4j2/commit/17a77f5c27bda545de4b8eda46590401313e0
breun opened a new pull request #23:
URL: https://github.com/apache/logging-log4j-kotlin/pull/23
Closes LOG4J2-3400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
srdo closed pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
rgoers commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1037900620
@carterkozak Does the PR you merged make this PR obsolete? My understanding
is that recursion isn't allowed anywhere now.
--
This is an automated message from the Apache
carterkozak commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1038248519
Yes, this is obsolete. We have much stricter controls over where recursion
is and is not allowed.
--
This is an automated message from the Apache Git Service.
To res
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1038251524
Sounds good, I'll close this then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1038251524
Sounds good, I'll close this then.
For reference, the commit in question is
https://github.com/apache/logging-log4j2/commit/17a77f5c27bda545de4b8eda46590401313e0
gomezabajo closed pull request #751:
URL: https://github.com/apache/logging-log4j2/pull/751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifi
jvz commented on pull request #22:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/22#issuecomment-1037552802
I resolved the issue. You should have permissions on Jira to edit issues.
Did you log in with your LDAP account?
--
This is an automated message from the Apache Git Ser
dependabot[bot] opened a new pull request #752:
URL: https://github.com/apache/logging-log4j2/pull/752
Bumps [maven-jxr-plugin](https://github.com/apache/maven-jxr) from 2.5 to
3.1.1.
Commits
https://github.com/apache/maven-jxr/commit/08070062e18b3cf1646147ff961f49f00e69b643";
vy merged pull request #752:
URL: https://github.com/apache/logging-log4j2/pull/752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
mikkorantalainen commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-1039259530
> I am also inclined to avoid convoluting the API with implementation
details. Messages are safe, it is how the implementation deals with them which
makes them un
fulldecent commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-1039618532
@vy The mailing list post you cite argues that "API isn't intended to be
interpreted..."
Therefore, Log4j2 is still underspecified.
That is the subject of
rgoers commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-1039639817
1. This is a pull request not an issue. If you wanted an issue you would
need to use Jira.
2. This is not even close to being a vulnerability. In no world has a
vulnerab
ppkarwasz opened a new pull request #753:
URL: https://github.com/apache/logging-log4j2/pull/753
This PR fixes a couple of issues concerning filters in the Log4j 1.x bridge:
- there is an endless loop in `FilterAdapter#filter` that hangs the program
if more than one filter per appen
ppkarwasz commented on a change in pull request #753:
URL: https://github.com/apache/logging-log4j2/pull/753#discussion_r806304150
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/bridge/FilterAdapter.java
##
@@ -37,14 +81,14 @@ public Result filter(LogEvent event) {
ppkarwasz commented on a change in pull request #753:
URL: https://github.com/apache/logging-log4j2/pull/753#discussion_r806306691
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/filter/CompositeFilter.java
##
@@ -62,9 +62,9 @@ public CompositeFilter addFi
garydgregory commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-1039676373
I agree with all of @rgoers 's points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dependabot[bot] opened a new pull request #754:
URL: https://github.com/apache/logging-log4j2/pull/754
Bumps maven-bundle-plugin from 3.5.0 to 5.1.4.
[ {
fulldecent commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-1039618532
@vy The mailing list post you cite argues that "API isn't intended to be
interpreted..."
Therefore, Log4j2 is still underspecified.
That is the subject of
ppkarwasz commented on a change in pull request #753:
URL: https://github.com/apache/logging-log4j2/pull/753#discussion_r806304150
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/bridge/FilterAdapter.java
##
@@ -37,14 +81,14 @@ public Result filter(LogEvent event) {
mikkorantalainen commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-1039259530
> I am also inclined to avoid convoluting the API with implementation
details. Messages are safe, it is how the implementation deals with them which
makes them un
rgoers commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-1039639817
1. This is a pull request not an issue. If you wanted an issue you would
need to use Jira.
2. This is not even close to being a vulnerability. In no world has a
vulnerab
garydgregory commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-1039676373
I agree with all of @rgoers 's points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
marcushoja opened a new pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755
using log4j1.2-api-2.x bridge with log4j.properties a blank after
MaxBackupIndex= stops creating the appender and logging is disabled
--
This is an automated message from the Apache Git Serv
marcushoja commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1040828316
an invisible NumberFormatException is thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
vy merged pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
garydgregory commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1041405005
Just a second... would it not be better to look for all call sites and
refactor this kind of convertion into an internal utility?
--
This is an automated message f
ppkarwasz opened a new pull request #756:
URL: https://github.com/apache/logging-log4j2/pull/756
When a default `PatternLayout` is created without a `Configuration` a new
`DefaultConfiguration` is created and abandoned. This causes a leak of
`ConsoleManager`s.
This PR provides a `Co
carterkozak commented on a change in pull request #756:
URL: https://github.com/apache/logging-log4j2/pull/756#discussion_r808076590
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AbstractManager.java
##
@@ -204,6 +204,13 @@ protected static Stat
ppkarwasz commented on pull request #756:
URL: https://github.com/apache/logging-log4j2/pull/756#issuecomment-1041594559
@carterkozak: I'll check if we can leave the `Configuration` as `null` and
update the PR.
--
This is an automated message from the Apache Git Service.
To respond to th
vy commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1041787442
@garydgregory I have indeed addressed this everywhere in
`DefaultRolloverStrategy`. For practicing this throughout the entire code base,
be my guest. :wink:
--
This is an au
ppkarwasz commented on a change in pull request #756:
URL: https://github.com/apache/logging-log4j2/pull/756#discussion_r808247913
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java
##
@@ -763,10 +762,7 @@ public Builder withFooter(f
ppkarwasz commented on pull request #756:
URL: https://github.com/apache/logging-log4j2/pull/756#issuecomment-1041943565
@carterkozak: that should do it.
As far as I can see, no NPEs will result from providing `null` as
configuration in the `PatternLayout`. I added a null check for t
ppkarwasz commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1042361172
@vy: shouldn't `max` be of type `Integer`, so that the injection framework
takes care of the conversion?
This would break the API, so can probably only be done in
4801 - 4900 of 7264 matches
Mail list logo
