[GitHub] [logging-log4j2] carterkozak commented on pull request #730: LOG4J2-3368 Bump Tomcat from 8.5.20 to 10.0.14 in log4j-appserver along with some dependency clean-up.

2022-01-26 Thread GitBox
carterkozak commented on pull request #730: URL: https://github.com/apache/logging-log4j2/pull/730#issuecomment-1022497645 I defer to @garydgregory for Tomact knowledge, but I'd question bumping a minimum dependency constraint two major versions in a patch release. -- This is an automate

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #730: LOG4J2-3368 Bump Tomcat from 8.5.20 to 10.0.14 in log4j-appserver along with some dependency clean-up.

2022-01-26 Thread GitBox
ppkarwasz commented on pull request #730: URL: https://github.com/apache/logging-log4j2/pull/730#issuecomment-1022528780 The only Tomcat class used by Log4j is `org.apache.juli.logging.Log`, which has not been modified in ages (cf. [Github](https://github.com/apache/tomcat/blob/main/java/o

[GitHub] [logging-log4cxx] rm5248 commented on pull request #106: Sonarcloud build

2022-01-26 Thread GitBox
rm5248 commented on pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106#issuecomment-1022725569 Merging to master does produce a number of(expected) bugs: https://sonarcloud.io/summary/overall?id=log4cxx It's scanning a bunch of files that we don't care about a

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #731: Adds a Tomcat lookup

2022-01-26 Thread GitBox
ppkarwasz opened a new pull request #731: URL: https://github.com/apache/logging-log4j2/pull/731 The `TomcatLookup` can be used to retrieve the engine, host and context names under which the application is running. These are also provided by the original Tomcat JULI implementation (cf. [C

[GitHub] [logging-log4j2] vy commented on pull request #690: Add mention of "CVE creation process" to the security page.

2022-01-27 Thread GitBox
vy commented on pull request #690: URL: https://github.com/apache/logging-log4j2/pull/690#issuecomment-1022966398 Really sharp of you @jvz! :hocho: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [logging-log4j2] vy merged pull request #728: Bump plexus-utils from 3.4.0 to 3.4.1

2022-01-27 Thread GitBox
vy merged pull request #728: URL: https://github.com/apache/logging-log4j2/pull/728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] rdotterer09 commented on a change in pull request #722: LOG4J2-3350: Evaluate configuration property substitutions eagerly

2022-01-27 Thread GitBox
rdotterer09 commented on a change in pull request #722: URL: https://github.com/apache/logging-log4j2/pull/722#discussion_r792815957 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/Property.java ## @@ -57,6 +63,14 @@ public String getName() {

[GitHub] [logging-log4j2] vy merged pull request #729: Fixes a StringIndexOutOfBoundsException

2022-01-27 Thread GitBox
vy merged pull request #729: URL: https://github.com/apache/logging-log4j2/pull/729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #729: Fixes a StringIndexOutOfBoundsException

2022-01-27 Thread GitBox
vy commented on pull request #729: URL: https://github.com/apache/logging-log4j2/pull/729#issuecomment-1023334369 Thanks so much @ppkarwasz! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [logging-log4j2] avandeursen commented on a change in pull request #731: Adds a Tomcat lookup

2022-01-27 Thread GitBox
avandeursen commented on a change in pull request #731: URL: https://github.com/apache/logging-log4j2/pull/731#discussion_r793929483 ## File path: log4j-appserver/src/main/java/org/apache/logging/log4j/appserver/tomcat/TomcatLookup.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #731: Adds a Tomcat lookup

2022-01-27 Thread GitBox
ppkarwasz commented on a change in pull request #731: URL: https://github.com/apache/logging-log4j2/pull/731#discussion_r793958070 ## File path: log4j-appserver/src/main/java/org/apache/logging/log4j/appserver/tomcat/TomcatLookup.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to th

[GitHub] [logging-log4j2] carterkozak opened a new pull request #732: LOG4J2-3350: Lookup recursion is not allowed, except through config properties

2022-01-27 Thread GitBox
carterkozak opened a new pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732 Previously lookups between configuration properties weren't evaluated until they were used in the configuration, which resulted in behavior more prohibitive for RoutingAppenders than anti

[GitHub] [logging-log4j2] jvz opened a new pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
jvz opened a new pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733 This adds a properties format feature where the property names "rootLogger" and "logger." can be set to a level and one or more appender refs. https://issues.apache.org/jira/browse/LOG4J2-3341

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #734: Bump mockitoVersion from 4.2.0 to 4.3.1

2022-01-27 Thread GitBox
dependabot[bot] opened a new pull request #734: URL: https://github.com/apache/logging-log4j2/pull/734 Bumps `mockitoVersion` from 4.2.0 to 4.3.1. Updates `mockito-core` from 4.2.0 to 4.3.1 Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's

[GitHub] [logging-log4j2] Apache9 commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
Apache9 commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794212770 ## File path: log4j-core/src/test/resources/LoggerLevelAppenderTest.properties ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794221405 ## File path: log4j-core/src/test/resources/LoggerLevelAppenderTest.properties ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794221405 ## File path: log4j-core/src/test/resources/LoggerLevelAppenderTest.properties ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
rgoers commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794225373 ## File path: log4j-core/src/test/resources/LoggerLevelAppenderTest.properties ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (A

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
rgoers commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794225373 ## File path: log4j-core/src/test/resources/LoggerLevelAppenderTest.properties ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (A

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794225556 ## File path: log4j-core/src/test/resources/LoggerLevelAppenderTest.properties ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794226178 ## File path: log4j-core/src/test/resources/RootLoggerLevelAppenderTest.properties ## @@ -0,0 +1,21 @@ +# +# Licensed to the Apache Software Foundation (

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794225556 ## File path: log4j-core/src/test/resources/LoggerLevelAppenderTest.properties ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-27 Thread GitBox
ppkarwasz commented on pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#issuecomment-1023935035 @jvz: maybe you can add a default for all component names: `name = key.replaceAll("-", ".")`? This way you'll allow also to configure a logger in one property: `l

[GitHub] [logging-log4j2] Apache9 commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
Apache9 commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794282859 ## File path: log4j-core/src/test/resources/LoggerLevelAppenderTest.properties ## @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation (

[GitHub] [logging-log4cxx] pseiderer opened a new pull request #107: boost-fallback: only check for boost if really needed

2022-01-28 Thread GitBox
pseiderer opened a new pull request #107: URL: https://github.com/apache/logging-log4cxx/pull/107 - only check for boost if really needed (in case of legacy c++ standard < c++17) Signed-off-by: Peter Seiderer --- Notes: - fixes the following buildroot configure/compil

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
carterkozak commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794523439 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java ## @@ -190,6 +193,17

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #732: LOG4J2-3350: Lookup recursion is not allowed, except through config properties

2022-01-28 Thread GitBox
carterkozak commented on a change in pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732#discussion_r794552367 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/PropertiesPlugin.java ## @@ -45,15 +46,14 @@ private PropertiesPlugi

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #732: LOG4J2-3350: Lookup recursion is not allowed, except through config properties

2022-01-28 Thread GitBox
carterkozak commented on a change in pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732#discussion_r794553848 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/LookupResult.java ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4j2] garydgregory commented on pull request #732: LOG4J2-3350: Lookup recursion is not allowed, except through config properties

2022-01-28 Thread GitBox
garydgregory commented on pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732#issuecomment-1024309838 Maybe this is the wrong place to ask but it feels to me we are going about this backward or I am missing some information. I would find it helpful to work from the do

[GitHub] [logging-log4j2] vorburger closed pull request #700: StatusLogger uses default status level configured from property not just for listeners but all its logging (fixes LOG4J2-3340)

2022-01-28 Thread GitBox
vorburger closed pull request #700: URL: https://github.com/apache/logging-log4j2/pull/700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794643584 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java ## @@ -190,6 +193,17 @@ publi

[GitHub] [logging-log4j2] jvz commented on pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz commented on pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#issuecomment-1024367931 > @jvz: maybe you can add a default for all component names: `name = key.replaceAll("-", ".")`? This way you'll allow also to configure a logger in one property: > > `l

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794645183 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java ## @@ -190,6 +193,17 @@ publi

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794647949 ## File path: log4j-core/src/test/resources/RootLoggerLevelAppenderTest.properties ## @@ -0,0 +1,21 @@ +# +# Licensed to the Apache Software Foundation (

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794652735 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java ## @@ -190,6 +193,17 @@ publi

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
carterkozak commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794655910 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java ## @@ -190,6 +193,17

[GitHub] [logging-log4j2] jvz commented on a change in pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz commented on a change in pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#discussion_r794657514 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java ## @@ -190,6 +193,17 @@ publi

[GitHub] [logging-log4j2] carterkozak commented on pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

2022-01-28 Thread GitBox
carterkozak commented on pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717#issuecomment-1024420037 committed as fc31b44b629d9fe46bd96bfd02382519dfdb5f40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] carterkozak closed pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

2022-01-28 Thread GitBox
carterkozak closed pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] carterkozak commented on pull request #732: LOG4J2-3350: Lookup recursion is not allowed, except through config properties

2022-01-28 Thread GitBox
carterkozak commented on pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732#issuecomment-1024613948 This experiment came out of a discussion with Ralph, and deserves more context in this PR. This is still marked as a draft, and needs a better description of intent an

[GitHub] [logging-log4j2] carterkozak commented on pull request #732: LOG4J2-3350: Lookup recursion is not allowed, except through config properties

2022-01-28 Thread GitBox
carterkozak commented on pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732#issuecomment-1024737180 I have updated the description with several more words :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [logging-log4j2] jvz commented on pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz commented on pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#issuecomment-1024803593 I've squashed what's been reviewed. Will add more commits for docs and changelog. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [logging-log4j2] jvz merged pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz merged pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [logging-log4j2] jvz commented on pull request #729: Fixes a StringIndexOutOfBoundsException

2022-01-28 Thread GitBox
jvz commented on pull request #729: URL: https://github.com/apache/logging-log4j2/pull/729#issuecomment-1024824326 Noticed this is needed in master as well in order to support the new properties format features. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
ppkarwasz commented on pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#issuecomment-1024854364 @jvz: #729 drops previously invalid entries like `logger.core-config-properties=INFO,app1,app2`. You should probably add a test for that. -- This is an automated mess

[GitHub] [logging-log4j2] jvz commented on pull request #733: [LOG4J2-3341] Support logger level and appender refs shorthand

2022-01-28 Thread GitBox
jvz commented on pull request #733: URL: https://github.com/apache/logging-log4j2/pull/733#issuecomment-1024854475 I have some code in PropertiesConfigurationBuilder that manually includes the invalid keys left behind. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [logging-log4j2] jvz commented on pull request #727: Bump h2 from 1.4.200 to 2.1.210

2022-01-29 Thread GitBox
jvz commented on pull request #727: URL: https://github.com/apache/logging-log4j2/pull/727#issuecomment-1024861520 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [logging-log4j2] jvz commented on pull request #695: Bump liquibase-core from 3.5.5 to 4.7.0

2022-01-29 Thread GitBox
jvz commented on pull request #695: URL: https://github.com/apache/logging-log4j2/pull/695#issuecomment-1024861817 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [logging-log4j2] jvz commented on pull request #727: Bump h2 from 1.4.200 to 2.1.210

2022-01-29 Thread GitBox
jvz commented on pull request #727: URL: https://github.com/apache/logging-log4j2/pull/727#issuecomment-1024861926 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #695: Bump liquibase-core from 3.5.5 to 4.7.0

2022-01-29 Thread GitBox
dependabot[bot] commented on pull request #695: URL: https://github.com/apache/logging-log4j2/pull/695#issuecomment-1024862206 OK, I won't notify you about version 4.x.x again, unless you re-open this PR or update to a 4.x.x release yourself. -- This is an automated message from the Apac

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #695: Bump liquibase-core from 3.5.5 to 4.7.0

2022-01-29 Thread GitBox
dependabot[bot] closed pull request #695: URL: https://github.com/apache/logging-log4j2/pull/695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] jvz commented on pull request #695: Bump liquibase-core from 3.5.5 to 4.7.0

2022-01-29 Thread GitBox
jvz commented on pull request #695: URL: https://github.com/apache/logging-log4j2/pull/695#issuecomment-1024862185 @dependabot ignore this major version Breaking API changes. Probably needs a new module. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #735: Adds a shorthand method to specify components names

2022-01-29 Thread GitBox
ppkarwasz opened a new pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735 As an extension of #733, this PR allows to specify the name of any component in its key. Dots in components names are escaped using dashes `-`. Since this is not the only way to specify a compo

[GitHub] [logging-log4j2] garydgregory commented on pull request #735: Adds a shorthand method to specify components names

2022-01-29 Thread GitBox
garydgregory commented on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1024942878 Do we really want to open the door here? What about underscore? Any valid Java name separators? What about mixing separators? -- This is an automated message from

[GitHub] [logging-log4j2] carterkozak commented on pull request #735: Adds a shorthand method to specify components names

2022-01-29 Thread GitBox
carterkozak commented on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1024944765 I agree with Gary. I’m concerned about the user experience, when an operator sees logger.org-apache-foo it’s not going to be obvious that is equivalent to org.apache.f

[GitHub] [logging-log4j2] ronosaurus opened a new pull request #736: LOG4J2-3332: SmtpAppender - option for sending buffered messages as an email attachment (text, zip, gzip)

2022-01-29 Thread GitBox
ronosaurus opened a new pull request #736: URL: https://github.com/apache/logging-log4j2/pull/736 DO NOT MERGE: candidate for a 2.19 release after more important changes occur in 2.18 ``` // logEvents.html.zip smtpBuilder.setAttachEvents(true); smtpBuilder.setAttachEventsCo

[GitHub] [logging-log4cxx] rm5248 merged pull request #107: boost-fallback: only check for boost if really needed

2022-01-29 Thread GitBox
rm5248 merged pull request #107: URL: https://github.com/apache/logging-log4cxx/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [logging-log4cxx] rm5248 commented on pull request #107: boost-fallback: only check for boost if really needed

2022-01-29 Thread GitBox
rm5248 commented on pull request #107: URL: https://github.com/apache/logging-log4cxx/pull/107#issuecomment-1024955174 I'm surprised that it failed - I thought that the try_compile tests would not cause it to completely fail. Maybe I just don't understand enough about how it works. --

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #735: Adds a shorthand method to specify components names

2022-01-29 Thread GitBox
ppkarwasz commented on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1024956766 What about a more common way of escaping the dots, like `\.`? Or maybe quoting/double-quoting the logger name? Although it might not be intuitive why the part after `log

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #102: Create intermediate directories for both fixedwindowrollingpolicy and…

2022-01-29 Thread GitBox
rm5248 commented on a change in pull request #102: URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r795079918 ## File path: src/main/cpp/rollingpolicybase.cpp ## @@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase) RollingPolicyBase::RollingPolicy

[GitHub] [logging-log4j2] jvz commented on a change in pull request #736: LOG4J2-3332: SmtpAppender - option for sending buffered messages as an email attachment (text, zip, gzip)

2022-01-29 Thread GitBox
jvz commented on a change in pull request #736: URL: https://github.com/apache/logging-log4j2/pull/736#discussion_r795089083 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java ## @@ -16,24 +16,16 @@ */ package org.apache.logging.log4j.

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #735: Adds a shorthand method to specify components names

2022-01-29 Thread GitBox
ppkarwasz edited a comment on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1024956766 What about a more common way of escaping the dots, like `\.`? Or maybe quoting/double-quoting the logger name? Although it might not be intuitive why the part aft

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #735: Adds a shorthand method to specify components names

2022-01-29 Thread GitBox
ppkarwasz edited a comment on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1024956766 What about a more common way of escaping the dots, like `\.`? Or maybe quoting/double-quoting the logger name? Although it might not be intuitive why the part aft

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #737: Add missing properties and fixes default values

2022-01-29 Thread GitBox
ppkarwasz opened a new pull request #737: URL: https://github.com/apache/logging-log4j2/pull/737 The properties of the generated appenders are not always the same as in Log4j 1.x. This PR: - adds default values to all Log4j 1.x configuration builders, - adds a couple of properti

[GitHub] [logging-log4j2] rdotterer09 commented on pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

2022-01-30 Thread GitBox
rdotterer09 commented on pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717#issuecomment-1025161115 thanks for the help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] rdotterer09 removed a comment on pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

2022-01-30 Thread GitBox
rdotterer09 removed a comment on pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717#issuecomment-1025161115 thanks for the help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #738: Bump xmlunitVersion from 2.8.4 to 2.9.0

2022-01-30 Thread GitBox
dependabot[bot] opened a new pull request #738: URL: https://github.com/apache/logging-log4j2/pull/738 Bumps `xmlunitVersion` from 2.8.4 to 2.9.0. Updates `xmlunit-core` from 2.8.4 to 2.9.0 Release notes Sourced from https://github.com/xmlunit/xmlunit/releases";>xmlunit-core's

[GitHub] [logging-log4j2] vy merged pull request #730: LOG4J2-3368 Bump Tomcat from 8.5.20 to 10.0.14 in log4j-appserver along with some dependency clean-up.

2022-01-31 Thread GitBox
vy merged pull request #730: URL: https://github.com/apache/logging-log4j2/pull/730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #662: Bump tomcat-catalina from 8.5.20 to 10.0.14

2022-01-31 Thread GitBox
dependabot[bot] closed pull request #662: URL: https://github.com/apache/logging-log4j2/pull/662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #662: Bump tomcat-catalina from 8.5.20 to 10.0.14

2022-01-31 Thread GitBox
dependabot[bot] commented on pull request #662: URL: https://github.com/apache/logging-log4j2/pull/662#issuecomment-1025695730 Looks like org.apache.tomcat:tomcat-catalina is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service.

[GitHub] [logging-log4j2] carterkozak commented on pull request #735: Adds a shorthand method to specify components names

2022-01-31 Thread GitBox
carterkozak commented on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1026245393 I could see something like this working: `logger.org.apache.foo.level = INFO, console` If the property name begins with a known value `logger.` and ends with

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #739: Bump maven-checkstyle-plugin from 3.0.0 to 3.1.2

2022-01-31 Thread GitBox
dependabot[bot] opened a new pull request #739: URL: https://github.com/apache/logging-log4j2/pull/739 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.0.0 to 3.1.2. Commits https://github.com/apache/maven-checkstyle-plugin/commit/27b9

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #735: Adds a shorthand method to specify components names

2022-01-31 Thread GitBox
ppkarwasz commented on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1026545182 @carterkozak: this could work, but maybe let's use another suffix for the condensed property. Is `.config` Ok? Basically it could work like this: - the implici

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #735: Adds a shorthand method to specify components names

2022-01-31 Thread GitBox
ppkarwasz edited a comment on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1026545182 @carterkozak: this could work, but maybe let's use another suffix for the condensed property. Is `.config` Ok? Basically it could work like this: - the

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #735: Adds a shorthand method to specify components names

2022-01-31 Thread GitBox
ppkarwasz edited a comment on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1026545182 @carterkozak: this could work, but maybe let's use another suffix for the condensed property. Is `.config` Ok? Basically it could work like this: - the

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #735: Adds a shorthand method to specify components names

2022-01-31 Thread GitBox
ppkarwasz edited a comment on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1026545182 @carterkozak: this could work, but maybe let's use another suffix for the condensed property. Is `.config` or `.value` Ok? Basically it could work like this

[GitHub] [logging-log4j2] carterkozak commented on pull request #735: Adds a shorthand method to specify components names

2022-02-01 Thread GitBox
carterkozak commented on pull request #735: URL: https://github.com/apache/logging-log4j2/pull/735#issuecomment-1027030918 It sounds like we're discussing improving several different parts of the properties configuration scheme at once -- It's great to have an idea of where we want to go b

[GitHub] [logging-log4j2] vy commented on pull request #731: Adds a Tomcat lookup

2022-02-02 Thread GitBox
vy commented on pull request #731: URL: https://github.com/apache/logging-log4j2/pull/731#issuecomment-1028077995 I am against introducing components for 3rd party software integrations. These better be developed and maintained by the community; Log4j provides first-class extensibility mec

[GitHub] [logging-log4j2] vy merged pull request #734: Bump mockitoVersion from 4.2.0 to 4.3.1

2022-02-02 Thread GitBox
vy merged pull request #734: URL: https://github.com/apache/logging-log4j2/pull/734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #737: Adds support for missing Log4j 1.x properties and fixes default values

2022-02-02 Thread GitBox
vy commented on pull request #737: URL: https://github.com/apache/logging-log4j2/pull/737#issuecomment-1028089316 @garydgregory, would you be interested in taking this on as a part of your ongoing `log4j-1.2-bridge` crusade? -- This is an automated message from the Apache Git Service. To

[GitHub] [logging-log4j2] vy merged pull request #738: Bump xmlunitVersion from 2.8.4 to 2.9.0

2022-02-02 Thread GitBox
vy merged pull request #738: URL: https://github.com/apache/logging-log4j2/pull/738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy merged pull request #739: Bump maven-checkstyle-plugin from 3.0.0 to 3.1.2

2022-02-02 Thread GitBox
vy merged pull request #739: URL: https://github.com/apache/logging-log4j2/pull/739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] garydgregory commented on pull request #737: Adds support for missing Log4j 1.x properties and fixes default values

2022-02-02 Thread GitBox
garydgregory commented on pull request #737: URL: https://github.com/apache/logging-log4j2/pull/737#issuecomment-1028104019 @vy I might be able to take a look this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] sman-81 commented on pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2022-02-02 Thread GitBox
sman-81 commented on pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-1028218237 "we love pull requests" they say you send them prs you listen to their criticism you incorporate their feedback you think you're done then nothing happens

[GitHub] [logging-log4j2] sman-81 closed pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2022-02-02 Thread GitBox
sman-81 closed pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [logging-log4j2] sman-81 commented on pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2022-02-02 Thread GitBox
sman-81 commented on pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-1028224532 "we love pull requests" they say you send them prs you listen to their criticism you incorporate their feedback you think you're done then nothing happens

[GitHub] [logging-log4j2] avandeursen commented on pull request #720: Expand test suite and fix NPE for StructuredDataLookup class

2022-02-02 Thread GitBox
avandeursen commented on pull request #720: URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1028227148 This PR seems a bit stalled, so let me re-explain why I think it's important to merge it: - Doing a lookup in structured data with a null key is valid according

[GitHub] [logging-log4j2] avandeursen edited a comment on pull request #720: Expand test suite and fix NPE for StructuredDataLookup class

2022-02-02 Thread GitBox
avandeursen edited a comment on pull request #720: URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1028227148 This PR seems a bit stalled. I understand everyone is super busy, so let me briefly explain why I think it's important to merge it: - Doing a lookup in s

[GitHub] [logging-log4j2] jvz commented on pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2022-02-02 Thread GitBox
jvz commented on pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-1028315065 PRs are welcome; the PMC are all volunteers, though, who don't work on this project full time. Before each release, we usually go over open PRs and Jira issues to make sure to

[GitHub] [logging-log4j2] carterkozak commented on pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2022-02-02 Thread GitBox
carterkozak commented on pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-1028513533 @sman-81 we are all volunteers and have limited time to devote to review. Your most recent comment comes across as entitled and rude. Please work on that. In your posi

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #740: Bump elasticsearch-rest-high-level-client from 7.16.3 to 7.17.0

2022-02-02 Thread GitBox
dependabot[bot] opened a new pull request #740: URL: https://github.com/apache/logging-log4j2/pull/740 Bumps [elasticsearch-rest-high-level-client](https://github.com/elastic/elasticsearch) from 7.16.3 to 7.17.0. Release notes Sourced from https://github.com/elastic/elasticsearch

[GitHub] [logging-log4j2] sman-81 commented on pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2022-02-02 Thread GitBox
sman-81 commented on pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-1028625847 @carterkozak I'm a volunteer just like you. My pull request is from July 1st, thus seven months old by now! The last comment from anyone other than me was Augus

[GitHub] [logging-log4j2] vy merged pull request #740: Bump elasticsearch-rest-high-level-client from 7.16.3 to 7.17.0

2022-02-03 Thread GitBox
vy merged pull request #740: URL: https://github.com/apache/logging-log4j2/pull/740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] carterkozak commented on pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2022-02-03 Thread GitBox
carterkozak commented on pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-1029134939 The point is that `string.split` is inefficient, regardless of internal details because it's allocating several new strings unnecessarily. -- This is an automated me

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #732: LOG4J2-3350: Lookup recursion is not allowed, except through config properties

2022-02-03 Thread GitBox
carterkozak commented on a change in pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732#discussion_r798723570 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/PropertiesLookup.java ## @@ -29,29 +32,28 @@ */ public final clas

[GitHub] [logging-log4j2] carterkozak commented on pull request #732: LOG4J2-3350: Lookup recursion is not allowed, except through config properties

2022-02-03 Thread GitBox
carterkozak commented on pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732#issuecomment-1029409723 I’m having a bit of an internal struggle with this — in its current state, it changes the behavior of `$${ctx:foo}` used in properties because today we build propertie

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #741: Bump slf4jVersion from 1.7.25 to 1.7.35

2022-02-03 Thread GitBox
dependabot[bot] opened a new pull request #741: URL: https://github.com/apache/logging-log4j2/pull/741 Bumps `slf4jVersion` from 1.7.25 to 1.7.35. Updates `slf4j-api` from 1.7.25 to 1.7.35 Commits https://github.com/qos-ch/slf4j/commit/02860b67ef7ff39fa9c7d98fd00da2ee913faed

[GitHub] [logging-log4j2] vy merged pull request #741: Bump slf4jVersion from 1.7.25 to 1.7.35

2022-02-04 Thread GitBox
vy merged pull request #741: URL: https://github.com/apache/logging-log4j2/pull/741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy merged pull request #661: Bump spring-ws-core from 2.1.4.RELEASE to 3.1.2

2022-02-04 Thread GitBox
vy merged pull request #661: URL: https://github.com/apache/logging-log4j2/pull/661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy merged pull request #610: Bump maven-core from 3.6.0 to 3.8.4

2022-02-04 Thread GitBox
vy merged pull request #610: URL: https://github.com/apache/logging-log4j2/pull/610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

<    43   44   45   46   47   48   49   50   51   52   >