[GitHub] [logging-log4cxx] rm5248 commented on pull request #105: Prevent static initialization order faults by using local statics

2022-01-18 Thread GitBox
rm5248 commented on pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105#issuecomment-1015955472 > If `static` objects are being destroyed while another thread is logging, then `APRInitializer` is also destroyed (which is bad). So all logging activity must be stopped

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

2022-01-18 Thread GitBox
carterkozak commented on a change in pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717#discussion_r787261885 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThreadContextDataInjector.java ## @@ -62,21 +62,9 @@ public stati

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #719: Bump maven-source-plugin from 3.0.1 to 3.2.1

2022-01-18 Thread GitBox
dependabot[bot] opened a new pull request #719: URL: https://github.com/apache/logging-log4j2/pull/719 Bumps [maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.0.1 to 3.2.1. Commits https://github.com/apache/maven-source-plugin/commit/a59a2e481f7d8e46f

[GitHub] [logging-log4j-scala] vy merged pull request #16: ci: Scala 2.13.8

2022-01-19 Thread GitBox
vy merged pull request #16: URL: https://github.com/apache/logging-log4j-scala/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [logging-log4j2] vy merged pull request #719: Bump maven-source-plugin from 3.0.1 to 3.2.1

2022-01-19 Thread GitBox
vy merged pull request #719: URL: https://github.com/apache/logging-log4j2/pull/719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #671: [LOG4J2-3303] Add support for FileSize in TB

2022-01-19 Thread GitBox
vy commented on pull request #671: URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1016578739 @ramananravi, it is on `release-2.x`. I will port this to `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [logging-log4j2] vy closed pull request #671: [LOG4J2-3303] Add support for FileSize in TB

2022-01-19 Thread GitBox
vy closed pull request #671: URL: https://github.com/apache/logging-log4j2/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

2022-01-19 Thread GitBox
ppkarwasz commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1016598479 @garydgregory: I cut the #706 commit into pieces and now every PR should have its own tests. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #709: Adds default property values to TTCCLayout (Log4j 1.x bridge)

2022-01-19 Thread GitBox
ppkarwasz commented on a change in pull request #709: URL: https://github.com/apache/logging-log4j2/pull/709#discussion_r787887554 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/TTCCLayoutBuilder.java ## @@ -91,10 +91,10 @@ public Layout parseLayout

[GitHub] [logging-log4j2] avandeursen opened a new pull request #720: Expand test suite and fix NPE for StructuredDataLookup class

2022-01-19 Thread GitBox
avandeursen opened a new pull request #720: URL: https://github.com/apache/logging-log4j2/pull/720 This PR strengthens the test suite for the `StructuredDataLookup` class so that it achieves full branch coverage. The corner cases revealed the problem that a lookup of a null key with a corr

[GitHub] [logging-log4j2] avandeursen opened a new pull request #721: Expand test suite for DateLookup

2022-01-19 Thread GitBox
avandeursen opened a new pull request #721: URL: https://github.com/apache/logging-log4j2/pull/721 This commit strengthens the test suite for the `DateLookup` class so that it achieves full branch coverage. The javadoc for the `lookup(event, key)` method incorrectly stated that the

[GitHub] [logging-log4j2] avandeursen commented on pull request #720: Expand test suite and fix NPE for StructuredDataLookup class

2022-01-19 Thread GitBox
avandeursen commented on pull request #720: URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1016848096 I doubt the failing build is related to the code change here. Is there an easier way to re-trigger the build than me pushing an empty commit? -- This is an automated

[GitHub] [logging-log4j2] carterkozak commented on pull request #720: Expand test suite and fix NPE for StructuredDataLookup class

2022-01-19 Thread GitBox
carterkozak commented on pull request #720: URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1016850499 I've retriggered the jobs :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [logging-log4j2] avandeursen commented on pull request #720: Expand test suite and fix NPE for StructuredDataLookup class

2022-01-19 Thread GitBox
avandeursen commented on pull request #720: URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1016886343 That did the trick. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [logging-log4j2] carterkozak opened a new pull request #722: LOG4J2-3350: Evaluate configuration property substitutions eagerly

2022-01-19 Thread GitBox
carterkozak opened a new pull request #722: URL: https://github.com/apache/logging-log4j2/pull/722 Previously lookups between configuration properties weren't evaluated until they were used in the configuration, which resulted in behavior more prohibitive for RoutingAppenders than anti

[GitHub] [logging-log4j2] rgoers commented on pull request #722: LOG4J2-3350: Evaluate configuration property substitutions eagerly

2022-01-19 Thread GitBox
rgoers commented on pull request #722: URL: https://github.com/apache/logging-log4j2/pull/722#issuecomment-1017024373 Other than adding a couple of comments this looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #723: Fixes service file

2022-01-19 Thread GitBox
ppkarwasz opened a new pull request #723: URL: https://github.com/apache/logging-log4j2/pull/723 The META-INF/services file used the old `javax` namespace, hence the `ServletContainerInitializer` was never detected. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #724: Bump maven-dependency-plugin from 3.0.2 to 3.2.0

2022-01-19 Thread GitBox
dependabot[bot] opened a new pull request #724: URL: https://github.com/apache/logging-log4j2/pull/724 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.0.2 to 3.2.0. Commits https://github.com/apache/maven-dependency-plugin/commit/367a

[GitHub] [logging-log4j2] vy commented on a change in pull request #721: Expand test suite for DateLookup

2022-01-20 Thread GitBox
vy commented on a change in pull request #721: URL: https://github.com/apache/logging-log4j2/pull/721#discussion_r788564237 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/DateLookupTest.java ## @@ -23,31 +23,42 @@ import org.junit.jupiter.api.Test

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-01-20 Thread GitBox
atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r788637603 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -211,6 +214,10 @@ public String getExcept

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-01-20 Thread GitBox
atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r788637972 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -425,6 +440,7 @@ protected SyslogAppender

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-01-20 Thread GitBox
atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r788638315 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java ## @@ -270,7 +278,7 @@ private static PatternParse

[GitHub] [logging-log4j2] atulpendse commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-01-20 Thread GitBox
atulpendse commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r788639623 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -104,6 +104,9 @@ @PluginElement(

[GitHub] [logging-log4j2] atulpendse commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-01-20 Thread GitBox
atulpendse commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1017493771 > I only took a cursory look this AM. Please use the style of the files you are editing: Use spaces, no tabs. The bigger question is whether we should use an enum for t

[GitHub] [logging-log4j2] garydgregory closed pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

2022-01-20 Thread GitBox
garydgregory closed pull request #707: URL: https://github.com/apache/logging-log4j2/pull/707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

2022-01-20 Thread GitBox
garydgregory commented on pull request #707: URL: https://github.com/apache/logging-log4j2/pull/707#issuecomment-1017505827 @ppkarwasz Thank you for your PR! It turns out I had an implementation in flight similar to this PR. Please see the latest from git. You are credited in changes.x

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

2022-01-20 Thread GitBox
ppkarwasz commented on pull request #707: URL: https://github.com/apache/logging-log4j2/pull/707#issuecomment-1017542712 @garydgregory Looks great and since `AbstractLog4j1ConfigurationTest` is in the repository now, I can rebase the remaining PRs on top of your commit. This will reduce

[GitHub] [logging-log4j2] knoxyz commented on pull request #662: Bump tomcat-catalina from 8.5.20 to 10.0.14

2022-01-20 Thread GitBox
knoxyz commented on pull request #662: URL: https://github.com/apache/logging-log4j2/pull/662#issuecomment-1017564083 Pay attention! tomcat 8 and 9 are pretty good compatible, but with version 10 comes huge breaks (namespace javax -> jakarta)! Therefore still tomcat 9 is in use by the

[GitHub] [logging-log4j2] garydgregory merged pull request #724: Bump maven-dependency-plugin from 3.0.2 to 3.2.0

2022-01-20 Thread GitBox
garydgregory merged pull request #724: URL: https://github.com/apache/logging-log4j2/pull/724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on pull request #709: Adds default property values to TTCCLayout (Log4j 1.x bridge)

2022-01-20 Thread GitBox
garydgregory commented on pull request #709: URL: https://github.com/apache/logging-log4j2/pull/709#issuecomment-1017618416 @ppkarwasz Please rebase on branch `release-2.x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] garydgregory commented on pull request #710: Corrects the file pattern of the rolling appenders (Log4j 1.x bridge)

2022-01-20 Thread GitBox
garydgregory commented on pull request #710: URL: https://github.com/apache/logging-log4j2/pull/710#issuecomment-1017618892 @ppkarwasz Please rebase on branch `release-2.x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #709: Adds default property values to TTCCLayout (Log4j 1.x bridge)

2022-01-20 Thread GitBox
ppkarwasz commented on pull request #709: URL: https://github.com/apache/logging-log4j2/pull/709#issuecomment-1017763775 @garydgregory: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] garydgregory commented on pull request #723: Fix `log4j-jakarta-web` service file

2022-01-20 Thread GitBox
garydgregory commented on pull request #723: URL: https://github.com/apache/logging-log4j2/pull/723#issuecomment-1017837641 @ppkarwasz Please rebase on branch `release-2.x` to pick up fixes that should make the build more reliable (hopefully). -- This is an automated message from the

[GitHub] [logging-log4j2] garydgregory commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

2022-01-20 Thread GitBox
garydgregory commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1017838202 @ppkarwasz Please rebase on branch `release-2.x` to resolve the conflicts and pick up fixes that should make the build more reliable (hopefully). -- This is an

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

2022-01-20 Thread GitBox
ppkarwasz commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1017880760 @garydgregory: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] garydgregory merged pull request #723: Fix `log4j-jakarta-web` service file

2022-01-20 Thread GitBox
garydgregory merged pull request #723: URL: https://github.com/apache/logging-log4j2/pull/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #710: Corrects the file pattern of the rolling appenders (Log4j 1.x bridge)

2022-01-20 Thread GitBox
ppkarwasz commented on pull request #710: URL: https://github.com/apache/logging-log4j2/pull/710#issuecomment-1017933371 @garydgregory: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] garydgregory commented on pull request #709: Log4j 1.2 bridge uses the wrong default values for a TTCCLayout

2022-01-20 Thread GitBox
garydgregory commented on pull request #709: URL: https://github.com/apache/logging-log4j2/pull/709#issuecomment-1017946833 Tested that a local module build fails without the main changes and passes with the full PR. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] garydgregory merged pull request #709: Log4j 1.2 bridge uses the wrong default values for a TTCCLayout

2022-01-20 Thread GitBox
garydgregory merged pull request #709: URL: https://github.com/apache/logging-log4j2/pull/709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-20 Thread GitBox
garydgregory commented on pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708#issuecomment-1017985988 @ppkarwasz Please rebase on git branch `release-2.x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-20 Thread GitBox
ppkarwasz edited a comment on pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708#issuecomment-1018002002 @garydgregory, I rebased the PR and added some licenses to the XML config files. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-20 Thread GitBox
ppkarwasz commented on pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708#issuecomment-1018002002 @garydgregory, I rebase the PR and added some licenses to the XML config files. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [logging-log4j2] garydgregory closed pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-20 Thread GitBox
garydgregory closed pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-20 Thread GitBox
garydgregory commented on pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708#issuecomment-1018018231 @ppkarwasz Thank you for your work on this PR! 👍 :-) I brought in this PR directly as a diff with these changes: - Add the Apache license header to XML test fix

[GitHub] [logging-log4j2] garydgregory commented on pull request #710: Log4j 1.2 bridge uses the wrong file pattern for rolling file appenders

2022-01-20 Thread GitBox
garydgregory commented on pull request #710: URL: https://github.com/apache/logging-log4j2/pull/710#issuecomment-1018024520 @ppkarwasz Thank you for your updates. I brought in this PR with these changes: - Add the Apache license header to XML test fixtures. - Remove unused imports.

[GitHub] [logging-log4j2] garydgregory closed pull request #710: Log4j 1.2 bridge uses the wrong file pattern for rolling file appenders

2022-01-20 Thread GitBox
garydgregory closed pull request #710: URL: https://github.com/apache/logging-log4j2/pull/710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #711: Use Log4j1XmlLayout instead of XmlLayout

2022-01-20 Thread GitBox
garydgregory commented on a change in pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#discussion_r789234841 ## File path: log4j-1.2-api/src/test/resources/config-1.2/log4j-console-XmlLayout.xml ## @@ -0,0 +1,20 @@ + Review comment: Please add

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-20 Thread GitBox
ppkarwasz commented on pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708#issuecomment-1018045983 @garydgregory, I don't see these changes on the `release-2.x` branch. The main point of this PR is to exchange the lower bound `AbstractBuilder` in the signature:

[GitHub] [logging-log4j2] garydgregory commented on pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-20 Thread GitBox
garydgregory commented on pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708#issuecomment-1018048671 @ppkarwasz Oops, I messed up by closing this PR, so sorry, would you mind rebasing on `release-2.x`? -- This is an automated message from the Apache Git Service

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #725: Bump java-allocation-instrumenter from 3.0.1 to 3.3.0

2022-01-20 Thread GitBox
dependabot[bot] opened a new pull request #725: URL: https://github.com/apache/logging-log4j2/pull/725 Bumps [java-allocation-instrumenter](https://github.com/google/allocation-instrumenter) from 3.0.1 to 3.3.0. Release notes Sourced from https://github.com/google/allocation-inst

[GitHub] [logging-log4j2] vy commented on pull request #662: Bump tomcat-catalina from 8.5.20 to 10.0.14

2022-01-21 Thread GitBox
vy commented on pull request #662: URL: https://github.com/apache/logging-log4j2/pull/662#issuecomment-1018284569 AFAIK, Tomcat is only used by `log4j-appserver`. There I don't see any dependencies on the `javax` namespace, but just an implementation of `org.apache.juli.logging.Log` packag

[GitHub] [logging-log4j2] vy merged pull request #725: Bump java-allocation-instrumenter from 3.0.1 to 3.3.0

2022-01-21 Thread GitBox
vy merged pull request #725: URL: https://github.com/apache/logging-log4j2/pull/725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-21 Thread GitBox
ppkarwasz commented on pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708#issuecomment-1018420349 @garydgregory, I rebased the PR and added a failsafe to `BuilderManager#createBuilder`: if a builder does not implement any of the `*Builder` interfaces a warning

[GitHub] [logging-log4j2] garydgregory merged pull request #708: Log4j 1.2 bridge throws `ClassCastException` when using `SimpleLayout` and others

2022-01-21 Thread GitBox
garydgregory merged pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on pull request #661: Bump spring-ws-core from 2.1.4.RELEASE to 3.1.2

2022-01-21 Thread GitBox
garydgregory commented on pull request #661: URL: https://github.com/apache/logging-log4j2/pull/661#issuecomment-1018518371 Hi @rgoers, Merge or Close? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [logging-log4j2] carterkozak opened a new pull request #726: LOG4J2-3358: Fix substitutions when the DefaultConfiguraiton is used

2022-01-21 Thread GitBox
carterkozak opened a new pull request #726: URL: https://github.com/apache/logging-log4j2/pull/726 The problem is that some configuration creation paths fail to use the Interpolator constructor which loads all plugins. This produces inconsistent behavior based on the configuration cons

[GitHub] [logging-log4j2] vy commented on a change in pull request #726: LOG4J2-3358: Fix substitutions when the DefaultConfiguraiton is used

2022-01-21 Thread GitBox
vy commented on a change in pull request #726: URL: https://github.com/apache/logging-log4j2/pull/726#discussion_r789717797 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/layout/JsonLayoutTest.java ## @@ -604,6 +608,37 @@ public void testEmptyValuesAreIgn

[GitHub] [logging-log4j2] avandeursen commented on pull request #721: Expand test suite for DateLookup

2022-01-21 Thread GitBox
avandeursen commented on pull request #721: URL: https://github.com/apache/logging-log4j2/pull/721#issuecomment-1018587402 Thanks! Based on the feedback I made a few changes. For the test with the known format, I indeed added the test whether the returned date is today (and even adde

[GitHub] [logging-log4j2] carterkozak commented on pull request #726: LOG4J2-3358: Fix substitutions when the DefaultConfiguraiton is used

2022-01-21 Thread GitBox
carterkozak commented on pull request #726: URL: https://github.com/apache/logging-log4j2/pull/726#issuecomment-1018588038 TODO: More description and context, I'll try to write something up by the end of the day -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [logging-log4j2] avandeursen commented on a change in pull request #721: Expand test suite for DateLookup

2022-01-21 Thread GitBox
avandeursen commented on a change in pull request #721: URL: https://github.com/apache/logging-log4j2/pull/721#discussion_r789731643 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/DateLookupTest.java ## @@ -23,31 +23,42 @@ import org.junit.jupiter

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #726: LOG4J2-3358: Fix substitutions when the DefaultConfiguraiton is used

2022-01-21 Thread GitBox
carterkozak commented on a change in pull request #726: URL: https://github.com/apache/logging-log4j2/pull/726#discussion_r789743264 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/layout/JsonLayoutTest.java ## @@ -604,6 +608,37 @@ public void testEmptyVal

[GitHub] [logging-log4j2] vy commented on pull request #661: Bump spring-ws-core from 2.1.4.RELEASE to 3.1.2

2022-01-21 Thread GitBox
vy commented on pull request #661: URL: https://github.com/apache/logging-log4j2/pull/661#issuecomment-1018607212 I am in favor of merging this, checks are green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [logging-log4j2] vy merged pull request #721: Expand test suite for DateLookup

2022-01-21 Thread GitBox
vy merged pull request #721: URL: https://github.com/apache/logging-log4j2/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #721: Expand test suite for DateLookup

2022-01-21 Thread GitBox
vy commented on pull request #721: URL: https://github.com/apache/logging-log4j2/pull/721#issuecomment-1018630640 @avandeursen, I think the tests could be improved in many angles, but yours is certainly an improvement anyway and I have neither time, nor interest to invest on this further.

[GitHub] [logging-log4j2] atulpendse commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

2022-01-21 Thread GitBox
atulpendse commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1018735056 Looks like a test is failing on MacOS. Failure doesn't look related to my changes though. I don't have access to Mac to find out why exactly it's failing. -- This is

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

2022-01-21 Thread GitBox
ppkarwasz commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1018782447 @garydgregory, everything should be Ok now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [logging-log4j2] carterkozak closed pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

2022-01-21 Thread GitBox
carterkozak closed pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] garydgregory commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

2022-01-21 Thread GitBox
garydgregory commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-101578 @ppkarwasz CC: @rgoers Something is not quite right IMO: All the layout builders in this package build core layouts and wrap them. Why should this one be diffe

[GitHub] [logging-log4j2] carterkozak edited a comment on pull request #726: LOG4J2-3358: Fix substitutions when programmatic configuration is used

2022-01-21 Thread GitBox
carterkozak edited a comment on pull request #726: URL: https://github.com/apache/logging-log4j2/pull/726#issuecomment-1018588038 in 2.17.1 we paired down the list of allowed lookups based on javadoc, however that wasn't correct because the objects aren't always used precisely how the Abst

[GitHub] [logging-log4j2] carterkozak closed pull request #656: [WIP] Interpolator always loads StrLookup plugins

2022-01-21 Thread GitBox
carterkozak closed pull request #656: URL: https://github.com/apache/logging-log4j2/pull/656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] carterkozak merged pull request #726: LOG4J2-3358: Fix substitutions when programmatic configuration is used

2022-01-21 Thread GitBox
carterkozak merged pull request #726: URL: https://github.com/apache/logging-log4j2/pull/726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #722: LOG4J2-3350: Evaluate configuration property substitutions eagerly

2022-01-21 Thread GitBox
carterkozak commented on a change in pull request #722: URL: https://github.com/apache/logging-log4j2/pull/722#discussion_r790087262 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/Property.java ## @@ -57,6 +63,14 @@ public String getName() {

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

2022-01-22 Thread GitBox
ppkarwasz commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1019136281 The schema of the `XMLLayout` in Log4j 1.x and Log4j 2.x differ (e.g. the capitalization of the tags). There is a discussion about it in [LOG4J2-1522](https://issues.apa

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

2022-01-22 Thread GitBox
ppkarwasz edited a comment on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1019136281 The schemas of the `XMLLayout` in Log4j 1.x and Log4j 2.x differ (e.g. the capitalization of the tags). There is a discussion about it in [LOG4J2-1522](https://is

[GitHub] [logging-log4j2] garydgregory commented on pull request #693: Bump h2 from 1.4.200 to 2.0.206

2022-01-22 Thread GitBox
garydgregory commented on pull request #693: URL: https://github.com/apache/logging-log4j2/pull/693#issuecomment-1019294182 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #727: Bump h2 from 1.4.200 to 2.1.210

2022-01-22 Thread GitBox
dependabot[bot] opened a new pull request #727: URL: https://github.com/apache/logging-log4j2/pull/727 Bumps [h2](https://github.com/h2database/h2database) from 1.4.200 to 2.1.210. Release notes Sourced from https://github.com/h2database/h2database/releases";>h2's releases.

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #693: Bump h2 from 1.4.200 to 2.0.206

2022-01-22 Thread GitBox
dependabot[bot] closed pull request #693: URL: https://github.com/apache/logging-log4j2/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #693: Bump h2 from 1.4.200 to 2.0.206

2022-01-22 Thread GitBox
dependabot[bot] commented on pull request #693: URL: https://github.com/apache/logging-log4j2/pull/693#issuecomment-1019295758 Superseded by #727. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] garydgregory commented on pull request #727: Bump h2 from 1.4.200 to 2.1.210

2022-01-22 Thread GitBox
garydgregory commented on pull request #727: URL: https://github.com/apache/logging-log4j2/pull/727#issuecomment-1019345332 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] jvz merged pull request #690: Add mention of "CVE creation process" to the security page.

2022-01-22 Thread GitBox
jvz merged pull request #690: URL: https://github.com/apache/logging-log4j2/pull/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [logging-log4j2] jvz commented on pull request #690: Add mention of "CVE creation process" to the security page.

2022-01-22 Thread GitBox
jvz commented on pull request #690: URL: https://github.com/apache/logging-log4j2/pull/690#issuecomment-1019397625 Do we need a cherry pick to master as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [logging-log4j2] jvz commented on pull request #689: [LOG4J2-3319] Add support for log4j 1.2 API bundle in Eclipse IDE

2022-01-22 Thread GitBox
jvz commented on pull request #689: URL: https://github.com/apache/logging-log4j2/pull/689#issuecomment-1019397848 This looks like it should work. @garydgregory the fragments thing has to do with modules scanning for non-public bits for the most part. Generally, that means the 2.x plugin s

[GitHub] [logging-log4j2] jvz merged pull request #632: Update Required.java

2022-01-22 Thread GitBox
jvz merged pull request #632: URL: https://github.com/apache/logging-log4j2/pull/632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [logging-log4j2] jvz commented on pull request #632: Update Required.java

2022-01-22 Thread GitBox
jvz commented on pull request #632: URL: https://github.com/apache/logging-log4j2/pull/632#issuecomment-1019398040 Thanks for the PR! Looks like I originally used a fairly vague default error message despite the behavior of the constraint. -- This is an automated message from the Apache

[GitHub] [logging-log4j2] jvz commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2022-01-23 Thread GitBox
jvz commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1019582347 I'm leaning toward closing this for a couple reasons: * Setting a depth limit of something like 10 would still be vulnerable to billion-laughs style attacks. * The is

[GitHub] [logging-log4j2] srdo commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2022-01-23 Thread GitBox
srdo commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1019592372 > Setting a depth limit of something like 10 would still be vulnerable to billion-laughs style attacks Good point. I guess in order to prevent such an attack, you would

[GitHub] [logging-log4cxx] swebb2066 merged pull request #105: Prevent static initialization order faults by using local statics

2022-01-23 Thread GitBox
swebb2066 merged pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #106: Sonarcloud build

2022-01-24 Thread GitBox
rm5248 opened a new pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106 Scan the library using sonarcloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #728: Bump plexus-utils from 3.4.0 to 3.4.1

2022-01-24 Thread GitBox
dependabot[bot] opened a new pull request #728: URL: https://github.com/apache/logging-log4j2/pull/728 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.0 to 3.4.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>p

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #106: Sonarcloud build

2022-01-24 Thread GitBox
ams-tschoening commented on pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106#issuecomment-1020890387 Just out of interest: What exactly does Sonarcloud scan for in this context? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4cxx] sonarcloud[bot] commented on pull request #106: Sonarcloud build

2022-01-25 Thread GitBox
sonarcloud[bot] commented on pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106#issuecomment-1021143460 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed

[GitHub] [logging-log4cxx] rm5248 commented on pull request #106: Sonarcloud build

2022-01-25 Thread GitBox
rm5248 commented on pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106#issuecomment-1021160518 Well it _should_ be scanning for whatever vulnerabilities that Sonarqube scans for via static code analysis, although it says there are no problems which is very suspiciou

[GitHub] [logging-log4cxx] sonarcloud[bot] commented on pull request #106: Sonarcloud build

2022-01-25 Thread GitBox
sonarcloud[bot] commented on pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106#issuecomment-1021143460 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed

[GitHub] [logging-log4cxx] rm5248 commented on pull request #106: Sonarcloud build

2022-01-25 Thread GitBox
rm5248 commented on pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106#issuecomment-1021160518 Well it _should_ be scanning for whatever vulnerabilities that Sonarqube scans for via static code analysis, although it says there are no problems which is very suspiciou

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #106: Sonarcloud build

2022-01-25 Thread GitBox
ams-tschoening commented on pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106#issuecomment-1020890387 Just out of interest: What exactly does Sonarcloud scan for in this context? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4cxx] rm5248 merged pull request #106: Sonarcloud build

2022-01-25 Thread GitBox
rm5248 merged pull request #106: URL: https://github.com/apache/logging-log4cxx/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #729: Fixes a StringIndexOutOfBoundsException

2022-01-26 Thread GitBox
ppkarwasz opened a new pull request #729: URL: https://github.com/apache/logging-log4j2/pull/729 `PropertiesUtilTest#partitionOnCommonPrefixes` fails if a property does not contain any dots. The bug appears when parsing a `log4j2.properties` like in [this StackOverflow question](htt

[GitHub] [logging-log4j2] rdotterer09 commented on a change in pull request #722: LOG4J2-3350: Evaluate configuration property substitutions eagerly

2022-01-26 Thread GitBox
rdotterer09 commented on a change in pull request #722: URL: https://github.com/apache/logging-log4j2/pull/722#discussion_r792815957 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/Property.java ## @@ -57,6 +63,14 @@ public String getName() {

[GitHub] [logging-log4j2] rdotterer09 commented on pull request #720: Expand test suite and fix NPE for StructuredDataLookup class

2022-01-26 Thread GitBox
rdotterer09 commented on pull request #720: URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1022367104 Ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [logging-log4j2] rdotterer09 commented on pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

2022-01-26 Thread GitBox
rdotterer09 commented on pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717#issuecomment-1022367664 Ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

<    42   43   44   45   46   47   48   49   50   51   >