[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

carterkozak commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785030436 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apac

[GitHub] [logging-log4j2] vorburger opened a new pull request #699: Increase to-jul priority from 15 to 20

vorburger opened a new pull request #699: URL: https://github.com/apache/logging-log4j2/pull/699 The original 15 was blindly copied from SLF4JProvider (by myself). It's probably better to not have them be the same, and have To-JUL's higher than SLF4j's (which in turn is higher than C

[GitHub] [logging-log4j2] vorburger commented on pull request #699: Increase to-jul priority from 15 to 20

vorburger commented on pull request #699: URL: https://github.com/apache/logging-log4j2/pull/699#issuecomment-1013339724 @carterkozak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [logging-log4j2] vorburger opened a new pull request #700: StatusLogger uses default status level configured from property not just for listeners but all its logging (fixes LOG4J2-3340)

vorburger opened a new pull request #700: URL: https://github.com/apache/logging-log4j2/pull/700 With this StatusLogger uses default status level configured from property not just for listeners but all its logging. This fixes https://issues.apache.org/jira/browse/LOG4J2-3340 for me.

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785067137 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785068359 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4j2] vorburger commented on pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger commented on pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#issuecomment-1013361743 > Please see my comments/questions. TY! Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

carterkozak commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785072734 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apac

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

carterkozak commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785073240 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apac

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785075733 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785078943 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785079189 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

carterkozak commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785083277 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apac

[GitHub] [logging-log4j2] garydgregory commented on pull request #698: Support source class & method in to-jul (LOG4J2-3282)

garydgregory commented on pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#issuecomment-1013424236 I approved the PR but as my comments are resolved. I'll let @carterkozak give the final nod.😉 TY @vorburger -- This is an automated message from the Apache Git

[GitHub] [logging-log4j2] carterkozak commented on pull request #698: Support source class & method in to-jul (LOG4J2-3282)

carterkozak commented on pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#issuecomment-1013429061 Thanks, Gary :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

carterkozak commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785134421 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apac

[GitHub] [logging-log4j2] garydgregory commented on pull request #700: StatusLogger uses default status level configured from property not just for listeners but all its logging (fixes LOG4J2-3340)

garydgregory commented on pull request #700: URL: https://github.com/apache/logging-log4j2/pull/700#issuecomment-1013433366 Anything that makes it easier to use is fine by me. Any thoughts @rgoers ? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785153033 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4j2] carterkozak commented on pull request #700: StatusLogger uses default status level configured from property not just for listeners but all its logging (fixes LOG4J2-3340)

carterkozak commented on pull request #700: URL: https://github.com/apache/logging-log4j2/pull/700#issuecomment-1013461189 Are the test failures related to this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] rgoers commented on pull request #700: StatusLogger uses default status level configured from property not just for listeners but all its logging (fixes LOG4J2-3340)

rgoers commented on pull request #700: URL: https://github.com/apache/logging-log4j2/pull/700#issuecomment-1013480001 I'm not sure we have that many tests on StatusLogger. This change looks like it makes sense to me. -- This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4j2] carterkozak merged pull request #698: Support source class & method in to-jul (LOG4J2-3282)

carterkozak merged pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] carterkozak merged pull request #699: Increase to-jul priority from 15 to 20

carterkozak merged pull request #699: URL: https://github.com/apache/logging-log4j2/pull/699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] carterkozak merged pull request #701: Add vorburger@ as Contributor in POM

carterkozak merged pull request #701: URL: https://github.com/apache/logging-log4j2/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] carterkozak merged pull request #696: Strengthen test coverage of StrSubstitutor class

carterkozak merged pull request #696: URL: https://github.com/apache/logging-log4j2/pull/696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4cxx] rm5248 merged pull request #101: Fix NPE when attempting to cast a null pointer

rm5248 merged pull request #101: URL: https://github.com/apache/logging-log4cxx/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [logging-log4cxx] rm5248 merged pull request #100: LOGCXX-102 Parse rolling file appender options from properties file

rm5248 merged pull request #100: URL: https://github.com/apache/logging-log4cxx/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [logging-log4j2] strugerk opened a new pull request #703: fix deleteAction can't distinguish basePath of symbolicLink

strugerk opened a new pull request #703: URL: https://github.com/apache/logging-log4j2/pull/703 fix Appenders DeleteAction didn't work when basepath is symbolicLink. jira:https://issues.apache.org/jira/browse/LOG4J2-3342 ![image](https://user-images.githubusercontent.com/37694724/

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #703: fix deleteAction can't distinguish basePath of symbolicLink

garydgregory commented on a change in pull request #703: URL: https://github.com/apache/logging-log4j2/pull/703#discussion_r785303041 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/AbstractPathAction.java ## @@ -103,7 +103,15 @@ pu

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #703: fix deleteAction can't distinguish basePath of symbolicLink

garydgregory commented on a change in pull request #703: URL: https://github.com/apache/logging-log4j2/pull/703#discussion_r785303138 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/AbstractPathAction.java ## @@ -103,7 +103,15 @@ pu

[GitHub] [logging-log4j2] strugerk commented on a change in pull request #703: fix deleteAction can't distinguish basePath of symbolicLink

strugerk commented on a change in pull request #703: URL: https://github.com/apache/logging-log4j2/pull/703#discussion_r785308866 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/AbstractPathAction.java ## @@ -103,7 +103,15 @@ public

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #102: Create intermediate directories for both fixedwindowrollingpolicy and…

rm5248 opened a new pull request #102: URL: https://github.com/apache/logging-log4cxx/pull/102 … timebasedrollingpolicy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [logging-log4j2] sweetascherri-labs commented on pull request #702: Add inceptionYear 2022 in to-jul POM

sweetascherri-labs commented on pull request #702: URL: https://github.com/apache/logging-log4j2/pull/702#issuecomment-1013752729 kerstintdur...@gmail.com" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #704: Multiple small improvements in Log4j 1.x configuration parsing (including LOG4J2-3328)

ppkarwasz opened a new pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704 The unit tests provided by `Log4j1ConfigurationFactoryTest` unfortunately were not applied to the newer `PropertiesConfigurationFactory` and `XmlConfigurationFactory`. After applying the tests,

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #102: Create intermediate directories for both fixedwindowrollingpolicy and…

ams-tschoening commented on a change in pull request #102: URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r785426142 ## File path: src/main/cpp/rollingpolicybase.cpp ## @@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase) RollingPolicyBase::Rolli

[GitHub] [logging-log4j2] strugerk commented on a change in pull request #703: fix deleteAction can't distinguish basePath of symbolicLink

strugerk commented on a change in pull request #703: URL: https://github.com/apache/logging-log4j2/pull/703#discussion_r785426539 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/AbstractPathAction.java ## @@ -103,7 +103,15 @@ public

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #102: Create intermediate directories for both fixedwindowrollingpolicy and…

rm5248 commented on a change in pull request #102: URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r785460548 ## File path: src/main/cpp/rollingpolicybase.cpp ## @@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase) RollingPolicyBase::RollingPolicy

[GitHub] [logging-log4j2] garydgregory commented on pull request #704: Multiple small improvements in Log4j 1.x configuration parsing (including LOG4J2-3328)

garydgregory commented on pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013915115 Hello @ppkarwasz Thank you for your PR. You must have missed in Jira that the ticket https://issues.apache.org/jira/browse/LOG4J2-3328 was assigned to me, so we w

[GitHub] [logging-log4j2] garydgregory merged pull request #702: Add inceptionYear 2022 in to-jul POM

garydgregory merged pull request #702: URL: https://github.com/apache/logging-log4j2/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] ppkarwasz closed pull request #705: Release 2.x rebased

ppkarwasz closed pull request #705: URL: https://github.com/apache/logging-log4j2/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #705: Release 2.x rebased

ppkarwasz commented on pull request #705: URL: https://github.com/apache/logging-log4j2/pull/705#issuecomment-1013945398 Sorry, I wanted to modify #704 instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

ppkarwasz commented on pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013950184 Sorry @garydgregory, I didn't plan to provide a fix to LOG4J2-3328 at first, but some of the tests the I copied from `Log4j1ConfigurationFactoryTest` were failing

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

ppkarwasz edited a comment on pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013950184 Sorry @garydgregory, I didn't plan to provide a fix to LOG4J2-3328 at first, but some of the tests I copied from `Log4j1ConfigurationFactoryTest` were fail

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

garydgregory commented on a change in pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785534352 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java ## @@ -86,12 +86,25 @@ protected String getNameAttribu

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

ppkarwasz commented on a change in pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785539228 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java ## @@ -86,12 +86,25 @@ protected String getNameAttribute(

[GitHub] [logging-log4j2] rgoers commented on pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

rgoers commented on pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013972910 Yeah - I would appreciate this being split into a series of PRs. I got part of that through and didn't see anything terribly concerning but I also did dig as deep as I woul

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

ppkarwasz commented on a change in pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785540531 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java ## @@ -86,12 +86,25 @@ protected String getNameAttribute(

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

ppkarwasz commented on a change in pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785540531 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java ## @@ -86,12 +86,25 @@ protected String getNameAttribute(

[GitHub] [logging-log4j2] ppkarwasz closed pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

ppkarwasz closed pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #706: Common unit tests for Log4j 1.x configuration factories

ppkarwasz opened a new pull request #706: URL: https://github.com/apache/logging-log4j2/pull/706 `Log4j1ConfigurationFactoryTest` contains many interesting tests that fail if we apply them to the `PropertiesConfigurationFactory` and `XmlConfigurationFactory` that replaced `Log4j1Configurat

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

ppkarwasz opened a new pull request #707: URL: https://github.com/apache/logging-log4j2/pull/707 Log4j 1.x allows for both capitalized (`InfoLocation`) and Java-style (`infoLocation`) component property names (`PropertySetter` calls `Introspector.decapitalize`). This PR allows for Java-sty

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #708: Fixes `ClassCastException` when using `SimpleLayout` in a Log4j 1.x configuration

ppkarwasz opened a new pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708 Since not all Log4j 1.x component builders extend `AbstractBuilder`, `BuilderManager#createBuilder` throws a `ClassCastException` when instantiating some of them. For example using a `Si

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #709: Adds default property values to TTCCLayout (Log4j 1.x bridge)

ppkarwasz opened a new pull request #709: URL: https://github.com/apache/logging-log4j2/pull/709 The default values used by `TTCCLayoutBuilder` were different from those used by Log4j 1.x. This PR fixes the tests concerning the `TTCCLayout` from #706. -- This is an automated messa

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #710: Corrects the file pattern of the rolling appenders (Log4j 1.x bridge)

ppkarwasz opened a new pull request #710: URL: https://github.com/apache/logging-log4j2/pull/710 The Log4j 1.x bridge incorrectly sets the pattern of the rolling file appenders. Moreover the `RollingFileAppender` did not have a time based triggering policy in the original Log4j 1.x.

[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #711: Use Log4j1XmlLayout instead of XmlLayout

ppkarwasz opened a new pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711 The Log4j 1.x bridge should arguably use the `Log4j1XmlLayout` instead of the Log4j 2.x specific `XmlLayout`. That is also the layout used by the older `Log4j1ConfigurationFactory`. This

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #704: Multiple small improvements in Log4j 1.x configuration parsing

ppkarwasz commented on pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013999717 I split this PR into 6 smaller ones: #706, #707, #708, #709, #710, #711. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [logging-log4cxx] swebb2066 opened a new pull request #103: Reference expat xml library consistenty

swebb2066 opened a new pull request #103: URL: https://github.com/apache/logging-log4cxx/pull/103 Currently, the examples use ${XMLLIB_LIBRARIES} while tests and the log4cxx library use EXPAT::EXPAT. This PR aims to localise in the top level CMakeLists.txt the expat library referenc

[GitHub] [logging-log4cxx] rm5248 commented on pull request #103: Reference expat xml library consistenty

rm5248 commented on pull request #103: URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014095458 Would it make more sense to merge this into master instead of next_stable? Otherwise it looks good to me. -- This is an automated message from the Apache Git Servi

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #103: Reference expat xml library consistenty

swebb2066 commented on pull request #103: URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014152730 It occurred to me I should hande bot types of find result. If this is OK I will cherry-pick to a master destined PR. -- This is an automated message from the Ap

[GitHub] [logging-log4cxx] swebb2066 edited a comment on pull request #103: Reference expat xml library consistenty

swebb2066 edited a comment on pull request #103: URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014152730 It occurred to me I should hande both types of find result. If this is OK I will cherry-pick to a master destined PR. -- This is an automated message fro

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #102: Create intermediate directories for both fixedwindowrollingpolicy and…

ams-tschoening commented on a change in pull request #102: URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r785672563 ## File path: src/main/cpp/rollingpolicybase.cpp ## @@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase) RollingPolicyBase::Rolli

[GitHub] [logging-log4cxx] swebb2066 opened a new pull request #105: Prevent static initialization order faults by using local statics

swebb2066 opened a new pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105 This PR is further work towards fixing LOGCXX-532. I believe localstatics are thread safe since C++11 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [logging-log4j2] atulpendse commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

atulpendse commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1014358483 @vy @garydgregory anything else that I should do to make progress on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

garydgregory commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r785986466 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -300,6 +307,11 @@ public B setLoggerFie

[GitHub] [logging-log4j2] garydgregory commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

garydgregory commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1014522355 Hello @ppkarwasz Thank you for your PR. We need a matching test that fails if the main changes are reverted, otherwise, there is no way to know why this change

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #709: Adds default property values to TTCCLayout (Log4j 1.x bridge)

garydgregory commented on a change in pull request #709: URL: https://github.com/apache/logging-log4j2/pull/709#discussion_r785996466 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java ## @@ -91,7 +91,11 @@ protected String getValueAttribu

[GitHub] [logging-log4j2] garydgregory commented on pull request #708: Fixes `ClassCastException` when using `SimpleLayout` in a Log4j 1.x configuration

garydgregory commented on pull request #708: URL: https://github.com/apache/logging-log4j2/pull/708#issuecomment-1014529504 "Since not all Log4j 1.x component builders extend AbstractBuilder, BuilderManager#createBuilder throws a ClassCastException when instantiating some of them."

[GitHub] [logging-log4j2] garydgregory commented on pull request #707: Allows Java-style property names in Log4j 1.x XML configuration

garydgregory commented on pull request #707: URL: https://github.com/apache/logging-log4j2/pull/707#issuecomment-1014536381 Hi @ppkarwasz You need tests to fail without these main changes to show the main changes actually fix something. Otherwise, future changes might just reintroduce t

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #706: Common unit tests for Log4j 1.x configuration factories

garydgregory commented on a change in pull request #706: URL: https://github.com/apache/logging-log4j2/pull/706#discussion_r786004843 ## File path: log4j-1.2-api/src/test/java/org/apache/log4j/config/AbstractLog4j1ConfigurationTest.java ## @@ -0,0 +1,264 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] garydgregory commented on pull request #700: StatusLogger uses default status level configured from property not just for listeners but all its logging (fixes LOG4J2-3340)

garydgregory commented on pull request #700: URL: https://github.com/apache/logging-log4j2/pull/700#issuecomment-1014541566 > Are the test failures related to this change? I just started a re-run of all the jobs. Let's see if the build passes. -- This is an automated message from t

[GitHub] [logging-log4cxx] rm5248 commented on pull request #105: Prevent static initialization order faults by using local statics

rm5248 commented on pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105#issuecomment-1014550892 One (potential) issue that I see here is that because the variables are still declared as `static`, they may get destroyed when the application is exiting(but another thre

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

ppkarwasz commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1014635782 This modification is tested by `AbstractLog4j1ConfigurationTest.testConsoleXmlLayout()` I submitted in #706. That PR is hard to split into parts without generating many

[GitHub] [logging-log4j2] garydgregory commented on pull request #706: Common unit tests for Log4j 1.x configuration factories

garydgregory commented on pull request #706: URL: https://github.com/apache/logging-log4j2/pull/706#issuecomment-1014655999 Hi @ppkarwasz Failing a build is not going to be acceptable IMO. Because different team members work at different times and availability, like me, I don't want to

[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #706: Common unit tests for Log4j 1.x configuration factories

garydgregory edited a comment on pull request #706: URL: https://github.com/apache/logging-log4j2/pull/706#issuecomment-1014655999 Hi @ppkarwasz Failing a build is not going to be acceptable IMO. Because different team members work at different times and availability, like me, I don't w

[GitHub] [logging-log4j2] ppkarwasz closed pull request #706: Common unit tests for Log4j 1.x configuration factories

ppkarwasz closed pull request #706: URL: https://github.com/apache/logging-log4j2/pull/706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #706: Common unit tests for Log4j 1.x configuration factories

ppkarwasz commented on pull request #706: URL: https://github.com/apache/logging-log4j2/pull/706#issuecomment-1014676863 I'll move the tests to the PRs that actually fix bugs, then. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [logging-log4j2] jvz commented on a change in pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

jvz commented on a change in pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#discussion_r786137086 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ## @@ -104,6 +104,9 @@ @PluginElement("Logger

[GitHub] [logging-log4cxx] rm5248 commented on pull request #103: Reference expat xml library consistenty

rm5248 commented on pull request #103: URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014708051 looks good to me. I prefer to merge into master and then merge master into next_stable manually once I have a few changes(so I don't have to do the same fix twice),

[GitHub] [logging-log4j2] carterkozak opened a new pull request #712: Additional log4j-to-jul test coverage for correct formatting

carterkozak opened a new pull request #712: URL: https://github.com/apache/logging-log4j2/pull/712 These tests provide additional coverage in the event parameters are passed through, demonstrating how JUL formatters are likely to misinterpret such LogRecords. -- This is an automated

[GitHub] [logging-log4j2] carterkozak closed pull request #714: Fix StackLocator regression on java 9+

carterkozak closed pull request #714: URL: https://github.com/apache/logging-log4j2/pull/714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] vy merged pull request #691: Bump build-helper-maven-plugin from 1.12 to 3.3.0

vy merged pull request #691: URL: https://github.com/apache/logging-log4j2/pull/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j-scala] vy merged pull request #14: Scala 2.13.8

vy merged pull request #14: URL: https://github.com/apache/logging-log4j-scala/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [logging-log4j-scala] vy merged pull request #15: note scala 2.13 support

vy merged pull request #15: URL: https://github.com/apache/logging-log4j-scala/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [logging-log4j-scala] vy commented on pull request #15: note scala 2.13 support

vy commented on pull request #15: URL: https://github.com/apache/logging-log4j-scala/pull/15#issuecomment-1014915107 @pjfanning, thanks for the contribution. For [scala-api.html](https://logging.apache.org/log4j/2.x/manual/scala-api.html), search for `scala-api.*` files in [Log4j 2](/apac

[GitHub] [logging-log4j-scala] pjfanning commented on pull request #15: note scala 2.13 support

pjfanning commented on pull request #15: URL: https://github.com/apache/logging-log4j-scala/pull/15#issuecomment-1014919650 @vy I just added https://github.com/apache/logging-log4j2/pull/715 - I will create a 2nd PR (for master) when the first one is merged. -- This is an automated mess

[GitHub] [logging-log4j2] vy merged pull request #715: Documentation: Scala 3 support

vy merged pull request #715: URL: https://github.com/apache/logging-log4j2/pull/715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy merged pull request #716: Documentation: note scala 3 support

vy merged pull request #716: URL: https://github.com/apache/logging-log4j2/pull/716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] carterkozak opened a new pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

carterkozak opened a new pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717 draft, I need to validate performance related to the original reason this ran on another thread: https://issues.apache.org/jira/browse/LOG4J2-2867 Now that the serviceloader is guarded

[GitHub] [logging-log4cxx] swebb2066 merged pull request #103: Reference expat xml library consistenty

swebb2066 merged pull request #103: URL: https://github.com/apache/logging-log4cxx/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [logging-log4cxx] swebb2066 merged pull request #104: Prevent compilation error when -DBUILD_SHARED_LIBS=off

swebb2066 merged pull request #104: URL: https://github.com/apache/logging-log4cxx/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [logging-log4j2] carterkozak commented on pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

carterkozak commented on pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717#issuecomment-1014986859 @rgoers I can't seem to find the performance test you added as `log4j-core/src/test/java/org/apache/logging/log4j/core/LoggingTest.java` In the original issue, initi

[GitHub] [logging-log4j2] carterkozak merged pull request #713: LOG4J2-3345: log4j-jpl formats messages correctly using MessageFormat

carterkozak merged pull request #713: URL: https://github.com/apache/logging-log4j2/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] carterkozak merged pull request #712: Additional log4j-to-jul test coverage for correct formatting

carterkozak merged pull request #712: URL: https://github.com/apache/logging-log4j2/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #105: Prevent static initialization order faults by using local statics

swebb2066 commented on pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105#issuecomment-1015034924 If `static` objects are being destroyed while another thread is logging, then `APRInitializer` is also destroyed (which is bad). So all logging activity must be stopped

[GitHub] [logging-log4cxx] swebb2066 edited a comment on pull request #105: Prevent static initialization order faults by using local statics

swebb2066 edited a comment on pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105#issuecomment-1015034924 If `static` objects are being destroyed while another thread is logging, then `APRInitializer` is also destroyed (which is bad). So all logging activity must be

[GitHub] [logging-log4cxx] swebb2066 edited a comment on pull request #105: Prevent static initialization order faults by using local statics

swebb2066 edited a comment on pull request #105: URL: https://github.com/apache/logging-log4cxx/pull/105#issuecomment-1015034924 If `static` objects are being destroyed while another thread is logging, then `APRInitializer` is also destroyed (which is bad). So all logging activity must be

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #718: Bump elasticsearch-rest-high-level-client from 7.6.2 to 7.16.3

dependabot[bot] opened a new pull request #718: URL: https://github.com/apache/logging-log4j2/pull/718 Bumps [elasticsearch-rest-high-level-client](https://github.com/elastic/elasticsearch) from 7.6.2 to 7.16.3. Release notes Sourced from https://github.com/elastic/elasticsearch/

[GitHub] [logging-log4j2] vy merged pull request #718: Bump elasticsearch-rest-high-level-client from 7.6.2 to 7.16.3

vy merged pull request #718: URL: https://github.com/apache/logging-log4j2/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #717: LOG4J2-3333: Fix ThreadContextDataInjector classloader deadlock

garydgregory commented on a change in pull request #717: URL: https://github.com/apache/logging-log4j2/pull/717#discussion_r786715672 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThreadContextDataInjector.java ## @@ -62,21 +62,9 @@ public stat

[GitHub] [logging-log4j2] garydgregory commented on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

garydgregory commented on pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1015376017 @ppkarwasz ping? ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [logging-log4j2] garydgregory commented on pull request #700: StatusLogger uses default status level configured from property not just for listeners but all its logging (fixes LOG4J2-3340)

garydgregory commented on pull request #700: URL: https://github.com/apache/logging-log4j2/pull/700#issuecomment-1015379096 This PR is indeed the cause of the build failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

<    41   42   43   44   45   46   47   48   49   50   >