[GitHub] [logging-log4j2] vorburger commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

vorburger commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007091452 @carterkozak perhaps you would like to merge this? (It's -about to- have a full green build.) -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [logging-log4j2] vorburger commented on pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

vorburger commented on pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1007091463 > I'll have to wait for that to be fixed, and then merge that in here and it should be green. @carterkozak build for this now running (I expect it to be green).

[GitHub] [logging-log4j2] carterkozak commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

carterkozak commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007100337 Great find, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] carterkozak merged pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

carterkozak merged pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] benjaminr-ps opened a new pull request #689: [LOG4J2-3319] Add support for log4j 1.2 API bundle in Eclipse IDE

benjaminr-ps opened a new pull request #689: URL: https://github.com/apache/logging-log4j2/pull/689 This will add the "Eclipse-ExtensibleAPI" header to the manifest of "core" bundle, to allow any fragement (resp. the log4j 1.2 bridge) to extend the API of core bundle. -- This is an auto

[GitHub] [logging-log4j2] vorburger commented on pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

vorburger commented on pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1007291907 > The `JULLogger` class could be package private, as the type itself is never exposed directly, only used as a cast target in tests. This would give us leniency for futu

[GitHub] [logging-log4j2] garydgregory commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

garydgregory commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007365746 I thought the RAT version was set in the parent POM through a property? I don't think we want to override it, do we? Gary On Thu, Jan 6, 2022, 21:57 Ca

[GitHub] [logging-log4j2] garydgregory commented on pull request #680: [LOG4J2-3326] Fix parsing filters from Log4j 1.2 properties configuration file

garydgregory commented on pull request #680: URL: https://github.com/apache/logging-log4j2/pull/680#issuecomment-1007372996 Hi @benjaminr-ps Thank you for your PR. Would you add a test please? Without a test there is no way to see that this fixes anything or that the undoing

[GitHub] [logging-log4j2] vy merged pull request #681: Fix StatusLogger Javadoc

vy merged pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vorburger commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

vorburger commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007384817 > I thought the RAT version was set in the parent POM through a property? I don't think we want to override it, do we? This PR does not override it. If you look at

[GitHub] [logging-log4j2] garydgregory commented on pull request #681: Fix StatusLogger Javadoc

garydgregory commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007386837 Does this need to be cherry-picked to master? Gary On Fri, Jan 7, 2022, 07:53 Volkan Yazıcı ***@***.***> wrote: > Merged #681

[GitHub] [logging-log4j2] garydgregory commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

garydgregory commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007387515 It does make perfect sense 😀 but it is not the best solution 😉 . All is well, thank you for pitching in 👍 -- This is an automated message from the Apache Git Servic

[GitHub] [logging-log4j2] MariusVolkhart commented on pull request #681: Fix StatusLogger Javadoc

MariusVolkhart commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007435350 Yes please. It has not yet been changed there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] carterkozak commented on pull request #681: Fix StatusLogger Javadoc

carterkozak commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007441197 I've handled the cherry-pick -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r780541031 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Softw

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

vorburger commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r780541889 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [logging-log4j2] carterkozak commented on pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak commented on pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1007756608 I think this is ready to merge once level agreement is fixed :-) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

vorburger commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r780546050 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [logging-log4j2] carterkozak merged pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak merged pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] garydgregory commented on pull request #689: [LOG4J2-3319] Add support for log4j 1.2 API bundle in Eclipse IDE

garydgregory commented on pull request #689: URL: https://github.com/apache/logging-log4j2/pull/689#issuecomment-1007870825 Should other modules include this type of change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4j2] garydgregory commented on pull request #681: Fix StatusLogger Javadoc

garydgregory commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007386837 Does this need to be cherry-picked to master? Gary On Fri, Jan 7, 2022, 07:53 Volkan Yazıcı ***@***.***> wrote: > Merged #681

[GitHub] [logging-log4j2] vorburger commented on pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

vorburger commented on pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1007291907 > The `JULLogger` class could be package private, as the type itself is never exposed directly, only used as a cast target in tests. This would give us leniency for futu

[GitHub] [logging-log4j2] vy merged pull request #681: Fix StatusLogger Javadoc

vy merged pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] carterkozak commented on pull request #681: Fix StatusLogger Javadoc

carterkozak commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007441197 I've handled the cherry-pick -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [logging-log4j2] carterkozak merged pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak merged pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] garydgregory commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

garydgregory commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007365746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [logging-log4j2] MariusVolkhart commented on pull request #681: Fix StatusLogger Javadoc

MariusVolkhart commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007435350 Yes please. It has not yet been changed there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] carterkozak commented on pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak commented on pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1007756608 I think this is ready to merge once level agreement is fixed :-) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r780541031 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Softw

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

vorburger commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r780541889 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [logging-log4j2] garydgregory commented on pull request #680: [LOG4J2-3326] Fix parsing filters from Log4j 1.2 properties configuration file

garydgregory commented on pull request #680: URL: https://github.com/apache/logging-log4j2/pull/680#issuecomment-1007372996 Hi @benjaminr-ps Thank you for your PR. Would you add a test please? Without a test there is no way to see that this fixes anything or that the undoing

[GitHub] [logging-log4j2] vorburger commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

vorburger commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007384817 > I thought the RAT version was set in the parent POM through a property? I don't think we want to override it, do we? This PR does not override it. If you look at

[GitHub] [logging-log4j2] garydgregory commented on pull request #689: [LOG4J2-3319] Add support for log4j 1.2 API bundle in Eclipse IDE

garydgregory commented on pull request #689: URL: https://github.com/apache/logging-log4j2/pull/689#issuecomment-1007870825 Should other modules include this type of change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4cxx] coldtobi opened a new pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

coldtobi opened a new pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99 The way the doxygen documenation is generated with CMake, it is unfortunatly not reproducible (as in https://reproducible-builds.org/). This is a regression as log4cxx has been previously

[GitHub] [logging-log4cxx] rm5248 commented on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

rm5248 commented on pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008162731 The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible. I changed the `c

[GitHub] [logging-log4cxx] coldtobi commented on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

coldtobi commented on pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008185839 > The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible. Ack. >

[GitHub] [logging-log4cxx] coldtobi edited a comment on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

coldtobi edited a comment on pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008185839 > The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible. Ack.

[GitHub] [logging-log4cxx] rm5248 merged pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

rm5248 merged pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [logging-log4cxx] rm5248 merged pull request #86: Update log4cxx.h.in

rm5248 merged pull request #86: URL: https://github.com/apache/logging-log4cxx/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [logging-log4j2] ramananravi commented on pull request #671: [LOG4J2-3303] Add support for FileSize in TB

ramananravi commented on pull request #671: URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1008336846 > > @ramananravi, we think there are a few more places in the code where a similar improvement might be handy. Mind creating a JIRA ticket for this change, please?

[GitHub] [logging-log4cxx] jmdavison46 commented on pull request #86: Update log4cxx.h.in

jmdavison46 commented on pull request #86: URL: https://github.com/apache/logging-log4cxx/pull/86#issuecomment-1008346079 For run-time version information, what do you think of the approach taken by OpenSSL (https://www.openssl.org), i.e. providing a function that provides the run-time val

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #100: LOGCXX-102 Parse rolling file appender options from properties file

rm5248 opened a new pull request #100: URL: https://github.com/apache/logging-log4cxx/pull/100 Implement parsing of the options for the rolling file appender. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [logging-log4cxx] rm5248 commented on pull request #86: Update log4cxx.h.in

rm5248 commented on pull request #86: URL: https://github.com/apache/logging-log4cxx/pull/86#issuecomment-1008363348 I don't think that would provide enough value to be worth it. This at least provides the information; clients can do what they want with the information. Part of this

[GitHub] [logging-log4j2] vy commented on pull request #687: NF: Correct a broken markdown link

vy commented on pull request #687: URL: https://github.com/apache/logging-log4j2/pull/687#issuecomment-1008379470 Thanks so much @Arthur-Milchior! Keep these corrections coming! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] vy merged pull request #687: NF: Correct a broken markdown link

vy merged pull request #687: URL: https://github.com/apache/logging-log4j2/pull/687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

vy commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008421459 Fantastic work @atulpendse! Thanks so much! Mind adding `SyslogAppender` tests and a `changes.xml` entry, please? I am also not sure if a `timestampPrecision` argum

[GitHub] [logging-log4j2] vy commented on pull request #688: Expand test suite for SortedArrayStringMap

vy commented on pull request #688: URL: https://github.com/apache/logging-log4j2/pull/688#issuecomment-1008422111 These are great additions! Thanks so much @avandeursen! I will merge the changes as soon as build succeeds. -- This is an automated message from the Apache Git Service. To re

[GitHub] [logging-log4j2] vy commented on pull request #671: [LOG4J2-3303] Add support for FileSize in TB

vy commented on pull request #671: URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1008422800 @ramananravi, I will do my best to pick this up as soon as possible, unless another committer steps up. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j2] vy commented on pull request #690: Add mention of "CVE creation process" to the security page.

vy commented on pull request #690: URL: https://github.com/apache/logging-log4j2/pull/690#issuecomment-1008423615 > Looks good. Could potentially note that the vote happens on the security list or something. Good point @jvz! Done. -- This is an automated message from the Apache Gi

[GitHub] [logging-log4j2] vy commented on pull request #624: LOG4J-3215 Update the documentation instructions on using Log4j in a Gradle build

vy commented on pull request #624: URL: https://github.com/apache/logging-log4j2/pull/624#issuecomment-1008430513 Thanks so much @quapka! Applied your changes to both `release-2.x` and `master`. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4j2] garydgregory commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

garydgregory commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008430785 I would NOT update changes.xml, this makes cherry-picking the commit to master impossible. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] vy merged pull request #688: Expand test suite for SortedArrayStringMap

vy merged pull request #688: URL: https://github.com/apache/logging-log4j2/pull/688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

vy commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008432086 IMHO, cherry-picking to `master` is almost already impossible. Nevertheless, I will rephrase my comment to exclude the `changes.xml` part. -- This is an automated message fro

[GitHub] [logging-log4j2] vy edited a comment on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

vy edited a comment on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008421459 Fantastic work @atulpendse! Thanks so much! Mind adding `SyslogAppender` tests ~~and a `changes.xml` entry~~, please? I am also not sure if a `timestampPreci

[GitHub] [logging-log4j2] atulpendse commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

atulpendse commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008543504 @vy Thanks for taking time to review the PR. Here are my thoughts about questions you raised. > I am also not sure if a `timestampPrecision` argument of typ

[GitHub] [logging-log4j2] atulpendse edited a comment on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

atulpendse edited a comment on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008543504 @vy Thanks for taking time to review the PR. Here are my thoughts about questions you raised. > I am also not sure if a `timestampPrecision` argument

[GitHub] [logging-log4j2] benjaminr-ps commented on pull request #689: [LOG4J2-3319] Add support for log4j 1.2 API bundle in Eclipse IDE

benjaminr-ps commented on pull request #689: URL: https://github.com/apache/logging-log4j2/pull/689#issuecomment-1008738139 No, the change is made in **log4j-core**, only. But have seen that several other libraries, like "log4j-appserver" or "log4j-cassandra" or ..., would benefit fr

[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #680: [LOG4J2-3326] Fix parsing filters from Log4j 1.2 properties configuration file

garydgregory edited a comment on pull request #680: URL: https://github.com/apache/logging-log4j2/pull/680#issuecomment-1007372996 Hi @benjaminr-ps Thank you for your PR. Would you add a test, please? Without a test, there is no way to see that this fixes anything or that un

[GitHub] [logging-log4j2] garydgregory commented on pull request #680: [LOG4J2-3326] Fix parsing filters from Log4j 1.2 properties configuration file

garydgregory commented on pull request #680: URL: https://github.com/apache/logging-log4j2/pull/680#issuecomment-1008857707 https://issues.apache.org/jira/browse/LOG4J2-3326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #680: [LOG4J2-3326] Fix parsing filters from Log4j 1.2 properties configuration file

garydgregory commented on a change in pull request #680: URL: https://github.com/apache/logging-log4j2/pull/680#discussion_r781176438 ## File path: log4j-1.2-api/src/test/resources/LOG4J2-3326.properties ## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) un

[GitHub] [logging-log4j2] garydgregory merged pull request #680: [LOG4J2-3326] Fix parsing filters from Log4j 1.2 properties configuration file

garydgregory merged pull request #680: URL: https://github.com/apache/logging-log4j2/pull/680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory merged pull request #605: Bump mongodb3.version from 3.12.4 to 3.12.10

garydgregory merged pull request #605: URL: https://github.com/apache/logging-log4j2/pull/605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory merged pull request #663: Bump awaitility from 4.0.3 to 4.1.1

garydgregory merged pull request #663: URL: https://github.com/apache/logging-log4j2/pull/663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on pull request #665: Bump spring-boot.version from 2.5.7 to 2.6.2

garydgregory commented on pull request #665: URL: https://github.com/apache/logging-log4j2/pull/665#issuecomment-1008881463 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] garydgregory commented on pull request #374: Bump build-helper-maven-plugin from 1.12 to 3.2.0

garydgregory commented on pull request #374: URL: https://github.com/apache/logging-log4j2/pull/374#issuecomment-1008882036 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #374: Bump build-helper-maven-plugin from 1.12 to 3.2.0

dependabot[bot] commented on pull request #374: URL: https://github.com/apache/logging-log4j2/pull/374#issuecomment-100642 Superseded by #691. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #374: Bump build-helper-maven-plugin from 1.12 to 3.2.0

dependabot[bot] closed pull request #374: URL: https://github.com/apache/logging-log4j2/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #691: Bump build-helper-maven-plugin from 1.12 to 3.3.0

dependabot[bot] opened a new pull request #691: URL: https://github.com/apache/logging-log4j2/pull/691 Bumps [build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin) from 1.12 to 3.3.0. Release notes Sourced from https://github.com/mojohaus/build-helper-

[GitHub] [logging-log4j2] garydgregory closed pull request #674: mockito 4.2.0

garydgregory closed pull request #674: URL: https://github.com/apache/logging-log4j2/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on pull request #674: mockito 4.2.0

garydgregory commented on pull request #674: URL: https://github.com/apache/logging-log4j2/pull/674#issuecomment-1008897211 Hi @sullis This PR does not even compile. Please run a successful local build with 'mvn clean package' or 'mvn clean install' before creating a PR. Closing PR;

[GitHub] [logging-log4j2] ramananravi commented on pull request #671: [LOG4J2-3303] Add support for FileSize in TB

ramananravi commented on pull request #671: URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1008904285 > @vy - thanks for the reply. Just to add, my question is, is my current PR ok to be merged or do you suggest any changes on the same? If there are any suggest

[GitHub] [logging-log4j2] garydgregory commented on pull request #689: [LOG4J2-3319] Add support for log4j 1.2 API bundle in Eclipse IDE

garydgregory commented on pull request #689: URL: https://github.com/apache/logging-log4j2/pull/689#issuecomment-1009064814 https://issues.apache.org/jira/browse/LOG4J2-3319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #692: Bump kafka-clients from 1.1.1 to 3.0.0

dependabot[bot] opened a new pull request #692: URL: https://github.com/apache/logging-log4j2/pull/692 Bumps kafka-clients from 1.1.1 to 3.0.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.kafka:k

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #665: Bump spring-boot.version from 2.5.7 to 2.6.2

dependabot[bot] commented on pull request #665: URL: https://github.com/apache/logging-log4j2/pull/665#issuecomment-1009618052 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for

[GitHub] [logging-log4j2] rgoers closed pull request #665: Bump spring-boot.version from 2.5.7 to 2.6.2

rgoers closed pull request #665: URL: https://github.com/apache/logging-log4j2/pull/665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers commented on pull request #665: Bump spring-boot.version from 2.5.7 to 2.6.2

rgoers commented on pull request #665: URL: https://github.com/apache/logging-log4j2/pull/665#issuecomment-1009618034 Closing this as Spring made changes in 2.6.0 that require testing and likely changes. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4j2] atulpendse commented on pull request #683: LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

atulpendse commented on pull request #683: URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1009618838 Commit fbccefc updates existing test for SyslogAppender -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4net] StarWars999123 commented on pull request #18: Update XmlLayoutSchemaLog4j.cs

StarWars999123 commented on pull request #18: URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-1009868382 I highly doubt, that this PR should have been closed. I currently assume, that the RenderLoggingEvent method might have challenges to keep up with this change. I

[GitHub] [logging-log4j2] mron7 commented on pull request #632: Update Required.java

mron7 commented on pull request #632: URL: https://github.com/apache/logging-log4j2/pull/632#issuecomment-1010013646 "empty" should be spelled correctly in the updated message before you merge this PR. The current PR has "empty" spelled wrong. -- This is an automated message from the Apa

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #693: Bump h2 from 1.4.200 to 2.0.206

dependabot[bot] opened a new pull request #693: URL: https://github.com/apache/logging-log4j2/pull/693 Bumps [h2](https://github.com/h2database/h2database) from 1.4.200 to 2.0.206. Release notes Sourced from https://github.com/h2database/h2database/releases";>h2's releases.

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #694: Bump kubernetes-client from 4.6.1 to 5.11.2

dependabot[bot] opened a new pull request #694: URL: https://github.com/apache/logging-log4j2/pull/694 Bumps [kubernetes-client](https://github.com/fabric8io/kubernetes-client) from 4.6.1 to 5.11.2. Release notes Sourced from https://github.com/fabric8io/kubernetes-client/releases

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #695: Bump liquibase-core from 3.5.5 to 4.7.0

dependabot[bot] opened a new pull request #695: URL: https://github.com/apache/logging-log4j2/pull/695 Bumps [liquibase-core](https://github.com/liquibase/liquibase) from 3.5.5 to 4.7.0. Release notes Sourced from https://github.com/liquibase/liquibase/releases";>liquibase-core's

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #664: Bump liquibase-core from 3.5.5 to 4.6.2

dependabot[bot] commented on pull request #664: URL: https://github.com/apache/logging-log4j2/pull/664#issuecomment-1010609208 Superseded by #695. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #664: Bump liquibase-core from 3.5.5 to 4.6.2

dependabot[bot] closed pull request #664: URL: https://github.com/apache/logging-log4j2/pull/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] avandeursen opened a new pull request #696: Strengthen test coverage of StrSubstitutor class

avandeursen opened a new pull request #696: URL: https://github.com/apache/logging-log4j2/pull/696 I noticed that the central `substitute` method in the `StrSubstitutor` class that was involved in a recent CVE had some code not covered by (unit) tests. This untested logic related to cases

[GitHub] [logging-log4j2] MouettE-SC commented on pull request #682: Add environment variable arbiter

MouettE-SC commented on pull request #682: URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1011384397 Sorry, forgot to comment that I was able to create working tests for the environment arbiter using system-lambda. Hope you'll find them satisfying ! -- This is an aut

[GitHub] [logging-log4j2] MouettE-SC commented on pull request #682: Add environment variable arbiter

MouettE-SC commented on pull request #682: URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1011391582 Let me know if there is anything I can do to help, like opening an issue on Jira, writing the documentation part or anything, I'll be happy to ! -- This is an automat

[GitHub] [logging-log4j2] carterkozak opened a new pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

carterkozak opened a new pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697 _This pr is meant only as an example for discussion_ What do you think about using a code formatter? In my experience, it makes reviews easier, avoids unnecessary style commits later on

[GitHub] [logging-log4j2] garydgregory commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

garydgregory commented on pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1011749927 FWIW, in Eclipse at least you can use a customizable comment to disable the formatted for specific areas like this: ... // @formatter:off ... // this

[GitHub] [logging-log4j2] rgoers commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

rgoers commented on pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1011817999 This scares the heck out of me. 1,995 files modified means no human could review this. Gary used to (still does?) use tools to do formatting and invariably would change a p

[GitHub] [logging-log4j2] carterkozak commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

carterkozak commented on pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1012183850 I'm not suggesting merging anything that formats the entire codebase in one go, this was meant as an example of the result before we commit to going down that path. Ro

[GitHub] [logging-log4j2] garydgregory commented on pull request #697: [idea & example, request for input] Thoughts on using a code formatter?

garydgregory commented on pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1012258440 The Eclipse formatter has so many options that it's dizzying. I'm sure we can bend it to our will ;-) Gary On Thu, Jan 13, 2022, 09:24 Carter Kozak

[GitHub] [logging-log4j-scala] pjfanning commented on pull request #15: note scala 2.13 support

pjfanning commented on pull request #15: URL: https://github.com/apache/logging-log4j-scala/pull/15#issuecomment-1013061387 @jvz minor readme update I also noticed that https://logging.apache.org/log4j/2.x/manual/scala-api.html does not mention Scala 2.13 or Scala 3.x (3.0 and 3.1

[GitHub] [logging-log4j2] vorburger opened a new pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger opened a new pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698 This is a LOG4J2-3282 related follow-up to #653. @carterkozak is this what you were meant [in our conversation here](https://github.com/apache/logging-log4j2/pull/653#discussion_r77837499

[GitHub] [logging-log4j2] carterkozak commented on pull request #698: Support source class & method in to-jul (LOG4J2-3282)

carterkozak commented on pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#issuecomment-1013278874 > @carterkozak is this what you meant in our conversation here? Yessir! Looks great :-) I probably could have described it more clearly. Just needs a licen

[GitHub] [logging-log4j2] vorburger commented on pull request #698: Support source class & method in to-jul (LOG4J2-3282)

vorburger commented on pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#issuecomment-1013287207 > Just needs a license header to appease rat. Duh! I should know better; done! > We might consider naming the record type something more descriptive like `L

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

garydgregory commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785018771 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apa

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

garydgregory commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785019107 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apa

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

garydgregory commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785020235 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apa

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #698: Support source class & method in to-jul (LOG4J2-3282)

garydgregory commented on a change in pull request #698: URL: https://github.com/apache/logging-log4j2/pull/698#discussion_r785020969 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/LazyLog4jLogRecord.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apa

<    40   41   42   43   44   45   46   47   48   49   >