swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
swebb2066 commented on a change in pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r777150208
##
File path: src/main/cpp/aprinitializer.cpp
##
@@ -127,3 +127,21 @@ void APRInitializer::unregisterCleanup(FileWatchdog*
watchdog)
}
}
swebb2066 commented on a change in pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r777150343
##
File path: src/main/cpp/logmanager.cpp
##
@@ -47,28 +47,19 @@ using namespace log4cxx::helpers;
IMPLEMENT_LOG4CXX_OBJECT(DefaultRepositorySelect
swebb2066 commented on pull request #94:
URL: https://github.com/apache/logging-log4cxx/pull/94#issuecomment-1003641406
To determine the cost of Logger holding a weak pointer instead of a raw
pointer as in this PR, I experimently changed m_priv->repository to a
std::weak_ptr. The result s
swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777152029
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777152029
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
rm5248 commented on a change in pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r777154084
##
File path: src/main/cpp/logmanager.cpp
##
@@ -47,28 +47,19 @@ using namespace log4cxx::helpers;
IMPLEMENT_LOG4CXX_OBJECT(DefaultRepositorySelector)
rm5248 commented on a change in pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r777154247
##
File path: src/main/cpp/aprinitializer.cpp
##
@@ -127,3 +127,21 @@ void APRInitializer::unregisterCleanup(FileWatchdog*
watchdog)
}
}
+v
rm5248 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777154659
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if al
swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777155197
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
rm5248 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777156489
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if al
rm5248 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777156521
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if al
swebb2066 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777156662
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if
rm5248 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777157888
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if al
swebb2066 commented on pull request #94:
URL: https://github.com/apache/logging-log4cxx/pull/94#issuecomment-1003669899
I believe this also fixes https://issues.apache.org/jira/browse/LOGCXX-532
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rgoers merged pull request #677:
URL: https://github.com/apache/logging-log4j2/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
swebb2066 merged pull request #94:
URL: https://github.com/apache/logging-log4cxx/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r777230229
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softwar
vorburger commented on pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1003744225
@carterkozak This is "code complete" and ready for your review, from my
side.
PS: I was trying to figure out why Apache RAT initially choked on my new
`log4j-to-
rm5248 opened a new pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95
This is an extension of PR #75. This will calculate the short filename at
compile time(assuming you have C++17) and give it to the LocationInfo class.
If you do not have C++17 and you request the
jmdavison46 commented on pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#issuecomment-1003830945
The point is to allow the developer to recover the major/minor/patch/tweak
fields from an integer-valued LOG4CXX_VERSION; one use case is the act of
logging the major/m
swebb2066 opened a new pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96
Also remove temporary LOGCXX-322 patch that causes compilation error when
APR_HAS_THREADS is set to 0
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
swebb2066 opened a new pull request #97:
URL: https://github.com/apache/logging-log4cxx/pull/97
This change is as per master and also include serialization of additions to
results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r777344076
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -45,16 +45,35 @@ LocationInfo::LocationInfo( const char* const fileName1,
int lineNum
jvz merged pull request #12:
URL: https://github.com/apache/logging-log4j-scala/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
jvz merged pull request #11:
URL: https://github.com/apache/logging-log4j-scala/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rm5248 commented on pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#issuecomment-1004401456
> The utility of LOG4CXX_VERSION_GET_{MAJOR,MINOR,PATCH,TWEAK} would be more
obvious if we were to add a version identifier object (i.e. an externally
visible integer value)
rm5248 commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r36412
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -45,16 +45,35 @@ LocationInfo::LocationInfo( const char* const fileName1,
int lineNumber1 )
rm5248 commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r44337
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -132,9 +152,28 @@ class LOG4CXX_EXPORT LocationInfo
#if !defined(__LOG4CXX_FU
rm5248 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1004427963
Looks good to me.
The ABI failure is not due to this change, but due to some of the other
changes that you've made(e.g. returning a reference instead of the
`shared_p
rm5248 merged pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
rm5248 merged pull request #97:
URL: https://github.com/apache/logging-log4cxx/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
swebb2066 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1004441759
To copy a shared_ptr the reference count must be incremented, for which a
lock must be acquired.
By returning a const reference, the caller can decide whether to co
rm5248 merged pull request #98:
URL: https://github.com/apache/logging-log4cxx/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r777873523
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -45,16 +45,35 @@ LocationInfo::LocationInfo( const char* const fileName1,
int lineNum
ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r777998623
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -132,9 +152,28 @@ class LOG4CXX_EXPORT LocationInfo
#if !defined(__LO
ams-tschoening commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1004721218
> To copy a shared_ptr the reference count must be incremented, for which a
lock must be acquired.
The link Robert provided tells the exact opposite:
>
ams-tschoening edited a comment on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1004721218
> To copy a shared_ptr the reference count must be incremented, for which a
lock must be acquired.
The link Robert provided tells the exact opposite:
carterkozak closed pull request #678:
URL: https://github.com/apache/logging-log4j2/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on pull request #678:
URL: https://github.com/apache/logging-log4j2/pull/678#issuecomment-1004828382
closing as spam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
carterkozak commented on pull request #679:
URL: https://github.com/apache/logging-log4j2/pull/679#issuecomment-1004828615
spam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
carterkozak closed pull request #679:
URL: https://github.com/apache/logging-log4j2/pull/679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
rm5248 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1004836869
I think it may actually depend on the context. If you're returning a new
`shared_ptr` the reference count would not have to be incremented. If you're
returning a `shared_p
benjaminr-ps opened a new pull request #680:
URL: https://github.com/apache/logging-log4j2/pull/680
Problem: The log4j 1.x configuration file is not properly parsed, in regards
of filters. Whatever is configured in file, is getting ignored, and default
values are used.
E.g. for "level
carterkozak commented on pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1005138990
Thanks, @vorburger :-)
It looks like our pom.xml has exclusions for `META-INF/services` in some
modules `src/main/resources/META-INF/services/**/*`, but I
think
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r778374993
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Softw
swebb2066 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1005192530
To prevent unnecessary locks in #90 it was necessary to change the return
type of getEffectiveLevel() to a const reference. So RVO probably does not
happen for virtual fu
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r778441809
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Softwar
rm5248 commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r778442479
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -132,9 +152,28 @@ class LOG4CXX_EXPORT LocationInfo
#if !defined(__LOG4CXX_FU
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r778441809
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Softwar
rm5248 commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r778442479
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -132,9 +152,28 @@ class LOG4CXX_EXPORT LocationInfo
#if !defined(__LOG4CXX_FU
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r778467489
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Softw
MariusVolkhart opened a new pull request #681:
URL: https://github.com/apache/logging-log4j2/pull/681
The Javadoc explaining how to override the StatusLogger level linked to the
wrong property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r778637752
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -45,21 +58,28 @@ class LOG4CXX_EXPORT LocationInfo
s
ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r778642762
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -45,21 +58,28 @@ class LOG4CXX_EXPORT LocationInfo
s
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r778937770
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Softw
MouettE-SC opened a new pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682
This is a simple arbiter using environment variables functionnally based on
the existing system property arbiter (on which I corrected some typos).
I tried to write unit tests for it but
rgoers commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005915855
Thanks for this. I should be able to create the unit tests for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
atulpendse opened a new pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683
This pull request is to imlement RFE LOG4J2-3280
The change
- Adds new attribute timestampPrecision to Rfc5424Layout and
SyslogAppender.
- Replaces existing logic to append timest
MouettE-SC commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005973657
> Thanks for this. I should be able to create the unit tests for it.
Great ! I've added the tests I wrote, based on the current system property
ones with system-r
MouettE-SC edited a comment on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005973657
> Thanks for this. I should be able to create the unit tests for it.
Great ! I've added the tests I wrote, based on the current system property
ones with s
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r779049362
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Softwar
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1005987340
The [test failures
here](https://github.com/vorburger/logging-log4j2/runs/4718590938?check_suite_focus=true)
appears to be unrelated to this PR, looks like someone broke
vorburger commented on pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1005988157
> It looks like our pom.xml has exclusions for `META-INF/services` in some
modules `src/main/resources/META-INF/services/**/*`, but I
think your solution is cleaner.
vorburger commented on pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1006005856
> make the Maven RAT plugin actually print out the offending files, instead
of pointing to a file where these are listed
As far as I can tell this isn't something
garydgregory commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006027274
> The [test failures
here](https://github.com/vorburger/logging-log4j2/runs/4718590938?check_suite_focus=true)
appears to be unrelated to this PR, looks like someone
vorburger opened a new pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685
This fixes the problem seen e.g. on #684.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
vorburger commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006028325
@garydgregory do you want to merge this when it passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006029158
> Hi, Rebase on master and it should work. I initially wrote the test on
macOS and later found it failed when I ran it on Windows.
But this is failing on the `rele
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006029579
@garydgregory would you consider merging this PR, because the build test
failure is obviously not related to the small change made to the POM here?
--
This is an autom
garydgregory commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006030286
Note the config file has a / in it so you end up with two /
What is in the sys temp dir prop has a / at the end too IIRC in macOS at
least. AFK for a few hours.
vorburger commented on pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1006040324
> @carterkozak the RAT failure is back again, and I'm not sure I understand
why, given I've only added 3 commits without
Please ignore, I'm tired and somehow mixe
garydgregory commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006040596
> @garydgregory would you consider merging this PR, because the build test
failure is obviously not related to the small change made to the POM here?
Not yet.
vorburger opened a new pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686
See https://issues.apache.org/jira/browse/RAT-294,
and https://github.com/apache/logging-log4j2/pull/653.
--
This is an automated message from the Apache Git Service.
To respond to the
vorburger commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006050959
Indeed, now the CI failed on Mac (only) due to this.
To me this actually seems more like a bug in
`org.apache.commons.lang3.SystemUtils#getJavaIoTmpDir()` - it rea
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006051522
> Not yet.
This PR is (only) about "Exclude Eclipse project file from RAT in root POM"
(and #685 is about the test failure).
--
This is an automated message fro
vorburger edited a comment on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006050959
Indeed, now the CI failed on Mac (only) due to this.
To me this actually seems more like a bug in
`org.apache.commons.lang3.SystemUtils#getJavaIoTmpDir()` -
vorburger commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1006052585
This PR will fail to pass the CI build until the current known test failure
is fixed, see #685.
--
This is an automated message from the Apache Git Service.
To respond
garydgregory commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006128671
Hi @vorburger
I fixed the test differently in branches `release-2.x` and `master`.
--
This is an automated message from the Apache Git Service.
To respond to the
garydgregory commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006132805
I'm not sure we need this: When I run `mvn apache-rat:check` in the root for
the project for release-2.x, it passes, and I have Eclipse dot files all over
the place.
garydgregory edited a comment on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1006132805
Hi @vorburger
I'm not sure we need this: When I run `mvn apache-rat:check` in the root for
the project for release-2.x, it passes, and I have Eclipse dot fi
rm5248 commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r779192252
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -45,21 +58,28 @@ class LOG4CXX_EXPORT LocationInfo
static co
swebb2066 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1006239373
It occurred to me that RVO is only relevent for functions that create the
returned object. getEffectiveLevel() returns the LevelPtr held by theLogger.
--
This is an aut
atulpendse commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1006322842
I believe the failure in PropertiesConfigurationTest is unrelated to this
change, and being fixed with #685
Once that is fixed, how do I get this PR to build and run
garydgregory commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1006563262
Hi @atulpendse
You will need to rebase this PR to pick up the latest changes.
--
This is an automated message from the Apache Git Service.
To respond to the messa
atulpendse commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1006572274
> Hi @atulpendse
> You will need to rebase this PR to pick up the latest changes.
Thanks for the info. I have updated PR with the latest from upstream. Latest
avandeursen opened a new pull request #688:
URL: https://github.com/apache/logging-log4j2/pull/688
I noticed that some corner cases of the equals and serialization methods of
the SortedArrayStringMap class were not (unit) tested, and that its hashCode
method was not tested at all. This pul
rm5248 merged pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
rm5248 closed pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
rm5248 commented on pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#issuecomment-1006971776
Created PR #95 off of this one and merged in; closing this PR. Thank you
for the patch.
--
This is an automated message from the Apache Git Service.
To respond to the mes
pjfanning opened a new pull request #13:
URL: https://github.com/apache/logging-log4j-scala/pull/13
Update apply methods to use macros - to match what happens with scala 2 build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vorburger closed pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
jvz merged pull request #13:
URL: https://github.com/apache/logging-log4j-scala/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
vorburger commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1007076340
> Hi @vorburger I'm not sure we need this: When I run `mvn apache-rat:check`
in the root for the project for release-2.x, it passes, and I have Eclipse dot
files all ove
vorburger closed pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
garydgregory commented on pull request #684:
URL: https://github.com/apache/logging-log4j2/pull/684#issuecomment-1007077707
@vorburger
Thanks for the update 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
4301 - 4400 of 7264 matches
Mail list logo
