KristjanESPERANTO edited a comment on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001190408
Yes, that would address my point. The master branch is now the entry point
for people who want to start dealing with the code. Since I can also see
curren
rm5248 merged pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
rm5248 merged pull request #657:
URL: https://github.com/apache/logging-log4j2/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
dependabot[bot] commented on pull request #600:
URL: https://github.com/apache/logging-log4j2/pull/600#issuecomment-1001235253
Looks like these dependencies are no longer a dependency, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to
dependabot[bot] closed pull request #600:
URL: https://github.com/apache/logging-log4j2/pull/600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
dependabot[bot] commented on pull request #606:
URL: https://github.com/apache/logging-log4j2/pull/606#issuecomment-1001236731
Looks like com.github.spotbugs:spotbugs is no longer a dependency, so this
is no longer needed.
--
This is an automated message from the Apache Git Service.
To r
dependabot[bot] closed pull request #606:
URL: https://github.com/apache/logging-log4j2/pull/606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
dependabot[bot] commented on pull request #408:
URL: https://github.com/apache/logging-log4j2/pull/408#issuecomment-1001237113
Looks like org.apache.maven.plugins:maven-shade-plugin is up-to-date now, so
this is no longer needed.
--
This is an automated message from the Apache Git Servic
dependabot[bot] closed pull request #408:
URL: https://github.com/apache/logging-log4j2/pull/408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
dependabot[bot] closed pull request #494:
URL: https://github.com/apache/logging-log4j2/pull/494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
dependabot[bot] commented on pull request #494:
URL: https://github.com/apache/logging-log4j2/pull/494#issuecomment-1001237745
Superseded by #661.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] opened a new pull request #661:
URL: https://github.com/apache/logging-log4j2/pull/661
Bumps [spring-ws-core](https://github.com/spring-projects/spring-ws) from
2.1.4.RELEASE to 3.1.2.
Commits
https://github.com/spring-projects/spring-ws/commit/7c7e86bfa54606a7
dependabot[bot] opened a new pull request #662:
URL: https://github.com/apache/logging-log4j2/pull/662
Bumps tomcat-catalina from 8.5.20 to 10.0.14.
[ from 4.0.3 to
4.1.1.
Changelog
Sourced from https://github.com/awaitility/awaitility/blob/master/changelog.txt";>awai
dependabot[bot] opened a new pull request #664:
URL: https://github.com/apache/logging-log4j2/pull/664
Bumps [liquibase-core](https://github.com/liquibase/liquibase) from 3.5.5 to
4.6.2.
Release notes
Sourced from https://github.com/liquibase/liquibase/releases";>liquibase-core's
dependabot[bot] commented on pull request #603:
URL: https://github.com/apache/logging-log4j2/pull/603#issuecomment-1001239295
Superseded by #665.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] opened a new pull request #665:
URL: https://github.com/apache/logging-log4j2/pull/665
Bumps `spring-boot.version` from 2.5.7 to 2.6.2.
Updates `spring-boot-dependencies` from 2.5.7 to 2.6.2
Release notes
Sourced from https://github.com/spring-projects/spring-boo
dependabot[bot] closed pull request #603:
URL: https://github.com/apache/logging-log4j2/pull/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
dependabot[bot] opened a new pull request #666:
URL: https://github.com/apache/logging-log4j2/pull/666
Bumps org.apache.felix.framework from 5.6.12 to 7.0.3.
[ functions.
Also disconnects the Logger from the Hierarchy when the Hie
swebb2066 opened a new pull request #89:
URL: https://github.com/apache/logging-log4cxx/pull/89
This PR is required to prevent 'No appender could be found for logger
(bench_logger)' warning in throughputtests after applying #88
--
This is an automated message from the Apache Git Service
swebb2066 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-1001350144
This has been superceded by #87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
swebb2066 closed pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
Kenducky opened a new pull request #668:
URL: https://github.com/apache/logging-log4j2/pull/668
some PatternLayOut.java source code about "disableAnsi" in master branch
like this:
If {@code "true"} (default is value of system property `log4j.skipJansi`, or
`true` if undefined), do not o
swebb2066 opened a new pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90
**throughputtests after these changes:**
```
Benchmarking library only(no writing out):
**
Benchmarking Single threaded: 100
swebb2066 closed pull request #89:
URL: https://github.com/apache/logging-log4cxx/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
swebb2066 commented on pull request #89:
URL: https://github.com/apache/logging-log4cxx/pull/89#issuecomment-1001372552
Suerceded by #90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
swebb2066 commented on pull request #88:
URL: https://github.com/apache/logging-log4cxx/pull/88#issuecomment-1001372699
Superceded by #90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
garydgregory commented on pull request #667:
URL: https://github.com/apache/logging-log4j2/pull/667#issuecomment-1001585742
Yikes, nice find @carterkozak 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775528603
##
File path: pom.xml
##
@@ -964,6 +964,19 @@
0.8.1
test
+
+com.google.guava
+
+guava-testl
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775572900
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softwar
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775574350
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softwar
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775575152
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softwar
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775577767
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softwar
ramananravi commented on pull request #670:
URL: https://github.com/apache/logging-log4j2/pull/670#issuecomment-1001669932
Currently the default value of 'exceeds' attribute of
'IfAccumulatedFileSize' is Long.MAX_VALUE, which is considerably larger than
1000 TB itself. Hence adding support
carterkozak merged pull request #667:
URL: https://github.com/apache/logging-log4j2/pull/667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
ramananravi closed pull request #670:
URL: https://github.com/apache/logging-log4j2/pull/670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775600190
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean subst
carterkozak commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775600190
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean subst
carterkozak commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775600190
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean subst
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775604217
##
File path: pom.xml
##
@@ -964,6 +964,19 @@
0.8.1
test
+
+com.google.guava
+
+guava-tes
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775604539
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softw
ramananravi commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1001690144
Currently the default value of 'exceeds' attribute of
'IfAccumulatedFileSize' is Long.MAX_VALUE, which is considerably larger than
1000 TB itself. Hence adding support
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775607662
##
File path: pom.xml
##
@@ -964,6 +964,19 @@
0.8.1
test
+
+com.google.guava
+
+guava-testl
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775607939
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softw
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775609043
##
File path: pom.xml
##
@@ -964,6 +964,19 @@
0.8.1
test
+
+com.google.guava
+
+guava-testl
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775609433
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softwar
vorburger commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775609860
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softwar
swebb2066 opened a new pull request #91:
URL: https://github.com/apache/logging-log4cxx/pull/91
This PR completes #87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
swebb2066 closed pull request #91:
URL: https://github.com/apache/logging-log4cxx/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
swebb2066 commented on pull request #91:
URL: https://github.com/apache/logging-log4cxx/pull/91#issuecomment-1001858047
Duplicates #90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
swebb2066 opened a new pull request #92:
URL: https://github.com/apache/logging-log4cxx/pull/92
This change adorns literal strings within LOG4CXX_STR where required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vy commented on pull request #672:
URL: https://github.com/apache/logging-log4j2/pull/672#issuecomment-1002281324
@carterkozak, @jvz, why do we exclude docs? I think we just need to add
license headers to them as any other file. (For the records, I've addressed
this in `release-2.x` withou
vy commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1002287774
@ramananravi, thanks so much for the contribution. This looks like a legit
request to me. Though I find the existing `(long) (double * long)`
multiplications in `FileSize` dang
jvz commented on pull request #672:
URL: https://github.com/apache/logging-log4j2/pull/672#issuecomment-1002289256
Good catch. I think the commented out license header for markdown files
makes sense. We can revert the rat exclusion.
--
This is an automated message from the Apache Git Ser
vy commented on pull request #669:
URL: https://github.com/apache/logging-log4j2/pull/669#issuecomment-1002290247
It wasn't invalid, but broken; fixed. @Xunzhuo, thanks so much for the heads
up!
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
vy closed pull request #669:
URL: https://github.com/apache/logging-log4j2/pull/669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
swebb2066 opened a new pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93
This new unit test covers the undocumented automatic configuration function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
rm5248 commented on pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#issuecomment-1002365783
Looks good to me. I also get rather dramatic increases in the number of log
messages/second when logging is disabled(approx. 10x on my machine). Other
stats are about 5-10
swebb2066 commented on pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#issuecomment-1002412720
Do you think this performance fix warrent a release (0.12.3) before
next_stable is ready?
--
This is an automated message from the Apache Git Service.
To respond to the
swebb2066 edited a comment on pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#issuecomment-1002412720
Do you think this performance fix warrants a release (0.12.3) before
next_stable is ready?
--
This is an automated message from the Apache Git Service.
To respon
ams-tschoening commented on a change in pull request #92:
URL: https://github.com/apache/logging-log4cxx/pull/92#discussion_r776230335
##
File path: src/test/cpp/throughput/throughput-main.cpp
##
@@ -71,14 +74,14 @@ static void benchmark_conversion_pattern( std::string name,
rm5248 commented on pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#issuecomment-1002651075
My current thought is that we'll do a 0.13.0 release in a few weeks; there
are a number of fixes for that already in master. next_stable probably won't
be for several month
garydgregory commented on pull request #668:
URL: https://github.com/apache/logging-log4j2/pull/668#issuecomment-1002652178
Hi @Kenducky
Thank you for your PR.
You'll want to look at the branch 'release-2.x', that where the 2.x releases
originate while the branch 'master' is for futu
sullis commented on pull request #446:
URL: https://github.com/apache/logging-log4j2/pull/446#issuecomment-1002749324
obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
sullis closed pull request #446:
URL: https://github.com/apache/logging-log4j2/pull/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
sullis commented on pull request #445:
URL: https://github.com/apache/logging-log4j2/pull/445#issuecomment-1002749381
obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
sullis closed pull request #445:
URL: https://github.com/apache/logging-log4j2/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
sullis opened a new pull request #673:
URL: https://github.com/apache/logging-log4j2/pull/673
latest version of Mockito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sullis commented on pull request #673:
URL: https://github.com/apache/logging-log4j2/pull/673#issuecomment-1002759421
Mistaken PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
sullis closed pull request #673:
URL: https://github.com/apache/logging-log4j2/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
carterkozak closed pull request #672:
URL: https://github.com/apache/logging-log4j2/pull/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on pull request #672:
URL: https://github.com/apache/logging-log4j2/pull/672#issuecomment-1002808751
This was meant to match the `README.md` file. No strong preference either
way from my end, I opted for exclusion initially since it's easier to read
through the file i
vy commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1002900021
@ramananravi, we think there are a few more places in the code where a
similar improvement might be handy. Mind creating a JIRA ticket for this
change, please?
--
This is an
ams-tschoening merged pull request #92:
URL: https://github.com/apache/logging-log4cxx/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: not
ams-tschoening commented on pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#issuecomment-1002920713
Before:
```text
Benchmarking library only(no writing out):
**
Benchmarking Single threaded:
RogerioBlanco opened a new pull request #675:
URL: https://github.com/apache/logging-log4j2/pull/675
The DirectWriteRolloverStrategy should at the start up choose the last index
if has eligible files instead the eligible files size.
--
This is an automated message from the Apache Git Ser
ramananravi commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1003021312
> @ramananravi, we think there are a few more places in the code where a
similar improvement might be handy. Mind creating a JIRA ticket for this
change, please?
Francis-FY opened a new pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676
Fix the issue that the initialize status of LogManager is not set when
logger factoryClassName is present and instantiate successfully, see
[LOG4J2-3304](https://issues.apache.org/jira/browse/
garydgregory commented on pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676#issuecomment-1003084416
Hi @Francis-FY
Thank you for your PR?
How could this be validated in a unit test?
--
This is an automated message from the Apache Git Service.
To respond to t
garydgregory edited a comment on pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676#issuecomment-1003084416
Hi @Francis-FY
Thank you for your PR.
How could this be validated in a unit test?
--
This is an automated message from the Apache Git Service.
To respo
rgoers commented on pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676#issuecomment-1003093157
I'm having a hard time understanding how this relates to Log4j's Spring Boot
support.
--
This is an automated message from the Apache Git Service.
To respond to the messa
Francis-FY commented on pull request #676:
URL: https://github.com/apache/logging-log4j2/pull/676#issuecomment-1003100483
@rgoers The method getEvnironment of SpringEnvironmentHolder will check if
LogManager is initialized through LogManagerStatus.isInitialized(). You can
run a unit test
ramananravi commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1003111212
Edited the PR description to add reference to jira ticket (LOG4J2-3303).
Could see some checks failing now (previously all checks passed). Are these
intermittent failu
ramananravi edited a comment on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1003111212
Edited the PR title to add reference to jira ticket (LOG4J2-3303). Could see
some checks failing now (previously all checks passed). Are these intermittent
fail
rm5248 merged pull request #10:
URL: https://github.com/apache/logging-chainsaw/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers opened a new pull request #677:
URL: https://github.com/apache/logging-log4j2/pull/677
Reverts to using prior logic but prevents endless conversion. Note that the
StrSubstitutor implementation had some issues - it still could get a
StackOverflowError, just in a different scenario. S
swebb2066 commented on pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#issuecomment-1003503632
Is this good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
swebb2066 commented on pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#issuecomment-1003504095
Merged using https://gitbox.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
swebb2066 closed pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
swebb2066 commented on pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93#issuecomment-1003508384
Merged as 7fedcdbf using https://gitbox.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
swebb2066 closed pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
swebb2066 opened a new pull request #94:
URL: https://github.com/apache/logging-log4cxx/pull/94
when using disabled logging statements.
throughputtests output after applyinh these changes:
```Benchmarking library only(no writing out):
rm5248 commented on a change in pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r776895762
##
File path: src/main/cpp/aprinitializer.cpp
##
@@ -127,3 +127,21 @@ void APRInitializer::unregisterCleanup(FileWatchdog*
watchdog)
}
}
+v
rm5248 commented on a change in pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#discussion_r773494809
##
File path: src/main/include/log4cxx/log4cxx.h.in
##
@@ -29,10 +29,14 @@
#define LOG4CXX_VERSION_MINOR @log4cxx_VERSION_MINOR@
#define LOG4CXX_VERS
rm5248 commented on pull request #93:
URL: https://github.com/apache/logging-log4cxx/pull/93#issuecomment-1003560920
Apparently I forgot to submit my review comments, but those are above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rm5248 commented on a change in pull request #90:
URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r776893142
##
File path: src/main/include/log4cxx/logger.h
##
@@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger :
@throws RuntimeException if al
4201 - 4300 of 7264 matches
Mail list logo
