vorburger opened a new pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653
https://issues.apache.org/jira/browse/LOG4J2-3282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
UditE5 commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r774917352
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/JndiLdapLookupTest.java
##
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apac
vy commented on a change in pull request #637:
URL: https://github.com/apache/logging-log4j2/pull/637#discussion_r775014358
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesPropertySource.java
##
@@ -29,15 +29,21 @@
private static final Stri
vy commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775016870
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int B
vy commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000844140
I tend to agree with @carterkozak. According to my experience, these kind of
measures have the potential to shadow the underlying problem. If the
configuration has something du
vy commented on pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-1000845984
LGTM. Thanks so much for the contribution @Francis-FY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vy merged pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-1000847776
Cherry-picked to `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
vy commented on pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-1000859937
@SR-G, no, your use case is actually pretty common: feeding Log4j to ELK.
Actually, we even have a layout to ease this process: `JsonTemplateLayout`. In
a nutshell, it was only
rm5248 commented on pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000862347
I'll have to take a look at that; I would be surprised if that was a
significant source of performance issues, but some testing would confirm that.
FWIW, using the `LO
hboutemy opened a new pull request #3:
URL: https://github.com/apache/logging-parent/pull/3
see https://issues.apache.org/jira/browse/MRELEASE-1071 bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
hboutemy opened a new pull request #654:
URL: https://github.com/apache/logging-log4j2/pull/654
see https://maven.apache.org/guides/mini/guide-reproducible-builds.html
having a value defined here make it follow your releases, instead of having
a value fixed by inheritance from parent
-
swebb2066 commented on pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000882788
Your data shows the rate of disabled log calls for multithread case which
should be near the single thread rate for each thread.
On Dec 25, 2021 1:38 AM, Robert Mid
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-100088
@KristjanESPERANTO, thanks for the contribution! This update needs to go
into `announcement.vm` in `release-2.x` branch.
--
This is an automated message from the Apache Git S
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000890111
Hrm... I will do it myself. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy closed pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
swebb2066 edited a comment on pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000882788
Your data shows the rate of disabled log calls for multithread case which
should be near the single thread rate for each thread.
I checked version 11 and the
garydgregory merged pull request #654:
URL: https://github.com/apache/logging-log4j2/pull/654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
garydgregory commented on pull request #654:
URL: https://github.com/apache/logging-log4j2/pull/654#issuecomment-1000890828
I'll apply the same to release-2.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
carterkozak opened a new pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655
This adds missing lookups: `bundle`, `event`, and `sd`
There's a comment suggesting that the PluginManager could be used,
however that will require additional validation before I'm co
garydgregory commented on pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000905659
Woa, aren't we missing unit tests that exercise those lookups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
carterkozak commented on pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000906261
> Woa, aren't we missing unit tests that exercise those lookups?
I think the issue is abundance of branches.
The non-plugin constructor is used initially w
carterkozak edited a comment on pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000906261
> Woa, aren't we missing unit tests that exercise those lookups?
I think the issue is abundance of branches.
The non-plugin constructor is used init
garydgregory commented on pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000907893
Double woa ;-) thank you for the clarification :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
carterkozak merged pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
jvz merged pull request #3:
URL: https://github.com/apache/logging-parent/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-uns
jvz commented on pull request #3:
URL: https://github.com/apache/logging-parent/pull/3#issuecomment-1000914945
Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
Gamebuster19901 commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000924743
> I tend to agree with @carterkozak. According to my experience, these kind
of measures have the potential to shadow the underlying problem. If the
configuration h
garydgregory commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775075046
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static f
garydgregory commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000926102
> I tend to agree with @carterkozak. According to my experience, these kind
of measures have the potential to shadow the underlying problem. If the
configuration has
jvz commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000927476
FWIW, I think making a specific finite limit on recursion is easier to
configure than relying on the stack size at runtime to run out of space.
--
This is an automated messa
carterkozak commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1000927711
When the recursion limit is hit, it's not clear whether we should return the
original string, or avoid recursing further.
Consider `java version: ${java:version}
carterkozak opened a new pull request #656:
URL: https://github.com/apache/logging-log4j2/pull/656
Previously a list of lookups was defined in code in parallel to
those available from the PluginManager.
The constuctor described these as lookups which don't require a
LogEvent, howeve
rm5248 opened a new pull request #657:
URL: https://github.com/apache/logging-log4j2/pull/657
Document the API separation of log4j2 and how to use it with other logging
frameworks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
carterkozak commented on a change in pull request #657:
URL: https://github.com/apache/logging-log4j2/pull/657#discussion_r775080805
##
File path: src/site/markdown/api-separation.md
##
@@ -0,0 +1,241 @@
+
+
+
+# API Separation
+
+When selecting a logging library, some care mus
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775081486
##
File path: pom.xml
##
@@ -964,6 +964,19 @@
0.8.1
test
+
+com.google.guava
+
+guava-tes
carterkozak commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775083886
##
File path:
log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Softw
garydgregory commented on a change in pull request #653:
URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r775084582
##
File path: pom.xml
##
@@ -964,6 +964,19 @@
0.8.1
test
+
+com.google.guava
+
+guava-te
Marcono1234 opened a new pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658
Some tests were changing system properties, but were not reverting their
changes. This pull request tries to address this issue.
In some cases there were
`System.setProperty(Constants.
Marcono1234 commented on a change in pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#discussion_r775094711
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/Log4j1222Test.java
##
@@ -34,8 +34,13 @@
@Test
public void
Marcono1234 commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1000960051
The test failures seem to be unrelated to these changes; they are also
occurring for `master`, e.g.
[here](https://github.com/apache/logging-log4j2/runs/4628017826).
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775102029
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private stati
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775102029
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private stati
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775102137
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private stati
remkop commented on pull request #657:
URL: https://github.com/apache/logging-log4j2/pull/657#issuecomment-1000967131
Would it make sense to include some of the images used in the FAQ on this
page as well?
For example:
https://github.com/apache/logging-log4j2/blob/master/src/site/resour
remkop edited a comment on pull request #657:
URL: https://github.com/apache/logging-log4j2/pull/657#issuecomment-1000967131
Would it make sense to include some of the images used in the FAQ on this
page as well?
For example:
https://github.com/apache/logging-log4j2/blob/master/src/site
remkop edited a comment on pull request #657:
URL: https://github.com/apache/logging-log4j2/pull/657#issuecomment-1000967131
Would it make sense to include some of the images used in the FAQ on this
page as well?
For example:
https://github.com/apache/logging-log4j2/blob/master/src/site
KristjanESPERANTO commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000997057
When will the changes be transferred from the `release-2.x` branch to the
master branch?
The `RELEASE-NOTES.md` in the master branch is still outdated.
-
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775126323
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775126323
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-100189
> Should we return the input, or the pieces that we could successfully
replace
Neither string is likely to be the output the author wanted I think. If this
case is hit
srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-100189
> Should we return the input, or the pieces that we could successfully
replace
Neither string is likely to be the output the author wanted I think. If this
case
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775127430
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775127430
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int
dongjinleekr commented on pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#issuecomment-1001001300
Hi @garydgregory,
After some trial and error, I concluded that maintaining the ignored package
list in an array would be better than a file-based approach. Here
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001010713
Updated to avoid throwing a potentially unhandled exception. Also moved the
max depth constant into the substitute method, and fixed a conflict with the
base branch.
--
Th
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001011990
The error messages are a little harder to understand now, since the logged
string will be whatever was being handled by `substitute` when the limit was
exceeded, instead of t
srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001011990
The error messages are a little harder to understand now, since the logged
error string will be whatever was being handled by `substitute` when the limit
was exceeded,
srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001011990
The error messages are a little harder to understand now, since the logged
error string will be whatever was being handled by `substitute` when the limit
was exceeded,
garydgregory commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775151693
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##
@@ -136,6 +136,18 @@ public B setRetryCou
carterkozak opened a new pull request #659:
URL: https://github.com/apache/logging-log4j2/pull/659
https://issues.apache.org/jira/browse/LOG4J2-3289
By passing a parameter array to slf4j, we hinted that the message string was
a template and should be substituted, however the result o
jvz merged pull request #10:
URL: https://github.com/apache/logging-log4j-scala/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
carterkozak merged pull request #659:
URL: https://github.com/apache/logging-log4j2/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775165870
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean s
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775165870
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean s
vy commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001070245
I am in favor of reading the cap from a property and returning the lookup as
is, i.e., no error logging via `StatusLogger`.
--
This is an automated message from the Apache Gi
vy commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001070661
Isn't there a mechanism we can hook into to take a snapshot of existing
properties before and restoring them after a test method?
--
This is an automated message from the Apa
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001070873
> When will the changes be transferred from the release-2.x branch to the
master branch?
[Never, since every release will have its own
content.](https://lists.apache.org
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775170010
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean substitute(f
Gamebuster19901 commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001072402
> I am in favor of reading the cap from a property and returning the lookup
as is, i.e., no error logging via `StatusLogger`.
I agree with no error logging f
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001072449
@vy Could you elaborate on why you prefer this?
For the system property, can we come up with a case where people will
actually need/want >10 (or some other limit) level
garydgregory commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001072849
> Isn't there a mechanism we can hook into to take a snapshot of existing
properties before and restoring them after a test method?
Yes, there's an app for that
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775170590
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean substitute(f
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775172956
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean s
Gamebuster19901 edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001072402
> I am in favor of reading the cap from a property and returning the lookup
as is, i.e., no error logging via `StatusLogger`.
~~I agree with no error
Gamebuster19901 edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001072402
> I am in favor of reading the cap from a property and returning the lookup
as is, i.e., no error logging via `StatusLogger`.
~~I agree with no error
Gamebuster19901 commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001075553
> For the `StatusLogger`, removing the log will mean a user hitting this
limit won't know about it, which makes it harder for them to fix. Their logs
will just be
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775173387
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/StrSubstitutorTest.java
##
@@ -249,4 +249,37 @@ public void
tes
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775173387
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/StrSubstitutorTest.java
##
@@ -249,4 +249,37 @@ public void
tes
KristjanESPERANTO commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001077412
Then you will never find a reference to the current release notes in the
master branch. If that's the way you want it, I don't understand it, but that's
okay too
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775176529
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/StrSubstitutorTest.java
##
@@ -249,4 +249,37 @@ public void
testTopLevelLo
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775176529
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/StrSubstitutorTest.java
##
@@ -249,4 +249,37 @@ public void
testTopLevelLo
Marcono1234 commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001090717
The issue is that currently some tests are still using JUnit 4. For that
there is the [System Rules](https://github.com/stefanbirkner/system-rules)
project, but I did
dongjinleekr commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775189022
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##
@@ -136,6 +136,18 @@ public B setRetryCou
garydgregory commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775190696
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##
@@ -136,6 +136,18 @@ public B setRetryCou
garydgregory commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001101249
> The issue is that currently some tests are still using JUnit 4. For that
there is the [System Rules](https://github.com/stefanbirkner/system-rules)
project, but I d
dongjinleekr commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775197551
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##
@@ -136,6 +136,18 @@ public B setRetryCou
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001158550
I see your point @KristjanESPERANTO, maybe we should set the default branch
to `release-2.x`. I guess this addresses your concern, right?
--
This is an automated message from
vy commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001159235
> Yes, there's an app for that ;-)
https://junit-pioneer.org/docs/system-properties/
The reason I did not mention about `system-properties` of JUnit Pioneer is
that it o
vy commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001159870
> The issue is that currently some tests are still using JUnit 4. For that
there is the [System Rules](https://github.com/stefanbirkner/system-rules)
project, but I did not wan
carterkozak commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001178492
Each test class in core runs in an isolated fork, otherwise we couldn’t test
different values of properties which are stored into static final fields (e.g.
Constants.j
garydgregory commented on pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#issuecomment-1001187534
@dongjinleekr
I modified GitHub patch #640 and pushed patches to branches release-2.x and
master.
You are credited in changes.xml.
Thank you for
garydgregory closed pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
garydgregory edited a comment on pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#issuecomment-1001187534
@dongjinleekr
I modified GitHub patch #640 and pushed patches to branches `release-2.x`
and `master`.
You are credited in `changes.xml`.
T
KristjanESPERANTO commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001190408
Yes, that would address my point. The master branch is now the entry point
for people who want to start dealing with the code. Since I can also see
current chang
garydgregory commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001190503
> Each test class in core runs in an isolated fork, otherwise we couldn’t
test different values of properties which are stored into static final fields
(e.g. Constant
garydgregory commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001191452
> > The issue is that currently some tests are still using JUnit 4. For that
there is the [System Rules](https://github.com/stefanbirkner/system-rules)
project, but I
garydgregory edited a comment on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001191452
> > The issue is that currently some tests are still using JUnit 4. For that
there is the [System Rules](https://github.com/stefanbirkner/system-rules)
project
garydgregory commented on a change in pull request #660:
URL: https://github.com/apache/logging-log4j2/pull/660#discussion_r775250119
##
File path: CONTRIBUTING.md
##
@@ -62,9 +62,9 @@ In this case, it is appropriate to start the first line of a
commit with '(doc)'
+ [Proje
KristjanESPERANTO commented on a change in pull request #660:
URL: https://github.com/apache/logging-log4j2/pull/660#discussion_r775253495
##
File path: CONTRIBUTING.md
##
@@ -62,9 +62,9 @@ In this case, it is appropriate to start the first line of a
commit with '(doc)'
+ [
4101 - 4200 of 7264 matches
Mail list logo
