quaff commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997717857
> You are right that 3230 fixes the vulnerability, I'm not opening this PR
to fix a known problem. I'm coming at this from the point of view that if there
is no reason to all
remkop closed pull request #638:
URL: https://github.com/apache/logging-log4j2/pull/638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
remkop commented on a change in pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#discussion_r772281862
##
File path: src/site/xdoc/manual/layouts.xml.vm
##
@@ -1455,9 +1455,9 @@ WARN [main]: Message 2
-
garydgregory commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997897168
> > @quaff I don't think that fixes the same thing? This fix is trying to
limit recursion depth in all cases, the fix you are linking disables recursion
in some cases.
garydgregory opened a new pull request #645:
URL: https://github.com/apache/logging-log4j2/pull/645
[LOG4J2-3242] Limit JNDI to the java protocol only. JNDI will remain
disabled by default. The enablement property has been renamed to
'log4j2.enableJndiJava'.
--
This is an automated me
rgoers merged pull request #645:
URL: https://github.com/apache/logging-log4j2/pull/645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
vy commented on pull request #631:
URL: https://github.com/apache/logging-log4j2/pull/631#issuecomment-998327523
@zhuyou1234, thanks for your contribution. I think allowing empty names were
already a bug in the first place. Hence, I am inclined to keep the code in its
current state (that i
vy closed pull request #631:
URL: https://github.com/apache/logging-log4j2/pull/631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
garydgregory commented on a change in pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#discussion_r772766541
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/MapLookupTest.java
##
@@ -107,7 +107,7 @@ public void testLookupDef
quaff commented on a change in pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#discussion_r772771184
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/MapLookupTest.java
##
@@ -107,7 +107,7 @@ public void testLookupDefaultMap
carterkozak commented on a change in pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#discussion_r772782217
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/MapLookup.java
##
@@ -122,14 +122,14 @@ public String lookup(final L
carterkozak commented on a change in pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#discussion_r772782492
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/MapLookup.java
##
@@ -122,14 +122,14 @@ public String lookup(final L
carterkozak commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-998413709
I'm not sure I entirely understand what we're protecting against -- I'd
consider any recursion beyond what the configuration author expects to be an
incredibly serious
rm5248 merged pull request #82:
URL: https://github.com/apache/logging-log4cxx/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
sullis closed pull request #4:
URL: https://github.com/apache/logging-log4j-scala/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
sullis commented on pull request #4:
URL: https://github.com/apache/logging-log4j-scala/pull/4#issuecomment-998426571
obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
sullis commented on pull request #6:
URL: https://github.com/apache/logging-log4j-scala/pull/6#issuecomment-998426835
@jvz @garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jvz merged pull request #6:
URL: https://github.com/apache/logging-log4j-scala/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
jvz commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-998438723
Made some minor dependency updates recently. Go ahead and rebase or merge
from master.
--
This is an automated message from the Apache Git Service.
To respond to the message
jvz merged pull request #7:
URL: https://github.com/apache/logging-log4j-scala/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-998546015
@carterkozak An issue like 3230 would have been much less serious if the
substitutor weren't capable of infinite recursion. This is an attempt at harm
reduction in case an iss
vy closed pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-998746689
As @jvz noted in the mailing list:
> I'll note here that the messages API isn't intended to be interpreted
> the way that CVE-2021-44228 allowed. Messages are supposed t
pjfanning opened a new pull request #8:
URL: https://github.com/apache/logging-log4j-scala/pull/8
@jvz this config should work for existing log4j-scala users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
fulldecent commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-998791311
The Messages are NOT strings nor are they "messages".
The specification is wrong and therefore it is vulnerable. Sometimes it is
shell-code vulnerable but definit
garydgregory commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-998805145
" Sometimes it is shell-code vulnerable "
That is just FUD and actually impossible because Logger is an interface.
There is no implementation or behavior here, not e
carterkozak commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-998837161
I believe there's (understandably) some confusion here. @fulldecent can you
please provide a minimal unit-test against the release-2.x branch, or otherwise
using the 2.
fulldecent commented on pull request #630:
URL: https://github.com/apache/logging-log4j2/pull/630#issuecomment-998868962
Thank you. Here is a minimal test case.
Here is an implementation, a subclass of log4v2 `Logger` and `Message`
classes:
```
public error(string message)
Sadboipoor commented on a change in pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r773300837
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -102,6 +120,14 @@ const char* LocationInfo::getFileName() const
return fileName;
}
+/*
Sadboipoor removed a comment on pull request #82:
URL: https://github.com/apache/logging-log4cxx/pull/82#issuecomment-997399720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
Sadboipoor commented on a change in pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r773300837
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -102,6 +120,14 @@ const char* LocationInfo::getFileName() const
return fileName;
}
+/*
carterkozak commented on pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#issuecomment-998993808
I think this PR suggests correct behavior, however, before it merges we need
to split out a separate lookup for configuration properties which is not
impacted by map-me
sullis commented on pull request #9:
URL: https://github.com/apache/logging-log4j-scala/pull/9#issuecomment-999013865
@jvz can you merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
carterkozak opened a new pull request #647:
URL: https://github.com/apache/logging-log4j2/pull/647
`MapLookup` includes special handling for `MapMessages` in addition
to the configuration properties map. This change aims to prevent
unwanted interactions between these two concerns.
--
jmdavison46 opened a new pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86
Parenthesize arguments to LOG4CXX_MAKE_VERSION. Provide companion
LOG4CXX_VERSION_GET_{MAJOR, MINOR, PATCH, TWEAK} macros to facilitate
reporting, and other usage, of LOG4CXX_VERSION at compi
jvz merged pull request #8:
URL: https://github.com/apache/logging-log4j-scala/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
carterkozak commented on a change in pull request #647:
URL: https://github.com/apache/logging-log4j2/pull/647#discussion_r773420538
##
File path: src/site/xdoc/manual/lookups.xml
##
@@ -493,7 +493,6 @@ public static void main(String args[]) {
Provi
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999078320
@jvz I've made some progress but could you look at my comment from 10 days
ago? Is it ok just to delegate the traceEntry and traceExit calls to wrapped
logger instead of
jvz merged pull request #9:
URL: https://github.com/apache/logging-log4j-scala/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
jvz commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999096680
Oh yeah, please, go ahead and make that a delegated method. The point of the
macros in the past were to allow for string interpolation to be elided when
logging is disabled fo
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999106843
@jvz is it ok to change the scala 2 build so that traceEntry and traceExit
use no macros there either (for consistency)?
--
This is an automated message from the Apach
jvz commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999107132
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999121194
@jvz could you review this when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
rm5248 commented on a change in pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#discussion_r773494371
##
File path: src/main/include/log4cxx/log4cxx.h.in
##
@@ -29,10 +29,14 @@
#define LOG4CXX_VERSION_MINOR @log4cxx_VERSION_MINOR@
#define LOG4CXX_VERS
rm5248 opened a new pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87
This PR adds in a utility used for benchmarking the log4cxx library. It
does not benchmark anything about actually writing data out; that is outside of
the scope of what this benchmarks at the mom
rm5248 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-999254310
I've added my performance tests in a separate PR(#87). I think it is
equivalent to this PR and covers more cases. If you are able to take a look at
it and provide feedback,
ellizamiller001 opened a new pull request #648:
URL: https://github.com/apache/logging-log4j2/pull/648
Reverts apache/logging-log4j2#635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
riven8192 opened a new pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649
To address the log4j jndi-vulnerability, many companies have removed
JndiLookup.class from the artifact, whether or not they upgraded log4j2. This
is a safeguard against the potential of newly
garydgregory commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999784891
This has already been handled in 2.17.0. Note that PRs should be created
against the release-2.x branch.
--
This is an automated message from the Apache Git Service.
riven8192 commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999785941
@garydgregory The 2.17.0 patch does not factor in a safeguard for repackaged
dependencies (where the java package-names are changed)
--
This is an automated message fro
garydgregory commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999789007
Now that we have provides releases for all Java versions that ever saw a
Log4j 2 release, I don't think our code should account for mangled jar files.
- Java 8 -> 2.
garydgregory commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999792045
You might not have noticed the master branch is labeled 3.0.0-SNAPSHOT. The
branch for 2.x is called release-2.x.
--
This is an automated message from the Apache Git
carterkozak opened a new pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650
Rather than checking properties after each invocation, jndi
properties are all read into static final boolean fields when
the JndiManager class is initialized, this way properties cannot
garydgregory commented on pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650#issuecomment-999846809
How is that going to work for tests that set and clear properties? You
don't want to set a property "forever"...
Gaty
On Wed, Dec 22, 2021, 15:25 Carter
garydgregory edited a comment on pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650#issuecomment-999846809
How is that going to work for tests that set and clear properties? You
don't want to set a property "forever"...
Gary
On Wed, Dec 22, 2021, 15:2
carterkozak commented on pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650#issuecomment-999860302
> How is that going to work for tests that set and clear properties? You
don't want to set a property "forever"...
Good question. I'm letting CI run our tests to
garydgregory commented on pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650#issuecomment-999870082
> > How is that going to work for tests that set and clear properties? You
don't want to set a property "forever"...
>
> Good question. I'm letting CI run our te
carterkozak commented on pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650#issuecomment-999870595
Local build succeeded :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
garydgregory commented on pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650#issuecomment-999871597
> Local build succeeded :-)
Ka-pow! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
carterkozak merged pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak merged pull request #647:
URL: https://github.com/apache/logging-log4j2/pull/647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
riven8192 commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999883312
Thanks for the information regarding the branches @garydgregory.
I will not (yet) make PRs for those branches, as it seems it'd be preferable
to agree on the underl
rgoers commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999887585
We were in such a hurry to get patches out that nothing was brought back to
the master (3.0) branch. I am actually in the process right now of moving the
JNDI pieces to thei
rgoers edited a comment on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999887585
We were in such a hurry to get patches out that nothing was brought back to
the master (3.0) branch. I am actually in the process right now of moving the
JNDI pieces
riven8192 commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999896230
Thanks for your reply. With repackaging I didn't mean a refactor on the
log4j side, but for example a 3rd party library like a google client-api, that
renames:
`org.ap
riven8192 edited a comment on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999896230
Thanks for your reply. With repackaging I didn't mean a refactor on the
log4j side, but for example a 3rd party library like a google client-api, that
renames:
riven8192 edited a comment on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-999896230
Thanks for your reply. With repackaging I didn't mean a refactor on the
log4j side, but for example a 3rd party library like a google client-api, that
renames:
carterkozak commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-00777
@riven8192 the repackaging plugins I'm aware of also match string constants
and rewrite those when they match fully qualified class names. I believe that
would work cor
riven8192 commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-08082
Thanks @carterkozak - that indeed ensures security in the case I described.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
carterkozak commented on pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#issuecomment-08178
@quaff I've resolved that issue, would you mind rebasing to `release-2.x`? I
think you'll need to update one of the tests in `InterpolatorTest` as well.
Thanks!
--
T
riven8192 closed pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
swebb2066 commented on pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-33135
Hi Robert,
This should do the initial job just fine.
However, a couple of things occur to me in hindsight.
1. Multi threaded logging to a single logger
swebb2066 commented on a change in pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#discussion_r77423
##
File path: src/test/cpp/throughput/CMakeLists.txt
##
@@ -0,0 +1,40 @@
+option(BUILD_THROUGHPUT_TESTS "Build throughput tests" OFF)
+
+if( NOT BU
swebb2066 edited a comment on pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-33135
Hi Robert,
This should do the initial job just fine.
However, a couple of things occur to me in hindsight.
1. Multi threaded logging to a single
quaff commented on pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#issuecomment-71506
> @quaff I've resolved that issue, would you mind rebasing to `release-2.x`?
I think you'll need to update one of the tests in `InterpolatorTest` as well.
Thanks!
@car
rm5248 commented on a change in pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#discussion_r774285680
##
File path: src/test/cpp/throughput/CMakeLists.txt
##
@@ -0,0 +1,40 @@
+option(BUILD_THROUGHPUT_TESTS "Build throughput tests" OFF)
+
+if( NOT BUILD
rm5248 commented on pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-114049
> 1. Multi threaded logging to a single logger probably should be part
of the unit tests rather than a throughput test. The mutex in
log4cxx::Hierarchy (or AppenderAttac
rm5248 edited a comment on pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-114049
> 1. Multi threaded logging to a single logger probably should be part of
the unit tests rather than a throughput test. The mutex in log4cxx::Hierarchy
(or AppenderA
garydgregory commented on pull request #649:
URL: https://github.com/apache/logging-log4j2/pull/649#issuecomment-117158
> We were in such a hurry to get patches out that nothing was brought back
to the master (3.0) branch. I am actually in the process right now of moving
the JNDI piece
dpsenner closed pull request #643:
URL: https://github.com/apache/logging-log4j2/pull/643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
vy commented on pull request #648:
URL: https://github.com/apache/logging-log4j2/pull/648#issuecomment-1000398388
Spam.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vorburger opened a new pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651
Yo Log4j maintainers - hope this helps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
vorburger opened a new pull request #652:
URL: https://github.com/apache/logging-log4j2/pull/652
- LOG4J2-2236 Removed unnecessary dependency on jcommander since Log4j uses
embedded picocli since 2.9.
- [LOG4J2-2243] Cannot see or copy all of certain JAnsi exception messages
on Windows
vorburger commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000414777
Builds failing? I've opened
https://issues.apache.org/jira/browse/LOG4J2-3229.
BTW should I be raising a 2nd PR to cherry-pick this to `release-2.x` from
`master`
garydgregory commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000416627
Hello @vorburger,
Please base your PR on the branch release-2.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
carterkozak commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000417982
It would be helpful to describe what has been resolved rather than using the
description `fixed bug in ClassName` ;-)
I'd appreciate it if you could PR into `rel
larrywest42 commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000418438
That's a helpful change, especially as the most recent version mentioned in
"RELEASE-NOTE.md" is `2.11.0`, from 2018.
--
This is an automated message from the Apache
larrywest42 edited a comment on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000418438
That's a helpful change, especially as the most recent version mentioned in
"RELEASE-NOTES.md" is `2.11.0`, from 2018.
--
This is an automated message from th
vorburger commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000424173
> Please base your PR on the branch release-2.x.
done
> It would be helpful to describe what has been resolved rather than using
the description `fixed bug
vorburger commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000425549
BTW just FYI this PR is a result of my staring at this code in the context
of [LOG4J2-3282](https://issues.apache.org/jira/browse/LOG4J2-3282) - it seemed
like a Good Id
carterkozak commented on pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651#issuecomment-1000429985
lgtm, thanks for the contribution! I'll get this merged once tests complete.
I've filed https://issues.apache.org/jira/browse/LOG4J2-3284 for tracking.
--
This
carterkozak merged pull request #652:
URL: https://github.com/apache/logging-log4j2/pull/652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#issuecomment-1000444053
@garydgregory You have an active disapproval on this PR, is there anything
you're waiting for?
--
This is an automated message from the Apache Git Service.
To respon
garydgregory commented on pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646#issuecomment-1000445117
> @garydgregory You have an active disapproval on this PR, is there anything
you're waiting for?
Approved, thank you for the reminder.
--
This is an automat
carterkozak merged pull request #646:
URL: https://github.com/apache/logging-log4j2/pull/646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak merged pull request #651:
URL: https://github.com/apache/logging-log4j2/pull/651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
pjfanning commented on pull request #5:
URL:
https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-1000514813
@jvz I'm happy to get this merged as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
jvz merged pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
jvz commented on pull request #5:
URL:
https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-1000515452
Thanks so much for the PR! I'll work on a release candidate sometime today
(assuming the rest of the build still works as documented).
--
This is an automated message from
swebb2066 commented on pull request #87:
URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000584520
> Part of the performance testing is to also help us find areas where we can
better parallelize the logging. There are probably a number of places we can
replace a mutex
4001 - 4100 of 7264 matches
Mail list logo
