[GitHub] [logging-log4j2] tbwork commented on a change in pull request #396: Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

tbwork commented on a change in pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471211570 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java ## @@ -16,20 +16,13 @@ */ package org.apache.logging

[GitHub] [logging-log4j2] tbwork commented on pull request #396: Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

tbwork commented on pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674697992 @rgoers Hi, rgoers. How to understand your comments: **_The Lookups would be loaded again as normal as Plugins during configuration._** If all pre-loaded looku

[GitHub] [logging-log4j2] tbwork edited a comment on pull request #396: Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

tbwork edited a comment on pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674697992 @rgoers Hi, rgoers. After debuging and reading the log4j2 codes, I realize that the **_public Interpolator(final Map properties)_** is called several times during fac

[GitHub] [logging-log4j2] rgoers commented on pull request #396: Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

rgoers commented on pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674967144 Well, the Interpolator constructor that has the hard-coded list of lookups is initializing the lookups that could be using while constructing the configuration. The other lo

[GitHub] [logging-log4j2] rgoers commented on pull request #402: Added two articles recently published

rgoers commented on pull request #402: URL: https://github.com/apache/logging-log4j2/pull/402#issuecomment-675277664 A couple of comments on the Srping Boot article: 1. In the first two paragraphs you say "new" in each. The first commit for Log4j 2 was 10 years ago and the first GA relea

[GitHub] [logging-log4j2] rgoers edited a comment on pull request #402: Added two articles recently published

rgoers edited a comment on pull request #402: URL: https://github.com/apache/logging-log4j2/pull/402#issuecomment-675277664 A couple of comments on the Srping Boot article: 1. In the first two paragraphs you say "new" in each. The first commit for Log4j 2 was 10 years ago and the first G

[GitHub] [logging-log4j2] fmarchioni commented on pull request #402: Added two articles recently published

fmarchioni commented on pull request #402: URL: https://github.com/apache/logging-log4j2/pull/402#issuecomment-675412587 Thanks for taking the time to review the article. I've fixed point 1) and 2) Also for point 3) I've added a section to show how to use log4j-bom both both for Sprin

[GitHub] [logging-log4j2] rgoers merged pull request #402: Added two articles recently published

rgoers merged pull request #402: URL: https://github.com/apache/logging-log4j2/pull/402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers commented on pull request #402: Added two articles recently published

rgoers commented on pull request #402: URL: https://github.com/apache/logging-log4j2/pull/402#issuecomment-675593486 Thanks for making the changes. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [logging-log4j2] rgoers merged pull request #360: LOG4J2-2847 - Extend Log4j-config.xsd

rgoers merged pull request #360: URL: https://github.com/apache/logging-log4j2/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #35: Changed some docs and model dependencies for tests etc. using MVN.

ams-tschoening commented on pull request #35: URL: https://github.com/apache/logging-log4cxx/pull/35#issuecomment-675894748 I've added a hint, but leave merging to @rm5248 to not break his release-process. This is an automat

[GitHub] [logging-log4cxx] ams-tschoening opened a new pull request #36: Remove MD5, add SHA-512 file extension.

ams-tschoening opened a new pull request #36: URL: https://github.com/apache/logging-log4cxx/pull/36 MD5 is not used anymore for releases and the SHA file extension needed to be different because of SHA-512. This is an autom

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #36: Remove MD5, add SHA-512 file extension.

ams-tschoening commented on pull request #36: URL: https://github.com/apache/logging-log4cxx/pull/36#issuecomment-675897117 I didn't test things, it's more of a reminder that this needs to be done anyway and don't want to break release process of @rm5248. -

[GitHub] [logging-log4cxx] rm5248 commented on pull request #35: Changed some docs and model dependencies for tests etc. using MVN.

rm5248 commented on pull request #35: URL: https://github.com/apache/logging-log4cxx/pull/35#issuecomment-676824485 Looks good to me - I'll merge it shortly once the release gets finalized. This is an automated message from t

[GitHub] [logging-log4j2] jvz commented on pull request #401: run CI build for pull requests

jvz commented on pull request #401: URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678719464 PRs already seem to be built by default without that config setting though? This is an automated message from t

[GitHub] [logging-log4j2] jvz merged pull request #403: Bump plexus-compiler-javac-errorprone from 2.8.5 to 2.8.7

jvz merged pull request #403: URL: https://github.com/apache/logging-log4j2/pull/403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] jvz merged pull request #398: Bump maven-resources-plugin from 3.0.2 to 3.2.0

jvz merged pull request #398: URL: https://github.com/apache/logging-log4j2/pull/398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] jvz merged pull request #377: Bump maven-checkstyle-plugin from 3.0.0 to 3.1.1

jvz merged pull request #377: URL: https://github.com/apache/logging-log4j2/pull/377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] jvz commented on pull request #403: Bump plexus-compiler-javac-errorprone from 2.8.5 to 2.8.7

jvz commented on pull request #403: URL: https://github.com/apache/logging-log4j2/pull/403#issuecomment-678724467 This one didn't work right. This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [logging-log4j2] sullis commented on pull request #401: run CI build for pull requests

sullis commented on pull request #401: URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678791217 > PRs already seem to be built by default without that config setting though? PR 400 ( https://github.com/apache/logging-log4j2/pull/400 ) did not trigger a build.

[GitHub] [logging-log4j2] sullis edited a comment on pull request #401: run CI build for pull requests

sullis edited a comment on pull request #401: URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678791217 > PRs already seem to be built by default without that config setting though? PR 400 ( https://github.com/apache/logging-log4j2/pull/400 ) did not trigger a bui

[GitHub] [logging-log4j2] jvz commented on pull request #401: run CI build for pull requests

jvz commented on pull request #401: URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678800065 Is this PR only being built then because of the config update here? BTW, our workflow is broken at the moment anyways. Hopefully we can figure it out soon, but something

[GitHub] [logging-log4j2] jvz commented on pull request #401: run CI build for pull requests

jvz commented on pull request #401: URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678810486 In the meantime, I've enabled Jenkins builds for PRs from collaborators at least. This is an automated message

[GitHub] [logging-log4j2] jvz commented on pull request #400: mockito 3.5.5

jvz commented on pull request #400: URL: https://github.com/apache/logging-log4j2/pull/400#issuecomment-678813464 Looks like I'm going to need this dependency update in order to use `mockito-junit-jupiter`. After the tests pass, we can merge this. -

[GitHub] [logging-log4j2] jvz commented on pull request #400: mockito 3.5.5

jvz commented on pull request #400: URL: https://github.com/apache/logging-log4j2/pull/400#issuecomment-678815187 Test failures look unrelated. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4j2] jvz merged pull request #400: mockito 3.5.5

jvz merged pull request #400: URL: https://github.com/apache/logging-log4j2/pull/400 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] sullis commented on pull request #401: run CI build for pull requests

sullis commented on pull request #401: URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678815563 > Is this PR only being built then because of the config update here? > Yes. This is an autom

[GitHub] [logging-log4j2] jvz merged pull request #401: run CI build for pull requests

jvz merged pull request #401: URL: https://github.com/apache/logging-log4j2/pull/401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #404: Bump org.apache.felix.framework from 5.6.10 to 6.0.3

dependabot[bot] opened a new pull request #404: URL: https://github.com/apache/logging-log4j2/pull/404 Bumps org.apache.felix.framework from 5.6.10 to 6.0.3. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #406: Bump maven-pmd-plugin from 3.10.0 to 3.13.0

dependabot[bot] opened a new pull request #406: URL: https://github.com/apache/logging-log4j2/pull/406 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.10.0 to 3.13.0. Commits https://github.com/apache/maven-pmd-plugin/commit/63feb99bcd764b9cae88bc44

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #405: Bump jackson2Version from 2.11.1 to 2.11.2

dependabot[bot] opened a new pull request #405: URL: https://github.com/apache/logging-log4j2/pull/405 Bumps `jackson2Version` from 2.11.1 to 2.11.2. Updates `jackson-core` from 2.11.1 to 2.11.2 Commits https://github.com/FasterXML/jackson-core/commit/71ea59578be8d2e50f0d789

[GitHub] [logging-log4j2] vy merged pull request #405: Bump jackson2Version from 2.11.1 to 2.11.2

vy merged pull request #405: URL: https://github.com/apache/logging-log4j2/pull/405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy merged pull request #380: Bump commons-compress from 1.18 to 1.20

vy merged pull request #380: URL: https://github.com/apache/logging-log4j2/pull/380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy merged pull request #395: Bump jctools-core from 1.2.1 to 3.1.0

vy merged pull request #395: URL: https://github.com/apache/logging-log4j2/pull/395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy merged pull request #406: Bump maven-pmd-plugin from 3.10.0 to 3.13.0

vy merged pull request #406: URL: https://github.com/apache/logging-log4j2/pull/406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy merged pull request #404: Bump org.apache.felix.framework from 5.6.10 to 6.0.3

vy merged pull request #404: URL: https://github.com/apache/logging-log4j2/pull/404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy merged pull request #393: Bump jetty-util from 8.2.0.v20160908 to 9.4.31.v20200723

vy merged pull request #393: URL: https://github.com/apache/logging-log4j2/pull/393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] ramazanpolat commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

ramazanpolat commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-680817438 Hi, do you have a documentation for `JsonTemplateLayout`? This is an automated message from the Apach

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-680820895 @ramazanpolat, you can access [the latest version of the manual here](https://github.com/apache/logging-log4j2/blob/master/src/site/asciidoc/manual/json-template-layout.adoc.vm).

[GitHub] [logging-log4net] fluffynuts opened a new pull request #62: Move site back where it belongs

fluffynuts opened a new pull request #62: URL: https://github.com/apache/logging-log4net/pull/62 This is work-in-progress: trying to get the log4net site generation working properly again. This is an automated messag

[GitHub] [logging-log4net] fluffynuts commented on pull request #62: Move site back where it belongs

fluffynuts commented on pull request #62: URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-681014918 @rgoers I've moved the artifacts back where maven recognises them, but the result I get from running a command like `mvn site:stage -DstagingDirectory=$HOME/log4net` give

[GitHub] [logging-log4net] rgoers commented on pull request #62: Move site back where it belongs

rgoers commented on pull request #62: URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-681021839 FWIW, the Apache Logging project generally uses "CTR " (commit - then review). So if you are comfortable with the changes being made you don't need to create a PR. Committers

[GitHub] [logging-log4net] rgoers merged pull request #62: Move site back where it belongs

rgoers merged pull request #62: URL: https://github.com/apache/logging-log4net/pull/62 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4cxx] rm5248 merged pull request #36: Remove MD5, add SHA-512 file extension.

rm5248 merged pull request #36: URL: https://github.com/apache/logging-log4cxx/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #37: Search for programs needed for tests

rm5248 opened a new pull request #37: URL: https://github.com/apache/logging-log4cxx/pull/37 Add a check for applications that are needed for tests to run successfully. This is an automated message from the Apache Git Service

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #38: Added .asf.yaml file to better configure the github git mirror

rm5248 opened a new pull request #38: URL: https://github.com/apache/logging-log4cxx/pull/38 See documentation for details: https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features This is an automated mess

[GitHub] [logging-log4net] fluffynuts commented on pull request #62: Move site back where it belongs

fluffynuts commented on pull request #62: URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-681321862 @rgoers I had 2 subsequent commits on the PR (didn't realise that you'd acted on it so quickly!) which restore the release folder in the site area, fixing all the missing

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #408: Bump maven-shade-plugin from 2.2 to 3.2.4

dependabot[bot] opened a new pull request #408: URL: https://github.com/apache/logging-log4j2/pull/408 Bumps [maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 2.2 to 3.2.4. Commits https://github.com/apache/maven-shade-plugin/commit/768092f38b0b1650217642

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #409: Bump disruptor from 1.2.15 to 1.2.17

dependabot[bot] opened a new pull request #409: URL: https://github.com/apache/logging-log4j2/pull/409 Bumps [disruptor](https://github.com/conversant/disruptor) from 1.2.15 to 1.2.17. Release notes Sourced from https://github.com/conversant/disruptor/releases";>disruptor's relea

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #412: Bump assertj-core from 3.14.0 to 3.17.0

dependabot[bot] opened a new pull request #412: URL: https://github.com/apache/logging-log4j2/pull/412 Bumps [assertj-core](https://github.com/joel-costigliola/assertj-core) from 3.14.0 to 3.17.0. Commits https://github.com/joel-costigliola/assertj-core/commit/5238cf24b7757b65

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #410: Bump jeromq from 0.4.3 to 0.5.2

dependabot[bot] opened a new pull request #410: URL: https://github.com/apache/logging-log4j2/pull/410 Bumps [jeromq](https://github.com/zeromq/jeromq) from 0.4.3 to 0.5.2. Changelog Sourced from https://github.com/zeromq/jeromq/blob/master/CHANGELOG.md";>jeromq's changelog.

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #407: Bump tomcat-catalina from 8.5.20 to 9.0.37

dependabot[bot] opened a new pull request #407: URL: https://github.com/apache/logging-log4j2/pull/407 Bumps tomcat-catalina from 8.5.20 to 9.0.37. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tom

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #411: Bump spring-ws-core from 2.1.4.RELEASE to 3.0.9.RELEASE

dependabot[bot] opened a new pull request #411: URL: https://github.com/apache/logging-log4j2/pull/411 Bumps [spring-ws-core](https://github.com/spring-projects/spring-ws) from 2.1.4.RELEASE to 3.0.9.RELEASE. Commits https://github.com/spring-projects/spring-ws/commit/c0dedba3

[GitHub] [logging-log4net] rgoers commented on pull request #62: Move site back where it belongs

rgoers commented on pull request #62: URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-681441776 > On Aug 26, 2020, at 8:27 PM, Davyd McColl wrote: > > > @rgoers I had 2 subsequent commits on the PR (didn't realise that you'

[GitHub] [logging-log4net] fluffynuts commented on pull request #62: Move site back where it belongs

fluffynuts commented on pull request #62: URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-681595433 @rgoers cool -- but I can't push to apache/logging-log4net: ``` ERROR: Permission to apache/logging-log4net.git denied to fluffynuts. ``` ---

[GitHub] [logging-log4net] rgoers commented on pull request #62: Move site back where it belongs

rgoers commented on pull request #62: URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-681613249 Your apache userid is davydm. It needs to be linked with your GitHub user. See https://gitbox.apache.org/setup/. Apache Logging doesn't have a guide but many projects do. For

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #37: Search for programs needed for tests

ams-tschoening commented on a change in pull request #37: URL: https://github.com/apache/logging-log4cxx/pull/37#discussion_r478184458 ## File path: CMakeLists.txt ## @@ -123,3 +123,10 @@ message(STATUS " logchar type : ${LOG4CXX_CHAR}") message(STATUS "

[GitHub] [logging-log4net] fluffynuts commented on pull request #62: Move site back where it belongs

round team addition 4. gitbox seems to think I should be able to push:  however, I still can't push to github.com/apache/logging-log4net: ``` ERROR: Permission to apac

[GitHub] [logging-log4net] fluffynuts removed a comment on pull request #62: Move site back where it belongs

mail around team addition 4. gitbox seems to think I should be able to push:  however, I still can't push to github.com/apache/logging-log4net: ``` ERROR: Permission

[GitHub] [logging-log4net] fluffynuts commented on pull request #62: Move site back where it belongs

fluffynuts commented on pull request #62: URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-681705099 Thanks @rgoers I've managed to push & I've pushed new site content via svn too; getting a little stuck at point 7 of https://cwiki.apache.org/confluence/display/LOGGING/M

[GitHub] [logging-log4net] fluffynuts edited a comment on pull request #62: Move site back where it belongs

fluffynuts edited a comment on pull request #62: URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-681705099 Thanks @rgoers I've managed to push & I've pushed new site content via svn too; getting a little stuck at point 7 of https://cwiki.apache.org/confluence/display/LO

[GitHub] [logging-log4cxx] rm5248 merged pull request #38: Added .asf.yaml file to better configure the github git mirror

rm5248 merged pull request #38: URL: https://github.com/apache/logging-log4cxx/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] ramazanpolat commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

ramazanpolat commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-681930880 Thank you @vy I think you made a great addition to log4j2 with this work. This is an automated mess

[GitHub] [logging-log4j2] ramazanpolat edited a comment on pull request #335: Import of LogstashLayout as JsonTemplateLayout

ramazanpolat edited a comment on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-683172100 @vy One quick question: Will `JsonTemplateLayout` have the ability to jsonify the message object passed to Logger? e.g: Currently with using JsonLayout, t

[GitHub] [logging-log4j2] ramazanpolat commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

ramazanpolat commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-683172100 @vy One quick question: Will `JsonTemplateLayout` have the ability to jsonify the message object passed to Logger? e.g: Currently with using JsonLayout, this cod

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #37: Search for programs needed for tests

rm5248 commented on a change in pull request #37: URL: https://github.com/apache/logging-log4cxx/pull/37#discussion_r479646584 ## File path: CMakeLists.txt ## @@ -123,3 +123,10 @@ message(STATUS " logchar type : ${LOG4CXX_CHAR}") message(STATUS " Using

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #37: Search for programs needed for tests

ams-tschoening commented on a change in pull request #37: URL: https://github.com/apache/logging-log4cxx/pull/37#discussion_r478184458 ## File path: CMakeLists.txt ## @@ -123,3 +123,10 @@ message(STATUS " logchar type : ${LOG4CXX_CHAR}") message(STATUS "

[GitHub] [logging-log4cxx] rm5248 merged pull request #37: Search for programs needed for tests

rm5248 merged pull request #37: URL: https://github.com/apache/logging-log4cxx/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] jvz commented on pull request #401: run CI build for pull requests

jvz commented on pull request #401: URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-68181 I noticed one potential issue here which I'm not sure how to configure: PRs that are created from branches on origin (e.g., how Dependabot is configured) end up being built twi

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #413: Bump assertj-core from 3.14.0 to 3.17.1

dependabot[bot] opened a new pull request #413: URL: https://github.com/apache/logging-log4j2/pull/413 Bumps [assertj-core](https://github.com/joel-costigliola/assertj-core) from 3.14.0 to 3.17.1. Commits https://github.com/joel-costigliola/assertj-core/commit/0ca7f6edd5d76f0a

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #412: Bump assertj-core from 3.14.0 to 3.17.0

dependabot[bot] closed pull request #412: URL: https://github.com/apache/logging-log4j2/pull/412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #412: Bump assertj-core from 3.14.0 to 3.17.0

dependabot[bot] commented on pull request #412: URL: https://github.com/apache/logging-log4j2/pull/412#issuecomment-683539080 Superseded by #413. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [logging-log4j2] rschmitt commented on pull request #392: [LOG4J2-2902] Add missing LoaderUtil permissions check

rschmitt commented on pull request #392: URL: https://github.com/apache/logging-log4j2/pull/392#issuecomment-684006943 @rgoers Done. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [logging-log4j2] jvz commented on a change in pull request #392: [LOG4J2-2902] Add missing LoaderUtil permissions check

jvz commented on a change in pull request #392: URL: https://github.com/apache/logging-log4j2/pull/392#discussion_r480396776 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/util/LoaderUtilTest.java ## @@ -55,4 +62,52 @@ public void systemClassLoader() {

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-684510122 @ramazanpolat, yes, `JsonTemplateLayout` can do that. You just need to set `stringified` to `false` (the default) as follows: ```json { "$resolver": "message",

[GitHub] [logging-log4net] cremor commented on pull request #59: Update build system

cremor commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-684517717 @fluffynuts I've just updated a few of my projects to log4net 2.0.9. First of all, thanks for your work! But I have to report a few problems and oddities: **Breakin

[GitHub] [logging-log4net] cremor edited a comment on pull request #59: Update build system

cremor edited a comment on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-684517717 @fluffynuts I've just updated a few of my projects to log4net 2.0.9. First of all, thanks for your work! But I have to report a few problems and oddities: **

[GitHub] [logging-log4net] cremor edited a comment on pull request #59: Update build system

cremor edited a comment on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-684517717 @fluffynuts I've just updated a few of my projects to log4net 2.0.9. First of all, thanks for your work! But I have to report a few problems and oddities: **

[GitHub] [logging-log4j2] vy merged pull request #413: Bump assertj-core from 3.14.0 to 3.17.1

vy merged pull request #413: URL: https://github.com/apache/logging-log4j2/pull/413 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy commented on pull request #409: Bump disruptor from 1.2.15 to 1.2.17

vy commented on pull request #409: URL: https://github.com/apache/logging-log4j2/pull/409#issuecomment-684812863 This PR is causing the following warning: ``` java.lang.UnsupportedClassVersionError: com/conversantmedia/util/concurrent/SpinPolicy has been compiled by a more recent

[GitHub] [logging-log4j2] vy merged pull request #410: Bump jeromq from 0.4.3 to 0.5.2

vy merged pull request #410: URL: https://github.com/apache/logging-log4j2/pull/410 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4net] jvz commented on pull request #59: Update build system

jvz commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-684873931 Filed https://issues.apache.org/jira/browse/INFRA-20802 to re-open the Jira tracker. Thanks for the reminder! T

[GitHub] [logging-log4j2] ramazanpolat commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

ramazanpolat commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-684935378 @vy Sorry but `LogstashLayout` spits my object's as toString() output: ```json { "line" : 123, "class" : "tr.gov.sgk.logclient.DAO", "message" :

[GitHub] [logging-log4j2] rschmitt commented on a change in pull request #392: [LOG4J2-2902] Add missing LoaderUtil permissions check

rschmitt commented on a change in pull request #392: URL: https://github.com/apache/logging-log4j2/pull/392#discussion_r481336032 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/util/LoaderUtilTest.java ## @@ -55,4 +62,52 @@ public void systemClassLoader() {

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #415: Bump je from 5.0.73 to 18.3.12

dependabot[bot] opened a new pull request #415: URL: https://github.com/apache/logging-log4j2/pull/415 Bumps je from 5.0.73 to 18.3.12. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.sleepycat:je&package-m

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #414: Bump maven-core from 3.6.0 to 3.6.3

dependabot[bot] opened a new pull request #414: URL: https://github.com/apache/logging-log4j2/pull/414 Bumps [maven-core](https://github.com/apache/maven) from 3.6.0 to 3.6.3. Commits https://github.com/apache/maven/commit/cecedd343002696d0abb50b32b541b8a6ba2883f";>cecedd3 [ma

[GitHub] [logging-log4net] NicholasNoise opened a new pull request #63: Implimented proper support of netstandard2.0

NicholasNoise opened a new pull request #63: URL: https://github.com/apache/logging-log4net/pull/63 Changelog: - removed nuspec using build-in csproj packing. - miltiframework test runner: net462, netcoreapp1.0, netcoreapp2.1, netcoreapp3.1 (for future builds of netstandard2.1 or netc

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685327198 @rgoers @fluffynuts This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4net] fluffynuts commented on pull request #63: Implemented proper support of netstandard2.0

fluffynuts commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685442735 @NicholasNoise I really appreciate the PR & the time taken to produce multi-target tests! Good job. There are two changes I'd like to make -- either we can collabor

[GitHub] [logging-log4net] fluffynuts edited a comment on pull request #63: Implemented proper support of netstandard2.0

fluffynuts edited a comment on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685442735 @NicholasNoise I really appreciate the PR & the time taken to produce multi-target tests! Good job. There are two changes I'd like to make -- either we can c

[GitHub] [logging-log4j2] vy commented on pull request #335: Import of LogstashLayout as JsonTemplateLayout

vy commented on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-685462219 1. Unless there is a reason to do so, I would avoid custom classes to represent the logging structure. In your case a simple `logger.info(new MapMessage(Map.of("message", messag

[GitHub] [logging-log4j2] vy edited a comment on pull request #335: Import of LogstashLayout as JsonTemplateLayout

vy edited a comment on pull request #335: URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-685462219 @ramazanpolat, 1. Unless there is a reason to do so, I would avoid custom classes to represent the logging structure. In your case a simple `logger.info(new MapMessage

[GitHub] [logging-log4net] cremor commented on pull request #59: Update build system

cremor commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-685486982 @jvz Thanks. Does this mean I should create tickets for the points in my last comment? This is an automated

[GitHub] [logging-log4net] fluffynuts commented on pull request #59: Update build system

fluffynuts commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-685547877 @cremor could you see if the changes here fix this: https://github.com/apache/logging-log4net/pull/63 Perhaps: 1. clone the PR branch 2. build (if you have no

[GitHub] [logging-log4net] SymbioticKilla opened a new pull request #64: XmlConfigurator: do longer allow dtd processing across all platforms …

SymbioticKilla opened a new pull request #64: URL: https://github.com/apache/logging-log4net/pull/64 …(LOG4NET-575) This patch fixes a security vulnerabiliy reported by Karthik Balasundaram. The security vulnerability was found in the way how log4net parses xml configuration file

[GitHub] [logging-log4net] SymbioticKilla commented on pull request #64: XmlConfigurator: do longer allow dtd processing across all platforms …

SymbioticKilla commented on pull request #64: URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-685614850 I hope it is fine. If not than sorry => close/delete it. Thanks! This is an automated message from

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685695290 @fluffynuts Thank you for quick response! I made this PR from non-personal fork, but already requested branch setting change to an admin of organization (should be g

[GitHub] [logging-log4net] NicholasNoise edited a comment on pull request #63: Implemented proper support of netstandard2.0

NicholasNoise edited a comment on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685695290 @fluffynuts Thank you for quick response! I made this PR from non-personal fork, but already requested branch setting change to an admin of organization (shou

[GitHub] [logging-log4net] NicholasNoise edited a comment on pull request #63: Implemented proper support of netstandard2.0

NicholasNoise edited a comment on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685695290 @fluffynuts Thank you for quick response! I made this PR from non-personal fork, but already requested branch setting change to an admin of organization (shou

[GitHub] [logging-log4net] cremor commented on pull request #59: Update build system

cremor commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-685715057 @fluffynuts Thanks for the pointer to #63 and for the precompiled NuGet package from that PR! I just tested it and it indeed fixes all of the points I mentioned above.

<    1   2   3   4   5   6   7   8   9   10   >