rgoers commented on pull request #171:
URL: https://github.com/apache/logging-log4j2/pull/171#issuecomment-974774724
This now has conflicts and I just don't see the value of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rgoers merged pull request #599:
URL: https://github.com/apache/logging-log4j2/pull/599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers commented on pull request #87:
URL: https://github.com/apache/logging-log4j2/pull/87#issuecomment-974774341
Closing since no one responded to my last inquiry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dependabot[bot] closed pull request #418:
URL: https://github.com/apache/logging-log4j2/pull/418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
rgoers commented on pull request #434:
URL: https://github.com/apache/logging-log4j2/pull/434#issuecomment-974773891
@carterkozak Are you doing something with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dependabot[bot] commented on pull request #418:
URL: https://github.com/apache/logging-log4j2/pull/418#issuecomment-974862355
Looks like com.github.tomakehurst:wiremock is up-to-date now, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond
rgoers commented on pull request #460:
URL: https://github.com/apache/logging-log4j2/pull/460#issuecomment-974773547
Is anything happening with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers merged pull request #541:
URL: https://github.com/apache/logging-log4j2/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers commented on pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-974773142
The discussion on the mailing list died off without any clear resolution.
I'm not sure what to do with this.
--
This is an automated message from the Apache Git Service.
T
rgoers commented on pull request #513:
URL: https://github.com/apache/logging-log4j2/pull/513#issuecomment-974687401
I applied the commit via github desktop but somehow this PR wasn't updated.
It didn't even update the file diffs to show they are now the same.
--
This is an automated mes
rgoers commented on pull request #417:
URL: https://github.com/apache/logging-log4j2/pull/417#issuecomment-974775969
I'm not sure why this isn't closed. We are already at 1.2.19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rgoers closed pull request #550:
URL: https://github.com/apache/logging-log4j2/pull/550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers commented on pull request #418:
URL: https://github.com/apache/logging-log4j2/pull/418#issuecomment-974861104
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
rgoers closed pull request #417:
URL: https://github.com/apache/logging-log4j2/pull/417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers commented on pull request #208:
URL: https://github.com/apache/logging-log4j2/pull/208#issuecomment-974775371
Does anyone have an interest in doing something with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
rgoers commented on pull request #549:
URL: https://github.com/apache/logging-log4j2/pull/549#issuecomment-974873533
I started to apply this and got an error from revapi that compatibility had
been broken. The previous version passed in a default value and used that if
there was an error.
dependabot[bot] commented on pull request #417:
URL: https://github.com/apache/logging-log4j2/pull/417#issuecomment-974775974
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or min
rgoers closed pull request #171:
URL: https://github.com/apache/logging-log4j2/pull/171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers closed pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers closed pull request #87:
URL: https://github.com/apache/logging-log4j2/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
rgoers commented on pull request #550:
URL: https://github.com/apache/logging-log4j2/pull/550#issuecomment-974773288
Closing this since no one has expressed a desire to commit this. Personally,
I see no reason to add this.
--
This is an automated message from the Apache Git Service.
To r
rgoers commented on pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594#issuecomment-974730450
Because of the 2 bad files I had to manually create a patch and apply it,
but this patch has been applied.
--
This is an automated message from the Apache Git Service.
bwoester commented on pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594#issuecomment-974809226
Tanks a lot! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
rgoers commented on pull request #173:
URL: https://github.com/apache/logging-log4j2/pull/173#issuecomment-974775020
Leaving this open as we may want to look at it again after I get the master
build straightened out.
--
This is an automated message from the Apache Git Service.
To respond
rgoers commented on pull request #549:
URL: https://github.com/apache/logging-log4j2/pull/549#issuecomment-974920629
Part of the patch was applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
rgoers closed pull request #549:
URL: https://github.com/apache/logging-log4j2/pull/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
dependabot[bot] opened a new pull request #600:
URL: https://github.com/apache/logging-log4j2/pull/600
Bumps `byteBuddyVersion` from 1.11.0 to 1.12.1.
Updates `byte-buddy` from 1.11.0 to 1.12.1
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>byte-buddy'
wuqian0808 commented on pull request #598:
URL: https://github.com/apache/logging-log4j2/pull/598#issuecomment-975326309
> a little confused by the title of this PR. It mentions protecting Kafk
Actually if the log4j2 configuration starts failed and with monitorinterval
set. The sched
vy closed pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-975942442
IIRC, as indicated in the mailing list discussion, the necessary set of
changes is not as simple as this PR implies. I am taking the liberty to close
this ticket. Feel free to r
david-burke-securian opened a new pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601
For https://issues.apache.org/jira/browse/LOG4J2-3193
I can't get the project to build locally, even with a clean copy of
`master`. I will work on that and I also intend to add
rgoers commented on pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-975981340
You are on the master branch. That requires Java 11 (it may work with later
versions as well, I haven't tried). In addition, the build currently only works
from the command
ronosaurus commented on pull request #460:
URL: https://github.com/apache/logging-log4j2/pull/460#issuecomment-976105125
Didn't realize this PR is 11 months old. I'm going to close, review the
feedback, then eventually submit another PR from more current code.
--
This is an automated mes
ronosaurus closed pull request #460:
URL: https://github.com/apache/logging-log4j2/pull/460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifi
NicholasNoise opened a new pull request #77:
URL: https://github.com/apache/logging-log4net/pull/77
Same bug as #71.
npgsql@4.1.9 (above 4.* in general) completely destroys adonet appender.
3.* fails to prepare command but allows to execute it.
4+ fails to prepare and to execute
NicholasNoise commented on pull request #77:
URL: https://github.com/apache/logging-log4net/pull/77#issuecomment-976244274
@fluffynuts 2.0.14 pretty please? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
fluffynuts merged pull request #77:
URL: https://github.com/apache/logging-log4net/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
NicholasNoise commented on pull request #77:
URL: https://github.com/apache/logging-log4net/pull/77#issuecomment-976390837
Thank you!
Patiently waiting for upcoming release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
david-burke-securian commented on pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-976574629
Is master the correct branch to base this PR on?
When I build on a clean copy of master with `./mvnw clean install` on Java
11, I get:
```
[INF
vy commented on pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-977049681
@david-burke-securian, if you are fixing a problem in the Log4j 2, you
better target `release-2.x` branch. Building `release-2.x` is kind of a hassle
due to the JPMS integration
vy commented on a change in pull request #598:
URL: https://github.com/apache/logging-log4j2/pull/598#discussion_r755448296
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/config/LoggerContextChangeTest.java
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apac
chubbard opened a new pull request #602:
URL: https://github.com/apache/logging-log4j2/pull/602
Fix for LOG4J2-3190. Documentation referred to importPackage() method in
ScriptAppenderSelector section which is broken in Nashorn so the fix was to
remove the importPackage(java.lang) and repl
dependabot[bot] opened a new pull request #603:
URL: https://github.com/apache/logging-log4j2/pull/603
Bumps `spring-boot.version` from 2.5.7 to 2.6.0.
Updates `spring-boot-dependencies` from 2.5.7 to 2.6.0
Release notes
Sourced from https://github.com/spring-projects/spring-boo
rgoers commented on pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-977539045
Thanks. This is my fault. I applied a PR that was targeted to the
release-2.x branch to master and forgot to change the version when I did. I
would have caught the compile e
vy merged pull request #602:
URL: https://github.com/apache/logging-log4j2/pull/602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #602:
URL: https://github.com/apache/logging-log4j2/pull/602#issuecomment-977634049
Thanks so much @chubbard! Ported this to `master` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
garydgregory commented on pull request #598:
URL: https://github.com/apache/logging-log4j2/pull/598#issuecomment-977897088
@vy makes a very important point here that I would like to emphasize: if
your test passes without the changes to the main tree, then your test does not
prove that you'
david-burke-securian commented on pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-977991464
@rgoers @vy Thanks! I got my build working on both `master` and
`release-2.x` branches. I am fixing a problem in Log4j2 and ideally I'd like it
released in a 2
dependabot[bot] opened a new pull request #604:
URL: https://github.com/apache/logging-log4j2/pull/604
Bumps
[elasticsearch-rest-high-level-client](https://github.com/elastic/elasticsearch)
from 7.6.2 to 7.15.2.
Release notes
Sourced from https://github.com/elastic/elasticsearch/
david-burke-securian commented on pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-978839979
I think this is ready to go. A couple notes:
In the [JIRA issue](https://issues.apache.org/jira/browse/LOG4J2-3193) I
talked about updating the `TreeSet`
vy merged pull request #604:
URL: https://github.com/apache/logging-log4j2/pull/604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #560:
URL: https://github.com/apache/logging-log4j2/pull/560#issuecomment-979027145
I am eager to approve this change. Note that `.mvn/wrapper/*` files need to
be updated too. Any objections? @rgoers? @carterkozak? @jvz? @garydgregory?
--
This is an automated
dependabot[bot] commented on pull request #372:
URL: https://github.com/apache/logging-log4j2/pull/372#issuecomment-979044560
Superseded by #605.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] opened a new pull request #605:
URL: https://github.com/apache/logging-log4j2/pull/605
Bumps `mongodb3.version` from 3.12.4 to 3.12.10.
Updates `mongodb-driver` from 3.12.4 to 3.12.10
Release notes
Sourced from https://github.com/mongodb/mongo-java-driver/release
dependabot[bot] closed pull request #372:
URL: https://github.com/apache/logging-log4j2/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
craterone opened a new pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75
As "F" in pattern layout would be a full absolute path, but I would like to
log a "short" filename. I use "f" to indicate the short one.
For example:
using "F"
```
log4j.appe
ams-tschoening commented on a change in pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r756902852
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -102,6 +120,14 @@ const char* LocationInfo::getFileName() const
return fileName;
}
ams-tschoening commented on pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#issuecomment-979241416
Thanks for adding this and having that option seems fine to me. Though: I
don't like the current wording about file name vs. short file name vs. actually
being some f
ams-tschoening edited a comment on pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#issuecomment-979241416
Thanks for adding this and having that option seems fine to me. Though: I
don't like the current wording about file name vs. short file name vs. actually
being
rm5248 commented on a change in pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r756944581
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -102,6 +120,14 @@ const char* LocationInfo::getFileName() const
return fileName;
}
+/**
+
rm5248 commented on a change in pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r756953860
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -35,6 +41,21 @@ const LocationInfo& LocationInfo::getLocationUnavailable()
return unavailable
rm5248 commented on pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#issuecomment-979287785
> Thanks for adding this and having that option seems fine to me. Though: I
don't like the current wording about file name vs. short file name vs. actually
being some file pa
ams-tschoening commented on a change in pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r757029168
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -35,6 +41,21 @@ const LocationInfo& LocationInfo::getLocationUnavailable()
return una
ams-tschoening commented on pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#issuecomment-979347587
> If we want to rename things, doing it as part of a general cleanup would
be the best time to do it.
So create an issue instead for the renaming, linking to th
jvz commented on pull request #560:
URL: https://github.com/apache/logging-log4j2/pull/560#issuecomment-979385583
Please go ahead and update the maven wrapper files! I don’t think they’ve
been updated in a long time.
Matt Sicker
> On Nov 25, 2021, at 03:36, Volkan Yazıcı ***@*
rgoers commented on pull request #603:
URL: https://github.com/apache/logging-log4j2/pull/603#issuecomment-979471131
This cannot be done until Spring Cloud publishes a version compatible with
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
rgoers commented on pull request #560:
URL: https://github.com/apache/logging-log4j2/pull/560#issuecomment-979505442
To be honest I have no idea why we have a dependency on maven-core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
craterone commented on pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#issuecomment-979586559
> Thanks for adding this and having that option seems fine to me. Though: I
don't like the current wording about file name vs. short file name vs. actually
being some file
ams-tschoening commented on a change in pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r757029168
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -35,6 +41,21 @@ const LocationInfo& LocationInfo::getLocationUnavailable()
return una
bagdemir commented on a change in pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#discussion_r757705852
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertySource.java
##
@@ -81,16 +81,22 @@ default boolean containsProperty(Str
dependabot[bot] opened a new pull request #606:
URL: https://github.com/apache/logging-log4j2/pull/606
Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.1.2 to 4.5.0.
Release notes
Sourced from https://github.com/spotbugs/spotbugs/releases";>spotbugs's
releases.
carterkozak opened a new pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607
Lookups in messages are confusing, and muddy the line between logging APIs
and implementation. Given a particular API, there's an expectation that a
particular shape of call will result i
david-burke-securian commented on a change in pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#discussion_r758490618
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertySource.java
##
@@ -81,16 +81,22 @@ default boolean contains
vy commented on pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-981930041
@carterkozak, this PR only touches to the `PatternLayout`. Shouldn't we
rather consolidate all lookup related code into a single place and disable it
there? Otherwise, JSON Temp
carterkozak commented on pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-981954557
@vy I think this is the only place which uses lookups in this way, did I
miss something?
--
This is an automated message from the Apache Git Service.
To respond to th
vy commented on pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-981973603
@carterkozak, you're right. I've got confused by lookups used in
configurations. Simply searching for `${"` in the code base gave me false
positives. I have checked if `logger.i
rgoers opened a new pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608
Restricts access to LDAP via JNDI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
rgoers commented on pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-982307401
To test environment variables in JUnit you can do something like:
```
@Rule
public final EnvironmentVariables environmentVariables = new
EnvironmentVariables
carterkozak commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759126375
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/NetUtils.java
##
@@ -79,6 +84,45 @@ public static String getLocalHostn
carterkozak commented on pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-982491749
> I am unclear as to why a system property was needed if only Pattern Layout
is affected.
We had hundreds of services, each of which with default configurations a
vy commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759193685
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -17,31 +17,76 @@
package org.apache.logging.log4j.core
vy merged pull request #609:
URL: https://github.com/apache/logging-log4j2/pull/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #609:
URL: https://github.com/apache/logging-log4j2/pull/609#issuecomment-982576431
Thanks @alexandreiev! Keep these improvements coming! :100: Maybe a little
bit more next time? :stuck_out_tongue_winking_eye:
--
This is an automated message from the Apache G
alexandreiev commented on pull request #609:
URL: https://github.com/apache/logging-log4j2/pull/609#issuecomment-982603346
> Thanks @alexandreiev! Keep these improvements coming! 100 Maybe a little
bit more next time? stuck_out_tongue_winking_eye
Just started to work with it. I will
carterkozak commented on pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-982633247
I've updated this PR removing the property, allowing only explicit opt-in
via `%m{lookups}`
--
This is an automated message from the Apache Git Service.
To respond to
david-burke-securian commented on pull request #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-982637326
@rgoers Is that from
[system-rules](https://github.com/stefanbirkner/system-rules/)? That seems to
be for JUnit 4 and isn't a current dependency of the project
carterkozak commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759431336
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -17,31 +17,76 @@
package org.apache.logging.l
carterkozak commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759434336
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -17,31 +17,76 @@
package org.apache.logging.l
rgoers commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759845982
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/NetUtils.java
##
@@ -79,6 +84,45 @@ public static String getLocalHostname()
rgoers commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759847957
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -17,31 +17,76 @@
package org.apache.logging.log4j.
rgoers commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759848498
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/JndiLdapLookupTest.java
##
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apac
rgoers commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759848647
##
File path: log4j-core/src/test/resources/java-import.ldif
##
@@ -0,0 +1,4 @@
+dn: dc=apache,dc=org
Review comment:
Yeah - I will rename it
rgoers commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759849806
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/JndiLdapLookupTest.java
##
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apac
rgoers commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759849948
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -17,31 +17,76 @@
package org.apache.logging.log4j.
remkop commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r759869682
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -17,31 +17,76 @@
package org.apache.logging.log4j.
carterkozak commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r760083167
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -168,21 +206,89 @@ protected boolean releaseSub(
carterkozak commented on pull request #607:
URL: https://github.com/apache/logging-log4j2/pull/607#issuecomment-983738001
@rgoers Do you have any additional feedback for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
rgoers commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r760302127
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -168,21 +206,89 @@ protected boolean releaseSub(final
carterkozak commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r760363447
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -168,21 +206,89 @@ protected boolean releaseSub(
rgoers commented on a change in pull request #608:
URL: https://github.com/apache/logging-log4j2/pull/608#discussion_r760380895
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
##
@@ -168,21 +206,89 @@ protected boolean releaseSub(final
3301 - 3400 of 7264 matches
Mail list logo
