[GitHub] [logging-log4j2] bwoester opened a new pull request #594: Log4 j2 3168 overwritten rotated logs

2021-10-29 Thread GitBox
bwoester opened a new pull request #594: URL: https://github.com/apache/logging-log4j2/pull/594 This fixes an issue in the rolling file appender. The increment counter in the filePattern didn't work if the filenames contained regex characters. In our case it was the '+' character introduce

[GitHub] [logging-log4cxx] rm5248 commented on pull request #74: Register FallbackErrorHandler class

2021-10-29 Thread GitBox
rm5248 commented on pull request #74: URL: https://github.com/apache/logging-log4cxx/pull/74#issuecomment-95511 The `FallbackErrorHandler` does get registered someplace(at least on Linux), but it doesn't look like this will hurt at all. merged. -- This is an automated message from t

[GitHub] [logging-log4cxx] rm5248 merged pull request #74: Register FallbackErrorHandler class

2021-10-29 Thread GitBox
rm5248 merged pull request #74: URL: https://github.com/apache/logging-log4cxx/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [logging-log4net] fluffynuts commented on pull request #73: adds ActivatorProvider to allow custom type activation (Resolves LOG4NET-565)

2021-10-31 Thread GitBox
fluffynuts commented on pull request #73: URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-955657755 @tschettler I think next steps would be to raise a PR with a mvp implmentation of the described pattern in log4net. I don't know when I'll get time to look at an implemen

[GitHub] [logging-log4j2] garydgregory commented on pull request #593: LOG4J2-3182

2021-11-01 Thread GitBox
garydgregory commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-956138347 This PR lacks a test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4net] tschettler commented on pull request #73: adds ActivatorProvider to allow custom type activation (Resolves LOG4NET-565)

2021-11-01 Thread GitBox
tschettler commented on pull request #73: URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-957005054 Sounds good, I’d be up for that, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [logging-log4net] fluffynuts closed pull request #73: adds ActivatorProvider to allow custom type activation (Resolves LOG4NET-565)

2021-11-01 Thread GitBox
fluffynuts closed pull request #73: URL: https://github.com/apache/logging-log4net/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4net] fluffynuts closed pull request #65: Fix: RollingFileAppender does not work on Android and iOS

2021-11-01 Thread GitBox
fluffynuts closed pull request #65: URL: https://github.com/apache/logging-log4net/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4net] fluffynuts commented on pull request #65: Fix: RollingFileAppender does not work on Android and iOS

2021-11-01 Thread GitBox
fluffynuts commented on pull request #65: URL: https://github.com/apache/logging-log4net/pull/65#issuecomment-957132782 This PR is quite stale & conflicts with the target branch; please re-open if it's still an issue you'd like to solve (: Thanks for your contribution. -- This is an auto

[GitHub] [logging-log4net] fluffynuts closed pull request #48: Fixes LOG4NET-587 Mutex ~ UnauthorizedAccessException Access to the path is denied

2021-11-01 Thread GitBox
fluffynuts closed pull request #48: URL: https://github.com/apache/logging-log4net/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4net] fluffynuts commented on pull request #48: Fixes LOG4NET-587 Mutex ~ UnauthorizedAccessException Access to the path is denied

2021-11-01 Thread GitBox
fluffynuts commented on pull request #48: URL: https://github.com/apache/logging-log4net/pull/48#issuecomment-957133802 Hi @Evgentus0 and @markdemich This was updated as per the changes here in the last release (2.0.13). Hope this works out well as I don't really know how to reliably te

[GitHub] [logging-log4net] fluffynuts commented on pull request #48: Fixes LOG4NET-587 Mutex ~ UnauthorizedAccessException Access to the path is denied

2021-11-02 Thread GitBox
fluffynuts commented on pull request #48: URL: https://github.com/apache/logging-log4net/pull/48#issuecomment-957133802 Hi @Evgentus0 and @markdemich This was updated as per the changes here in the last release (2.0.13). Hope this works out well as I don't really know how to reliably te

[GitHub] [logging-log4net] fluffynuts closed pull request #48: Fixes LOG4NET-587 Mutex ~ UnauthorizedAccessException Access to the path is denied

2021-11-02 Thread GitBox
fluffynuts closed pull request #48: URL: https://github.com/apache/logging-log4net/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4net] fluffynuts closed pull request #73: adds ActivatorProvider to allow custom type activation (Resolves LOG4NET-565)

2021-11-02 Thread GitBox
fluffynuts closed pull request #73: URL: https://github.com/apache/logging-log4net/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4net] fluffynuts commented on pull request #65: Fix: RollingFileAppender does not work on Android and iOS

2021-11-02 Thread GitBox
fluffynuts commented on pull request #65: URL: https://github.com/apache/logging-log4net/pull/65#issuecomment-957132782 This PR is quite stale & conflicts with the target branch; please re-open if it's still an issue you'd like to solve (: Thanks for your contribution. -- This is an auto

[GitHub] [logging-log4net] tschettler commented on pull request #73: adds ActivatorProvider to allow custom type activation (Resolves LOG4NET-565)

2021-11-02 Thread GitBox
tschettler commented on pull request #73: URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-957005054 Sounds good, I’d be up for that, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [logging-log4net] fluffynuts closed pull request #65: Fix: RollingFileAppender does not work on Android and iOS

2021-11-02 Thread GitBox
fluffynuts closed pull request #65: URL: https://github.com/apache/logging-log4net/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4net] fluffynuts commented on pull request #48: Fixes LOG4NET-587 Mutex ~ UnauthorizedAccessException Access to the path is denied

2021-11-02 Thread GitBox
fluffynuts commented on pull request #48: URL: https://github.com/apache/logging-log4net/pull/48#issuecomment-957133802 Hi @Evgentus0 and @markdemich This was updated as per the changes here in the last release (2.0.13). Hope this works out well as I don't really know how to reliably te

[GitHub] [logging-log4net] fluffynuts closed pull request #48: Fixes LOG4NET-587 Mutex ~ UnauthorizedAccessException Access to the path is denied

2021-11-02 Thread GitBox
fluffynuts closed pull request #48: URL: https://github.com/apache/logging-log4net/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4net] fluffynuts closed pull request #73: adds ActivatorProvider to allow custom type activation (Resolves LOG4NET-565)

2021-11-02 Thread GitBox
fluffynuts closed pull request #73: URL: https://github.com/apache/logging-log4net/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4net] fluffynuts commented on pull request #65: Fix: RollingFileAppender does not work on Android and iOS

2021-11-02 Thread GitBox
fluffynuts commented on pull request #65: URL: https://github.com/apache/logging-log4net/pull/65#issuecomment-957132782 This PR is quite stale & conflicts with the target branch; please re-open if it's still an issue you'd like to solve (: Thanks for your contribution. -- This is an auto

[GitHub] [logging-log4net] tschettler commented on pull request #73: adds ActivatorProvider to allow custom type activation (Resolves LOG4NET-565)

2021-11-02 Thread GitBox
tschettler commented on pull request #73: URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-957005054 Sounds good, I’d be up for that, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [logging-log4net] fluffynuts closed pull request #65: Fix: RollingFileAppender does not work on Android and iOS

2021-11-02 Thread GitBox
fluffynuts closed pull request #65: URL: https://github.com/apache/logging-log4net/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #593: LOG4J2-3182

2021-11-03 Thread GitBox
wuqian0808 commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-958764989 > This PR lacks a test case. Test case added. Pls help to review and kindly help to advise -- This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #593: LOG4J2-3182

2021-11-03 Thread GitBox
wuqian0808 commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-958764989 > This PR lacks a test case. Test case added. Pls help to review and kindly help to advise -- This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #593: LOG4J2-3182

2021-11-03 Thread GitBox
wuqian0808 commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-958764989 > This PR lacks a test case. Test case added. Pls help to review and kindly help to advise -- This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #593: LOG4J2-3182

2021-11-03 Thread GitBox
wuqian0808 commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-958764989 > This PR lacks a test case. Test case added. Pls help to review and kindly help to advise -- This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j2] vy merged pull request #595: Fix broken link to LMAX Disruptor in the documentation

2021-11-05 Thread GitBox
vy merged pull request #595: URL: https://github.com/apache/logging-log4j2/pull/595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy merged pull request #595: Fix broken link to LMAX Disruptor in the documentation

2021-11-05 Thread GitBox
vy merged pull request #595: URL: https://github.com/apache/logging-log4j2/pull/595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy merged pull request #595: Fix broken link to LMAX Disruptor in the documentation

2021-11-05 Thread GitBox
vy merged pull request #595: URL: https://github.com/apache/logging-log4j2/pull/595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] garydgregory commented on pull request #596: Add volatile qualifier to DefaultErrorHandler fields

2021-11-07 Thread GitBox
garydgregory commented on pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596#issuecomment-962645063 I am not sure this solves the whole issue of multi-threading usage, in particular, I wonder if the methods that access both of these variables shouldn't just be synchr

[GitHub] [logging-log4j2] rgoers commented on pull request #596: Add volatile qualifier to DefaultErrorHandler fields

2021-11-07 Thread GitBox
rgoers commented on pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596#issuecomment-962758033 Actually, the problems with the ErrorHandler are much bigger than this. See https://issues.apache.org/jira/browse/LOG4J2-2927. This issue should also have a Jira as it is a

[GitHub] [logging-log4j2] mzbonnt commented on pull request #596: Add volatile qualifier to DefaultErrorHandler fields

2021-11-07 Thread GitBox
mzbonnt commented on pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596#issuecomment-962758278 > I am not sure this solves the whole issue of multi-threading usage, in particular, I wonder if the methods that access both of these variables shouldn't just be synchroni

[GitHub] [logging-log4j2] vy commented on a change in pull request #593: LOG4J2-3182

2021-11-08 Thread GitBox
vy commented on a change in pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#discussion_r744536353 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java ## @@ -623,7 +623,12 @@ public Configuration setConfiguration(fin

[GitHub] [logging-log4j2] vy commented on a change in pull request #593: LOG4J2-3182

2021-11-08 Thread GitBox
vy commented on a change in pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#discussion_r744533579 ## File path: log4j-core/src/test/resources/log4j2-3182-error.xml ## @@ -0,0 +1,33 @@ + Review comment: License header is missing. ## Fil

[GitHub] [logging-log4j2] vy commented on pull request #593: LOG4J2-3182 Protect KafkaManager against start failures upon config changes.

2021-11-08 Thread GitBox
vy commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-962966682 @wuqian0808, mind updating the `changes.xml` too, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [logging-log4j2] garydgregory commented on pull request #596: Add volatile qualifier to DefaultErrorHandler fields

2021-11-08 Thread GitBox
garydgregory commented on pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596#issuecomment-963099301 > > I am not sure this solves the whole issue of multi-threading usage, in particular, I wonder if the methods that access both of these variables shouldn'

[GitHub] [logging-log4j2] garydgregory commented on pull request #596: Add volatile qualifier to DefaultErrorHandler fields

2021-11-08 Thread GitBox
garydgregory commented on pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596#issuecomment-963104008 > Actually, the problems with the ErrorHandler are much bigger than this. See https://issues.apache.org/jira/browse/LOG4J2-2927. This issue should also have a Jira as

[GitHub] [logging-log4j2] vy commented on pull request #596: Add volatile qualifier to DefaultErrorHandler fields

2021-11-08 Thread GitBox
vy commented on pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596#issuecomment-963104872 > > > I am not sure this solves the whole issue of multi-threading usage, in particular, I wonder if the methods that access both of these variables shouldn't just be synchroniz

[GitHub] [logging-log4j2] garydgregory commented on pull request #597: LOG4J2-3060 LOG4J2-3185 Fix thread-safety issues in DefaultErrorHandler.

2021-11-08 Thread GitBox
garydgregory commented on pull request #597: URL: https://github.com/apache/logging-log4j2/pull/597#issuecomment-963162612 Hi @vy I am curious as to why not simply make methods synchronized. Also, isn't it the case that you do not need to make variables volatile if they are updated ins

[GitHub] [logging-log4j2] garydgregory commented on pull request #593: LOG4J2-3182 Protect KafkaManager against start failures upon config changes.

2021-11-08 Thread GitBox
garydgregory commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-963417641 Hi all, Did someone make sure the tests fail if the changes in main are not applied? I can't check ATM. -- This is an automated message from the Apache Git Se

[GitHub] [logging-log4j2] vy commented on pull request #597: LOG4J2-3060 LOG4J2-3185 Fix thread-safety issues in DefaultErrorHandler.

2021-11-08 Thread GitBox
vy commented on pull request #597: URL: https://github.com/apache/logging-log4j2/pull/597#issuecomment-963459997 @garydgregory, thanks so much for the review. `volatile` modifiers are not needed indeed, removed them. I have used the `synchronized` block around the smallest possible group t

[GitHub] [logging-log4j2] vy merged pull request #597: LOG4J2-3060 LOG4J2-3185 Fix thread-safety issues in DefaultErrorHandler.

2021-11-08 Thread GitBox
vy merged pull request #597: URL: https://github.com/apache/logging-log4j2/pull/597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy closed pull request #481: LOG4J2-3060 Fix integer overflow in DefaultErrorHandler

2021-11-08 Thread GitBox
vy closed pull request #481: URL: https://github.com/apache/logging-log4j2/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #481: LOG4J2-3060 Fix integer overflow in DefaultErrorHandler

2021-11-08 Thread GitBox
vy commented on pull request #481: URL: https://github.com/apache/logging-log4j2/pull/481#issuecomment-963461664 Superseded by #597. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [logging-log4j2] vy commented on pull request #596: Add volatile qualifier to DefaultErrorHandler fields

2021-11-08 Thread GitBox
vy commented on pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596#issuecomment-963461872 Superseded by #597. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [logging-log4j2] vy closed pull request #596: Add volatile qualifier to DefaultErrorHandler fields

2021-11-08 Thread GitBox
vy closed pull request #596: URL: https://github.com/apache/logging-log4j2/pull/596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] mzbonnt commented on pull request #597: LOG4J2-3060 LOG4J2-3185 Fix thread-safety issues in DefaultErrorHandler.

2021-11-08 Thread GitBox
mzbonnt commented on pull request #597: URL: https://github.com/apache/logging-log4j2/pull/597#issuecomment-963752378 > @garydgregory, thanks so much for the review. `volatile` modifiers are not needed indeed, removed them. I have used the `synchronized` block around the smallest possible

[GitHub] [logging-log4j2] garydgregory commented on pull request #597: LOG4J2-3060 LOG4J2-3185 Fix thread-safety issues in DefaultErrorHandler.

2021-11-08 Thread GitBox
garydgregory commented on pull request #597: URL: https://github.com/apache/logging-log4j2/pull/597#issuecomment-963765451 > > @garydgregory, thanks so much for the review. `volatile` modifiers are not needed indeed, removed them. I have used the `synchronized` block around the smallest po

[GitHub] [logging-log4j2] wuqian0808 commented on a change in pull request #593: LOG4J2-3182 Protect KafkaManager against start failures upon config changes.

2021-11-08 Thread GitBox
wuqian0808 commented on a change in pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#discussion_r745260747 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java ## @@ -623,7 +623,12 @@ public Configuration setConfigura

[GitHub] [logging-log4j2] wuqian0808 commented on a change in pull request #593: LOG4J2-3182 Protect KafkaManager against start failures upon config changes.

2021-11-08 Thread GitBox
wuqian0808 commented on a change in pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#discussion_r745262415 ## File path: log4j-core/src/test/resources/log4j2-3182.xml ## @@ -0,0 +1,33 @@ + + + +%d{-MM-dd HH:mm:ss.SSS} |-%-5level [%threa

[GitHub] [logging-log4j2] wuqian0808 opened a new pull request #598: Log4 j2 3182

2021-11-08 Thread GitBox
wuqian0808 opened a new pull request #598: URL: https://github.com/apache/logging-log4j2/pull/598 LOG4J2-3182 Protect KafkaManager against start failures upon config changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #598: Log4 j2 3182

2021-11-08 Thread GitBox
wuqian0808 commented on pull request #598: URL: https://github.com/apache/logging-log4j2/pull/598#issuecomment-963786307 @garydgregory Raise new clean PR instead. Add all modifications -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #593: LOG4J2-3182 Protect KafkaManager against start failures upon config changes.

2021-11-08 Thread GitBox
wuqian0808 commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-963786553 Open new clean pre instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [logging-log4j2] wuqian0808 closed pull request #593: LOG4J2-3182 Protect KafkaManager against start failures upon config changes.

2021-11-08 Thread GitBox
wuqian0808 closed pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [logging-log4j2] vy commented on pull request #593: LOG4J2-3182 Protect KafkaManager against start failures upon config changes.

2021-11-09 Thread GitBox
vy commented on pull request #593: URL: https://github.com/apache/logging-log4j2/pull/593#issuecomment-963903277 @wuqian0808, please don't abandon a PR like this. It becomes really difficult to keep track of what has happened and why. -- This is an automated message from the Apache Git S

[GitHub] [logging-log4j2] vy commented on pull request #598: LOG4J2-3182 Protect KafkaManager against start failures upon config changes

2021-11-09 Thread GitBox
vy commented on pull request #598: URL: https://github.com/apache/logging-log4j2/pull/598#issuecomment-963903966 This PR supersedes #593. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [logging-log4j2] vy commented on a change in pull request #598: LOG4J2-3182 Protect KafkaManager against start failures upon config changes

2021-11-09 Thread GitBox
vy commented on a change in pull request #598: URL: https://github.com/apache/logging-log4j2/pull/598#discussion_r745397195 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/config/LoggerContextChangeTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apac

[GitHub] [logging-log4j2] wuqian0808 commented on a change in pull request #598: LOG4J2-3182 Protect KafkaManager against start failures upon config changes

2021-11-09 Thread GitBox
wuqian0808 commented on a change in pull request #598: URL: https://github.com/apache/logging-log4j2/pull/598#discussion_r745444637 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/config/LoggerContextChangeTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #583: Bump openjdk from 8 to 17

2021-11-13 Thread GitBox
dependabot[bot] commented on pull request #583: URL: https://github.com/apache/logging-log4j2/pull/583#issuecomment-967804501 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or min

[GitHub] [logging-log4j2] rgoers closed pull request #583: Bump openjdk from 8 to 17

2021-11-13 Thread GitBox
rgoers closed pull request #583: URL: https://github.com/apache/logging-log4j2/pull/583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers commented on pull request #583: Bump openjdk from 8 to 17

2021-11-13 Thread GitBox
rgoers commented on pull request #583: URL: https://github.com/apache/logging-log4j2/pull/583#issuecomment-967804498 Not gonna happen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [logging-log4j2] rgoers commented on pull request #574: LOG4J2-2978: add support for Jakarta EE 9

2021-11-13 Thread GitBox
rgoers commented on pull request #574: URL: https://github.com/apache/logging-log4j2/pull/574#issuecomment-967824433 This PR fails to build. It is referencing hamcrest-all. I believe release-2.x was modified to use the hamcrest dependency instead. -- This is an automated message from the

[GitHub] [logging-log4j2] mseele commented on pull request #574: LOG4J2-2978: add support for Jakarta EE 9

2021-11-15 Thread GitBox
mseele commented on pull request #574: URL: https://github.com/apache/logging-log4j2/pull/574#issuecomment-968695864 > This PR fails to build. It is referencing hamcrest-all. I believe release-2.x was modified to use the hamcrest dependency instead. @rgoers I've fixed that problem. E

[GitHub] [logging-log4j2] vy commented on a change in pull request #598: LOG4J2-3182 Protect KafkaManager against start failures upon config changes

2021-11-15 Thread GitBox
vy commented on a change in pull request #598: URL: https://github.com/apache/logging-log4j2/pull/598#discussion_r749204611 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/config/LoggerContextChangeTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apac

[GitHub] [logging-log4j2] rgoers commented on pull request #555: Improve worst-case NameAbbreviator performance

2021-11-15 Thread GitBox
rgoers commented on pull request #555: URL: https://github.com/apache/logging-log4j2/pull/555#issuecomment-969093561 I am unclear where things stand with this. I assume if you had wanted it incorporated you would have pushed it. -- This is an automated message from the Apache Git Service

[GitHub] [logging-log4j2] carterkozak commented on pull request #555: Improve worst-case NameAbbreviator performance

2021-11-15 Thread GitBox
carterkozak commented on pull request #555: URL: https://github.com/apache/logging-log4j2/pull/555#issuecomment-969096581 @rgoers I'll merge this shortly, it doesn't make a tremendous difference either way, and I'm not worried if it doesn't make the 2.15 release. -- This is an automated

[GitHub] [logging-log4j2] carterkozak commented on pull request #555: Improve worst-case NameAbbreviator performance

2021-11-15 Thread GitBox
carterkozak commented on pull request #555: URL: https://github.com/apache/logging-log4j2/pull/555#issuecomment-969120027 Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [logging-log4j2] carterkozak closed pull request #555: Improve worst-case NameAbbreviator performance

2021-11-15 Thread GitBox
carterkozak closed pull request #555: URL: https://github.com/apache/logging-log4j2/pull/555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] rgoers merged pull request #574: LOG4J2-2978: add support for Jakarta EE 9

2021-11-15 Thread GitBox
rgoers merged pull request #574: URL: https://github.com/apache/logging-log4j2/pull/574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] wuqian0808 commented on a change in pull request #598: LOG4J2-3182 Protect KafkaManager against start failures upon config changes

2021-11-17 Thread GitBox
wuqian0808 commented on a change in pull request #598: URL: https://github.com/apache/logging-log4j2/pull/598#discussion_r751814558 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/config/LoggerContextChangeTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #449: Bump xmlunit-core from 2.6.2 to 2.8.2

2021-11-18 Thread GitBox
dependabot[bot] commented on pull request #449: URL: https://github.com/apache/logging-log4j2/pull/449#issuecomment-973717805 Superseded by #599. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #599: Bump xmlunit-core from 2.6.2 to 2.8.3

2021-11-18 Thread GitBox
dependabot[bot] opened a new pull request #599: URL: https://github.com/apache/logging-log4j2/pull/599 Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.6.2 to 2.8.3. Release notes Sourced from https://github.com/xmlunit/xmlunit/releases";>xmlunit-core's releases.

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #449: Bump xmlunit-core from 2.6.2 to 2.8.2

2021-11-18 Thread GitBox
dependabot[bot] closed pull request #449: URL: https://github.com/apache/logging-log4j2/pull/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] rgoers commented on pull request #513: LOG4J2-3110 - Logger Improvements

2021-11-20 Thread GitBox
rgoers commented on pull request #513: URL: https://github.com/apache/logging-log4j2/pull/513#issuecomment-974687401 I applied the commit via github desktop but somehow this PR wasn't updated. It didn't even update the file diffs to show they are now the same. -- This is an automated mes

[GitHub] [logging-log4j2] rgoers merged pull request #513: LOG4J2-3110 - Logger Improvements

2021-11-20 Thread GitBox
rgoers merged pull request #513: URL: https://github.com/apache/logging-log4j2/pull/513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers commented on pull request #594: Log4 j2 3168 overwritten rotated logs

2021-11-20 Thread GitBox
rgoers commented on pull request #594: URL: https://github.com/apache/logging-log4j2/pull/594#issuecomment-974730450 Because of the 2 bad files I had to manually create a patch and apply it, but this patch has been applied. -- This is an automated message from the Apache Git Service.

[GitHub] [logging-log4j2] rgoers closed pull request #594: Log4 j2 3168 overwritten rotated logs

2021-11-20 Thread GitBox
rgoers closed pull request #594: URL: https://github.com/apache/logging-log4j2/pull/594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers merged pull request #541: LOG4J2-3114 - ensure the RollingFileAppender flushes immediately when bufferedIO=false (the same behavior as in FileAppender)

2021-11-20 Thread GitBox
rgoers merged pull request #541: URL: https://github.com/apache/logging-log4j2/pull/541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers merged pull request #599: Bump xmlunit-core from 2.6.2 to 2.8.3

2021-11-21 Thread GitBox
rgoers merged pull request #599: URL: https://github.com/apache/logging-log4j2/pull/599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers commented on pull request #477: MapMessage put methods should not mandate String values

2021-11-21 Thread GitBox
rgoers commented on pull request #477: URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-974773142 The discussion on the mailing list died off without any clear resolution. I'm not sure what to do with this. -- This is an automated message from the Apache Git Service. T

[GitHub] [logging-log4j2] rgoers commented on pull request #550: add gflog for comparison

2021-11-21 Thread GitBox
rgoers commented on pull request #550: URL: https://github.com/apache/logging-log4j2/pull/550#issuecomment-974773288 Closing this since no one has expressed a desire to commit this. Personally, I see no reason to add this. -- This is an automated message from the Apache Git Service. To r

[GitHub] [logging-log4j2] rgoers closed pull request #550: add gflog for comparison

2021-11-21 Thread GitBox
rgoers closed pull request #550: URL: https://github.com/apache/logging-log4j2/pull/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers commented on pull request #460: LOG4J2-2986: introduce filters.startFrames config element to specifc starting frame(s) during Throwable rendering

2021-11-21 Thread GitBox
rgoers commented on pull request #460: URL: https://github.com/apache/logging-log4j2/pull/460#issuecomment-974773547 Is anything happening with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers commented on pull request #434: LOG4J2-2954 Retain strong reference to shutdown callbacks

2021-11-21 Thread GitBox
rgoers commented on pull request #434: URL: https://github.com/apache/logging-log4j2/pull/434#issuecomment-974773891 @carterkozak Are you doing something with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [logging-log4j2] rgoers commented on pull request #87: [LOG4J2-928] Mostly wait-free MemoryMappedFileManager

2021-11-21 Thread GitBox
rgoers commented on pull request #87: URL: https://github.com/apache/logging-log4j2/pull/87#issuecomment-974774341 Closing since no one responded to my last inquiry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [logging-log4j2] rgoers closed pull request #87: [LOG4J2-928] Mostly wait-free MemoryMappedFileManager

2021-11-21 Thread GitBox
rgoers closed pull request #87: URL: https://github.com/apache/logging-log4j2/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notification

[GitHub] [logging-log4j2] rgoers commented on pull request #171: Add two new LuceneAppender which writes logging events to a lucene index library.

2021-11-21 Thread GitBox
rgoers commented on pull request #171: URL: https://github.com/apache/logging-log4j2/pull/171#issuecomment-974774724 This now has conflicts and I just don't see the value of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] rgoers closed pull request #171: Add two new LuceneAppender which writes logging events to a lucene index library.

2021-11-21 Thread GitBox
rgoers closed pull request #171: URL: https://github.com/apache/logging-log4j2/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] rgoers commented on pull request #173: [LOG4J2-2332] Unresolved variables in any file appender

2021-11-21 Thread GitBox
rgoers commented on pull request #173: URL: https://github.com/apache/logging-log4j2/pull/173#issuecomment-974775020 Leaving this open as we may want to look at it again after I get the master build straightened out. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] rgoers commented on pull request #208: [LOG4J2-2399] support for async formatting on reusable messages

2021-11-21 Thread GitBox
rgoers commented on pull request #208: URL: https://github.com/apache/logging-log4j2/pull/208#issuecomment-974775371 Does anyone have an interest in doing something with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #417: Bump disruptor from 1.2.15 to 1.2.19

2021-11-21 Thread GitBox
dependabot[bot] commented on pull request #417: URL: https://github.com/apache/logging-log4j2/pull/417#issuecomment-974775974 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or min

[GitHub] [logging-log4j2] rgoers commented on pull request #417: Bump disruptor from 1.2.15 to 1.2.19

2021-11-21 Thread GitBox
rgoers commented on pull request #417: URL: https://github.com/apache/logging-log4j2/pull/417#issuecomment-974775969 I'm not sure why this isn't closed. We are already at 1.2.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] rgoers closed pull request #417: Bump disruptor from 1.2.15 to 1.2.19

2021-11-21 Thread GitBox
rgoers closed pull request #417: URL: https://github.com/apache/logging-log4j2/pull/417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] bwoester commented on pull request #594: Log4 j2 3168 overwritten rotated logs

2021-11-21 Thread GitBox
bwoester commented on pull request #594: URL: https://github.com/apache/logging-log4j2/pull/594#issuecomment-974809226 Tanks a lot! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [logging-log4j2] rgoers commented on pull request #418: Bump wiremock from 2.19.0 to 2.27.2

2021-11-21 Thread GitBox
rgoers commented on pull request #418: URL: https://github.com/apache/logging-log4j2/pull/418#issuecomment-974861104 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #418: Bump wiremock from 2.19.0 to 2.27.2

2021-11-21 Thread GitBox
dependabot[bot] commented on pull request #418: URL: https://github.com/apache/logging-log4j2/pull/418#issuecomment-974862355 Looks like com.github.tomakehurst:wiremock is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #418: Bump wiremock from 2.19.0 to 2.27.2

2021-11-21 Thread GitBox
dependabot[bot] closed pull request #418: URL: https://github.com/apache/logging-log4j2/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] rgoers commented on pull request #549: LOG4J2-2955: More precise file size expression parsing; fail-fast behavior for invalid expressions

2021-11-21 Thread GitBox
rgoers commented on pull request #549: URL: https://github.com/apache/logging-log4j2/pull/549#issuecomment-974873533 I started to apply this and got an error from revapi that compatibility had been broken. The previous version passed in a default value and used that if there was an error.

[GitHub] [logging-log4j2] rgoers merged pull request #513: LOG4J2-3110 - Logger Improvements

2021-11-21 Thread GitBox
rgoers merged pull request #513: URL: https://github.com/apache/logging-log4j2/pull/513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

<    28   29   30   31   32   33   34   35   36   37   >