rm5248 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947155410
Is the objective to have a unit test, or a benchmarking test? Those are two
somewhat differing goals in my mind - a unit test makes sure that things are
working, while a ben
edwgiz commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732293762
##
File path:
log4j-maven-plugins/log4j-maven-plugins-shade-transformer/src/site/markdown/index.md
##
@@ -0,0 +1,81 @@
+
Review comment:
Cou
edwgiz commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732296538
##
File path:
log4j-maven-plugins/log4j-maven-plugins-shade-transformer/src/site/site.xml
##
@@ -0,0 +1,52 @@
+
+http://maven.apache.org/DECORATION/
swebb2066 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947167006
It is a benchmarking thing. Your benchmarking tools look good. When are you
thinking you will merge?
Have you run the benchmarks without the std::mutex lock in
Hier
rm5248 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947277364
> It is a benchmarking thing. Your benchmarking tools look good. When are
you thinking you will merge?
I don't have any timeframe for that at the moment. It is mostly
vy commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732543905
##
File path:
log4j-maven-plugins/log4j-maven-plugins-shade-transformer/src/site/markdown/index.md
##
@@ -0,0 +1,81 @@
+
Review comment:
Nevermi
sman-81 commented on pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-948332250
As interest and progress are nil, I'll close the pull request end of this
week.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
vy opened a new pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591
Certain `SocketAppender` tests are rewritten and the redundant/disabled ones
are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
rocketraman commented on pull request #20:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/20#issuecomment-949981751
Did you notice a problem that this was intended to solve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sschuberth commented on pull request #20:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/20#issuecomment-950110677
> Did you notice a problem that this was intended to solve?
No, it just felt more natural to me to use the cached loggers by default as
a potential performanc
lilbigmouth commented on pull request #437:
URL: https://github.com/apache/logging-log4j2/pull/437#issuecomment-950164980
Is there any update on this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
vy commented on pull request #437:
URL: https://github.com/apache/logging-log4j2/pull/437#issuecomment-950194437
@rgoers, last you indicated to merge this after 2.14.1 release. Would you
mind doing it, please?
--
This is an automated message from the Apache Git Service.
To respond to the
rgoers merged pull request #437:
URL: https://github.com/apache/logging-log4j2/pull/437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers commented on pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591#issuecomment-950213698
This looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
garydgregory commented on a change in pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591#discussion_r735020059
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
##
@@ -238,7 +238,10 @@ protected void write(fin
garydgregory commented on pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591#issuecomment-950214555
Are we losing any code coverage due to the removal of tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vy commented on pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591#issuecomment-950371887
> Are we losing any code coverage due to the removal of tests?
Not as far as I can see. The following tests were removed:
`SocketMessageLossTest`, `SocketReconnectTest`, a
vy commented on a change in pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591#discussion_r735154155
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
##
@@ -238,7 +238,10 @@ protected void write(final byte[]
vy commented on pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591#issuecomment-950372459
@rgoers, @garydgregory, thanks so much for the review. I am merging this
into `release-2.x`. Consequently I will cherry-pick this onto `master`.
--
This is an automated messag
vy merged pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
fluffynuts merged pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on a change in pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65#discussion_r735437906
##
File path: src/log4net/Appender/RollingFileAppender.cs
##
@@ -1158,10 +1158,8 @@ override public void ActivateOptions()
fluffynuts closed pull request #40:
URL: https://github.com/apache/logging-log4net/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #51:
URL: https://github.com/apache/logging-log4net/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #40:
URL: https://github.com/apache/logging-log4net/pull/40#issuecomment-950742108
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #51:
URL: https://github.com/apache/logging-log4net/pull/51#issuecomment-950742012
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #53:
URL: https://github.com/apache/logging-log4net/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #53:
URL: https://github.com/apache/logging-log4net/pull/53#issuecomment-950742177
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #49:
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-950742297
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #45:
URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-950742464
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #45:
URL: https://github.com/apache/logging-log4net/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #50:
URL: https://github.com/apache/logging-log4net/pull/50#issuecomment-950742379
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #43:
URL: https://github.com/apache/logging-log4net/pull/43#issuecomment-950742711
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #47:
URL: https://github.com/apache/logging-log4net/pull/47#issuecomment-950742542
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #29:
URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-950742627
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #47:
URL: https://github.com/apache/logging-log4net/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #42:
URL: https://github.com/apache/logging-log4net/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #42:
URL: https://github.com/apache/logging-log4net/pull/42#issuecomment-950742797
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #13:
URL: https://github.com/apache/logging-log4net/pull/13#issuecomment-950742873
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #24:
URL: https://github.com/apache/logging-log4net/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #25:
URL: https://github.com/apache/logging-log4net/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #19:
URL: https://github.com/apache/logging-log4net/pull/19#issuecomment-950742926
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #50:
URL: https://github.com/apache/logging-log4net/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #24:
URL: https://github.com/apache/logging-log4net/pull/24#issuecomment-950743014
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #49:
URL: https://github.com/apache/logging-log4net/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #29:
URL: https://github.com/apache/logging-log4net/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #43:
URL: https://github.com/apache/logging-log4net/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #22:
URL: https://github.com/apache/logging-log4net/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #23:
URL: https://github.com/apache/logging-log4net/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #13:
URL: https://github.com/apache/logging-log4net/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #19:
URL: https://github.com/apache/logging-log4net/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #25:
URL: https://github.com/apache/logging-log4net/pull/25#issuecomment-950742966
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #22:
URL: https://github.com/apache/logging-log4net/pull/22#issuecomment-950743166
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #16:
URL: https://github.com/apache/logging-log4net/pull/16#issuecomment-950743326
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #7:
URL: https://github.com/apache/logging-log4net/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts closed pull request #17:
URL: https://github.com/apache/logging-log4net/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #16:
URL: https://github.com/apache/logging-log4net/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #7:
URL: https://github.com/apache/logging-log4net/pull/7#issuecomment-950743218
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts commented on pull request #23:
URL: https://github.com/apache/logging-log4net/pull/23#issuecomment-950743064
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts commented on pull request #17:
URL: https://github.com/apache/logging-log4net/pull/17#issuecomment-950743276
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #10:
URL: https://github.com/apache/logging-log4net/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts closed pull request #2:
URL: https://github.com/apache/logging-log4net/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts commented on pull request #10:
URL: https://github.com/apache/logging-log4net/pull/10#issuecomment-950743436
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncom
fluffynuts closed pull request #9:
URL: https://github.com/apache/logging-log4net/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts commented on pull request #9:
URL: https://github.com/apache/logging-log4net/pull/9#issuecomment-950743515
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts commented on pull request #2:
URL: https://github.com/apache/logging-log4net/pull/2#issuecomment-950743370
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts commented on pull request #3:
URL: https://github.com/apache/logging-log4net/pull/3#issuecomment-950743664
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts commented on pull request #8:
URL: https://github.com/apache/logging-log4net/pull/8#issuecomment-950743578
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts closed pull request #3:
URL: https://github.com/apache/logging-log4net/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts closed pull request #8:
URL: https://github.com/apache/logging-log4net/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts closed pull request #5:
URL: https://github.com/apache/logging-log4net/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts commented on pull request #1:
URL: https://github.com/apache/logging-log4net/pull/1#issuecomment-950743834
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts commented on pull request #5:
URL: https://github.com/apache/logging-log4net/pull/5#issuecomment-950743722
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts commented on pull request #4:
URL: https://github.com/apache/logging-log4net/pull/4#issuecomment-950743794
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts closed pull request #1:
URL: https://github.com/apache/logging-log4net/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts closed pull request #4:
URL: https://github.com/apache/logging-log4net/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts commented on pull request #6:
URL: https://github.com/apache/logging-log4net/pull/6#issuecomment-950743984
Good day
It's been quite a while since this PR last saw activity. In an attempt to
get pull requests under some semblance of
order, I'm having to make the uncomfo
fluffynuts closed pull request #6:
URL: https://github.com/apache/logging-log4net/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
fluffynuts commented on pull request #18:
URL: https://github.com/apache/logging-log4net/pull/18#issuecomment-950928132
Please also note that this PR is against the develop branch which is in a
state which I can't vouch for, so I've cherry-picked be299bc into master
--
This is an automat
fluffynuts merged pull request #76:
URL: https://github.com/apache/logging-log4net/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #48:
URL: https://github.com/apache/logging-log4net/pull/48#issuecomment-950930077
Hi @Evgentus0 and @markdemich
I'm looking into this now, please give me some time. I'm trying to clean up
the log4net PR queue.
--
This is an automated message
fluffynuts commented on pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-950939434
Hi @tschettler
As discussed in #72, I still can't see the absolute necessity for providing
externally-controlled DI (more like service-locator, to be honest) to lo
fluffynuts commented on a change in pull request #54:
URL: https://github.com/apache/logging-log4net/pull/54#discussion_r735613416
##
File path: README.md
##
@@ -1,4 +1,3 @@
-Introduction
Review comment:
If I'm reading this correctly, the heading is removed? Why?
#
fluffynuts closed pull request #54:
URL: https://github.com/apache/logging-log4net/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
fluffynuts commented on pull request #54:
URL: https://github.com/apache/logging-log4net/pull/54#issuecomment-950946163
If you can motivate for the update, please open a new PR against the newer
log4net csproj file, which should require minimal changes.
--
This is an automated message fr
fluffynuts closed pull request #74:
URL: https://github.com/apache/logging-log4net/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
tschettler commented on pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-951019204
Thank you for the feedback @fluffynuts!
I understand your security concerns and completely agree with you. My
initial commit was just to provide a standard way to c
RyanShin0112 opened a new pull request #74:
URL: https://github.com/apache/logging-log4cxx/pull/74
There are two error handlers in log4cxx(OnlyOnceErrorHandler and
FallbackErrorHandler) but only ‘OnlyOnceErrorHandler’ gets registered.
The reason is that ‘FallbackErrorHandler’ is not refe
fluffynuts commented on pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-952597091
@tschettler before moving forward with any changes to log4net, I'd ask that
you try to achieve these goals in user-land (ie, not in log4net, but in the
consuming project)
zabetak opened a new pull request #592:
URL: https://github.com/apache/logging-log4j2/pull/592
Small clarification about feature coverage in the available formats based on
the answer on stackoverflow:
https://stackoverflow.com/questions/69659109/log4j2-configuration-format-with-best-cov
rgoers merged pull request #592:
URL: https://github.com/apache/logging-log4j2/pull/592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rgoers commented on pull request #592:
URL: https://github.com/apache/logging-log4j2/pull/592#issuecomment-953280404
This is merged into master. I will have to manually copy it into release-2.x
since it uses a different documentation format.
--
This is an automated message from the Apach
tschettler commented on pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-953506178
You are correct, due to the way types are instantiated in log4net, using a
service locator is the way I would do this now. However, when I mention "DI",
I'm not referring
tschettler edited a comment on pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-953506178
@fluffynuts you are correct, due to the way types are instantiated in
log4net, using a service locator is the way I would do this now. However, when
I mention "DI"
tschettler edited a comment on pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-953506178
@fluffynuts you are correct, due to the way types are instantiated in
log4net, using a service locator is the way I would do this now. However, when
I mention "DI"
fluffynuts commented on pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-953642068
@tschettler thanks for the response and the thorough code example. The
example does, however, back up exactly what my thoughts are on the whole story:
the ultimate result
edwgiz commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r738634733
##
File path:
log4j-maven-plugins/log4j-maven-plugins-shade-transformer/src/site/markdown/index.md
##
@@ -0,0 +1,81 @@
+
+
+
+# Log4j Maven Shaded P
edwgiz commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r738634935
##
File path: log4j-maven-plugins/log4j-maven-plugins-shade-transformer/pom.xml
##
@@ -0,0 +1,233 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:
wuqian0808 opened a new pull request #593:
URL: https://github.com/apache/logging-log4j2/pull/593
With MonitorInterval, if new config start failed, the previous watchmanager
and scheduler will never shut down.
Besides, the async threads will increase.
This is for fixing this i
tschettler commented on pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73#issuecomment-954420832
@fluffynuts thanks again for the response and great idea!
I think we are in agreement. I like the idea of log4net having its own
container, and allowing services to
3101 - 3200 of 7264 matches
Mail list logo
