garydgregory commented on pull request #208:
URL: https://github.com/apache/logging-log4j2/pull/208#issuecomment-665636379
On Wed, Jul 29, 2020 at 5:02 AM Remko Popma
wrote:
> I did not have time to do an in-depth review today, would need to take
> another detailed look.
>
Lemongrass3110 commented on pull request #173:
URL: https://github.com/apache/logging-log4j2/pull/173#issuecomment-665525997
@rgoers I tried to resolve the conflicts as good as possible.
Do you want me to move the new classes from
`org.apache.logging.log4j.core.config.plugins.validation.
remkop commented on pull request #208:
URL: https://github.com/apache/logging-log4j2/pull/208#issuecomment-665536829
I did not have time to do an in-depth review today, would need to take
another detailed look.
It has been a while since I looked, perhaps @bjlaub can clarify whether
liyuj commented on pull request #171:
URL: https://github.com/apache/logging-log4j2/pull/171#issuecomment-665560243
> Do we want to apply this? I'm not really sure why one would want to log
directly to Lucene instead of to Solr or ElasticSearch.
I think it's a simplified solution tha
jvz merged pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] commented on pull request #370:
URL: https://github.com/apache/logging-log4j2/pull/370#issuecomment-666089626
Superseded by #393.
This is an automated message from the Apache Git Service.
To respond to the mes
fluffynuts commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-666058294
@jvz thanks, two questions though:
1. The query about the CVE fix in this thread: that commit is on `develop`
-- I'm not sure of the workflow that is accepted on th
dependabot[bot] opened a new pull request #393:
URL: https://github.com/apache/logging-log4j2/pull/393
Bumps [jetty-util](https://github.com/eclipse/jetty.project) from
8.2.0.v20160908 to 9.4.31.v20200723.
Commits
https://github.com/eclipse/jetty.project/commit/450ba27947e13e6
dependabot[bot] closed pull request #370:
URL: https://github.com/apache/logging-log4j2/pull/370
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] merged pull request #1:
URL: https://github.com/apache/logging-parent/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] opened a new pull request #1:
URL: https://github.com/apache/logging-parent/pull/1
Bumps [apache](https://github.com/apache/maven-apache-parent) from 19 to 23.
Commits
See full diff in https://github.com/apache/maven-apache-parent/commits";>compare
view
jvz commented on pull request #1:
URL: https://github.com/apache/logging-parent/pull/1#issuecomment-665859627
@dependabot merge
This is an automated message from the Apache Git Service.
To respond to the message, please log o
carterkozak commented on pull request #329:
URL: https://github.com/apache/logging-log4j2/pull/329#issuecomment-666316087
Looking at this again, I think I should extract the predicate for classes
which can't be loaded to a separate change. It should be generally helpful
because the cost of
rgoers commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-666550770
@fluffynuts In answer to 1) as you know the main problem with the log4net
project is that all the active developers on it have left the project. So the
accepted workflow is u
fluffynuts commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-666570166
@rgoers I'm happy to follow up on the CVE and the recent email on the
mailing list
As for (2), I thought that's what this branch was, so am I correct in saying
tha
fluffynuts edited a comment on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-666570166
@rgoers I'm happy to follow up on the CVE and the recent email on the
mailing list
As for (2), I thought that's what this PR was, so am I correct in saying
rgoers commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-57635
Is there a tag included in the PR with the version number? Can those even be
added in a PR. If not it is a simple matter to tag the version associated with
this I guess.
cremor commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-666928536
> I'm wondering what's to be done about `develop`, ie are there other
commits on that branch which should be of interest
Most of the latest commits on develop are from
cremor commented on pull request #51:
URL: https://github.com/apache/logging-log4net/pull/51#issuecomment-666977916
Seems like #59 added .NET Standard 2.0 targets.
This is an automated message from the Apache Git Service.
To
shawjef3 closed pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
shawjef3 commented on pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-667584092
@rgoers thanks for the pointer to `Logger#atLevel`. It looks like that will
work for most of it, if not all. I'll have to copy implementations of parts of
AbstractLogger,
fluffynuts commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-667713711
Ok, I'm obviously doing something wrong. I sent a mail to
d...@logging.apache.org to try to start a vote on the 2.0.9 release and there
has been zero response. The Releas
jvz commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-667715247
Nothing done wrong. We're just all volunteers ourselves, so it sometimes
takes time for review. I've gone over the initial vote thread and provided some
feedback.
dependabot[bot] closed pull request #375:
URL: https://github.com/apache/logging-log4j2/pull/375
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] commented on pull request #375:
URL: https://github.com/apache/logging-log4j2/pull/375#issuecomment-667718388
Looks like junit:junit is up-to-date now, so this is no longer needed.
This is an automated message
sebthom commented on pull request #360:
URL: https://github.com/apache/logging-log4j2/pull/360#issuecomment-667949496
@rgoers I added a test case that validates the config xml files found under
/src/test/resources against the XSD.
--
rm5248 opened a new pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ams-tschoening commented on pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31#issuecomment-668432691
Is there anything special to do to make Doxygen use the MD-file or do things
happen automatically when generating the site using Maven?
-
rm5248 commented on pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31#issuecomment-668551500
This is setup only for Maven at the moment. Doxygen just needs to have
markdown enabled to generate HTML pages from Markdown, and scan the correct
directory for source files
ams-tschoening commented on pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31#issuecomment-668603673
Thinks worked OOB for me as well. I didn't like the top level menu entry,
though, your text seems to be plain FAQ to me. So I replaced the available FAQ
with a markdo
rm5248 commented on pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31#issuecomment-668684465
The FAQ is probably the correct place to put it, but looking at it now it's
really a sub-heading under 'Does log4cxx support unicode?', which also talks
about the `setlocale`
ams-tschoening commented on pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31#issuecomment-668697524
Changed. Is this closing
[LOGCXX-483](https://issues.apache.org/jira/browse/LOGCXX-483) as well? Then I
would mention this in `changes.xml` as well.
I have the
rm5248 commented on pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31#issuecomment-668870727
This is related to LOG4CXX-483. I don't think there's really a bug with
LOG4CXX-483, but this should help clarify.
According to the [libc
documentation](https://www.g
rm5248 edited a comment on pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31#issuecomment-668870727
This is related to LOG4CXX-483. I don't think there's really a bug with
LOG4CXX-483, but this should help clarify.
According to the [libc
documentation](https:
ams-tschoening commented on pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31#issuecomment-669013481
> According to the libc documentation, all programs start in the "C" locale
by default. The "C" locale is the same as ANSI_X3.4-1968. So before you do
setlocale, the
jakluk opened a new pull request #394:
URL: https://github.com/apache/logging-log4j2/pull/394
A pull request for issue
[https://issues.apache.org/jira/browse/LOG4J2-2892](https://issues.apache.org/jira/browse/LOG4J2-2892).
This PR adds ability to delimit Graylog Extended Log Format (
rgoers commented on a change in pull request #394:
URL: https://github.com/apache/logging-log4j2/pull/394#discussion_r466145003
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/layout/GelfLayoutTest.java
##
@@ -222,37 +224,42 @@ private void testCompressedL
asfgit merged pull request #31:
URL: https://github.com/apache/logging-log4cxx/pull/31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
coldtobi opened a new pull request #32:
URL: https://github.com/apache/logging-log4cxx/pull/32
This should fix LOGCXX-512…
Other alternative would be to change project versioning to match the SONAME.
In this case the autotools would need fixing (or retirement).
Cheer,
tobi
rm5248 merged pull request #32:
URL: https://github.com/apache/logging-log4cxx/pull/32
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] opened a new pull request #395:
URL: https://github.com/apache/logging-log4j2/pull/395
Bumps [jctools-core](https://github.com/JCTools/JCTools) from 1.2.1 to 3.1.0.
Release notes
Sourced from https://github.com/JCTools/JCTools/releases";>jctools-core's
releases.
dependabot[bot] closed pull request #371:
URL: https://github.com/apache/logging-log4j2/pull/371
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] commented on pull request #371:
URL: https://github.com/apache/logging-log4j2/pull/371#issuecomment-670310127
Superseded by #395.
This is an automated message from the Apache Git Service.
To respond to the mes
jakluk commented on pull request #394:
URL: https://github.com/apache/logging-log4j2/pull/394#issuecomment-670473304
@rgoers Thank you for the quick review. There was no test whether the null
byte delimiter is present so I've added that one as well.
---
ams-tschoening opened a new pull request #33:
URL: https://github.com/apache/logging-log4cxx/pull/33
Changed the implementation to handle "quietMode" always. That has been the
requested behaviour in LOGCXX-455 and it seems to simply make sense to handle
that always at one place.
htt
rm5248 merged pull request #33:
URL: https://github.com/apache/logging-log4cxx/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ams-tschoening opened a new pull request #34:
URL: https://github.com/apache/logging-log4cxx/pull/34
Transcoder::encode(const LogString&, std::wstring&)" by appending LOSSCHAR.
The most likely alternative would be to throw on any invalid input instead, but
that's not the case right now and
ams-tschoening opened a new pull request #35:
URL: https://github.com/apache/logging-log4cxx/pull/35
This is an improved version o #30, which DOES NOT remove the page about
dependencies. Reason is that without that page, one needs to model the
dependencies otherwise and that is not as easy
ams-tschoening closed pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ams-tschoening commented on pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30#issuecomment-670854807
Closing here in favour of #35, that contains all the commits here already.
This is an automated messa
rm5248 commented on pull request #34:
URL: https://github.com/apache/logging-log4cxx/pull/34#issuecomment-670947833
Looks good to me - I went and added a test case as well to validate that it
works correctly, if you want to take a look.
rm5248 commented on pull request #35:
URL: https://github.com/apache/logging-log4cxx/pull/35#issuecomment-670952319
If we do want to move away from maven in the not-too-distant future,
something like this may be more appropriate for the dependencies:
https://github.com/apache/logging-log4c
ams-tschoening merged pull request #34:
URL: https://github.com/apache/logging-log4cxx/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
tbwork opened a new pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396
issue link: [Provide a way to add customized StrLookUps in Interpolator
initialization.](https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2904?filter=reportedbyme)
---
ams-tschoening commented on pull request #35:
URL: https://github.com/apache/logging-log4cxx/pull/35#issuecomment-671254462
I don't like those markdown-tables too much, seem pretty difficult to
maintain in my opinion. But I'm fine with that approach as well. The following
sentence makes me
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671263947
What's wrong with the CI? The change should have nothing to do with the
error. :)
This is an automated mes
jvz commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671368699
No worries about the Travis check. The GitHub Actions checks are the
important ones. We need to disable our old Travis checks.
rgoers commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671433053
The only concern I have with this is the overhead of ServiceLoader during
startup. I recently had to make ServiceLoader run asynchronously during startup
while loading Custo
rgoers commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose.
This is an au
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose, which is to allow a way for user's to hook into a Lookup that
is configur
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose, which is to allow a way for users to hook into a Lookup that
is configure
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose, which is to allow a way for users to hook into a Lookup that
is configure
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose, which is to allow a way for users to hook into a Lookup that
is configure
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671473790
@rgoers Agree! This PR is intended to do that as you proposed. Hope this
could be supported ASAP :) . Have a nice day.
-
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671478573
@rgoers Do you mean all the pre-loaded Lookups should be loaded via
ServiceLoader? I am glad to contribute to this part if you do not mind. :)
-
rgoers commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671515763
Yes, that is exactly what I mean. Feel free to modify this PR to do that.
This is an automated message from
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671515763
Yes, that is exactly what I mean. Feel free to modify this PR to do that. In
essence, StrLookup would become the service interface and every plugin to be
pre-loaded w
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671695782
@rgoers ok.
This is an automated message from the Apache Git Service.
To respond to the message, please log
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671775670
@jvz @rgoers It seems the Log4jPlugins class is moved from
org.apache.logging.log4j.core.plugins. However in Activator class, Log4jPlugins
is still imported as "org.apache.l
rm5248 commented on pull request #35:
URL: https://github.com/apache/logging-log4cxx/pull/35#issuecomment-671912627
> I don't like those markdown-tables too much, seem pretty difficult to
maintain in my opinion. But I'm fine with that approach as well. The following
sentence makes me wonde
ams-tschoening commented on pull request #35:
URL: https://github.com/apache/logging-log4cxx/pull/35#issuecomment-671929462
I'm simply not using CMAKE yet and thought you are talking about something
MVN does automatically. I would suggest adding some hint that CMAKE only does
those things
sjrd218 opened a new pull request #397:
URL: https://github.com/apache/logging-log4j2/pull/397
Wrap the list coming from the getStandardConfigLocations in a list that can
be added to.
This is an automated message from the Ap
dependabot[bot] commented on pull request #373:
URL: https://github.com/apache/logging-log4j2/pull/373#issuecomment-672561099
Superseded by #398.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] closed pull request #373:
URL: https://github.com/apache/logging-log4j2/pull/373
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] opened a new pull request #398:
URL: https://github.com/apache/logging-log4j2/pull/398
Bumps
[maven-resources-plugin](https://github.com/apache/maven-resources-plugin) from
3.0.2 to 3.2.0.
Commits
https://github.com/apache/maven-resources-plugin/commit/61096d9
dependabot[bot] closed pull request #391:
URL: https://github.com/apache/logging-log4j2/pull/391
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] commented on pull request #391:
URL: https://github.com/apache/logging-log4j2/pull/391#issuecomment-673650591
Looks like these dependencies are updatable in another way, so this is no
longer needed.
This is a
dependabot[bot] opened a new pull request #399:
URL: https://github.com/apache/logging-log4j2/pull/399
Bumps `springVersion` from 5.1.8.RELEASE to 5.2.8.RELEASE.
Updates `spring-aop` from 5.1.8.RELEASE to 5.2.8.RELEASE
Release notes
Sourced from https://github.com/spring-project
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-673870883
@rgoers @jvz Hi, are you busy? Could you get round to take a review and
merge :).
This is an automated mess
jvz commented on a change in pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471024396
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/JndiLookup.java
##
@@ -40,6 +39,24 @@
/** JNDI resource path prefix use
jvz commented on a change in pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471024839
##
File path:
log4j-docker/src/main/java/org/apache/logging/log4j/docker/DockerLookup.java
##
@@ -46,6 +46,15 @@
private final Container container;
rgoers closed pull request #399:
URL: https://github.com/apache/logging-log4j2/pull/399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers commented on pull request #399:
URL: https://github.com/apache/logging-log4j2/pull/399#issuecomment-674438475
Already done.
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dependabot[bot] commented on pull request #399:
URL: https://github.com/apache/logging-log4j2/pull/399#issuecomment-674438477
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR and I'll
rgoers commented on pull request #397:
URL: https://github.com/apache/logging-log4j2/pull/397#issuecomment-674456730
Patch has been applied but it was done manually since the affected code
moved to another branch.
This is an
rgoers closed pull request #397:
URL: https://github.com/apache/logging-log4j2/pull/397
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers edited a comment on pull request #397:
URL: https://github.com/apache/logging-log4j2/pull/397#issuecomment-674456730
Patch has been applied but it was done manually since the affected code
moved to another directory.
rgoers commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674459086
These changes are not what I expected. All the Lookups should remain
plugins. You should have only had to modify Interpolator to load the required
lookups via ServiceLoader
rgoers merged pull request #394:
URL: https://github.com/apache/logging-log4j2/pull/394
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sullis opened a new pull request #400:
URL: https://github.com/apache/logging-log4j2/pull/400
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
sullis opened a new pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
fmarchioni opened a new pull request #402:
URL: https://github.com/apache/logging-log4j2/pull/402
I've added two fresh articles based on the latest releases of WildFly
application Server and Spring Boot 2.
This is an automat
tbwork commented on a change in pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471209697
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/JndiLookup.java
##
@@ -40,6 +39,24 @@
/** JNDI resource path prefix
tbwork commented on a change in pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471211554
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
##
@@ -39,157 +32,95 @@
/** Constant for the prefi
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674637748
@rgoers Hi, rgoers. It seems my first pull request was what you want? Here
is my plan:
1. Keep all the old lookup loaded as plugins.
2. Provide a SPI mode for custom lo
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674639216
@rgoers I propably misunderstood your opinion:
**_In essence, StrLookup would become the service interface and every
plugin to be pre-loaded would be listed in the se
tbwork removed a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674637748
@rgoers Hi, rgoers. It seems my first pull request was what you want? Here
is my plan:
1. Keep all the old lookup loaded as plugins.
2. Provide a SPI mode for c
tbwork edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674639216
@rgoers I propably misunderstood your opinion:
**_In essence, StrLookup would become the service interface and every
plugin to be pre-loaded would be listed in
dependabot[bot] opened a new pull request #403:
URL: https://github.com/apache/logging-log4j2/pull/403
Bumps plexus-compiler-javac-errorprone from 2.8.5 to 2.8.7.
[