jjmms edited a comment on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904468892
Updated PR with an additional assertion in `RewriteAppenderTest` to ensure
log event timestamps happen on or after initial log time.
--
This is an automated message
garydgregory commented on a change in pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#discussion_r694721875
##
File path:
log4j-1.2-api/src/test/java/org/apache/log4j/config/RewriteAppenderTest.java
##
@@ -73,5 +74,6 @@ public void testRewrite() throw
jjmms commented on a change in pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#discussion_r694755665
##
File path:
log4j-1.2-api/src/test/java/org/apache/log4j/config/RewriteAppenderTest.java
##
@@ -73,5 +74,6 @@ public void testRewrite() throws Excep
carterkozak commented on a change in pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#discussion_r694833345
##
File path:
log4j-1.2-api/src/test/java/org/apache/log4j/config/RewriteAppenderTest.java
##
@@ -73,5 +74,6 @@ public void testRewrite() throws
garydgregory commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904635670
This PR is still based on master, it needs to be for the `release-2.x`
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message
garydgregory commented on a change in pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568#discussion_r694843906
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/StringEncoder.java
##
@@ -39,26 +37,21 @@ private StringEncoder() {
jjmms commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904664445
Updated branch and PR to target `release-2.x` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
carterkozak commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904665877
Thank you for the contribution, @jjmms. Once the tests complete I'll get
this merged into 2.x and master.
--
This is an automated message from the Apache Git Service.
carterkozak commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904862677
I've added a changelog entry and committed this to release-2.x and master
branches: b1596ed52406dbb93865b99ce7c9563a04258d22
--
This is an automated message from the
carterkozak closed pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on a change in pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568#discussion_r695102789
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
##
@@ -158,17 +148,12 @@ protected static
carterkozak commented on a change in pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568#discussion_r695103398
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/util/StringEncoder.java
##
@@ -39,26 +37,21 @@ private StringEncoder() {
carterkozak merged pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695263225
##
File path: src/main/cpp/asyncappender.cpp
##
@@ -50,7 +51,7 @@ AsyncAppender::AsyncAppender()
locationInfo(false),
blocking(true
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695263774
##
File path: src/main/cpp/threadutility.cpp
##
@@ -0,0 +1,91 @@
+#include "log4cxx/helpers/threadutility.h"
+#include "log4cxx/private/log4cxx_private
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695269347
##
File path: src/main/cpp/threadutility.cpp
##
@@ -0,0 +1,91 @@
+#include "log4cxx/helpers/threadutility.h"
+#include "log4cxx/private/log4cxx_private
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695269717
##
File path: src/main/include/log4cxx/helpers/threadutility.h
##
@@ -0,0 +1,119 @@
+#ifndef _LOG4CXX_THREADUTILITY_H
+#define _LOG4CXX_THREADUTILITY_H
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695274586
##
File path: src/main/include/log4cxx/helpers/threadutility.h
##
@@ -0,0 +1,119 @@
+#ifndef _LOG4CXX_THREADUTILITY_H
+#define _LOG4CXX_THREADUTILITY_H
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695277961
##
File path: src/site/markdown/threading.md
##
@@ -0,0 +1,83 @@
+Threading {#threading}
+===
+
+
+# Threading Notes with Log4cxx
+
+Log4cxx is designe
rm5248 merged pull request #69:
URL: https://github.com/apache/logging-log4cxx/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
ams-tschoening commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695473112
##
File path: src/main/cpp/asyncappender.cpp
##
@@ -50,7 +51,7 @@ AsyncAppender::AsyncAppender()
locationInfo(false),
block
ams-tschoening commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695476624
##
File path: src/main/cpp/threadutility.cpp
##
@@ -0,0 +1,91 @@
+#include "log4cxx/helpers/threadutility.h"
+#include "log4cxx/private/log4cxx
ams-tschoening commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695481684
##
File path: src/main/include/log4cxx/helpers/threadutility.h
##
@@ -0,0 +1,119 @@
+#ifndef _LOG4CXX_THREADUTILITY_H
+#define _LOG4CXX_THREADU
ams-tschoening commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695517215
##
File path: src/site/markdown/threading.md
##
@@ -0,0 +1,83 @@
+Threading {#threading}
+===
+
+
+# Threading Notes with Log4cxx
+
+Log4cxx is
ams-tschoening commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695517215
##
File path: src/site/markdown/threading.md
##
@@ -0,0 +1,83 @@
+Threading {#threading}
+===
+
+
+# Threading Notes with Log4cxx
+
+Log4cxx is
maccamlc commented on pull request #569:
URL: https://github.com/apache/logging-log4j2/pull/569#issuecomment-905455117
Bug fix so that the isClassAvailable check correctly looks for presence of
[org/apache/logging/log4j/spring/boot/SpringEnvironmentHolder.java](https://github.com/apache/log
maccamlc removed a comment on pull request #569:
URL: https://github.com/apache/logging-log4j2/pull/569#issuecomment-905455117
Bug fix so that the isClassAvailable check correctly looks for presence of
[org/apache/logging/log4j/spring/boot/SpringEnvironmentHolder.java](https://github.com/ap
vy commented on pull request #558:
URL: https://github.com/apache/logging-log4j2/pull/558#issuecomment-905574302
Thanks so much for the contribution @sanyarnd!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
vy merged pull request #558:
URL: https://github.com/apache/logging-log4j2/pull/558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r696018350
##
File path: src/main/cpp/threadutility.cpp
##
@@ -0,0 +1,91 @@
+#include "log4cxx/helpers/threadutility.h"
+#include "log4cxx/private/log4cxx_priva
carterkozak opened a new pull request #570:
URL: https://github.com/apache/logging-log4j2/pull/570
https://issues.apache.org/jira/browse/LOG4J2-3150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rahimalizada commented on pull request #558:
URL: https://github.com/apache/logging-log4j2/pull/558#issuecomment-905890995
This change gives validation error '... duplicate attribute propertiesAsList
inJsonLayotuType. ... line 589' in eclipse IDE which relies on lemminx XML
language server
rahimalizada edited a comment on pull request #558:
URL: https://github.com/apache/logging-log4j2/pull/558#issuecomment-905890995
This change gives validation error '... duplicate attribute propertiesAsList
inJsonLayotuType. ... line 589' while validating log4j2.xml in eclipse IDE
which re
rahimalizada edited a comment on pull request #558:
URL: https://github.com/apache/logging-log4j2/pull/558#issuecomment-905890995
This change gives validation error '... duplicate attribute propertiesAsList
in JsonLayoutType. ... line 589' while validating log4j2.xml in eclipse IDE
which r
carterkozak merged pull request #570:
URL: https://github.com/apache/logging-log4j2/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
maccamlc commented on pull request #569:
URL: https://github.com/apache/logging-log4j2/pull/569#issuecomment-906073967
Thanks @rgoers
Not sure of the right process, but please let me know how to get this merged.
And will it be able to get included in any bug fix version, 2.14.
vy commented on pull request #558:
URL: https://github.com/apache/logging-log4j2/pull/558#issuecomment-906156252
@rahimalizada, I have fixed it. Thanks so much for the warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rgoers commented on pull request #569:
URL: https://github.com/apache/logging-log4j2/pull/569#issuecomment-906161364
Having a PR on the release-2.x branch would be great! Otherwise I would have
to cherry-pick it from master.
--
This is an automated message from the Apache Git Service.
To
vy merged pull request #569:
URL: https://github.com/apache/logging-log4j2/pull/569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #569:
URL: https://github.com/apache/logging-log4j2/pull/569#issuecomment-906164869
Thanks so much for the fix @maccamlc, I have cherry-picked this onto
`release-2.x`. Mind closing the JIRA ticket, please?
--
This is an automated message from the Apache Git S
vy merged pull request #561:
URL: https://github.com/apache/logging-log4j2/pull/561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-906468899
I have just skimmed over the changes and I am totally against this PR. We
already have 3 competing JSON layouts in the project: `GelfLayout`,
`JsonLayout`, and its successor `Js
vy closed pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
redapel commented on pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#issuecomment-906654798
Hi team,
Please have take a look to the new test case that i submitted. In that test,
i choose to use real MongoDB server instead of the Flapdoodle's embedded
MongoDB a
garydgregory commented on a change in pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#discussion_r697032754
##
File path: log4j-mongodb4/pom.xml
##
@@ -88,6 +88,17 @@
de.flapdoodle.embed.mongo
test
+
+ org.apache.logging.lo
garydgregory commented on pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#issuecomment-906799734
> Hi team,
> Please have take a look to the new test case that i submitted. In that
test, i choose to use real MongoDB server instead of the Flapdoodle's embedded
M
garydgregory commented on a change in pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#discussion_r697036474
##
File path: log4j-mongodb4/pom.xml
##
@@ -88,6 +88,17 @@
de.flapdoodle.embed.mongo
test
+
+ org.apache.logging.lo
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697068021
##
File path: src/main/cpp/threadutility.cpp
##
@@ -0,0 +1,91 @@
+#include "log4cxx/helpers/threadutility.h"
+#include "log4cxx/private/log4cxx_private
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697206398
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697206398
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697206398
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
sman-81 commented on pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-907319321
> [..] All existing patterns effectively use `rightWordCount=1`, however we
could make that configurable and allow existing options to work with this.
@carterkozak
I d
sman-81 edited a comment on pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-907319321
> [..] All existing patterns effectively use `rightWordCount=1`, however we
could make that configurable and allow existing options to work with this.
@carterk
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697747208
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtilit
redapel commented on a change in pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#discussion_r697823808
##
File path: log4j-mongodb4/pom.xml
##
@@ -88,6 +88,17 @@
de.flapdoodle.embed.mongo
test
+
+ org.apache.logging.log4j
+
redapel commented on a change in pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#discussion_r697825524
##
File path: log4j-mongodb4/pom.xml
##
@@ -88,6 +88,17 @@
de.flapdoodle.embed.mongo
test
+
+ org.apache.logging.log4j
+
redapel commented on pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#issuecomment-907585610
> > Hi team,
> > Please have take a look to the new test case that i submitted. In that
test, i choose to use real MongoDB server instead of the Flapdoodle's embedded
Mo
garydgregory commented on a change in pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#discussion_r697855364
##
File path: log4j-mongodb4/pom.xml
##
@@ -88,6 +88,17 @@
de.flapdoodle.embed.mongo
test
+
+ org.apache.logging.lo
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697873836
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697925078
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtilit
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697925078
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtilit
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697927015
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697927015
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697927015
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697927015
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
carterkozak opened a new pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573
Prefer fewer conditionals based on types known ahead of time.
Serializer extends Serializer2 with a default implementation
of the encode method -- all of our implementations of
the Ser
carterkozak commented on pull request #565:
URL: https://github.com/apache/logging-log4j2/pull/565#issuecomment-907946139
I've applied the fix as 177a85708535cad6a3e0af9468f323135cc91fbd, thanks for
the contribution!
--
This is an automated message from the Apache Git Service.
To respond
carterkozak closed pull request #565:
URL: https://github.com/apache/logging-log4j2/pull/565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
vy closed pull request #571:
URL: https://github.com/apache/logging-log4j2/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #571:
URL: https://github.com/apache/logging-log4j2/pull/571#issuecomment-908150631
@yaojingguo, thanks so much for taking time to submit a PR to improve the
documentation! Much appreciated! Though sadly these are not typos. For
instance, linked statements appl
dependabot[bot] opened a new pull request #575:
URL: https://github.com/apache/logging-log4j2/pull/575
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.2.0
to 2.3.0.
Release notes
Sourced from https://github.com/actions/setup-java/releases";>actions/setup-j
vy commented on pull request #575:
URL: https://github.com/apache/logging-log4j2/pull/575#issuecomment-908247836
Before blindly merging this PR, let's add `cache` option and while we are at
it, rename `adopt` to `temurin`.
--
This is an automated message from the Apache Git Service.
To r
garydgregory commented on pull request #575:
URL: https://github.com/apache/logging-log4j2/pull/575#issuecomment-908278574
Sounds good.
Gary
On Mon, Aug 30, 2021, 07:02 Volkan Yazıcı ***@***.***> wrote:
> Before blindly merging this PR, let's add cache option and while w
yaojingguo commented on pull request #571:
URL: https://github.com/apache/logging-log4j2/pull/571#issuecomment-908422218
> For instance, linked statements apply to both eventTemplate and
eventTemplateUri, hence the eventTemplate[Uri].
@vy Could you please kindly show me how to use `
carterkozak commented on pull request #572:
URL: https://github.com/apache/logging-log4j2/pull/572#issuecomment-908541298
Applied to release-2.x + master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
carterkozak closed pull request #572:
URL: https://github.com/apache/logging-log4j2/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
vy commented on pull request #571:
URL: https://github.com/apache/logging-log4j2/pull/571#issuecomment-908696388
The entire documentation assumes that square brackets are used for optional
parameters. Hence, in the case of, e.g., `eventTemplate[Uri]`, it means the
statement applies to both
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r698859515
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtilit
rm5248 merged pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r699005019
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r698859515
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtilit
carterkozak closed pull request #572:
URL: https://github.com/apache/logging-log4j2/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r699005019
##
File path: src/main/cpp/threadutility.cpp
##
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtil
rm5248 merged pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
vy commented on pull request #571:
URL: https://github.com/apache/logging-log4j2/pull/571#issuecomment-908696388
The entire documentation assumes that square brackets are used for optional
parameters. Hence, in the case of, e.g., `eventTemplate[Uri]`, it means the
statement applies to both
carterkozak commented on pull request #572:
URL: https://github.com/apache/logging-log4j2/pull/572#issuecomment-908541298
Applied to release-2.x + master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
yaojingguo commented on pull request #571:
URL: https://github.com/apache/logging-log4j2/pull/571#issuecomment-908422218
> For instance, linked statements apply to both eventTemplate and
eventTemplateUri, hence the eventTemplate[Uri].
@vy Could you please kindly show me how to use `
carterkozak opened a new pull request #576:
URL: https://github.com/apache/logging-log4j2/pull/576
Previously more precise patterns would be cached unexpectedly
within a millisecond interval, all using the microsecond or
nanosecond value of the first event that millisecond.
--
This
vy commented on pull request #576:
URL: https://github.com/apache/logging-log4j2/pull/576#issuecomment-910285774
Great catch! Thanks so much @carterkozak!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vy merged pull request #576:
URL: https://github.com/apache/logging-log4j2/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #576:
URL: https://github.com/apache/logging-log4j2/pull/576#issuecomment-910287283
Cherry-picked to `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
carterkozak merged pull request #577:
URL: https://github.com/apache/logging-log4j2/pull/577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
travisspencer opened a new pull request #578:
URL: https://github.com/apache/logging-log4j2/pull/578
Fixed a couple log messages that were missing params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
carterkozak merged pull request #578:
URL: https://github.com/apache/logging-log4j2/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
sman-81 commented on pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-914959246
@carterkozak Here's another small update to my pull request.
Can you merge it into the release branch please?
--
This is an automated message from the Apache Git Servic
rm5248 opened a new pull request #70:
URL: https://github.com/apache/logging-log4cxx/pull/70
As requested in LOGCXX-431 by @coldtobi, the new thread configuration blocks
signals on POSIX by default.
A new option for the configuration files has also been added, so that you
may config
travisspencer commented on pull request #578:
URL: https://github.com/apache/logging-log4j2/pull/578#issuecomment-915501455
Thanks, @carterkozak , for accepting this fix. Do you know if I can get a
build of this off the CI server somehow? I need the fix to test some other
stuff, and I'm no
carterkozak commented on pull request #578:
URL: https://github.com/apache/logging-log4j2/pull/578#issuecomment-915504002
It works best if you target the release-2.x branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
travisspencer commented on pull request #578:
URL: https://github.com/apache/logging-log4j2/pull/578#issuecomment-915515500
Ah, good to know. Would it help at all if I cherry-pick it to that branch
and make a separate PR or do commits to the main line get back-ported
automatically somehow?
carterkozak commented on pull request #578:
URL: https://github.com/apache/logging-log4j2/pull/578#issuecomment-915521576
When I merge changes I cherry-pick them to the other branch, no need to
create additional PRs since it tends to split the discussion. We add changelog
entries for most
2901 - 3000 of 7264 matches
Mail list logo
