sman-81 commented on a change in pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r681495858
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java
##
@@ -29,6 +32,11 @@
*/
private f
carterkozak opened a new pull request #553:
URL: https://github.com/apache/logging-log4j2/pull/553
`LoggerFactory.getLogger(name/class)` as well as
`LoggerFactory.getILoggerFactory().getLogger(name)`.
--
This is an automated message from the Apache Git Service.
To respond to the message,
carterkozak commented on a change in pull request #553:
URL: https://github.com/apache/logging-log4j2/pull/553#discussion_r681845225
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.java
##
@@ -40,6 +41,16 @@ public static StackLocator get
carterkozak opened a new pull request #554:
URL: https://github.com/apache/logging-log4j2/pull/554
`LoggerFactory.getLogger(name/class)` as well as
`LoggerFactory.getILoggerFactory().getLogger(name)`.
--
This is an automated message from the Apache Git Service.
To respond to the messag
carterkozak commented on pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-891993420
I slightly restructured the benchmark to fix the issue where only the first
class was ever used, and reused the StringBuilder and LogEvent objects to avoid
allocation o
carterkozak opened a new pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555
Previously the entire input string was written to the output
buffer, then small sections were deleted or replaced within that
string. This meant that for each section that was abbreviated
carterkozak commented on pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-892137360
@sman-81 I've created a PR which aims to improve the worst-case performance
of NameAbbreviator, however the the performance difference is smaller than I
had anticipated
carterkozak commented on a change in pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r682075572
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -285,40 +285,40 @@ public PatternAbbrevi
garydgregory commented on a change in pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r682082299
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -285,40 +285,40 @@ public PatternAbbrev
carterkozak commented on a change in pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r682083949
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -285,40 +285,40 @@ public PatternAbbrevi
carterkozak commented on a change in pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r682086487
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -285,40 +285,40 @@ public PatternAbbrevi
carterkozak opened a new pull request #556:
URL: https://github.com/apache/logging-log4j2/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
carterkozak commented on pull request #485:
URL: https://github.com/apache/logging-log4j2/pull/485#issuecomment-892191658
Sorry for the delay, @franz1981!
## This PR rebased to master
`java -jar log4j-perf/target/benchmarks.jar
".*AsyncAppenderLog4j2Benchmark\.throughputSimple
vy commented on pull request #476:
URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-892381981
@radut The following repository should work:
https://repository.apache.org/content/repositories/snapshots/
--
This is an automated message from the Apache Git Service.
To resp
vy merged pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-892391568
Thanks so much for the PR @sman-81! I have ported this to `master` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
carterkozak merged pull request #553:
URL: https://github.com/apache/logging-log4j2/pull/553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak merged pull request #554:
URL: https://github.com/apache/logging-log4j2/pull/554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
vy merged pull request #552:
URL: https://github.com/apache/logging-log4j2/pull/552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #545:
URL: https://github.com/apache/logging-log4j2/pull/545#issuecomment-892706763
Looks like a spam.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
vy closed pull request #545:
URL: https://github.com/apache/logging-log4j2/pull/545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
carterkozak opened a new pull request #557:
URL: https://github.com/apache/logging-log4j2/pull/557
…lf4j-api 1.7.14
See
https://github.com/qos-ch/slf4j/commit/ea3cca72cd5a9329a06b788317a17e806ee8acd0
and https://jira.qos.ch/browse/SLF4J-347
--
This is an automated message from
carterkozak commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-892717422
@vy I think this broke builds on release-2.x for the same reason the PR
build is failing, revapi needs the enum ordinal changes to be acknowledged.
--
This is an auto
carterkozak closed pull request #557:
URL: https://github.com/apache/logging-log4j2/pull/557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on pull request #557:
URL: https://github.com/apache/logging-log4j2/pull/557#issuecomment-892737122
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
carterkozak commented on a change in pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#discussion_r682718072
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -365,4 +372,51 @@ public void abbreviate
carterkozak commented on a change in pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#discussion_r682720416
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -365,4 +372,51 @@ public void abbreviate
sanyarnd opened a new pull request #558:
URL: https://github.com/apache/logging-log4j2/pull/558
Add 3 missing properties from
https://logging.apache.org/log4j/2.x/manual/layouts.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
schlosna commented on a change in pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r683117411
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -285,40 +285,40 @@ public PatternAbbreviato
vy commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893239718
:man_facepalming: @carterkozak, right, thanks for the warning, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
sman-81 commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999
Hi @carterkozak, hi @vy,
thank you both for fixing the **reviapi** build failure.
I should have spotted this myself. I must admit I've rarely built the whole
project a
sman-81 edited a comment on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999
Hi @carterkozak, hi @vy,
thank you both for fixing the `revapi` build failure which I have reproduced
earlier.
I should have spotted this myself. I must admit I
sman-81 edited a comment on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999
Hi @carterkozak, hi @vy,
thank you both for fixing the `revapi` build failure which I have reproduced
earlier.
I should have spotted this myself. I must admit I
carterkozak commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-892717422
@vy I think this broke builds on release-2.x for the same reason the PR
build is failing, revapi needs the enum ordinal changes to be acknowledged.
--
This is an auto
carterkozak commented on a change in pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#discussion_r682718072
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -365,4 +372,51 @@ public void abbreviate
vy commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893239718
:man_facepalming: @carterkozak, right, thanks for the warning, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
sman-81 commented on pull request #548:
URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999
Hi @carterkozak, hi @vy,
thank you both for fixing the **reviapi** build failure.
I should have spotted this myself. I must admit I've rarely built the whole
project a
carterkozak closed pull request #557:
URL: https://github.com/apache/logging-log4j2/pull/557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
vy merged pull request #552:
URL: https://github.com/apache/logging-log4j2/pull/552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
schlosna commented on a change in pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r683117411
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -285,40 +285,40 @@ public PatternAbbreviato
carterkozak merged pull request #554:
URL: https://github.com/apache/logging-log4j2/pull/554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
carterkozak commented on pull request #557:
URL: https://github.com/apache/logging-log4j2/pull/557#issuecomment-892737122
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
vy commented on pull request #545:
URL: https://github.com/apache/logging-log4j2/pull/545#issuecomment-892706763
Looks like a spam.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
vy closed pull request #545:
URL: https://github.com/apache/logging-log4j2/pull/545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
carterkozak merged pull request #553:
URL: https://github.com/apache/logging-log4j2/pull/553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
sman-81 commented on pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-893394475
Hi again @carterkozak interesting what you've found. Thanks for looking into
this.
Your research puts a question mark behind the usefulness of my pull request.
My benc
sman-81 commented on a change in pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#discussion_r683418964
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -365,4 +372,51 @@ public void abbreviate(fin
sman-81 commented on a change in pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#discussion_r683419578
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -365,4 +372,51 @@ public void abbreviate(fin
carterkozak commented on a change in pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r683429654
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java
##
@@ -285,40 +285,40 @@ public PatternAbbrevi
sman-81 edited a comment on pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-893394475
Hi again @carterkozak interesting what you've found. Thanks for looking into
this.
Your research puts a question mark behind the usefulness of my pull request.
carterkozak commented on pull request #555:
URL: https://github.com/apache/logging-log4j2/pull/555#issuecomment-893543113
## Azul Zulu JDK 16.0.2, OpenJDK 64-Bit Server VM, 16.0.2+7
### This PR (as is, using `indexOf(String, int)`)
_1_ (run numbers labeled to account for therma
carterkozak commented on pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-893569664
> My benchmarks were with a single thread only.
In practice, is this code executed in multiple log4j2 threads?
As usual, the answer is “it depends” :-)
in th
dependabot[bot] commented on pull request #546:
URL: https://github.com/apache/logging-log4j2/pull/546#issuecomment-893984027
Superseded by #559.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] closed pull request #546:
URL: https://github.com/apache/logging-log4j2/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
dependabot[bot] opened a new pull request #559:
URL: https://github.com/apache/logging-log4j2/pull/559
Bumps tomcat-catalina from 8.5.20 to 10.0.10.
[ from 3.6.0 to 3.8.2.
Commits
https://github.com/apache/maven/commit/ea98e05a04480131370aa0c110b8c54cf726c06f";>ea98e05
[ma
dependabot[bot] closed pull request #482:
URL: https://github.com/apache/logging-log4j2/pull/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
ams-tschoening commented on pull request #67:
URL: https://github.com/apache/logging-log4cxx/pull/67#issuecomment-899268642
@rm5248 How about the individual logging statements? Don't they need a
semicolon as well? All of those macros have been changed with 0.10.X already:
> Regarding
dependabot[bot] opened a new pull request #561:
URL: https://github.com/apache/logging-log4j2/pull/561
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.1.0
to 2.2.0.
Release notes
Sourced from https://github.com/actions/setup-java/releases";>actions/setup-j
rm5248 merged pull request #67:
URL: https://github.com/apache/logging-log4cxx/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
arVahedi opened a new pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562
Add Enhanced json layout for defined dynamic class as model of json structure
Signed-off-by: arVahedi
--
This is an automated message from the Apache Git Service.
To respond to the mess
vy commented on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901190938
Why don't you simply use `JsonTemplateLayout`?
On Wed, 18 Aug 2021, 02:09 Alireza Vahedi ***@***.***> wrote:
> Add Enhanced json layout for defined dynamic class as
rm5248 merged pull request #67:
URL: https://github.com/apache/logging-log4cxx/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
vy commented on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901190938
Why don't you simply use `JsonTemplateLayout`?
On Wed, 18 Aug 2021, 02:09 Alireza Vahedi ***@***.***> wrote:
> Add Enhanced json layout for defined dynamic class as
vladimirfx commented on pull request #8:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-901279407
Sorry for commenting closed pull request. When it might be released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
arVahedi commented on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901385314
> Why don't you simply use `JsonTemplateLayout`?
>
> On Wed, 18 Aug 2021, 02:09 Alireza Vahedi ***@***.***> wrote:
>
> > Add Enhanced json layout for defined d
arVahedi edited a comment on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901385314
> Why don't you simply use `JsonTemplateLayout`?
>
>
>
`JsonTemplateLayout` is a great feature, but it is still limited. imagine I
need to log som
arVahedi edited a comment on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901385314
> Why don't you simply use `JsonTemplateLayout`?
>
>
>
`JsonTemplateLayout` is a great feature, but it is still limited. imagine I
need to log som
arVahedi edited a comment on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901385314
> Why don't you simply use `JsonTemplateLayout`?
>
>
>
`JsonTemplateLayout` is a great feature, but it is still limited. imagine I
need to log som
carterkozak commented on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901392195
> imagine I need to log some value out of LogEvent context and based on some
logic at runtime, for example generate an activityId, digest value or something
like that a
arVahedi edited a comment on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901385314
> Why don't you simply use `JsonTemplateLayout`?
>
>
>
`JsonTemplateLayout` is a great feature, but it is still limited. imagine I
need to log som
arVahedi commented on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901630304
> > imagine I need to log some value out of LogEvent context and based on
some logic at runtime, for example generate an activityId, digest value or
something like that at
arVahedi edited a comment on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901630304
> > imagine I need to log some value out of LogEvent context and based on
some logic at runtime, for example generate an activityId, digest value or
something like
vy commented on pull request #562:
URL: https://github.com/apache/logging-log4j2/pull/562#issuecomment-901639026
I will back at my desk in a week or so, then I will be able to review this
PR. I'd appreciate holding this PR on hold until then.
Alireza, are you sure you understand Ca
rocketraman commented on pull request #8:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-901852051
@jvz what do you think about a new release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jvz commented on pull request #8:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-901925243
I've actually gotten back into using Kotlin lately thanks to Spinnaker using
it in newer code. I'm pretty booked this weekend, but I can help get a release
out after that. S
vladimirfx commented on pull request #8:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-902002062
@jvz thank you for your time! Very waiting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
PeripheralMike opened a new pull request #563:
URL: https://github.com/apache/logging-log4j2/pull/563
Noticed a spelling mistake in the README. Read the contribution
documentation and included the (doc) prefix
--
This is an automated message from the Apache Git Service.
To respond to the
rgoers merged pull request #563:
URL: https://github.com/apache/logging-log4j2/pull/563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
rm5248 opened a new pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68
In order to provide a way to block signals to threads created by log4cxx, a
new API has been created to set functions that will be called before a thread
has started, information about the thread t
redapel opened a new pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564
After do some debugging, i found out that there are some part of the code
that is missing in MongoDb4Provider class when creating log4j-mongodb4 module,
knowing that this part of the code is exis
garydgregory commented on pull request #564:
URL: https://github.com/apache/logging-log4j2/pull/564#issuecomment-903173794
> After do some debugging, i found out that there are some part of the code
that is missing in MongoDb4Provider class when creating log4j-mongodb4 module,
knowing that
asapha opened a new pull request #565:
URL: https://github.com/apache/logging-log4j2/pull/565
https://issues.apache.org/jira/browse/LOG4J2-2808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
garydgregory commented on a change in pull request #565:
URL: https://github.com/apache/logging-log4j2/pull/565#discussion_r693526761
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java
##
@@ -609,7 +610,13 @@ public Configuration setConfigu
asapha commented on a change in pull request #565:
URL: https://github.com/apache/logging-log4j2/pull/565#discussion_r693527832
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java
##
@@ -609,7 +610,13 @@ public Configuration setConfiguration
carterkozak merged pull request #566:
URL: https://github.com/apache/logging-log4j2/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
jjmms opened a new pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567
https://issues.apache.org/jira/browse/LOG4J2-3142
When using the `LogEventAdapter` we should return the
`LogEvent.getTimeMillis()` as this is the equivalent timestamp value from
Log4j2 to Lo
carterkozak commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904089216
Looks reasonable to me. Any chance you can provide a minimal test case?
Something as simple as an additional assert in `RewriteAppenderTest` should do
the trick, we can
jjmms commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904150662
I have written a test but unable to run it due to errors in Maven build and
test per CI errors:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compil
carterkozak commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904155637
Sorry, the `master` branch isn't in the best state, I generally target
`release-2.x` initially and port commits to master. CI builds are running
correctly on that branc
carterkozak opened a new pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568
Rerunning the benchmarks on modern java (in this case java 16,
however many optimizations are available in java 11 due to the
compact string optimizations) shows that the previous assumpt
garydgregory commented on pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568#issuecomment-904185436
Nice. I like that we can simplify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
carterkozak commented on pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568#issuecomment-904190754
Hoping the smaller methods are inlined more aggressively as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ams-tschoening commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r694560188
##
File path: src/main/cpp/threadutility.cpp
##
@@ -0,0 +1,91 @@
+#include "log4cxx/helpers/threadutility.h"
+#include "log4cxx/private/log4cxx
ams-tschoening opened a new pull request #69:
URL: https://github.com/apache/logging-log4cxx/pull/69
for XML-related tests:
> CMake Warning (dev) at src/test/cpp/xml/CMakeLists.txt:1 (add_executable):
> Policy CMP0115 is not set: Source file extensions must be explicit. Run
>
jjmms commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904468892
Updated PR with a test case to ensure log event timestamps happen after
initial log time.
--
This is an automated message from the Apache Git Service.
To respond to the mes
jjmms edited a comment on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904468892
Updated PR with an additional assertion in `RewriteAppenderTest` to ensure
log event timestamps happen after initial log time.
--
This is an automated message from t
2801 - 2900 of 7264 matches
Mail list logo
