[GitHub] [logging-log4cxx] stephen-webb commented on issue #14: Replace ant build with cmake

2020-02-08 Thread GitBox
stephen-webb commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583798950 Hi All, I have done everything I can think of prepare https://github.com/apache/logging-log4cxx/pull/14 for inclusion in the repository

[GitHub] [logging-log4j2] rgoers merged pull request #331: Fixed check for RollingFileManager, directWrite

2020-02-08 Thread GitBox
rgoers merged pull request #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4j2] rgoers commented on issue #330: Fixed log message in RollingFileAppender

2020-02-08 Thread GitBox
rgoers commented on issue #330: Fixed log message in RollingFileAppender URL: https://github.com/apache/logging-log4j2/pull/330#issuecomment-583802710 Create LOG4J2-2776 for this. This is an automated message from the Apache G

[GitHub] [logging-log4j2] rgoers merged pull request #330: Fixed log message in RollingFileAppender

2020-02-08 Thread GitBox
rgoers merged pull request #330: Fixed log message in RollingFileAppender URL: https://github.com/apache/logging-log4j2/pull/330 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout

2020-02-08 Thread GitBox
rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout URL: https://github.com/apache/logging-log4j2/pull/332#discussion_r376753729 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/cor

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-08 Thread GitBox
rgoers commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376760048 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java ## @@ -2

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-09 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376771316 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java ## @@

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-09 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376771316 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java ## @@

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583837151 So let's close #12 and really focus on this one, replacing things in favour of CMAKE instead of adding it? I don't use the ANT-build myself anywa

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376805122 ## File path: src/test/java/CMakeLists.txt ## @@ -0,0 +1,18 @@ +include(FetchContent) +FetchContent_Declare(l

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376805933 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache So

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376803532 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache So

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376806130 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache So

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376808023 ## File path: src/test/cpp/net/socketservertestcase.cpp ## @@ -478,4 +477,4 @@ LOGUNIT_CLASS(SocketServerTest

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376807031 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache So

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583884452 @stephen-webb Does `socketservertestcase` succeed for your? I get the following error messages for two tests which use the `%C` format flag in th

[GitHub] [logging-log4j2] rgoers merged pull request #319: log4j-kafka added with "retryCount" function

2020-02-09 Thread GitBox
rgoers merged pull request #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376811760 ## File path: src/site/apt/building/vcpkg.apt ## @@ -0,0 +1,41 @@ +~~ Licensed to the Apache Software Foundat

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376811526 ## File path: src/site/apt/building/cmake.apt ## @@ -0,0 +1,104 @@ +~~ Licensed to the Apache Software Founda

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376809913 ## File path: src/site/apt/building/cmake.apt ## @@ -0,0 +1,104 @@ +~~ Licensed to the Apache Software Founda

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583888615 https://github.com/apache/logging-log4cxx/tree/ghpr_14_replace-ant-build-with-cmake

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-09 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376814654 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java ## @@

[GitHub] [logging-log4j2] rgoers merged pull request #315: added retry count if failed to send

2020-02-09 Thread GitBox
rgoers merged pull request #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [logging-log4j2] rgoers commented on issue #315: added retry count if failed to send

2020-02-09 Thread GitBox
rgoers commented on issue #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315#issuecomment-583893907 PR manually merged with minor changes. This is an automated message from the Apa

[GitHub] [logging-log4j2] rgoers commented on issue #319: log4j-kafka added with "retryCount" function

2020-02-09 Thread GitBox
rgoers commented on issue #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319#issuecomment-583893976 PR merged with minor changes. This is an automated message from the Apa

[GitHub] [logging-log4j2] rgoers merged pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout

2020-02-09 Thread GitBox
rgoers merged pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout URL: https://github.com/apache/logging-log4j2/pull/332 This is an automated message from the Apache Git

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout

2020-02-09 Thread GitBox
rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout URL: https://github.com/apache/logging-log4j2/pull/332#discussion_r376753729 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/cor

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376840482 ## File path: src/test/cpp/net/socketservertestcase.cpp ## @@ -478,4 +477,4 @@ LOGUNIT_CLASS(SocketServerTestCa

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376843651 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Soft

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376844778 ## File path: src/site/apt/building/cmake.apt ## @@ -0,0 +1,104 @@ +~~ Licensed to the Apache Software Foundati

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376848071 ## File path: src/test/java/CMakeLists.txt ## @@ -0,0 +1,18 @@ +include(FetchContent) +FetchContent_Declare(log

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376884765 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Soft

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376894906 ## File path: src/site/apt/building/cmake.apt ## @@ -0,0 +1,104 @@ +~~ Licensed to the Apache Software Foundati

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376907831 ## File path: src/test/cpp/net/socketservertestcase.cpp ## @@ -478,4 +477,4 @@ LOGUNIT_CLASS(SocketServerTest

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-10 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376911085 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache So

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-10 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-584023353 > I have no idea where that `?` comes from... I think the log settings and witnesses were simply wrong, because the test has been disabled

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-10 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376936826 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache So

[GitHub] [logging-log4cxx] ams-tschoening closed pull request #12: Add support for building and testing with cmake

2020-02-10 Thread GitBox
ams-tschoening closed pull request #12: Add support for building and testing with cmake URL: https://github.com/apache/logging-log4cxx/pull/12 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #12: Add support for building and testing with cmake

2020-02-10 Thread GitBox
ams-tschoening commented on issue #12: Add support for building and testing with cmake URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-584023900 It currently looks like #14 gets merged, so I'm closing here for now. ---

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #3: LOGCXX-494: windows cmake build for log4cxx against apr-2

2020-02-10 Thread GitBox
ams-tschoening commented on issue #3: LOGCXX-494: windows cmake build for log4cxx against apr-2 URL: https://github.com/apache/logging-log4cxx/pull/3#issuecomment-584024279 It currently looks like #14 gets merged, so am closing here for now.

[GitHub] [logging-log4cxx] ams-tschoening closed pull request #3: LOGCXX-494: windows cmake build for log4cxx against apr-2

2020-02-10 Thread GitBox
ams-tschoening closed pull request #3: LOGCXX-494: windows cmake build for log4cxx against apr-2 URL: https://github.com/apache/logging-log4cxx/pull/3 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #2: Build with autotools+maven

2020-02-10 Thread GitBox
ams-tschoening commented on issue #2: Build with autotools+maven URL: https://github.com/apache/logging-log4cxx/pull/2#issuecomment-584024862 It currently looks like #14 gets merged and using Autotools might get abandoned on Linux altogether, so I'm closing here for now. --

[GitHub] [logging-log4cxx] ams-tschoening closed pull request #2: Build with autotools+maven

2020-02-10 Thread GitBox
ams-tschoening closed pull request #2: Build with autotools+maven URL: https://github.com/apache/logging-log4cxx/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [logging-log4cxx] ams-tschoening edited a comment on issue #14: Replace ant build with cmake

2020-02-10 Thread GitBox
ams-tschoening edited a comment on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-584023353 > I have no idea where that `?` comes from... I think the log settings and witnesses were simply wrong, because the test has been d

[GitHub] [logging-log4j-audit] JLLeitschuh opened a new pull request #23: [SECURITY] Use HTTPS to resolve dependencies in Maven Build

2020-02-10 Thread GitBox
JLLeitschuh opened a new pull request #23: [SECURITY] Use HTTPS to resolve dependencies in Maven Build URL: https://github.com/apache/logging-log4j-audit/pull/23 [![mitm_build](https://user-images.githubusercontent.com/1323708/59226671-90645200-8ba1-11e9-8ab3-39292bef99e9.jpeg)](https://me

[GitHub] [logging-log4cxx] stephen-webb opened a new pull request #15: Prepare for release

2020-02-10 Thread GitBox
stephen-webb opened a new pull request #15: Prepare for release URL: https://github.com/apache/logging-log4cxx/pull/15 Changes I believe are required prior to release This is an automated message from the Apache Git Service. T

[GitHub] [logging-log4j2] rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2020-02-10 Thread GitBox
rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-584469091 Closing this PR for the reasons stated in my prior comment. ---

[GitHub] [logging-log4j2] rgoers closed pull request #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2020-02-10 Thread GitBox
rgoers closed pull request #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312 This is an automated message from the Apache Git Se

[GitHub] [logging-log4j2] rgoers merged pull request #307: [LOG4J2-2652] JSON output wrong when using additonal fields

2020-02-10 Thread GitBox
rgoers merged pull request #307: [LOG4J2-2652] JSON output wrong when using additonal fields URL: https://github.com/apache/logging-log4j2/pull/307 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-10 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-584514283 Using `com.googlecode.cmake-maven-project` with OpenJDK 8 fails, because they [require JDK 11](https://github.com/cmake-maven-project/cmake-mave

[GitHub] [logging-log4cxx] stephen-webb commented on issue #14: Replace ant build with cmake

2020-02-11 Thread GitBox
stephen-webb commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-584517342 The previous version of cmake.maven.plugin did not work on Windows. The maintainer is active so may be receptive if you raise an issue. On

[GitHub] [logging-log4j2] rgoers commented on issue #307: [LOG4J2-2652] JSON output wrong when using additonal fields

2020-02-11 Thread GitBox
rgoers commented on issue #307: [LOG4J2-2652] JSON output wrong when using additonal fields URL: https://github.com/apache/logging-log4j2/pull/307#issuecomment-584696166 This fix PR has been applied to master but the code in master is significantly different than on the release-2.x branch

[GitHub] [logging-log4j-audit] andrei-ivanov merged pull request #23: [SECURITY] Use HTTPS to resolve dependencies in Maven Build

2020-02-11 Thread GitBox
andrei-ivanov merged pull request #23: [SECURITY] Use HTTPS to resolve dependencies in Maven Build URL: https://github.com/apache/logging-log4j-audit/pull/23 This is an automated message from the Apache Git Service. To respo

[GitHub] [logging-log4j-audit] rgoers commented on issue #23: [SECURITY] Use HTTPS to resolve dependencies in Maven Build

2020-02-11 Thread GitBox
rgoers commented on issue #23: [SECURITY] Use HTTPS to resolve dependencies in Maven Build URL: https://github.com/apache/logging-log4j-audit/pull/23#issuecomment-584775734 This should have a Jira issue and an entry in changes.xml. -

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-11 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r377943901 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMessage.java ##

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-11 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r377943882 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java ##

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-11 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r377943921 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/StringFormattedMessage.java

[GitHub] [logging-log4j2] vy opened a new pull request #339: LOG4J2-2703 Complex data type support in MapMessage JSON formatter

2020-02-12 Thread GitBox
vy opened a new pull request #339: LOG4J2-2703 Complex data type support in MapMessage JSON formatter URL: https://github.com/apache/logging-log4j2/pull/339 As discussed in [LOG4J2-2703](https://issues.apache.org/jira/browse/LOG4J2-2703), this patch adds support for complex data types in

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #16: Configuration output

2020-02-12 Thread GitBox
rm5248 opened a new pull request #16: Configuration output URL: https://github.com/apache/logging-log4cxx/pull/16 Add a small configuration output to help the user see how log4cxx is configured. Document how to disable tests. -

[GitHub] [logging-log4cxx] ams-tschoening merged pull request #16: Configuration output

2020-02-12 Thread GitBox
ams-tschoening merged pull request #16: Configuration output URL: https://github.com/apache/logging-log4cxx/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-13 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-585599767 I'm trying to test CMAKE and MVN on Sunday myself, just out of interest to see what happens, but nevertheless, as long as nobody objects, going t

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-02-13 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-585705483 @jvz, I could not get the test-jar thing working. I have pushed my progress: 7084934. I will be so glad if you can spare some time to help

[GitHub] [logging-log4j2] jvz commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-02-13 Thread GitBox
jvz commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-585869692 It's possible that there's a corresponding configuration to enable for the test jar to make it available as a dependency like in log4j-co

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-02-13 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-585946494 @jvz, I have the cloned `maven-jar-plugin` configuration in `/log4j-layout-json-template/pom.xml` and I can see both `log4j-layout-json-t

[GitHub] [logging-log4j2] jvz commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-02-13 Thread GitBox
jvz commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-585953434 I'm not really sure what else there is to configure. I can't get it working at the moment myself. --

[GitHub] [logging-log4cxx] stephen-webb opened a new pull request #17: Reduce msvc warnings

2020-02-13 Thread GitBox
stephen-webb opened a new pull request #17: Reduce msvc warnings URL: https://github.com/apache/logging-log4cxx/pull/17 Suppress "needs to have dll-interface" warnings for std::basic_string, std::map and std::stack. Use size_t instead of in where appropriate

[GitHub] [logging-log4j2] rgoers merged pull request #339: LOG4J2-2703 Complex data type support in MapMessage JSON formatter

2020-02-15 Thread GitBox
rgoers merged pull request #339: LOG4J2-2703 Complex data type support in MapMessage JSON formatter URL: https://github.com/apache/logging-log4j2/pull/339 This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] rgoers merged pull request #338: use 'final' modifier for fields where possible

2020-02-15 Thread GitBox
rgoers merged pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4j2] rgoers closed pull request #301: LOG4J-2676: Backport use of javax.annotation.processing.Messager to release-2.x.

2020-02-15 Thread GitBox
rgoers closed pull request #301: LOG4J-2676: Backport use of javax.annotation.processing.Messager to release-2.x. URL: https://github.com/apache/logging-log4j2/pull/301 This is an automated message from the Apache Git Servic

[GitHub] [logging-log4j2] rgoers commented on issue #301: LOG4J-2676: Backport use of javax.annotation.processing.Messager to release-2.x.

2020-02-15 Thread GitBox
rgoers commented on issue #301: LOG4J-2676: Backport use of javax.annotation.processing.Messager to release-2.x. URL: https://github.com/apache/logging-log4j2/pull/301#issuecomment-586649599 I committed the change without the bazel stuff. ---

[GitHub] [logging-log4j2] rgoers commented on issue #308: LOG4J2-1192 (support dynamic Subject)

2020-02-15 Thread GitBox
rgoers commented on issue #308: LOG4J2-1192 (support dynamic Subject) URL: https://github.com/apache/logging-log4j2/pull/308#issuecomment-586649722 Still waiting for a response . This is an automated message from the Apache Gi

[GitHub] [logging-log4j2] rgoers merged pull request #300: call #StatusLogger.getLogger() only when it's needed.

2020-02-15 Thread GitBox
rgoers merged pull request #300: call #StatusLogger.getLogger() only when it's needed. URL: https://github.com/apache/logging-log4j2/pull/300 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [logging-log4j2] rgoers commented on issue #298: Synchronize before looping over synchronized collection

2020-02-15 Thread GitBox
rgoers commented on issue #298: Synchronize before looping over synchronized collection URL: https://github.com/apache/logging-log4j2/pull/298#issuecomment-586655233 An alternative change was made This is an automated message

[GitHub] [logging-log4j2] rgoers closed pull request #298: Synchronize before looping over synchronized collection

2020-02-15 Thread GitBox
rgoers closed pull request #298: Synchronize before looping over synchronized collection URL: https://github.com/apache/logging-log4j2/pull/298 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [logging-log4j2] rgoers commented on issue #145: fix bug LOG4J2-2211

2020-02-15 Thread GitBox
rgoers commented on issue #145: fix bug LOG4J2-2211 URL: https://github.com/apache/logging-log4j2/pull/145#issuecomment-586678335 Closing this PR. The issue was fixed a different way. This is an automated message from the Apa

[GitHub] [logging-log4j2] rgoers closed pull request #145: fix bug LOG4J2-2211

2020-02-15 Thread GitBox
rgoers closed pull request #145: fix bug LOG4J2-2211 URL: https://github.com/apache/logging-log4j2/pull/145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] rgoers closed pull request #144: [LOG4J2-2211] Update StrSubstitutor.java

2020-02-15 Thread GitBox
rgoers closed pull request #144: [LOG4J2-2211] Update StrSubstitutor.java URL: https://github.com/apache/logging-log4j2/pull/144 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [logging-log4j2] rgoers commented on issue #144: [LOG4J2-2211] Update StrSubstitutor.java

2020-02-15 Thread GitBox
rgoers commented on issue #144: [LOG4J2-2211] Update StrSubstitutor.java URL: https://github.com/apache/logging-log4j2/pull/144#issuecomment-586678370 Closing this PR. The issue was fixed a different way. This is an automated

[GitHub] [logging-log4j2] rgoers closed pull request #25: LOG4J2-1301 added optionalMonitorFiles attribute for automatic reconf…

2020-02-15 Thread GitBox
rgoers closed pull request #25: LOG4J2-1301 added optionalMonitorFiles attribute for automatic reconf… URL: https://github.com/apache/logging-log4j2/pull/25 This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j2] rgoers commented on issue #25: LOG4J2-1301 added optionalMonitorFiles attribute for automatic reconf…

2020-02-15 Thread GitBox
rgoers commented on issue #25: LOG4J2-1301 added optionalMonitorFiles attribute for automatic reconf… URL: https://github.com/apache/logging-log4j2/pull/25#issuecomment-586678599 Closing this since it has been replaced with Composite Configurations.

[GitHub] [logging-log4j2] rgoers closed pull request #146: fixes capitalization of log4j2.ContextDataInjector property name in Documentation

2020-02-15 Thread GitBox
rgoers closed pull request #146: fixes capitalization of log4j2.ContextDataInjector property name in Documentation URL: https://github.com/apache/logging-log4j2/pull/146 This is an automated message from the Apache Git Servi

[GitHub] [logging-log4j2] rgoers commented on issue #146: fixes capitalization of log4j2.ContextDataInjector property name in Documentation

2020-02-15 Thread GitBox
rgoers commented on issue #146: fixes capitalization of log4j2.ContextDataInjector property name in Documentation URL: https://github.com/apache/logging-log4j2/pull/146#issuecomment-586678672 Closing this per Matt's comments.

[GitHub] [logging-log4j2] rgoers commented on issue #159: [LOG4J2-1013][Lookups] Allow variables with dashes

2020-02-15 Thread GitBox
rgoers commented on issue #159: [LOG4J2-1013][Lookups] Allow variables with dashes URL: https://github.com/apache/logging-log4j2/pull/159#issuecomment-586678868 Closing this as a fix has been committed to allow keys with leading dashes to be escaped. --

[GitHub] [logging-log4j2] rgoers closed pull request #159: [LOG4J2-1013][Lookups] Allow variables with dashes

2020-02-15 Thread GitBox
rgoers closed pull request #159: [LOG4J2-1013][Lookups] Allow variables with dashes URL: https://github.com/apache/logging-log4j2/pull/159 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [logging-log4j2] rgoers commented on issue #274: [LOG4J2-2600] Add declarative Groovy configuration DSL

2020-02-15 Thread GitBox
rgoers commented on issue #274: [LOG4J2-2600] Add declarative Groovy configuration DSL URL: https://github.com/apache/logging-log4j2/pull/274#issuecomment-586678946 Anything going on here or should it be closed? This is an au

[GitHub] [logging-log4j2] rgoers commented on issue #87: [LOG4J2-928] Mostly wait-free MemoryMappedFileManager

2020-02-16 Thread GitBox
rgoers commented on issue #87: [LOG4J2-928] Mostly wait-free MemoryMappedFileManager URL: https://github.com/apache/logging-log4j2/pull/87#issuecomment-586679295 @leventov Are you still interested in contributing this? This i

[GitHub] [logging-log4j2] rgoers commented on issue #152: exposes the location part of the Message to loggers

2020-02-16 Thread GitBox
rgoers commented on issue #152: exposes the location part of the Message to loggers URL: https://github.com/apache/logging-log4j2/pull/152#issuecomment-586679542 Closing this as this can now be accomplished by using the builder methods in the Logger class.

[GitHub] [logging-log4j2] rgoers closed pull request #152: exposes the location part of the Message to loggers

2020-02-16 Thread GitBox
rgoers closed pull request #152: exposes the location part of the Message to loggers URL: https://github.com/apache/logging-log4j2/pull/152 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [logging-log4j2] leventov commented on issue #87: [LOG4J2-928] Mostly wait-free MemoryMappedFileManager

2020-02-16 Thread GitBox
leventov commented on issue #87: [LOG4J2-928] Mostly wait-free MemoryMappedFileManager URL: https://github.com/apache/logging-log4j2/pull/87#issuecomment-586684110 @rgoers in principle, I would like, but I won't have time to do this in foreseeable future. -

[GitHub] [logging-log4cxx] asfgit merged pull request #14: Replace ant build with cmake

2020-02-16 Thread GitBox
asfgit merged pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] jvz commented on issue #274: [LOG4J2-2600] Add declarative Groovy configuration DSL

2020-02-16 Thread GitBox
jvz commented on issue #274: [LOG4J2-2600] Add declarative Groovy configuration DSL URL: https://github.com/apache/logging-log4j2/pull/274#issuecomment-586738537 This PR is stalled for now. I'll be revisiting this later, and it can be resurrected then.

[GitHub] [logging-log4cxx] asfgit merged pull request #15: Prepare for release

2020-02-16 Thread GitBox
asfgit merged pull request #15: Prepare for release URL: https://github.com/apache/logging-log4cxx/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [logging-log4cxx] asfgit merged pull request #17: Reduce msvc warnings

2020-02-16 Thread GitBox
asfgit merged pull request #17: Reduce msvc warnings URL: https://github.com/apache/logging-log4cxx/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] rgoers merged pull request #291: [LOG4J2-2604/2649] Change MethodHandle to Constructor to adapt graalvm

2020-02-16 Thread GitBox
rgoers merged pull request #291: [LOG4J2-2604/2649] Change MethodHandle to Constructor to adapt graalvm URL: https://github.com/apache/logging-log4j2/pull/291 This is an automated message from the Apache Git Service. To resp

[GitHub] [logging-log4cxx] stephen-webb opened a new pull request #18: Conditionally exclude tests that require the external 'zip' or 'gzip'

2020-02-16 Thread GitBox
stephen-webb opened a new pull request #18: Conditionally exclude tests that require the external 'zip' or 'gzip' URL: https://github.com/apache/logging-log4cxx/pull/18 Exclude tests that require 'zip' or 'gzip' when the program 'zip' or 'gzip' is not available --

[GitHub] [logging-log4cxx] stephen-webb commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip'

2020-02-17 Thread GitBox
stephen-webb commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip' URL: https://github.com/apache/logging-log4cxx/pull/18#issuecomment-586885978 I have not been through all the tests that use sed in as much detail as timebasedrollingtestcase. It ta

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip'

2020-02-17 Thread GitBox
ams-tschoening commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip' URL: https://github.com/apache/logging-log4cxx/pull/18#issuecomment-586895077 So what's the problem actually, are you not able to provide the necessary binaries for some reason or d

[GitHub] [logging-log4cxx] stephen-webb commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip'

2020-02-17 Thread GitBox
stephen-webb commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip' URL: https://github.com/apache/logging-log4cxx/pull/18#issuecomment-586896907 Tests fail on Windows at the moment. I believe that is not good enough for release. People will not be

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip'

2020-02-17 Thread GitBox
ams-tschoening commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip' URL: https://github.com/apache/logging-log4cxx/pull/18#issuecomment-586910735 I'm running all tests successfully already on Windows, so if that is the main problem, please create an

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip'

2020-02-17 Thread GitBox
ams-tschoening commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip' URL: https://github.com/apache/logging-log4cxx/pull/18#issuecomment-586918173 I've removed the SED-exceptions to be in-line with my former argument and am closing here for now as we

<    22   23   24   25   26   27   28   29   30   31   >