[GitHub] [logging-log4j2] rgoers commented on issue #315: added retry count if failed to send

2019-11-21 Thread GitBox
rgoers commented on issue #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315#issuecomment-557220093 sorry, this is showing 115 files changed. Did you modify line endings or something? I can't really review this as is. --

[GitHub] [logging-log4j2] supertomcat commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-21 Thread GitBox
supertomcat commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314#issuecomment-557261263 > > > > I'd love to provide one, but I wouldn't know how. > > Simple: Refactor the static

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-21 Thread GitBox
carterkozak commented on a change in pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314#discussion_r349307035 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/Uuid

[GitHub] [logging-log4j2] supertomcat commented on a change in pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-21 Thread GitBox
supertomcat commented on a change in pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314#discussion_r349316651 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/Uuid

[GitHub] [logging-log4j2] rgoers commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-21 Thread GitBox
rgoers commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314#issuecomment-557272195 Do NOT merge this. I need to review it. -

[GitHub] [logging-log4j2] joongs4 closed pull request #315: added retry count if failed to send

2019-11-21 Thread GitBox
joongs4 closed pull request #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [logging-log4j2] joongs4 commented on issue #315: added retry count if failed to send

2019-11-21 Thread GitBox
joongs4 commented on issue #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315#issuecomment-557284822 I modified and reopened This is an automated message from the Apache Git Servic

[GitHub] [logging-log4j2] joongs4 opened a new pull request #315: added retry count if failed to send

2019-11-21 Thread GitBox
joongs4 opened a new pull request #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315 In my system, there is Kafka only for logging but as Kafka is not yet completely installed, it often crashes. If Kafka is down, an application gets blocked. I

[GitHub] [logging-log4j2] anikosss opened a new pull request #316: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler

2019-11-27 Thread GitBox
anikosss opened a new pull request #316: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler URL: https://github.com/apache/logging-log4j2/pull/316 Added try/finally around event.execute() for RingBufferLogEventHandler to clear memory correctly in case of e

[GitHub] [logging-log4j2] anikosss opened a new pull request #317: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler

2019-11-27 Thread GitBox
anikosss opened a new pull request #317: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler URL: https://github.com/apache/logging-log4j2/pull/317 Added try/finally around event.execute() for RingBufferLogEventHandler to clear memory correctly in case of

[GitHub] [logging-log4j2] drx777 commented on issue #307: [LOG4J2-2652] JSON output wrong when using additonal fields

2019-11-28 Thread GitBox
drx777 commented on issue #307: [LOG4J2-2652] JSON output wrong when using additonal fields URL: https://github.com/apache/logging-log4j2/pull/307#issuecomment-559407023 I would also appreciate if this is fixed soon, it's completely breaking our logging with kibana. I'd be happy to help if

[GitHub] [logging-log4php] shigemk2 opened a new pull request #24: typo fixes

2019-11-30 Thread GitBox
shigemk2 opened a new pull request #24: typo fixes URL: https://github.com/apache/logging-log4php/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [logging-log4j2] carterkozak commented on issue #317: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler

2019-12-01 Thread GitBox
carterkozak commented on issue #317: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler URL: https://github.com/apache/logging-log4j2/pull/317#issuecomment-560184283 Great find! Is there any chance we can test this? [EventParameterMemoryLeakTest](https://

[GitHub] [logging-log4j2] rgoers merged pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-12-02 Thread GitBox
rgoers merged pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314 This is an automated message from the Apache Git Service. To resp

[GitHub] [logging-log4j2] rgoers commented on issue #315: added retry count if failed to send

2019-12-03 Thread GitBox
rgoers commented on issue #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315#issuecomment-561457429 This patch looks good to me. Can you also provide a patch to the release-2.x branch? Also, is there any way a test can be provided to verify thi

[GitHub] [logging-log4j2] rgoers merged pull request #313: [LOG4J2-2727] Add KafkaAppender.Builder#setKey

2019-12-03 Thread GitBox
rgoers merged pull request #313: [LOG4J2-2727] Add KafkaAppender.Builder#setKey URL: https://github.com/apache/logging-log4j2/pull/313 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4j2] rgoers commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup

2019-12-03 Thread GitBox
rgoers commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup URL: https://github.com/apache/logging-log4j2/pull/311#issuecomment-561460665 If there is a 2.10 version then master should upgrade to that. release-2.x should upgrade to 2.9.10. ---

[GitHub] [logging-log4j2] rgoers commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup

2019-12-03 Thread GitBox
rgoers commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup URL: https://github.com/apache/logging-log4j2/pull/311#issuecomment-561472691 I updated master to 2.10.1 and release-2.x to 2.9.10. ---

[GitHub] [logging-log4j2] rgoers closed pull request #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup

2019-12-03 Thread GitBox
rgoers closed pull request #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup URL: https://github.com/apache/logging-log4j2/pull/311 This is an automated message from the Apache Git Service. To resp

[GitHub] [logging-log4j2] cowtowncoder commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup

2019-12-04 Thread GitBox
cowtowncoder commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup URL: https://github.com/apache/logging-log4j2/pull/311#issuecomment-561807718 Makes sense. This is an automated mess

[GitHub] [logging-log4j2] rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-12-04 Thread GitBox
rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-561956297 I understand what you are trying to do. However, this fix is unnecessary. You can solve the pro

[GitHub] [logging-log4j2] rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-12-04 Thread GitBox
rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-561956297 I understand what you are trying to do. However, this fix is unnecessary. You can solve

[GitHub] [logging-log4j2] rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-12-04 Thread GitBox
rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-561956297 I understand what you are trying to do. However, this fix is unnecessary. You can solve

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #159: [LOG4J2-1013][Lookups] Allow variables with dashes

2019-12-05 Thread GitBox
rgoers commented on a change in pull request #159: [LOG4J2-1013][Lookups] Allow variables with dashes URL: https://github.com/apache/logging-log4j2/pull/159#discussion_r295861373 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java

[GitHub] [logging-log4j2] rgoers closed pull request #47: Add tinylog benchmarks

2019-12-05 Thread GitBox
rgoers closed pull request #47: Add tinylog benchmarks URL: https://github.com/apache/logging-log4j2/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] rgoers commented on issue #47: Add tinylog benchmarks

2019-12-05 Thread GitBox
rgoers commented on issue #47: Add tinylog benchmarks URL: https://github.com/apache/logging-log4j2/pull/47#issuecomment-562126538 Closing. I don't see us adding this. This is an automated message from the Apache Git Service.

[GitHub] [logging-log4j2] mattrpav opened a new pull request #318: [LOG4J2-2732] Add ThreadContext.putIfNull(key, value) helper method

2019-12-06 Thread GitBox
mattrpav opened a new pull request #318: [LOG4J2-2732] Add ThreadContext.putIfNull(key, value) helper method URL: https://github.com/apache/logging-log4j2/pull/318 This is an automated message from the Apache Git Service. To

[GitHub] [logging-log4j2] rgoers merged pull request #318: [LOG4J2-2732] Add ThreadContext.putIfNull(key, value) helper method

2019-12-06 Thread GitBox
rgoers merged pull request #318: [LOG4J2-2732] Add ThreadContext.putIfNull(key, value) helper method URL: https://github.com/apache/logging-log4j2/pull/318 This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] rgoers merged pull request #302: [LOG4J2-2674] CompositeConfiguration misleading configuration source

2019-12-06 Thread GitBox
rgoers merged pull request #302: [LOG4J2-2674] CompositeConfiguration misleading configuration source URL: https://github.com/apache/logging-log4j2/pull/302 This is an automated message from the Apache Git Service. To respon

[GitHub] [logging-log4j2] joongs4 opened a new pull request #319: log4j-kafka added with "retryCount" function

2019-12-06 Thread GitBox
joongs4 opened a new pull request #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319 I added log4j-kafka with "retryCount" function and also put test case. The test case is setting up wrong kafka endpoint and retry count. And then c

[GitHub] [logging-log4j2] rgoers merged pull request #283: LOG4J-2635: Fix java.version check in ThreadNameCachingStrategy

2019-12-06 Thread GitBox
rgoers merged pull request #283: LOG4J-2635: Fix java.version check in ThreadNameCachingStrategy URL: https://github.com/apache/logging-log4j2/pull/283 This is an automated message from the Apache Git Service. To respond to

[GitHub] [logging-log4j2] rgoers commented on issue #319: log4j-kafka added with "retryCount" function

2019-12-06 Thread GitBox
rgoers commented on issue #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319#issuecomment-562823301 In the master branch the kafka support was moved to the log4j-kafka module. We had not planned on moving it to its own module in 2.x.

[GitHub] [logging-log4j2] rgoers commented on issue #301: LOG4J-2676: Backport use of javax.annotation.processing.Messager to release-2.x.

2019-12-06 Thread GitBox
rgoers commented on issue #301: LOG4J-2676: Backport use of javax.annotation.processing.Messager to release-2.x. URL: https://github.com/apache/logging-log4j2/pull/301#issuecomment-562823668 I understand the desire to get rid of System.out calls but why is bazel being added? -

[GitHub] [logging-log4j2] joongs4 commented on issue #319: log4j-kafka added with "retryCount" function

2019-12-06 Thread GitBox
joongs4 commented on issue #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319#issuecomment-562825171 Oh sorry, I removed log4j-kafka and modified below files in log4j-core projects org.apache.logging.log4j.kafka.appender.KafkaMan

[GitHub] [logging-log4j2] carterkozak commented on issue #316: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler

2019-12-07 Thread GitBox
carterkozak commented on issue #316: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler URL: https://github.com/apache/logging-log4j2/pull/316#issuecomment-562893976 Thanks for your contribution @anikosss! --

[GitHub] [logging-log4j2] carterkozak merged pull request #316: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler

2019-12-07 Thread GitBox
carterkozak merged pull request #316: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler URL: https://github.com/apache/logging-log4j2/pull/316 This is an automated message from the Apache G

[GitHub] [logging-log4j2] carterkozak commented on issue #317: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler

2019-12-07 Thread GitBox
carterkozak commented on issue #317: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler URL: https://github.com/apache/logging-log4j2/pull/317#issuecomment-562894119 I have a test which reproduces, pushing shortly.

[GitHub] [logging-log4j2] carterkozak merged pull request #317: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler

2019-12-07 Thread GitBox
carterkozak merged pull request #317: LOG4J2-2725 - Added try/finally around event.execute() for RingBufferLogEventHandler URL: https://github.com/apache/logging-log4j2/pull/317 This is an automated message from the Apache

[GitHub] [logging-log4j2] rgoers merged pull request #287: [LOG4J2-2688] adding support for session attributes in log4j-web

2019-12-07 Thread GitBox
rgoers merged pull request #287: [LOG4J2-2688] adding support for session attributes in log4j-web URL: https://github.com/apache/logging-log4j2/pull/287 This is an automated message from the Apache Git Service. To respond to

[GitHub] [logging-log4j2] rgoers commented on issue #319: log4j-kafka added with "retryCount" function

2019-12-07 Thread GitBox
rgoers commented on issue #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319#issuecomment-562916875 After applying the patch and fixing the typo in KafkaAppenderTest.xml the KafkaAppenderTest is failing with: ```[INFO] Running o

[GitHub] [logging-log4j2] rgoers commented on issue #308: LOG4J2-1192 (support dynamic Subject)

2019-12-07 Thread GitBox
rgoers commented on issue #308: LOG4J2-1192 (support dynamic Subject) URL: https://github.com/apache/logging-log4j2/pull/308#issuecomment-562917090 Please provide a unit test for this. Also, if you would like it in a Log4j 2.x release then please provide an equivalent patch on the release-2

[GitHub] [logging-log4j2] rgoers commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka ProducerRecord

2019-12-07 Thread GitBox
rgoers commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka ProducerRecord URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-562917363 I applied this to master and when I ran the test I get ``` [INFO] Running org.apache.logging.log4j.kafka.appender.

[GitHub] [logging-log4j2] fedexist commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka ProducerRecord

2019-12-08 Thread GitBox
fedexist commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka ProducerRecord URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-562972161 > I applied this to master and when I ran the test I get > > ``` > [INFO] Running org.apache.logging.log4j.k

[GitHub] [logging-log4j2] rgoers merged pull request #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka ProducerRecord

2019-12-08 Thread GitBox
rgoers merged pull request #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka ProducerRecord URL: https://github.com/apache/logging-log4j2/pull/306 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4j-scala] JD557 commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-12-10 Thread GitBox
JD557 commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-564110595 @jvz any updates on this? This is an automated message from the Apache Gi

[GitHub] [logging-log4j2] elfogre opened a new pull request #320: Layouts doc possible fail

2019-12-10 Thread GitBox
elfogre opened a new pull request #320: Layouts doc possible fail URL: https://github.com/apache/logging-log4j2/pull/320 Not compact json means pretty style (previous it said not pretty) This is an automated message from the A

[GitHub] [logging-log4j2] rgoers merged pull request #320: Layouts doc possible fail

2019-12-10 Thread GitBox
rgoers merged pull request #320: Layouts doc possible fail URL: https://github.com/apache/logging-log4j2/pull/320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [logging-log4j2] rgoers commented on issue #320: Layouts doc possible fail

2019-12-10 Thread GitBox
rgoers commented on issue #320: Layouts doc possible fail URL: https://github.com/apache/logging-log4j2/pull/320#issuecomment-564206518 After re-reading this I realized the previous text, compact (a.k.a not "pretty"), is correct but confusing. compact does mean the output will not be pr

[GitHub] [logging-log4j2] wilkinsona opened a new pull request #321: LOG4J-2735 - make PluginCache output reproducible

2019-12-16 Thread GitBox
wilkinsona opened a new pull request #321: LOG4J-2735 - make PluginCache output reproducible URL: https://github.com/apache/logging-log4j2/pull/321 As discussed, here's a pull request for [LOG4J-2735](https://issues.apache.org/jira/browse/LOG4J2-2735). The commit message contains some det

[GitHub] [logging-log4j2] carterkozak opened a new pull request #322: LOG4J2-2677: Rollover and Deletion handle file deletions gracefully

2019-12-20 Thread GitBox
carterkozak opened a new pull request #322: LOG4J2-2677: Rollover and Deletion handle file deletions gracefully URL: https://github.com/apache/logging-log4j2/pull/322 It's common for multiple appenders to write (and roll) log files into a single directory. When these appenders are also r

[GitHub] [logging-log4j2] carterkozak commented on issue #322: LOG4J2-2677: Rollover and Deletion handle file deletions gracefully

2019-12-20 Thread GitBox
carterkozak commented on issue #322: LOG4J2-2677: Rollover and Deletion handle file deletions gracefully URL: https://github.com/apache/logging-log4j2/pull/322#issuecomment-567973260 Still needs a changelog and tests, not ready to merge.

[GitHub] [logging-log4j2] ahr-huber opened a new pull request #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…

2019-12-20 Thread GitBox
ahr-huber opened a new pull request #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr… URL: https://github.com/apache/logging-log4j2/pull/323 …onTriggeringPolicy There was a race condition in the computation of prevFireTime - which is used as time for th

[GitHub] [logging-log4j2] turbanoff opened a new pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData

2019-12-23 Thread GitBox
turbanoff opened a new pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData URL: https://github.com/apache/logging-log4j2/pull/324 This is an automated message from the A

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData

2019-12-23 Thread GitBox
carterkozak commented on a change in pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData URL: https://github.com/apache/logging-log4j2/pull/324#discussion_r360995202 ## File path: log4j-slf4j-impl/src/main/java/org/apache/loggi

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData

2019-12-23 Thread GitBox
turbanoff commented on a change in pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData URL: https://github.com/apache/logging-log4j2/pull/324#discussion_r361001932 ## File path: log4j-slf4j-impl/src/main/java/org/apache/logging

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData

2019-12-23 Thread GitBox
carterkozak commented on a change in pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData URL: https://github.com/apache/logging-log4j2/pull/324#discussion_r361013684 ## File path: log4j-slf4j-impl/src/main/java/org/apache/loggi

[GitHub] [logging-log4j2] carterkozak merged pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData

2019-12-23 Thread GitBox
carterkozak merged pull request #324: LOG4J2-2415 - Lock contention in classloader because of missing org.slf4j.ext.EventData URL: https://github.com/apache/logging-log4j2/pull/324 This is an automated message from the Apach

[GitHub] [logging-log4j2] carterkozak opened a new pull request #325: LOG4J2-2745: LOG4J2-2744: Upgrade slf4j-1.8 to beta4 (from alpha2)

2019-12-23 Thread GitBox
carterkozak opened a new pull request #325: LOG4J2-2745: LOG4J2-2744: Upgrade slf4j-1.8 to beta4 (from alpha2) URL: https://github.com/apache/logging-log4j2/pull/325 This deletes the EventDataConverter entirely from log4j-slf4j18-impl entirely because EventData is not supported in 1.8.

[GitHub] [logging-log4j2] carterkozak closed pull request #322: LOG4J2-2677: Rollover and Deletion handle file deletions gracefully

2019-12-23 Thread GitBox
carterkozak closed pull request #322: LOG4J2-2677: Rollover and Deletion handle file deletions gracefully URL: https://github.com/apache/logging-log4j2/pull/322 This is an automated message from the Apache Git Service. To re

[GitHub] [logging-log4j2] carterkozak commented on issue #322: LOG4J2-2677: Rollover and Deletion handle file deletions gracefully

2019-12-23 Thread GitBox
carterkozak commented on issue #322: LOG4J2-2677: Rollover and Deletion handle file deletions gracefully URL: https://github.com/apache/logging-log4j2/pull/322#issuecomment-568636847 merged This is an automated message from t

[GitHub] [logging-log4j2] carterkozak closed pull request #325: LOG4J2-2745: LOG4J2-2744: Upgrade slf4j-1.8 to beta4 (from alpha2)

2019-12-24 Thread GitBox
carterkozak closed pull request #325: LOG4J2-2745: LOG4J2-2744: Upgrade slf4j-1.8 to beta4 (from alpha2) URL: https://github.com/apache/logging-log4j2/pull/325 This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4j2] carterkozak commented on issue #325: LOG4J2-2745: LOG4J2-2744: Upgrade slf4j-1.8 to beta4 (from alpha2)

2019-12-24 Thread GitBox
carterkozak commented on issue #325: LOG4J2-2745: LOG4J2-2744: Upgrade slf4j-1.8 to beta4 (from alpha2) URL: https://github.com/apache/logging-log4j2/pull/325#issuecomment-568773010 merged This is an automated message from th

[GitHub] [logging-log4j2] carterkozak merged pull request #321: LOG4J-2735 - make PluginCache output reproducible

2019-12-24 Thread GitBox
carterkozak merged pull request #321: LOG4J-2735 - make PluginCache output reproducible URL: https://github.com/apache/logging-log4j2/pull/321 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4php] Falseclock opened a new pull request #25: Allow MDC use callable param

2019-12-25 Thread GitBox
Falseclock opened a new pull request #25: Allow MDC use callable param URL: https://github.com/apache/logging-log4php/pull/25 up to now it is impossible to use anonymouse function in LoggerMDC This small fix allows to use function as second parameter ```php LoggerMDC::put("s

[GitHub] [logging-log4php] jvz commented on issue #25: Allow MDC use callable param

2019-12-26 Thread GitBox
jvz commented on issue #25: Allow MDC use callable param URL: https://github.com/apache/logging-log4php/pull/25#issuecomment-569134582 Can you add a unit test for the supported syntax? This is an automated message from the Apa

[GitHub] [logging-log4j2] carterkozak commented on issue #326: LOG4J2-2750: Extended throwable class loading can be disabled

2019-12-30 Thread GitBox
carterkozak commented on issue #326: LOG4J2-2750: Extended throwable class loading can be disabled URL: https://github.com/apache/logging-log4j2/pull/326#issuecomment-569760210 TODOS: - Documentation for the new flag - Changelog ---

[GitHub] [logging-log4j2] carterkozak opened a new pull request #326: LOG4J2-2750: Extended throwable class loading can be disabled

2019-12-30 Thread GitBox
carterkozak opened a new pull request #326: LOG4J2-2750: Extended throwable class loading can be disabled URL: https://github.com/apache/logging-log4j2/pull/326 Implemented a new `log4j2.enable.extended.throwable.class.loading` flag which may be set to `false` in order to safely avoid pe

[GitHub] [logging-log4j2] carterkozak edited a comment on issue #326: LOG4J2-2750: Extended throwable class loading can be disabled

2019-12-30 Thread GitBox
carterkozak edited a comment on issue #326: LOG4J2-2750: Extended throwable class loading can be disabled URL: https://github.com/apache/logging-log4j2/pull/326#issuecomment-569760210 TODOS: - Test coverage - Documentation for the new flag - Changelog -

[GitHub] [logging-log4j2] carterkozak opened a new pull request #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers

2019-12-30 Thread GitBox
carterkozak opened a new pull request #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers URL: https://github.com/apache/logging-log4j2/pull/327 When reusable events are used with non-reusable message implementations (ParameterizedMessageFactory) there's no ne

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers

2019-12-30 Thread GitBox
carterkozak commented on a change in pull request #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers URL: https://github.com/apache/logging-log4j2/pull/327#discussion_r362109710 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/

[GitHub] [logging-log4j2] carterkozak commented on issue #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers

2019-12-30 Thread GitBox
carterkozak commented on issue #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers URL: https://github.com/apache/logging-log4j2/pull/327#issuecomment-569813409 Opened for comments for the night, I'll plan to merge tomorrow unless there are concerns. Overall I t

[GitHub] [logging-log4j2] carterkozak commented on issue #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers

2019-12-31 Thread GitBox
carterkozak commented on issue #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers URL: https://github.com/apache/logging-log4j2/pull/327#issuecomment-569940116 merged This is an automated message

[GitHub] [logging-log4j2] carterkozak closed pull request #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers

2019-12-31 Thread GitBox
carterkozak closed pull request #327: LOG4J2-2752: MutableLogEvent and RingBufferLogEvent lazily create buffers URL: https://github.com/apache/logging-log4j2/pull/327 This is an automated message from the Apache Git Service.

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders

2019-12-31 Thread GitBox
carterkozak commented on a change in pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders URL: https://github.com/apache/logging-log4j2/pull/328#discussion_r362274587 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/LoaderUti

[GitHub] [logging-log4j2] carterkozak opened a new pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders

2019-12-31 Thread GitBox
carterkozak opened a new pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders URL: https://github.com/apache/logging-log4j2/pull/328 The utility no longer erroneously returns a result with a null element in some environments. Also updated loadCla

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders

2019-12-31 Thread GitBox
carterkozak commented on a change in pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders URL: https://github.com/apache/logging-log4j2/pull/328#discussion_r362274678 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/LoaderUti

[GitHub] [logging-log4j2] carterkozak commented on issue #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders

2019-12-31 Thread GitBox
carterkozak commented on issue #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders URL: https://github.com/apache/logging-log4j2/pull/328#issuecomment-569984536 @rgoers I'm not as familiar with the consumers of `LoaderUtil.getClassLoaders()` as you are, I'd apprec

[GitHub] [logging-log4j2] carterkozak opened a new pull request #329: ThrowableProxy pre-warms its cache using the detected stack

2019-12-31 Thread GitBox
carterkozak opened a new pull request #329: ThrowableProxy pre-warms its cache using the detected stack URL: https://github.com/apache/logging-log4j2/pull/329 This allows us to avoid class loading even when order doesn't match the stack due to exceptions caught and pased from a slightly

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #329: ThrowableProxy pre-warms its cache using the detected stack

2019-12-31 Thread GitBox
carterkozak commented on a change in pull request #329: ThrowableProxy pre-warms its cache using the detected stack URL: https://github.com/apache/logging-log4j2/pull/329#discussion_r362289863 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyH

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #329: ThrowableProxy pre-warms its cache using the detected stack

2019-12-31 Thread GitBox
carterkozak commented on a change in pull request #329: ThrowableProxy pre-warms its cache using the detected stack URL: https://github.com/apache/logging-log4j2/pull/329#discussion_r362290037 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.

[GitHub] [logging-log4j2] carterkozak commented on issue #329: ThrowableProxy pre-warms its cache using the detected stack

2019-12-31 Thread GitBox
carterkozak commented on issue #329: ThrowableProxy pre-warms its cache using the detected stack URL: https://github.com/apache/logging-log4j2/pull/329#issuecomment-570002929 I need to think about this longer before I'm comfortable with it. Posted for early feedback on the idea. -

[GitHub] [logging-log4j2] carterkozak commented on issue #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders

2019-12-31 Thread GitBox
carterkozak commented on issue #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders URL: https://github.com/apache/logging-log4j2/pull/328#issuecomment-570004977 Thanks Ralph, tests all pass, I've merged this commit. It's not a clean cherry-pick to master because f

[GitHub] [logging-log4j2] carterkozak closed pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders

2019-12-31 Thread GitBox
carterkozak closed pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders may discover additional loaders URL: https://github.com/apache/logging-log4j2/pull/328 This is an automated message from the Apache Git Service. T

[GitHub] [logging-log4net] DHirani opened a new pull request #54: Upgraded to .net standard 2.1

2020-01-02 Thread GitBox
DHirani opened a new pull request #54: Upgraded to .net standard 2.1 URL: https://github.com/apache/logging-log4net/pull/54 I have upgraded this project to .net standard 2.1, you can cherry pick the changes. This is an automa

[GitHub] [logging-log4j2] joongs4 commented on issue #319: log4j-kafka added with "retryCount" function

2020-01-04 Thread GitBox
joongs4 commented on issue #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319#issuecomment-570796630 I fixted unit test and KafkaAppender.java if exception occurs while sending Kafka, I put retry logic. Thank you inadvance. --

[GitHub] [logging-log4j2] joongs4 commented on issue #319: log4j-kafka added with "retryCount" function

2020-01-04 Thread GitBox
joongs4 commented on issue #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319#issuecomment-570796706 Just check below files. org.apache.logging.log4j.kafka.appender.KafkaAppender org.apache.logging.log4j.kafka.appender.KafkaApp

[GitHub] [logging-log4cxx] ams-tschoening edited a comment on issue #12: Add support for building and testing with cmake

2020-01-07 Thread GitBox
ams-tschoening edited a comment on issue #12: Add support for building and testing with cmake URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-538741451 Thanks for the contribution, but I'm not sure how to deal with this currently and simply leave it open until further d

[GitHub] [logging-log4j2] ahr-huber closed pull request #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…

2020-01-07 Thread GitBox
ahr-huber closed pull request #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr… URL: https://github.com/apache/logging-log4j2/pull/323 This is an automated message from the Apache Git Service. To r

[GitHub] [logging-log4j2] ahr-huber commented on issue #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr…

2020-01-07 Thread GitBox
ahr-huber commented on issue #323: LOG4J2-2741 - Fix race condition in computation of prevFireTime in Cr… URL: https://github.com/apache/logging-log4j2/pull/323#issuecomment-571493853 Closing. Turned out this was already fixed on master. Ticket was LOG4J2-2575. The fix from master was cher

[GitHub] [logging-log4j2] ChristophKaser opened a new pull request #330: Fixed log message in RollingFileAppender

2020-01-10 Thread GitBox
ChristophKaser opened a new pull request #330: Fixed log message in RollingFileAppender URL: https://github.com/apache/logging-log4j2/pull/330 An error message in RollingFileAppender uses a placeholder for the name but does not specify the name argument in the logging call. This PR adds th

[GitHub] [logging-log4j-scala] LoafingBunny commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2020-01-11 Thread GitBox
LoafingBunny commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-573307781 @jvz if you have no time for this project you might want to add a new maintainer? I have no experience with apache but I may be

[GitHub] [logging-log4j-scala] LoafingBunny removed a comment on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2020-01-11 Thread GitBox
LoafingBunny removed a comment on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-573307781 @jvz if you have no time for this project you might want to add a new maintainer? I have no experience with apache but

[GitHub] [logging-log4j-scala] vimalaguti commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2020-01-11 Thread GitBox
vimalaguti commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-573309899 @jvz if you have no time to maintain this project you might want to add a new maintainer. I've no experience with apache but i may ge

[GitHub] [logging-log4j-scala] rgoers commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2020-01-11 Thread GitBox
rgoers commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-573332593 @vimalaguti Please see https://www.apache.org/foundation/how-it-works.html. It is great that you show an interest and your contributions

[GitHub] [logging-log4j-scala] jvz commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2020-01-12 Thread GitBox
jvz commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-573465908 Merging this won't be a problem. I haven't had time to make a release. This

[GitHub] [logging-log4j2] ChristophKaser opened a new pull request #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
ChristophKaser opened a new pull request #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331 Bugfix: Use the interface DirectFileRolloverStrategy instead of the concrete implementation DirectWriteRolloverStrategy when deciding whether

[GitHub] [logging-log4j2] carterkozak edited a comment on issue #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
carterkozak edited a comment on issue #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-573670239 Thanks @ChristophKaser, would you mind opening a jira issue to accompany this change? https://issues.apache.org/jira/p

[GitHub] [logging-log4j2] carterkozak commented on issue #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
carterkozak commented on issue #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-573670239 Thanks @ChristophKaser, would you mind opening a jira issue to accompany this change? -

[GitHub] [logging-log4j2] carterkozak commented on issue #330: Fixed log message in RollingFileAppender

2020-01-13 Thread GitBox
carterkozak commented on issue #330: Fixed log message in RollingFileAppender URL: https://github.com/apache/logging-log4j2/pull/330#issuecomment-573670803 Good catch,Thanks! I'll get this merged when I have a moment. This is

[GitHub] [logging-log4j2] ChristophKaser commented on issue #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
ChristophKaser commented on issue #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-573749205 Done: https://issues.apache.org/jira/browse/LOG4J2-2758 This

<    20   21   22   23   24   25   26   27   28   29   >