[GitHub] [logging-log4j2] pzygielo closed pull request #310: (doc) cleanup after #305

2019-09-14 Thread GitBox
pzygielo closed pull request #310: (doc) cleanup after #305 URL: https://github.com/apache/logging-log4j2/pull/310 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [logging-log4j2] gaurav9822 commented on issue #305: (doc) Fix typos in documentation

2019-09-15 Thread GitBox
gaurav9822 commented on issue #305: (doc) Fix typos in documentation URL: https://github.com/apache/logging-log4j2/pull/305#issuecomment-531551122 Thank you Ralph. On Sun, 15 Sep, 2019, 11:21 AM Ralph Goers, wrote: > Thanks, I have removed them. > > — > You are rec

[GitHub] [logging-log4j-scala] core-tec commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-09-18 Thread GitBox
core-tec commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-532610177 Is there any ETA for the next release? We are keen to use it in a Scala 2.13 project. Are there any blockers where we can contribute to

[GitHub] [logging-log4j-scala] jvz commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-09-18 Thread GitBox
jvz commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-532735351 I haven't had any time to make a release lately as I've been working on other things. I hope to find time to handle a release candidate soon

[GitHub] [logging-log4j2] Pebin commented on issue #307: [LOG4J2-2652] JSON output wrong when using additonal fields

2019-09-23 Thread GitBox
Pebin commented on issue #307: [LOG4J2-2652] JSON output wrong when using additonal fields URL: https://github.com/apache/logging-log4j2/pull/307#issuecomment-534139053 any progress on this? I could eventually help with testing if needed :) -

[GitHub] [logging-log4net] KamranShahid commented on issue #51: Added support for .Net Standard 2.0

2019-10-04 Thread GitBox
KamranShahid commented on issue #51: Added support for .Net Standard 2.0 URL: https://github.com/apache/logging-log4net/pull/51#issuecomment-538320890 Needed log4net for atleast .net standard 2.0. Problem in publishing app of .net core 3.0 where log4net 2.0,8 is referenced --

[GitHub] [logging-log4cxx] swebb2066 opened a new pull request #12: Add support for building and testing with cmake

2019-10-05 Thread GitBox
swebb2066 opened a new pull request #12: Add support for building and testing with cmake URL: https://github.com/apache/logging-log4cxx/pull/12 This just adds CMakeLists.txt files to various directories. No existing files are changed ---

[GitHub] [logging-log4cxx] ams-tschoening edited a comment on issue #3: LOGCXX-494: windows cmake build for log4cxx against apr-2

2019-10-06 Thread GitBox
ams-tschoening edited a comment on issue #3: LOGCXX-494: windows cmake build for log4cxx against apr-2 URL: https://github.com/apache/logging-log4cxx/pull/3#issuecomment-356979649 Just some notes: While it has been discussed in the past to move to CMAKE already, keep in mind that the curre

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #12: Add support for building and testing with cmake

2019-10-06 Thread GitBox
ams-tschoening commented on issue #12: Add support for building and testing with cmake URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-538741451 Thanks for the contribution, but I'm not sure how to deal with this currently and simply leave it open until further decision

[GitHub] [logging-log4j2] cowtowncoder opened a new pull request #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup

2019-10-06 Thread GitBox
cowtowncoder opened a new pull request #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup URL: https://github.com/apache/logging-log4j2/pull/311 Update Jackson patch version (as per Jira issue): also minor simplification for Jackson usage. I had a look at other

[GitHub] [logging-log4j2] jvz commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup

2019-10-06 Thread GitBox
jvz commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup URL: https://github.com/apache/logging-log4j2/pull/311#issuecomment-538783470 There's an open discussion somewhere around wrapping `ObjectMapper` into a plugin of some sort so it can be conf

[GitHub] [logging-log4j2] cowtowncoder commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup

2019-10-06 Thread GitBox
cowtowncoder commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup URL: https://github.com/apache/logging-log4j2/pull/311#issuecomment-538784369 That would probably make sense and isolate details better.

[GitHub] [logging-log4j2] jvz commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup

2019-10-06 Thread GitBox
jvz commented on issue #311: LOG4J2-2701: update jackson 2.9.9->2.9.10, minor jackson usage cleanup URL: https://github.com/apache/logging-log4j2/pull/311#issuecomment-538784818 Found it: https://issues.apache.org/jira/browse/LOG4J2-2670

[GitHub] [logging-log4cxx] swebb2066 commented on issue #12: Add support for building and testing with cmake

2019-10-06 Thread GitBox
swebb2066 commented on issue #12: Add support for building and testing with cmake URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-538808824 To enable inclusion by vcpkg, log4cxx needs a modern cmake build system. I can see no problem having an one more way to build log4

[GitHub] [logging-log4cxx] swebb2066 edited a comment on issue #12: Add support for building and testing with cmake

2019-10-06 Thread GitBox
swebb2066 edited a comment on issue #12: Add support for building and testing with cmake URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-538808824 To enable inclusion by vcpkg, log4cxx needs a modern cmake build system. I can see no problem having one more way to build

[GitHub] [logging-log4net] kabilanvk commented on issue #51: Added support for .Net Standard 2.0

2019-10-11 Thread GitBox
kabilanvk commented on issue #51: Added support for .Net Standard 2.0 URL: https://github.com/apache/logging-log4net/pull/51#issuecomment-541260630 > Needed log4net for atleast .net standard 2.0. > Problem in publishing app of .net core 3.0 where log4net 2.0,8 is referenced My cha

[GitHub] [logging-log4cxx] bblough opened a new pull request #13: Add JSONLayout class

2019-10-11 Thread GitBox
bblough opened a new pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13 This layout will format the LoggingEvent information such the date, logger, level, message, and location information, as well as the values in the MDC and NDC, into valid

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334276672 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334277332 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334276925 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334277314 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334277252 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334276904 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283090 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283190 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283225 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283267 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283269 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283976 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on issue #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on issue #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#issuecomment-541432949 For my use case, I think single-line log entries are preferred. But I can see how other use cases might benefit from pretty-printed output. I'll add it as a

[GitHub] [logging-log4cxx] bblough commented on issue #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on issue #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#issuecomment-541446258 Pretty-print option added. All changes pushed. This is an automated message from the Apache Gi

[GitHub] [logging-log4net] TechMinder opened a new pull request #52: Merging from Apache log4net

2019-10-14 Thread GitBox
TechMinder opened a new pull request #52: Merging from Apache log4net URL: https://github.com/apache/logging-log4net/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [logging-log4net] TechMinder closed pull request #52: Merging from Apache log4net

2019-10-14 Thread GitBox
TechMinder closed pull request #52: Merging from Apache log4net URL: https://github.com/apache/logging-log4net/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [logging-log4net] TechMinder commented on issue #52: Merging from Apache log4net

2019-10-14 Thread GitBox
TechMinder commented on issue #52: Merging from Apache log4net URL: https://github.com/apache/logging-log4net/pull/52#issuecomment-541724314 conflct This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [logging-log4j-scala] Guidoooch commented on a change in pull request #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-10-15 Thread GitBox
Guidoooch commented on a change in pull request #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#discussion_r334825127 ## File path: src/main/scala-2.13+/org/apache/logging/log4j/scala/LoggingContext.scala ## @@ -0,0

[GitHub] [logging-log4j-scala] Guidoooch commented on a change in pull request #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-10-15 Thread GitBox
Guidoooch commented on a change in pull request #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#discussion_r334825127 ## File path: src/main/scala-2.13+/org/apache/logging/log4j/scala/LoggingContext.scala ## @@ -0,0

[GitHub] [logging-log4j-scala] Guidoooch edited a comment on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-10-15 Thread GitBox
Guidoooch edited a comment on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-542110486 This looks very good, I did similar changes locally and works well. I have just a couple of comments: - Could update to u

[GitHub] [logging-log4j-scala] Guidoooch commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-10-15 Thread GitBox
Guidoooch commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-542110486 This looks very good, I did similar changes locally and works well. I have just a couple of comments: Could update to use sca

[GitHub] [logging-log4j-scala] Guidoooch edited a comment on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-10-15 Thread GitBox
Guidoooch edited a comment on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-542110486 This looks very good, I did similar changes locally and works well. I have just a couple of comments: - Could update to u

[GitHub] [logging-log4j-scala] Guidoooch commented on a change in pull request #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-10-15 Thread GitBox
Guidoooch commented on a change in pull request #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#discussion_r334825127 ## File path: src/main/scala-2.13+/org/apache/logging/log4j/scala/LoggingContext.scala ## @@ -0,0

[GitHub] [logging-log4j-scala] vimalaguti commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-10-15 Thread GitBox
vimalaguti commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-542197308 Any way we can help in publishing the new release? This is an automa

[GitHub] [logging-log4net] dpsenner commented on issue #51: Added support for .Net Standard 2.0

2019-10-17 Thread GitBox
dpsenner commented on issue #51: Added support for .Net Standard 2.0 URL: https://github.com/apache/logging-log4net/pull/51#issuecomment-543297947 I am afraid nant is no longer able to cope with this task. We would have to replace all what nant does with something else. This could be msbuil

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #13: Add JSONLayout class

2019-10-22 Thread GitBox
ams-tschoening commented on issue #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#issuecomment-545129157 Thanks for changing things, but I additionally ran into problems getting the new layout to compile in case the WCHAR_T-API is used and your tests failed

[GitHub] [logging-log4cxx] bblough commented on issue #13: Add JSONLayout class

2019-10-22 Thread GitBox
bblough commented on issue #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#issuecomment-545142247 Ah, sorry about that. Thanks for fixing it. I've just compiled and tested here and it still works for me. ---

[GitHub] [logging-log4cxx] asfgit merged pull request #13: Add JSONLayout class

2019-10-23 Thread GitBox
asfgit merged pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #13: Add JSONLayout class

2019-10-23 Thread GitBox
ams-tschoening commented on issue #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#issuecomment-545313185 That's good news, so I merged everything to master. Thanks for the contribution. This i

[GitHub] [logging-log4net] Laxo908 opened a new pull request #53: LoggingEvent: repository properties get added to the composite properites

2019-10-23 Thread GitBox
Laxo908 opened a new pull request #53: LoggingEvent: repository properties get added to the composite properites URL: https://github.com/apache/logging-log4net/pull/53 Just added a few lines of code to complete this TODO. The properties of the repository are now added to the aggregated pro

[GitHub] [logging-log4php] kategray commented on issue #2: Improve documentation of filters

2019-10-26 Thread GitBox
kategray commented on issue #2: Improve documentation of filters URL: https://github.com/apache/logging-log4php/pull/2#issuecomment-546642157 @ihabunek were you ever able to look at this pull request? I'm interested in contributing, and trying to figure out who would be responsible for the

[GitHub] [logging-log4php] kategray opened a new pull request #22: Update travis configuration and PHPUnit version

2019-10-26 Thread GitBox
kategray opened a new pull request #22: Update travis configuration and PHPUnit version URL: https://github.com/apache/logging-log4php/pull/22 The travis builds were breaking, in part due to old PHP versions. This pull request updates the travis configuration to newer PHP versions,

[GitHub] [logging-log4php] rgoers merged pull request #2: Improve documentation of filters

2019-10-28 Thread GitBox
rgoers merged pull request #2: Improve documentation of filters URL: https://github.com/apache/logging-log4php/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4php] rgoers commented on issue #2: Improve documentation of filters

2019-10-28 Thread GitBox
rgoers commented on issue #2: Improve documentation of filters URL: https://github.com/apache/logging-log4php/pull/2#issuecomment-547136597 I've looked at these. They all are for documentation so shouldn't cause any problems.

[GitHub] [logging-log4php] rgoers merged pull request #22: Update travis configuration and PHPUnit version

2019-10-28 Thread GitBox
rgoers merged pull request #22: Update travis configuration and PHPUnit version URL: https://github.com/apache/logging-log4php/pull/22 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4php] kategray commented on issue #5: typo fixes

2019-10-28 Thread GitBox
kategray commented on issue #5: typo fixes URL: https://github.com/apache/logging-log4php/pull/5#issuecomment-547168971 @rgoers There doesn't appear to be any code issues with this commit - it's just fixing typos. Travis failed because builds are failing. -

[GitHub] [logging-log4php] kategray commented on issue #14: Replaced the deprecated function split() that will be removed in PHP 7.

2019-10-28 Thread GitBox
kategray commented on issue #14: Replaced the deprecated function split() that will be removed in PHP 7. URL: https://github.com/apache/logging-log4php/pull/14#issuecomment-547169255 @rgoers Single line fix, in line with the PHP5 deprecation. ---

[GitHub] [logging-log4php] kategray commented on issue #15: Support logging of PHP 7 error class

2019-10-28 Thread GitBox
kategray commented on issue #15: Support logging of PHP 7 error class URL: https://github.com/apache/logging-log4php/pull/15#issuecomment-547171368 @rgoers my recommendation would be to close this issue as resolved, unless @czjvic's issue specifically requires not checking the type of the e

[GitHub] [logging-log4php] kategray edited a comment on issue #14: Replaced the deprecated function split() that will be removed in PHP 7.

2019-10-28 Thread GitBox
kategray edited a comment on issue #14: Replaced the deprecated function split() that will be removed in PHP 7. URL: https://github.com/apache/logging-log4php/pull/14#issuecomment-547169255 @rgoers Single line fix, in line with the PHP5 deprecation. I'd suggest approval.

[GitHub] [logging-log4php] kategray commented on issue #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
kategray commented on issue #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11#issuecomment-547173236 @rgoers it looks like this was already approved and merged - I'd imagine the PR can be closed. -

[GitHub] [logging-log4php] kategray commented on issue #13: tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path

2019-10-28 Thread GitBox
kategray commented on issue #13: tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path URL: https://github.com/apache/logging-log4php/pull/13#issuecomment-547175609 @rgoers Like the other commit, looks good in theory, but I'd like to get a un

[GitHub] [logging-log4php] kategray commented on issue #3: Add a new filter that matches against a logger name

2019-10-28 Thread GitBox
kategray commented on issue #3: Add a new filter that matches against a logger name URL: https://github.com/apache/logging-log4php/pull/3#issuecomment-547178213 @creature Hello, I'm going through old commits and trying to get everything merged. Would you be able to update the reque

[GitHub] [logging-log4php] rgoers commented on issue #5: typo fixes

2019-10-28 Thread GitBox
rgoers commented on issue #5: typo fixes URL: https://github.com/apache/logging-log4php/pull/5#issuecomment-547251446 Merging based no review feedback This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4php] rgoers merged pull request #5: typo fixes

2019-10-28 Thread GitBox
rgoers merged pull request #5: typo fixes URL: https://github.com/apache/logging-log4php/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [logging-log4php] rgoers merged pull request #14: Replaced the deprecated function split() that will be removed in PHP 7.

2019-10-28 Thread GitBox
rgoers merged pull request #14: Replaced the deprecated function split() that will be removed in PHP 7. URL: https://github.com/apache/logging-log4php/pull/14 This is an automated message from the Apache Git Service. To resp

[GitHub] [logging-log4php] rgoers commented on issue #14: Replaced the deprecated function split() that will be removed in PHP 7.

2019-10-28 Thread GitBox
rgoers commented on issue #14: Replaced the deprecated function split() that will be removed in PHP 7. URL: https://github.com/apache/logging-log4php/pull/14#issuecomment-547251617 Merging based on feedback This is an automat

[GitHub] [logging-log4php] rgoers commented on issue #7: Fix mismatched function signature and function call

2019-10-28 Thread GitBox
rgoers commented on issue #7: Fix mismatched function signature and function call URL: https://github.com/apache/logging-log4php/pull/7#issuecomment-547251946 It appears this was already merged. It would have been prior to the migration to GitHub. Closing based on that. --

[GitHub] [logging-log4php] rgoers closed pull request #7: Fix mismatched function signature and function call

2019-10-28 Thread GitBox
rgoers closed pull request #7: Fix mismatched function signature and function call URL: https://github.com/apache/logging-log4php/pull/7 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [logging-log4php] rgoers commented on issue #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
rgoers commented on issue #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11#issuecomment-547252097 I agree. Closing. This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4php] rgoers closed pull request #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
rgoers closed pull request #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4php] rgoers commented on issue #15: Support logging of PHP 7 error class

2019-10-28 Thread GitBox
rgoers commented on issue #15: Support logging of PHP 7 error class URL: https://github.com/apache/logging-log4php/pull/15#issuecomment-547252569 Leaving open for now pending feedback. This is an automated message from the Apa

[GitHub] [logging-log4php] rgoers commented on issue #12: add throwable information to xml layout if present

2019-10-28 Thread GitBox
rgoers commented on issue #12: add throwable information to xml layout if present URL: https://github.com/apache/logging-log4php/pull/12#issuecomment-547252755 OK. Got ahead and create the unit test. This is an automated mess

[GitHub] [logging-log4php] rgoers commented on issue #13: tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path

2019-10-28 Thread GitBox
rgoers commented on issue #13: tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path URL: https://github.com/apache/logging-log4php/pull/13#issuecomment-547252891 OK. Please go ahead with that.

[GitHub] [logging-log4php] d-ulyanov commented on issue #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
d-ulyanov commented on issue #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11#issuecomment-547282930 Funny, I thought that project is dead :) This is an automated message from the Apac

[GitHub] [logging-log4php] kategray removed a comment on issue #3: Add a new filter that matches against a logger name

2019-10-28 Thread GitBox
kategray removed a comment on issue #3: Add a new filter that matches against a logger name URL: https://github.com/apache/logging-log4php/pull/3#issuecomment-547178213 @creature Hello, I'm going through old commits and trying to get everything merged. Would you be able to update t

[GitHub] [logging-log4php] kategray commented on issue #3: Add a new filter that matches against a logger name

2019-10-28 Thread GitBox
kategray commented on issue #3: Add a new filter that matches against a logger name URL: https://github.com/apache/logging-log4php/pull/3#issuecomment-547283004 @rgoers I have created a merge branch that incorporates these changes into the develop branch. If you edit the pull reques

[GitHub] [logging-log4php] kategray commented on issue #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
kategray commented on issue #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11#issuecomment-547283588 @d-ulyanov It could use some love. I'm working on it :) This is an automated messag

[GitHub] [logging-log4php] kategray opened a new pull request #23: Update documentation

2019-10-29 Thread GitBox
kategray opened a new pull request #23: Update documentation URL: https://github.com/apache/logging-log4php/pull/23 - Update mailing list information - Update signatures to use SHA512 - Update URLs to use HTTPS - Update code example to avoid issue with duplicate class loading (for

[GitHub] [logging-log4php] jvz merged pull request #23: Update documentation

2019-10-30 Thread GitBox
jvz merged pull request #23: Update documentation URL: https://github.com/apache/logging-log4php/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [logging-log4j-scala] sullis commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668]

2019-10-30 Thread GitBox
sullis commented on issue #3: add support for scala 2.13.0 [LOG4J2-2668] URL: https://github.com/apache/logging-log4j-scala/pull/3#issuecomment-548159157 can you change '2.13.0' to '2.13.1' 🔢 This is an automated messag

[GitHub] [logging-log4j-audit] dependabot[bot] opened a new pull request #21: Bump jackson.version from 2.8.5 to 2.10.0

2019-11-01 Thread GitBox
dependabot[bot] opened a new pull request #21: Bump jackson.version from 2.8.5 to 2.10.0 URL: https://github.com/apache/logging-log4j-audit/pull/21 Bumps `jackson.version` from 2.8.5 to 2.10.0. Updates `jackson-core` from 2.8.5 to 2.10.0 Commits - [`2ce8890`](https://g

[GitHub] [logging-log4j2] qxo opened a new pull request #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-11 Thread GitBox
qxo opened a new pull request #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312 so that `logStdoutPattern:-%d{MMdd HH:mm:ss} %-5p %c{20}:%L - %m%n` will be ok by change variableResolverPr

[GitHub] [logging-log4j2] rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-11 Thread GitBox
rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-552485250 What problem is this solving? Is there a Jira issue? -

[GitHub] [logging-log4j2] qxo commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-12 Thread GitBox
qxo commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-552949253 > What problem is this solving? Is there a Jira issue? ``` ${logStdoutPattern:-%d{MMdd HH

[GitHub] [logging-log4j2] qxo edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-12 Thread GitBox
qxo edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-552949253 > What problem is this solving? Is there a Jira issue? There no Jira issue yet, Or please

[GitHub] [logging-log4j2] rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-12 Thread GitBox
rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-552971906 I still don't understand. Did you create a Lookup named logStdoutPattern? Where is the code for

[GitHub] [logging-log4j2] rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-12 Thread GitBox
rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-552971906 I still don't understand. Did you create a Lookup named logStdoutPattern? Where is the c

[GitHub] [logging-log4j-audit] dependabot[bot] opened a new pull request #22: Bump jackson.version from 2.8.5 to 2.10.1

2019-11-12 Thread GitBox
dependabot[bot] opened a new pull request #22: Bump jackson.version from 2.8.5 to 2.10.1 URL: https://github.com/apache/logging-log4j-audit/pull/22 Bumps `jackson.version` from 2.8.5 to 2.10.1. Updates `jackson-core` from 2.8.5 to 2.10.1 Commits - [`60956fc`](https://g

[GitHub] [logging-log4j-audit] dependabot[bot] closed pull request #21: Bump jackson.version from 2.8.5 to 2.10.0

2019-11-12 Thread GitBox
dependabot[bot] closed pull request #21: Bump jackson.version from 2.8.5 to 2.10.0 URL: https://github.com/apache/logging-log4j-audit/pull/21 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [logging-log4j-audit] dependabot[bot] commented on issue #21: Bump jackson.version from 2.8.5 to 2.10.0

2019-11-12 Thread GitBox
dependabot[bot] commented on issue #21: Bump jackson.version from 2.8.5 to 2.10.0 URL: https://github.com/apache/logging-log4j-audit/pull/21#issuecomment-553197658 Superseded by #22. This is an automated message from the Apa

[GitHub] [logging-log4j2] qxo commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-13 Thread GitBox
qxo commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-553442728 It's for log4j2 config file, such as log4j2.properties, log4j2.json or log4j.yaml before this P

[GitHub] [logging-log4j2] rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-13 Thread GitBox
rgoers commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-553460696 You are still not answering the question! Why is it necessary to change the suffix and prefix?

[GitHub] [logging-log4j2] rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-13 Thread GitBox
rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-553460696 You are still not answering the question! Why is it necessary to change the suffix and p

[GitHub] [logging-log4j2] rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-13 Thread GitBox
rgoers edited a comment on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-553460696 You are still not answering the question! Why is it necessary to change the suffix and p

[GitHub] [logging-log4j2] qxo commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable

2019-11-13 Thread GitBox
qxo commented on issue #312: make variableResolverPrefix/variableResolverSuffix/variableResolverEscape configable URL: https://github.com/apache/logging-log4j2/pull/312#issuecomment-553691818 Sorry for my poor english, and I have no time ... Please try add "appender.console.layout.patt

[GitHub] [logging-log4net] Laxo908 commented on issue #53: LoggingEvent: repository properties get added to the composite properites

2019-11-14 Thread GitBox
Laxo908 commented on issue #53: LoggingEvent: repository properties get added to the composite properites URL: https://github.com/apache/logging-log4net/pull/53#issuecomment-553798699 It seems like Nant fails to build the commit. But I do not have any idea why.

[GitHub] [logging-log4j2] cykl opened a new pull request #313: [LOG4J2-2727] Add KafkaAppender.Builder#setKey

2019-11-18 Thread GitBox
cykl opened a new pull request #313: [LOG4J2-2727] Add KafkaAppender.Builder#setKey URL: https://github.com/apache/logging-log4j2/pull/313 self-explanatory, see https://issues.apache.org/jira/browse/LOG4J2-2727 This is an aut

[GitHub] [logging-log4j2] supertomcat opened a new pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-20 Thread GitBox
supertomcat opened a new pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314 LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC address is longer than 6 bytes https://issues.apach

[GitHub] [logging-log4j2] garydgregory commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-20 Thread GitBox
garydgregory commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314#issuecomment-556673308 You'll need some kind of unit test to show what was broken and is now fixed. --

[GitHub] [logging-log4j2] supertomcat commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-20 Thread GitBox
supertomcat commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314#issuecomment-556832195 > > > You'll need some kind of unit test to show what was broken and is now fixed. I'd lo

[GitHub] [logging-log4j2] rgoers commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-20 Thread GitBox
rgoers commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314#issuecomment-556911201 I will review this in the next few days. Thi

[GitHub] [logging-log4j2] garydgregory commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

2019-11-21 Thread GitBox
garydgregory commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add… URL: https://github.com/apache/logging-log4j2/pull/314#issuecomment-557157810 > I'd love to provide one, but I wouldn't know how. Simple: Refactor the static initializer into

[GitHub] [logging-log4j2] joongs4 opened a new pull request #315: added retry count if failed to send

2019-11-21 Thread GitBox
joongs4 opened a new pull request #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315 In my system, there is Kafka only for logging but as Kafka is not yet completely installed, it often crashes. If Kafka is down, an application gets blocked. I

<    19   20   21   22   23   24   25   26   27   28   >