rgoers merged pull request #289: LOG4J2-2644 - Improve performance of getting
location info
URL: https://github.com/apache/logging-log4j2/pull/289
This is an automated message from the Apache Git Service.
To respond to the m
rgoers merged pull request #288: Log4 j2 2644 for release-2.x
URL: https://github.com/apache/logging-log4j2/pull/288
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Mhhli opened a new pull request #291: [LOG4J2-2604/2649] Change MethodHandle to
Constructor to adapt graalvm
URL: https://github.com/apache/logging-log4j2/pull/291
See https://issues.apache.org/jira/browse/LOG4J2-2649
https://issues.apache.org/jira/browse/LOG4J2-2604
Log4j2 c
Mhhli commented on issue #291: [LOG4J2-2604/2649] Change MethodHandle to
Constructor to adapt graalvm
URL: https://github.com/apache/logging-log4j2/pull/291#issuecomment-509950502
The pom.xml of log4j-api-java9 hased change jdk9 to jdk11, but the
.travis.yml has not changed for jdk11
remkop commented on issue #291: [LOG4J2-2604/2649] Change MethodHandle to
Constructor to adapt graalvm
URL: https://github.com/apache/logging-log4j2/pull/291#issuecomment-509961300
I don't disagree with these changes, but please do 2 things:
* respect the spacing of the original file: sp
Mhhli commented on issue #291: [LOG4J2-2604/2649] Change MethodHandle to
Constructor to adapt graalvm
URL: https://github.com/apache/logging-log4j2/pull/291#issuecomment-509979068
> I don't disagree with these changes, but please do 2 things:
>
> * respect the spacing of the original
remkop commented on issue #291: [LOG4J2-2604/2649] Change MethodHandle to
Constructor to adapt graalvm
URL: https://github.com/apache/logging-log4j2/pull/291#issuecomment-509985705
Thanks for changing the whitespace. About the reason for the changes, I
understand the background.
Wh
Mhhli commented on issue #291: [LOG4J2-2604/2649] Change MethodHandle to
Constructor to adapt graalvm
URL: https://github.com/apache/logging-log4j2/pull/291#issuecomment-510004310
> Thanks for changing the whitespace. About the reason for the changes, I
understand the background.
>
akrikheli opened a new pull request #292: Add support of
ignoreKafkaConnectionError flag
URL: https://github.com/apache/logging-log4j2/pull/292
See https://issues.apache.org/jira/browse/LOG4J2-2656
This is an automated messag
carterkozak opened a new pull request #293: LOG4J2-2658:
AbstractAction.reportException records a warning to the status logger
URL: https://github.com/apache/logging-log4j2/pull/293
This is an automated message from the Apac
carterkozak opened a new pull request #294: LOG4J2-2658:
AbstractAction.reportException records a warning to the status logger
URL: https://github.com/apache/logging-log4j2/pull/294
This is an automated message from the Apac
carterkozak opened a new pull request #295: Update Travis configuration to use
java11
URL: https://github.com/apache/logging-log4j2/pull/295
This is an automated message from the Apache Git Service.
To respond to the message
carterkozak merged pull request #293: LOG4J2-2658:
AbstractAction.reportException records a warning to the status logger
URL: https://github.com/apache/logging-log4j2/pull/293
This is an automated message from the Apache Git
carterkozak merged pull request #294: LOG4J2-2658:
AbstractAction.reportException records a warning to the status logger
URL: https://github.com/apache/logging-log4j2/pull/294
This is an automated message from the Apache Git
carterkozak opened a new pull request #296: LOG4J2-2659: AbstractAction handles
unchecked RuntimeException and Error
URL: https://github.com/apache/logging-log4j2/pull/296
This is an automated message from the Apache Git Ser
carterkozak opened a new pull request #297: LOG4J2-2659: AbstractAction handles
unchecked RuntimeException and Error
URL: https://github.com/apache/logging-log4j2/pull/297
This is an automated message from the Apache Git Ser
carterkozak merged pull request #297: LOG4J2-2659: AbstractAction handles
unchecked RuntimeException and Error
URL: https://github.com/apache/logging-log4j2/pull/297
This is an automated message from the Apache Git Service.
carterkozak merged pull request #296: LOG4J2-2659: AbstractAction handles
unchecked RuntimeException and Error
URL: https://github.com/apache/logging-log4j2/pull/296
This is an automated message from the Apache Git Service.
carterkozak closed pull request #295: Update Travis configuration to use java11
URL: https://github.com/apache/logging-log4j2/pull/295
This is an automated message from the Apache Git Service.
To respond to the message, pleas
garydgregory commented on issue #290: [LOG4J2-2650] Fix
ArrayIndexOutOfBoundsException when the mac variable is an ipv6
URL: https://github.com/apache/logging-log4j2/pull/290#issuecomment-513500470
Where are we on this?
This
rgoers commented on issue #290: [LOG4J2-2650] Fix
ArrayIndexOutOfBoundsException when the mac variable is an ipv6
URL: https://github.com/apache/logging-log4j2/pull/290#issuecomment-513502453
Thanks for the nudge. I meant to re-review this and life got in the way.
-
emopers opened a new pull request #298: Synchronize before looping over
synchronized collection
URL: https://github.com/apache/logging-log4j2/pull/298
In StatusConfiguration.java, `errorMessages =
Collections.synchronizedCollection(new LinkedList())` is iterated over
without synchronizati
rgoers commented on issue #292: LOG4J2-2656: Add support of
ignoreKafkaConnectionError flag
URL: https://github.com/apache/logging-log4j2/pull/292#issuecomment-513823442
I am continuing to think about this as I am not sure if this is the right
way to fix the problem.
-
carterkozak commented on issue #292: LOG4J2-2656: Add support of
ignoreKafkaConnectionError flag
URL: https://github.com/apache/logging-log4j2/pull/292#issuecomment-513832609
It feels a bit odd for the Kafka appender to work differently from other
appenders when creation fails. I wonder if
rgoers commented on issue #292: LOG4J2-2656: Add support of
ignoreKafkaConnectionError flag
URL: https://github.com/apache/logging-log4j2/pull/292#issuecomment-513864473
@carterkozak The AppenderControl already wraps Appenders to catch the
exceptions they throw. There is already a generic
carterkozak commented on issue #292: LOG4J2-2656: Add support of
ignoreKafkaConnectionError flag
URL: https://github.com/apache/logging-log4j2/pull/292#issuecomment-513866416
A workaround might be to use a RoutingAppender with a single default route
of the KafkaAppender defined in place. T
sullis opened a new pull request #2: Scala 2.13.0
URL: https://github.com/apache/logging-log4j-scala/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rgoers commented on issue #2: Scala 2.13.0
URL: https://github.com/apache/logging-log4j-scala/pull/2#issuecomment-514474132
No description and no Jira issue referenced?
This is an automated message from the Apache Git Service.
jvz commented on issue #2: Scala 2.13.0
URL: https://github.com/apache/logging-log4j-scala/pull/2#issuecomment-514638441
This was a todo item of mine that I hadn’t made a ticket for yet after the
release. This does need a ticket, though, before it can be merged.
On Tue, Jul 23, 201
AmlanAlok commented on issue #141: LOG4J2-2190 support writing JSON object in
message field
URL: https://github.com/apache/logging-log4j2/pull/141#issuecomment-514791035
> `layouts.xml.vm` is updated
Can someone please share the documentation link here.
-
rgoers merged pull request #290: [LOG4J2-2650] Fix
ArrayIndexOutOfBoundsException when the mac variable is an ipv6
URL: https://github.com/apache/logging-log4j2/pull/290
This is an automated message from the Apache Git Servi
rgoers commented on issue #298: Synchronize before looping over synchronized
collection
URL: https://github.com/apache/logging-log4j2/pull/298#issuecomment-515824261
Have you actually encountered a problem? If so, please file a Jira issue
with the stack trace. In reviewing the code all tha
rgoers edited a comment on issue #298: Synchronize before looping over
synchronized collection
URL: https://github.com/apache/logging-log4j2/pull/298#issuecomment-515824261
Have you actually encountered a problem? If so, please file a Jira issue
with the stack trace. In reviewing the code
rgoers closed pull request #107: Mark FileRenameAction as successful when using
alternative ways to mo…
URL: https://github.com/apache/logging-log4j2/pull/107
This is an automated message from the Apache Git Service.
To resp
rgoers commented on issue #107: Mark FileRenameAction as successful when using
alternative ways to mo…
URL: https://github.com/apache/logging-log4j2/pull/107#issuecomment-515825295
Closing this. Patch was already applied.
Thi
rgoers closed pull request #91: failing test - irregular log4j2.json nodes order
URL: https://github.com/apache/logging-log4j2/pull/91
This is an automated message from the Apache Git Service.
To respond to the message, pleas
rgoers commented on issue #91: failing test - irregular log4j2.json nodes order
URL: https://github.com/apache/logging-log4j2/pull/91#issuecomment-515825913
Closing this since it only provides a failing unit test, doesn't provide
code to fix it and the JSON in the test doesn't match our doc
rgoers commented on issue #47: Add tinylog benchmarks
URL: https://github.com/apache/logging-log4j2/pull/47#issuecomment-515830458
I've looked at this but I am not sure I see the point.
This is an automated message from the Ap
IgorPerelyotov opened a new pull request #299: [LOG4j2-1946] Fix problem with
purgeAscending if an old file was deleted
URL: https://github.com/apache/logging-log4j2/pull/299
I ran into the same problem as described in the ticket
https://issues.apache.org/jira/browse/LOG4J2-1946
There a
rgoers merged pull request #299: [LOG4j2-1946] Fix problem with purgeAscending
if an old file was deleted
URL: https://github.com/apache/logging-log4j2/pull/299
This is an automated message from the Apache Git Service.
To re
rgoers commented on issue #299: [LOG4j2-1946] Fix problem with purgeAscending
if an old file was deleted
URL: https://github.com/apache/logging-log4j2/pull/299#issuecomment-517344089
I tested these locally on release-2.x and verified the problem and the fix.
---
jvz commented on issue #2: [LOG4J2-2668] Add support for Scala 2.13.0
URL: https://github.com/apache/logging-log4j-scala/pull/2#issuecomment-517934811
Looks like this has a compilation error with the updated scalatest library?
qxo opened a new pull request #300: call #StatusLogger.getLogger() only when
it's needed.
URL: https://github.com/apache/logging-log4j2/pull/300
when Log4jWebSupport.IS_LOG4J_AUTO_INITIALIZATION_DISABLED=true should not
invoke #StatusLogger.getLogger() in Log4jServletContainerInitializer
greggdonovan opened a new pull request #301: LOG4J-2676: Backport use of
javax.annotation.processing.Messager to release-2.x.
URL: https://github.com/apache/logging-log4j2/pull/301
Add a test for Bazel support for the PluginProcessor, which does not work on
2.12.1 due to System.out calls,
bmuskalla opened a new pull request #303: Fixed typos on main site
URL: https://github.com/apache/logging-log4j2/pull/303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
hurtadogx opened a new pull request #304: Fix LOG4J2-2680: Not compressing
after rolling a file using copy and …
URL: https://github.com/apache/logging-log4j2/pull/304
…truncation
This fix set to true the return value of "execute" method in
"FileRenameAction" class, after successful
gaurav9822 opened a new pull request #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305
This is an automated message from the Apache Git Service.
To respond to the message, please lo
garydgregory commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to
Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-526413637
Should this really be optional? Why not just send the timestamp all the
time? That would be simpler IMO.
---
fedexist commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka
ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-526512809
>
>
> Should this really be optional? Why not just send the timestamp all the
time? That would be simpler IMO
vimalaguti opened a new pull request #3: add support for scala 2.13.0
[LOG4J2-2668]
URL: https://github.com/apache/logging-log4j-scala/pull/3
hi, some dependencies has been updated, both for junit test to compile and
to clean some deprecation in 2.13
feel free to modify as you wish
jvz commented on a change in pull request #3: add support for scala 2.13.0
[LOG4J2-2668]
URL: https://github.com/apache/logging-log4j-scala/pull/3#discussion_r319626087
##
File path:
src/main/scala-2.13+/org/apache/logging/log4j/scala/LoggingContext.scala
##
@@ -0,0 +1,75
vimalaguti commented on a change in pull request #3: add support for scala
2.13.0 [LOG4J2-2668]
URL: https://github.com/apache/logging-log4j-scala/pull/3#discussion_r319631658
##
File path:
src/main/scala-2.13+/org/apache/logging/log4j/scala/LoggingContext.scala
##
@@ -0,
vimalaguti commented on a change in pull request #3: add support for scala
2.13.0 [LOG4J2-2668]
URL: https://github.com/apache/logging-log4j-scala/pull/3#discussion_r319631658
##
File path:
src/main/scala-2.13+/org/apache/logging/log4j/scala/LoggingContext.scala
##
@@ -0,
IgorPerelyotov opened a new pull request #307: [LOG4J2-2652] JSON output wrong
when using additonal fields
URL: https://github.com/apache/logging-log4j2/pull/307
Fix and tests for the issue
https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2652
The cause of the issue is:
garydgregory commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to
Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-526962099
Unless this will break existing apps, I say we make it optional.
rgoers commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka
ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-526979931
@garydgregory How could making it optional possibly break existing apps?
Making it optional would be done to preserve t
rgoers edited a comment on issue #306: [LOG4J2-2678] Add LogEvent timestamp to
Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-526979931
@garydgregory How could making it optional possibly break existing apps?
Making it optional would be done to pre
garydgregory commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to
Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-527129640
I was asking the OP how it could break, since that person might have
domain-specific knowledge I am not aware of.
fedexist commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka
ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-527152446
I honestly wouldn't know whether there's any _actual_ use case where the
producer timestamp (i.e. the current behavio
fedexist edited a comment on issue #306: [LOG4J2-2678] Add LogEvent timestamp
to Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-527152446
I honestly wouldn't know whether there's any _actual_ use case where the
producer timestamp (i.e. the current
jvz commented on issue #307: [LOG4J2-2652] JSON output wrong when using
additonal fields
URL: https://github.com/apache/logging-log4j2/pull/307#issuecomment-527251506
If you rebase from master, you should get a working Travis config to test
this.
--
jvz commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka
ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-527251648
If you rebase from master, you should get a working Travis config to test
this.
As for the use case, making the eve
jvz commented on a change in pull request #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#discussion_r320051471
##
File path: src/site/asciidoc/index.adoc.rej
##
@@ -0,0 +1,21 @@
+diff a/src/site/asciidoc/index.adoc b/src/site/a
jvz commented on a change in pull request #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#discussion_r320051451
##
File path: mypatch.patch
##
@@ -0,0 +1,1081 @@
+diff --git
a/log4j-core/src/main/java/org/apache/logging/log4j/c
jvz commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka
ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-527602651
Seems like you broke the history somehow. Can you try using `git pull
--rebase origin/master`?
--
jvz edited a comment on issue #306: [LOG4J2-2678] Add LogEvent timestamp to
Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-527602651
Seems like you broke the history somehow. Can you try using `git pull
--rebase origin/master`?
Note that CI
jvz commented on issue #291: [LOG4J2-2604/2649] Change MethodHandle to
Constructor to adapt graalvm
URL: https://github.com/apache/logging-log4j2/pull/291#issuecomment-527610864
Ugh, and the API for MethodHandle is so much nicer than the reflection API
for these sorts of things. Does the J
jvz closed pull request #178: Use Travis CI configuration from master
URL: https://github.com/apache/logging-log4j2/pull/178
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
jvz commented on issue #178: Use Travis CI configuration from master
URL: https://github.com/apache/logging-log4j2/pull/178#issuecomment-527611316
The travis config has been updated again on master and release-2.x. I don't
think this is necessary anymore.
--
willdieh opened a new pull request #308: LOG4J2-1192 (support dynamic Subject)
URL: https://github.com/apache/logging-log4j2/pull/308
Edit sendMultipartMessage() to accept dynamic email Subject per comments
made in ticket LOG4J2-1192 by Harry Bawls
-
jvz commented on a change in pull request #158: [LOG4J2-2280] Introduce an
Apache Pulsar log4j appender
URL: https://github.com/apache/logging-log4j2/pull/158#discussion_r320450955
##
File path:
log4j-pulsar/src/main/java/org/apache/logging/log4j/pulsar/appender/PulsarManager.java
jvz commented on a change in pull request #158: [LOG4J2-2280] Introduce an
Apache Pulsar log4j appender
URL: https://github.com/apache/logging-log4j2/pull/158#discussion_r320450043
##
File path:
log4j-pulsar/src/main/java/org/apache/logging/log4j/pulsar/appender/PulsarAppender.java
jvz commented on a change in pull request #158: [LOG4J2-2280] Introduce an
Apache Pulsar log4j appender
URL: https://github.com/apache/logging-log4j2/pull/158#discussion_r320451657
##
File path:
log4j-pulsar/src/main/java/org/apache/logging/log4j/pulsar/appender/PulsarAppender.java
jvz commented on a change in pull request #158: [LOG4J2-2280] Introduce an
Apache Pulsar log4j appender
URL: https://github.com/apache/logging-log4j2/pull/158#discussion_r320448698
##
File path: log4j-pulsar/pom.xml
##
@@ -0,0 +1,176 @@
+
+
+http://maven.apache.org/POM/4.0
jvz commented on a change in pull request #287: adding support for session
attributes in log4j-web
URL: https://github.com/apache/logging-log4j2/pull/287#discussion_r320454341
##
File path: log4j-web/src/main/java/org/apache/logging/log4j/web/WebLookup.java
##
@@ -91,6 +93
fedexist commented on issue #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka
ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#issuecomment-527624332
>
>
> Seems like you broke the history somehow. Can you try using `git pull
--rebase origin/master`?
>
jvz commented on a change in pull request #158: [LOG4J2-2280] Introduce an
Apache Pulsar log4j appender
URL: https://github.com/apache/logging-log4j2/pull/158#discussion_r320487933
##
File path:
log4j-pulsar/src/main/java/org/apache/logging/log4j/pulsar/appender/PulsarAppender.java
sijie commented on a change in pull request #158: [LOG4J2-2280] Introduce an
Apache Pulsar log4j appender
URL: https://github.com/apache/logging-log4j2/pull/158#discussion_r320509537
##
File path:
log4j-pulsar/src/main/java/org/apache/logging/log4j/pulsar/appender/PulsarAppender.ja
rgoers commented on issue #158: [LOG4J2-2280] Introduce an Apache Pulsar log4j
appender
URL: https://github.com/apache/logging-log4j2/pull/158#issuecomment-527709765
My only concern is whether we really want this in the main log4j build.
Especially in 3.0 we could break a lot of the "extra
rmannibucau commented on issue #287: [LOG4J2-2688] adding support for session
attributes in log4j-web
URL: https://github.com/apache/logging-log4j2/pull/287#issuecomment-527800377
Sure, created LOG4J2-2688
This is an automate
rmannibucau commented on a change in pull request #287: [LOG4J2-2688] adding
support for session attributes in log4j-web
URL: https://github.com/apache/logging-log4j2/pull/287#discussion_r320635765
##
File path: log4j-web/src/main/java/org/apache/logging/log4j/web/WebLookup.java
##
qxo commented on issue #300: call #StatusLogger.getLogger() only when it's
needed.
URL: https://github.com/apache/logging-log4j2/pull/300#issuecomment-528440458
> This change looks fine to me. Are there any specific startup scenarios you
came across that warrants this?
>
> Edit: I s
garydgregory commented on a change in pull request #306: [LOG4J2-2678] Add
LogEvent timestamp to Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#discussion_r321844534
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAp
fedexist commented on a change in pull request #306: [LOG4J2-2678] Add LogEvent
timestamp to Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#discussion_r321860994
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppend
0xbad0c0d3 opened a new pull request #21: Accept Throwable interface instead of
its realization
URL: https://github.com/apache/logging-log4php/pull/21
This is an automated message from the Apache Git Service.
To respond to t
jvz merged pull request #21: Accept Throwable interface instead of its
realization
URL: https://github.com/apache/logging-log4php/pull/21
This is an automated message from the Apache Git Service.
To respond to the message, p
s50600822 opened a new pull request #309: broken link on
https://logging.apache.org/log4j/2.x/manual/thread-con…
URL: https://github.com/apache/logging-log4j2/pull/309
https://logging.apache.org/log4j/2.x/manual/thread-context.html's
```Including the ThreadContext when writing logs``` has
rgoers closed pull request #309: broken link on
https://logging.apache.org/log4j/2.x/manual/thread-con…
URL: https://github.com/apache/logging-log4j2/pull/309
This is an automated message from the Apache Git Service.
To resp
rgoers commented on issue #309: broken link on
https://logging.apache.org/log4j/2.x/manual/thread-con…
URL: https://github.com/apache/logging-log4j2/pull/309#issuecomment-531501322
Thanks for letting us know. I corrected the web site, master and release-2.x
branches. I didn't commit your p
rgoers merged pull request #303: Fixed typos on main site
URL: https://github.com/apache/logging-log4j2/pull/303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rgoers commented on issue #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#issuecomment-531502106
Wow. It must have taken some time to find and correct all of these. Thanks.
However, this fixes the master branch, which is still a work in progress
rgoers merged pull request #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
rgoers merged pull request #304: Fix LOG4J2-2680: Not compressing after rolling
a file using copy and …
URL: https://github.com/apache/logging-log4j2/pull/304
This is an automated message from the Apache Git Service.
To resp
gaurav9822 commented on issue #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#issuecomment-531535740
@rgoers Thank you for the kind words. Would love to contribute more to
log4j2.
pzygielo commented on issue #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#issuecomment-531535928
> Would love to contribute more to log4j2.
Could you provide PR to remove those new files @jvz had questions about?
---
rgoers commented on issue #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#issuecomment-531536469
@pzygielo No, because I have no idea what Matt was concerned about. There is
no reason he would want Layout.java to be removed.
---
pzygielo commented on issue #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#issuecomment-531536575
> @pzygielo No, because I have no idea what Matt was concerned about. There
is no reason he would want Layout.java to be removed.
* mypatc
pzygielo edited a comment on issue #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#issuecomment-531535928
> Would love to contribute more to log4j2.
Could you provide PR to remove those **new files** @jvz had questions about?
pzygielo opened a new pull request #310: (doc) cleanup after #305
URL: https://github.com/apache/logging-log4j2/pull/310
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
rgoers commented on issue #305: (doc) Fix typos in documentation
URL: https://github.com/apache/logging-log4j2/pull/305#issuecomment-531537017
Thanks, I have removed them.
This is an automated message from the Apache Git Servi
2201 - 2300 of 7264 matches
Mail list logo
