garydgregory commented on issue #215: LOG4J2-2427 log4j2 filter for logs with
no markers
URL: https://github.com/apache/logging-log4j2/pull/215#issuecomment-503508172
Hi All,
I think NullFilterMarker would be a better class name.
Gary
On Tue, Jun 18, 2019, 23:58 Ralph G
rgoers commented on issue #215: LOG4J2-2427 log4j2 filter for logs with no
markers
URL: https://github.com/apache/logging-log4j2/pull/215#issuecomment-503533646
I have to disagree. NullFilterMarker sounds like it somehow is a marker that
represents a null filter, whatever that is, whereas
carterkozak commented on issue #215: LOG4J2-2427 log4j2 filter for logs with no
markers
URL: https://github.com/apache/logging-log4j2/pull/215#issuecomment-503542999
Agreed, I could see a case for `NullMarkerFilter` over `NullFilterMarker`,
but I think the current name `NoMarkerFilter` mak
rgoers commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of
a RollingFileAppender
URL: https://github.com/apache/logging-log4j2/pull/224#issuecomment-503605791
After looking at the doc I agree this is the better option. Can you also
create a PR for the release-2.x br
hupfdule opened a new pull request #281: Log4 j2 2403 zero pad counter in
pattern release 2.x
URL: https://github.com/apache/logging-log4j2/pull/281
This patch introduces the possibility to use zero-padding for the counter in
the RollingFileAppender and therefore fixes the issue LOG4J2-240
hupfdule commented on issue #224: [LOG4J2-2403] Allow zero padding the counter
of a RollingFileAppender
URL: https://github.com/apache/logging-log4j2/pull/224#issuecomment-503986191
Done: [#281](https://github.com/apache/logging-log4j2/pull/281)
However, the documentation changes ar
carterkozak opened a new pull request #282: Break up large AsyncLogger methods
for inlining
URL: https://github.com/apache/logging-log4j2/pull/282
This is an automated message from the Apache Git Service.
To respond to the m
carterkozak commented on issue #282: Break up large AsyncLogger methods for
inlining
URL: https://github.com/apache/logging-log4j2/pull/282#issuecomment-503987669
@rgoers could you provide guidance on whether I should add a changelog
and/or jira ticket for this sort of thing? Thanks!
rgoers commented on issue #282: Break up large AsyncLogger methods for inlining
URL: https://github.com/apache/logging-log4j2/pull/282#issuecomment-504000217
Yes, you should create a Jira and a changelog.
This is an automated
rgoers merged pull request #224: [LOG4J2-2403] Allow zero padding the counter
of a RollingFileAppender
URL: https://github.com/apache/logging-log4j2/pull/224
This is an automated message from the Apache Git Service.
To res
rgoers merged pull request #281: Log4 j2 2403 zero pad counter in pattern
release 2.x
URL: https://github.com/apache/logging-log4j2/pull/281
This is an automated message from the Apache Git Service.
To respond to the message
rgoers closed pull request #280: [LOG4J2-2403] Allow zero padding of integer
values
URL: https://github.com/apache/logging-log4j2/pull/280
This is an automated message from the Apache Git Service.
To respond to the message,
rgoers commented on issue #280: [LOG4J2-2403] Allow zero padding of integer
values
URL: https://github.com/apache/logging-log4j2/pull/280#issuecomment-504067372
Closing this PR since the original PR was applied.
This is an au
carterkozak merged pull request #282: LOG4J2-2634: Break up large AsyncLogger
methods for inlining
URL: https://github.com/apache/logging-log4j2/pull/282
This is an automated message from the Apache Git Service.
To respond t
fgunbin opened a new pull request #283: LOG4J-2635: Fix java.version check in
ThreadNameCachingStrategy
URL: https://github.com/apache/logging-log4j2/pull/283
This is an automated message from the Apache Git Service.
To resp
fgunbin commented on issue #283: LOG4J-2635: Fix java.version check in
ThreadNameCachingStrategy
URL: https://github.com/apache/logging-log4j2/pull/283#issuecomment-504364852
@garydgregory No problem, though I viewed duplication in test file as a kind
of test that strings are right.
Add
remkop commented on issue #283: LOG4J-2635: Fix java.version check in
ThreadNameCachingStrategy
URL: https://github.com/apache/logging-log4j2/pull/283#issuecomment-504383978
@fgunbin if these are only locally used I would prefer not to define them in
`Constants` but just define them locall
carterkozak commented on issue #283: LOG4J-2635: Fix java.version check in
ThreadNameCachingStrategy
URL: https://github.com/apache/logging-log4j2/pull/283#issuecomment-504390983
I think we can use the enum `name()` from `ThreadNameCachingStrategy`
instead of defining new constants.
-
remkop commented on issue #283: LOG4J-2635: Fix java.version check in
ThreadNameCachingStrategy
URL: https://github.com/apache/logging-log4j2/pull/283#issuecomment-504393658
Makes sense.
This is an automated message from the
fgunbin commented on issue #283: LOG4J-2635: Fix java.version check in
ThreadNameCachingStrategy
URL: https://github.com/apache/logging-log4j2/pull/283#issuecomment-504414546
Pushed the update, please check.
There's Travis failure somewhere in Log4j Sample Configuration Service
build,
rgoers commented on issue #25: LOG4J2-1301 added optionalMonitorFiles attribute
for automatic reconf…
URL: https://github.com/apache/logging-log4j2/pull/25#issuecomment-504451158
In light of LOG4J2-494 and LOG4J2-913 this PR now has conflicts that would
have to be resolved. This functional
rgoers opened a new pull request #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284
This PR adds methods to the Logger interface to construct and log an event
using builder methods. It also allows the loc
rgoers merged pull request #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
rgoers opened a new pull request #285: Revert "Update SLF4J to 1.7.26"
URL: https://github.com/apache/logging-log4j2/pull/285
Reverts apache/logging-log4j2#276
This is an automated message from the Apache Git Service.
To respo
rgoers commented on issue #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276#issuecomment-504705492
This had to be reverted as SLF4J 1.7.26 breaks binary compatibility.
This is an automated mes
rgoers merged pull request #285: Revert "Update SLF4J to 1.7.26"
URL: https://github.com/apache/logging-log4j2/pull/285
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow
logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296490927
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/Abstra
carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow
logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296490684
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/L
carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow
logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296490390
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/L
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296492446
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/LogBui
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296492524
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/LogBui
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296492581
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLog
rgoers commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-504775111
Calling log twice on the same LogBuilder would result in 2 identical log
messages, other than the timest
carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow
logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296492908
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/Abstra
carterkozak commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-504775782
> Calling log twice on the same LogBuilder would result in 2 identical log
messages, other than the
rgoers commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-504853947
@carterkozak I have updated the code based on your comments above.
-
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296555077
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLog
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296555203
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLog
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296563688
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLog
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296563809
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLog
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296563809
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLog
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296753242
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLog
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296923818
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296932718
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296967824
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296969800
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296969800
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297013479
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297013479
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297015735
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297013479
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
remkop commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297013479
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
carterkozak commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-505562983
I'm worried about memory leaks in calls that never invoke `log()`
```java
logger.info().me
carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow
logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297328839
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/D
carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow
logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297329768
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/D
carterkozak commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-505567514
This doesn't support filters which enable higher verbosity logging based on
the presence of a marke
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297343789
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
rgoers commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-505577467
There should be no risk of a memory leak if log() is not called. The
LogBuilders are owned by a thread l
rgoers edited a comment on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-505577467
There should be no risk of a memory leak if log() is not called. The
LogBuilders are owned by a t
rgoers commented on a change in pull request #284: LOG4J2-2639 - Allow logging
calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297346364
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/Defaul
carterkozak commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-505579381
> There should be no risk of a memory leak if log() is not called. The
LogBuilders are owned by a t
rgoers commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-505583234
As I said, the message and parameter are no longer stored in the builder, so
I really don't think there
martin-g commented on issue #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276#issuecomment-505606138
@rgoers Can you give me some link(s) to discussion about the issue with .26
? I cannot find anything in SLF4J's JIRA or GitHub
rgoers commented on issue #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276#issuecomment-505616954
I merged the PR and quickly remembered that we had tried to do it before and
couldn't because the build failed. Ceki removed the EventData class from
slf4j-e
rgoers edited a comment on issue #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276#issuecomment-505616954
I merged the PR and quickly remembered that we had tried to do it before and
couldn't because the build failed. Ceki removed the EventData class from
rgoers edited a comment on issue #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276#issuecomment-505616954
I merged the PR and quickly remembered that we had tried to do it before and
couldn't because the build failed. Ceki removed the EventData class from
rgoers edited a comment on issue #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276#issuecomment-505616954
I merged the PR and quickly remembered that we had tried to do it before and
couldn't because the build failed. Ceki removed the EventData class from
carterkozak opened a new pull request #286: ResolverUtilTest cleans up jars
when it's done
URL: https://github.com/apache/logging-log4j2/pull/286
This is an automated message from the Apache Git Service.
To respond to the me
carterkozak closed pull request #286: ResolverUtilTest cleans up jars when it's
done
URL: https://github.com/apache/logging-log4j2/pull/286
This is an automated message from the Apache Git Service.
To respond to the message,
carterkozak commented on issue #286: ResolverUtilTest cleans up jars when it's
done
URL: https://github.com/apache/logging-log4j2/pull/286#issuecomment-505660279
This shouldn't do anything given the CleanFolders rule
This is
garydgregory commented on issue #286: ResolverUtilTest cleans up jars when it's
done
URL: https://github.com/apache/logging-log4j2/pull/286#issuecomment-505662811
This patch still allows the following to fail for me on Windows 10:
```
ResolverUtilTest
org.apache.logging.log4j.c
martin-g commented on issue #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276#issuecomment-505741856
Thank you for the explanation!
This is an automated message from the Apache Git Service.
To
remkop commented on issue #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-505757472
I will take another detailed look, but this is shaping up very nicely now I
think.
carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow
logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r297720896
##
File path: log4j-api/src/main/java/org/apache/logging/log4j/LogBuilder.
rmannibucau opened a new pull request #287: adding support for session
attributes in log4j-web
URL: https://github.com/apache/logging-log4j2/pull/287
Follow up of https://issues.apache.org/jira/browse/LOG4J2-2523 comments, can
need a new ticket though.
garydgregory commented on a change in pull request #287: adding support for
session attributes in log4j-web
URL: https://github.com/apache/logging-log4j2/pull/287#discussion_r298254564
##
File path: log4j-web/src/main/java/org/apache/logging/log4j/web/WebLookup.java
##
@@
mirec75 commented on issue #49: Fixes LOG4NET-630 Log4Net missing Timestamp
etc. in internal LogLog
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-506496113
I merged the "LogLogPatternString" to this pull request
rmannibucau commented on issue #287: adding support for session attributes in
log4j-web
URL: https://github.com/apache/logging-log4j2/pull/287#issuecomment-506630761
@rgoers good catch, added.
This is an automated message fro
rgoers merged pull request #284: LOG4J2-2639 - Allow logging calls to be
constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284
This is an automated message from the Apache Git Service.
To
rgoers opened a new pull request #288: Log4 j2 2644 for release-2.x
URL: https://github.com/apache/logging-log4j2/pull/288
Improves performance of calculating location info.
This is an automated message from the Apache Git Ser
rgoers opened a new pull request #289: LOG4J2-2644 - Improve performance of
getting location info
URL: https://github.com/apache/logging-log4j2/pull/289
Improves the performance of getting location info.
This is an automated
carterkozak commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r298841455
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.jav
carterkozak commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r298841477
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.jav
carterkozak commented on issue #289: LOG4J2-2644 - Improve performance of
getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#issuecomment-507050574
Any chance you have benchmarks which show the performance before and after
this change?
---
carterkozak commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r298841873
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.jav
rgoers edited a comment on issue #289: LOG4J2-2644 - Improve performance of
getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#issuecomment-507051471
For the benchmarks see the related Jira issue. I will try your suggested
changes. I also have some others I want t
rgoers commented on issue #289: LOG4J2-2644 - Improve performance of getting
location info
URL: https://github.com/apache/logging-log4j2/pull/289#issuecomment-507051471
For the benchmarks see the related Jira issue.
This is a
carterkozak commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299047174
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.jav
carterkozak commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299047989
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.jav
rgoers commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299077682
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.java
##
rgoers commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299080106
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.java
##
carterkozak commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299081942
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.jav
carterkozak commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299084747
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.jav
rgoers commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299086416
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.java
##
rgoers commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299086416
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.java
##
remkop commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r299254217
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.java
##
mattiabertorello opened a new pull request #290: [LOG4J2-2650] Fix
ArrayIndexOutOfBoundsException swhen the mac variable was an ipv6
URL: https://github.com/apache/logging-log4j2/pull/290
This is an automated message from th
rgoers commented on issue #290: [LOG4J2-2650] Fix
ArrayIndexOutOfBoundsException when the mac variable is an ipv6
URL: https://github.com/apache/logging-log4j2/pull/290#issuecomment-508540296
I don't understand this fix. NetUtils.getMacAddress is supposed to return a
MAC address or emulate
mattiabertorello commented on issue #290: [LOG4J2-2650] Fix
ArrayIndexOutOfBoundsException when the mac variable is an ipv6
URL: https://github.com/apache/logging-log4j2/pull/290#issuecomment-508564354
Yes you are right, I was not sure what part of the code fix.
Because I didn't think t
rgoers commented on a change in pull request #289: LOG4J2-2644 - Improve
performance of getting location info
URL: https://github.com/apache/logging-log4j2/pull/289#discussion_r300930046
##
File path:
log4j-api-java9/src/main/java/org/apache/logging/log4j/util/StackLocator.java
##
2101 - 2200 of 7264 matches
Mail list logo
