vy commented on pull request #384:
URL: https://github.com/apache/logging-log4j2/pull/384#issuecomment-657103113
Keep them coming @janmaterne! Thanks!
This is an automated message from the Apache Git Service.
To respond to th
rgoers commented on pull request #383:
URL: https://github.com/apache/logging-log4j2/pull/383#issuecomment-657105873
Just a reminder that these were only merged to master so will not affect the
active web site.
This is an au
rgoers commented on pull request #384:
URL: https://github.com/apache/logging-log4j2/pull/384#issuecomment-657106035
Just a reminder that these changes were only merged to master so will not
affect the live web site.
This is
rgoers edited a comment on pull request #383:
URL: https://github.com/apache/logging-log4j2/pull/383#issuecomment-657105873
Just a reminder that these were only merged to master so will not affect the
active web site. The release-2.x branch doesn't use asciidoc for this page so
the change
fluffynuts commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657108333
Uhm... so ok, this is merged, but how does a release now get out? 2.0.9 has
been ready for release for a while, without happening, long before I got
involved. It's all we
fluffynuts edited a comment on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657108333
Uhm... so ok, this is merged, but how does a release now get out? 2.0.9 has
been ready for release for a while, without happening, long before I got
involved. It's
fluffynuts edited a comment on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657108333
Uhm... so ok, this is merged, but how does a release now get out? 2.0.9 has
been ready for release for a while, without happening, long before I got
involved. It's
rgoers commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657133838
To get a release out someone needs to create whatever the PMC is going to
vote on. If it is just a source release then that should be packaged in gzip
and/or zip format. If t
rgoers edited a comment on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657133838
To get a release out someone needs to create whatever the PMC is going to
vote on. If it is just a source release then that should be packaged in gzip
and/or zip forma
fluffynuts commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657192785
@rgoers there are release artifacts for this PR, as mentioned in the initial
request, at
[https://ci.appveyor.com/project/fluffynuts/logging-log4net/builds/32915894/artif
fluffynuts edited a comment on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657192785
@rgoers there are release artifacts for this PR, as mentioned in the initial
request, at
[https://ci.appveyor.com/project/fluffynuts/logging-log4net/builds/3291589
TimSirmovics commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657319549
Not that this is really the place to comment, but can I just say that there
are probably many people who would love a new log4Net version updated for .NET
Standard 2.0.
rgoers commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657355124
@fluffynuts I see a nuget package and a file named log4net-binaries. I
downloaded that and it does not contain source. It looks like a binary
distribution. if it is it is mis
fluffynuts commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657508289
@rgoers thanks, I'll create a new PR to rectify: the release should have a
source artifact. You're correct about the licensing field in the nuspec,
insofar as the link wi
fluffynuts opened a new pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61
* Summary *
Adds the `log4net-source-{version}.zip` source archive to build artifacts.
This (should) mean that anyone who has set up AppVeyer for their account should
have built binaries
fluffynuts commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657534691
@rgoers I've created #61 - hope I've done the right thing(s); please let me
know if there's something I'm missing.
--
Thihup opened a new pull request #385:
URL: https://github.com/apache/logging-log4j2/pull/385
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rgoers commented on pull request #385:
URL: https://github.com/apache/logging-log4j2/pull/385#issuecomment-657631538
This almost certainly would be required on the release-2.x branch.
This is an automated message from the Apa
Thihup opened a new pull request #386:
URL: https://github.com/apache/logging-log4j2/pull/386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jvz merged pull request #386:
URL: https://github.com/apache/logging-log4j2/pull/386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Thihup commented on pull request #385:
URL: https://github.com/apache/logging-log4j2/pull/385#issuecomment-658134002
@rgoers Done! https://github.com/apache/logging-log4j2/pull/386
This is an automated message from the Apache
carterkozak opened a new pull request #387:
URL: https://github.com/apache/logging-log4j2/pull/387
Previously a new instance was created for each translator, which
occurred on every thread. Some applications do not reuse threads
efficiently, and shouldn't be over-penalized.
-
carterkozak opened a new pull request #388:
URL: https://github.com/apache/logging-log4j2/pull/388
Previously logging initialization would result in an AsyncLoggerContext
initializing an AsyncLoggerDisruptor, which would access a logger from
JUL, starting the process again. This change
carterkozak opened a new pull request #389:
URL: https://github.com/apache/logging-log4j2/pull/389
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
remkop commented on pull request #388:
URL: https://github.com/apache/logging-log4j2/pull/388#issuecomment-659045322
Thanks for taking care of this, Carter!
This is an automated message from the Apache Git Service.
To respond
remkop commented on pull request #389:
URL: https://github.com/apache/logging-log4j2/pull/389#issuecomment-659045453
Thanks for taking care of this, Carter!
This is an automated message from the Apache Git Service.
To respond
carterkozak commented on pull request #388:
URL: https://github.com/apache/logging-log4j2/pull/388#issuecomment-659046112
I appreciate the reviews, thanks @remkop :-)
I still need to finish full test runs locally for these changes, then I'll
merge along with #361, likely tomorrow.
remkop commented on pull request #388:
URL: https://github.com/apache/logging-log4j2/pull/388#issuecomment-659048207
If you can merge #361, that would be great! Thank you!
This is an automated message from the Apache Git Se
stephen-webb opened a new pull request #29:
URL: https://github.com/apache/logging-log4cxx/pull/29
when the test is run in a time zone east of the prime meridian
This is an automated message from the Apache Git Service.
To re
SymbioticKilla commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-659392987
Hi,
Thanks for your efforts!
Does this version fixes
https://www.whitesourcesoftware.com/vulnerability-database/CVE-2018-1285 ?
If yes, will it be release
SymbioticKilla edited a comment on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-659392987
Hi,
Thanks for your efforts!
Does this version fix
https://www.whitesourcesoftware.com/vulnerability-database/CVE-2018-1285 ?
If yes, will it be re
carterkozak commented on pull request #389:
URL: https://github.com/apache/logging-log4j2/pull/389#issuecomment-659661612
committed to release-2.x and master
This is an automated message from the Apache Git Service.
To respon
carterkozak closed pull request #388:
URL: https://github.com/apache/logging-log4j2/pull/388
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
carterkozak commented on pull request #388:
URL: https://github.com/apache/logging-log4j2/pull/388#issuecomment-659661589
committed to release-2.x and master
This is an automated message from the Apache Git Service.
To respon
carterkozak closed pull request #389:
URL: https://github.com/apache/logging-log4j2/pull/389
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
carterkozak commented on pull request #387:
URL: https://github.com/apache/logging-log4j2/pull/387#issuecomment-659661553
committed to release-2.x and master
This is an automated message from the Apache Git Service.
To respon
carterkozak closed pull request #387:
URL: https://github.com/apache/logging-log4j2/pull/387
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
carterkozak merged pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
carterkozak merged pull request #385:
URL: https://github.com/apache/logging-log4j2/pull/385
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
carterkozak commented on pull request #367:
URL: https://github.com/apache/logging-log4j2/pull/367#issuecomment-660502501
I've created a ticket for this contribution:
https://issues.apache.org/jira/browse/LOG4J2-2898
Merging momentarily.
carterkozak merged pull request #367:
URL: https://github.com/apache/logging-log4j2/pull/367
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
carterkozak opened a new pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
carterkozak commented on pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-660516966
@rgoers, I'd appreciate your feedback on this change when you have time. I'm
primarily interested in whether or not you think it's reasonable to replace
`Thread.getAllS
rgoers commented on pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-660576958
Yeah, I don't think it can be guaranteed that the methods will always be
called on the same thread.
This is
rgoers edited a comment on pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-660576958
Yeah, I don't think it can be guaranteed that the methods will always be
called on the same thread. But I am also noticing that the method stores the
thread it found
ams-tschoening commented on pull request #29:
URL: https://github.com/apache/logging-log4cxx/pull/29#issuecomment-660645411
https://issues.apache.org/jira/projects/LOGCXX/issues/LOGCXX-273
This is an automated message from th
ams-tschoening commented on pull request #29:
URL: https://github.com/apache/logging-log4cxx/pull/29#issuecomment-660647614
Tests still succeed for me, so am simply merging. Thanks for fixing!
This is an automated message fro
ams-tschoening merged pull request #29:
URL: https://github.com/apache/logging-log4cxx/pull/29
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
stephen-webb opened a new pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30
This PR removes the maven generated Dependencies page from the web site.
The maven generated dependencies report is not appropriate for a C++ project.
-
ams-tschoening commented on a change in pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30#discussion_r457169943
##
File path: INSTALL
##
@@ -15,24 +15,16 @@ limitations under the License.
Detailed build instructions are provided for in both HTML
and A
stephen-webb commented on a change in pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30#discussion_r457273830
##
File path: pom.xml
##
@@ -372,7 +372,6 @@
stephen-webb commented on a change in pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30#discussion_r457273830
##
File path: pom.xml
##
@@ -372,7 +372,6 @@
ams-tschoening commented on a change in pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30#discussion_r457335062
##
File path: pom.xml
##
@@ -372,7 +372,6 @@
ams-tschoening commented on a change in pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30#discussion_r457926498
##
File path: pom.xml
##
@@ -372,7 +372,6 @@
dependabot[bot] commented on pull request #376:
URL: https://github.com/apache/logging-log4j2/pull/376#issuecomment-662229367
Superseded by #391.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] closed pull request #376:
URL: https://github.com/apache/logging-log4j2/pull/376
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] opened a new pull request #391:
URL: https://github.com/apache/logging-log4j2/pull/391
Bumps `springVersion` from 3.2.18.RELEASE to 5.2.8.RELEASE.
Updates `spring-aop` from 3.2.18.RELEASE to 5.2.8.RELEASE
Release notes
Sourced from https://github.com/spring-proje
carterkozak commented on pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-662432635
> I don't think it can be guaranteed that the methods will always be called
on the same thread
It can't be guaranteed that the original thread is still around or
rgoers commented on pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-662709377
Of course it can be guaranteed the original thread is around because most of
the time the LogEventWrapper is called it will be from the same thread as the
caller. Only when
fluffynuts commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-662846390
Hi @SymbioticKilla
Apologies for the delayed response -- I dropped the ball with a bunch of GH
notifications recently 😞
As far as I'm aware, this PR does n
SymbioticKilla commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-662880285
>
>
> Hi @SymbioticKilla
>
> Apologies for the delayed response -- I dropped the ball with a bunch of
GH notifications recently 😞
>
> As far as I
fluffynuts commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-663096542
Well, this PR is to include the last required artifact (source zip) for the
build that I fixed up. It's just waiting on someone to ok it - I'm not sure if
I need to kick
fluffynuts commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-663098804
That linked jira ticket mentions commit d0b4b01, which is not in the lineage
for this pr - I'll need to hunt it down...
-
rgoers commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-663100312
Sorry, I have just been busy with my $day job.
Ralph
> On Jul 23, 2020, at 9:12 AM, Davyd McColl wrote:
>
>
> Well, this PR is to include the last req
fluffynuts commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-663102468
Looks like that commit is in the develop branch. @rgoers do you think I
could merge that into this? Or would develop get changes from master and then
make a new PR? Not s
fluffynuts commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-663103892
@rgoers I totally understand, and don't want to be a PITA :smile: whenever
you have time, I'd really appreciate your input.
-
rgoers commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-663104707
Don’t worry about it. I will be on vacation next week so will probably spend
more time on ASF related stuff.
Ralph
> On Jul 23, 2020, at 9:26 AM, Davyd McColl w
SymbioticKilla commented on pull request #61:
URL: https://github.com/apache/logging-log4net/pull/61#issuecomment-663200538
CVE-fix merge would be great! Thank you!
This is an automated message from the Apache Git Service.
To
rgoers commented on pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-664681823
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rgoers merged pull request #381:
URL: https://github.com/apache/logging-log4j2/pull/381
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers commented on pull request #128:
URL: https://github.com/apache/logging-log4j2/pull/128#issuecomment-665439972
The associated Jira was closed several months ago.
This is an automated message from the Apache Git Service.
carterkozak closed pull request #210:
URL: https://github.com/apache/logging-log4j2/pull/210
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Lemongrass3110 commented on pull request #173:
URL: https://github.com/apache/logging-log4j2/pull/173#issuecomment-665470680
>
>
> @Lemongrass3110 @jvz @garydgregory After all this time I am not sure where
this stands. It now has conflicts that need to be resolved. The PR is over 2
rgoers closed pull request #195:
URL: https://github.com/apache/logging-log4j2/pull/195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers commented on pull request #173:
URL: https://github.com/apache/logging-log4j2/pull/173#issuecomment-665438019
@Lemongrass3110 @jvz @garydgregory After all this time I am not sure where
this stands. It now has conflicts that need to be resolved. The PR is over 2
years old and we eith
rgoers commented on pull request #326:
URL: https://github.com/apache/logging-log4j2/pull/326#issuecomment-665414709
@carterkozak I added support for requiresLocation() to LoggerConfig and
various the various components a few releases ago. However, requiresLocation()
should really be used
rgoers commented on pull request #363:
URL: https://github.com/apache/logging-log4j2/pull/363#issuecomment-665309778
Patch was manually applied. For some reason merging the branch caused test
failures in log4j-taglib for me.
rgoers commented on pull request #210:
URL: https://github.com/apache/logging-log4j2/pull/210#issuecomment-664810752
Any progress? Should this be closed in lieu of a different solution?
This is an automated message from the A
rgoers merged pull request #358:
URL: https://github.com/apache/logging-log4j2/pull/358
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers closed pull request #363:
URL: https://github.com/apache/logging-log4j2/pull/363
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers edited a comment on pull request #329:
URL: https://github.com/apache/logging-log4j2/pull/329#issuecomment-665412865
@carterkozak Have you revisited this? To be honest I looked at the review
here but it is hard to tell what effect it might have. It would be great to
have some JMH be
rgoers commented on pull request #87:
URL: https://github.com/apache/logging-log4j2/pull/87#issuecomment-665442300
@leventov @remkop @jvz Is there value in accepting this as-is. It has merge
conflicts that have to be resolved. I have not checked to see how many there
are or how difficult t
rgoers commented on pull request #329:
URL: https://github.com/apache/logging-log4j2/pull/329#issuecomment-665412865
@carterkozak Have you revisited this. To be honest I looked at the review
here but it is hard to tell what effect it might have. It would be great to
have some JMH benchmark
rgoers merged pull request #206:
URL: https://github.com/apache/logging-log4j2/pull/206
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers closed pull request #163:
URL: https://github.com/apache/logging-log4j2/pull/163
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers commented on pull request #244:
URL: https://github.com/apache/logging-log4j2/pull/244#issuecomment-665310696
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rgoers commented on pull request #208:
URL: https://github.com/apache/logging-log4j2/pull/208#issuecomment-665312449
@remkop Do you have an opinion on this? It has been almost 2 years now.
This is an automated message from th
rgoers commented on pull request #163:
URL: https://github.com/apache/logging-log4j2/pull/163#issuecomment-665438922
Closing do to no response to my inquiries 2 years ago.
This is an automated message from the Apache Git Serv
rgoers commented on a change in pull request #208:
URL: https://github.com/apache/logging-log4j2/pull/208#discussion_r462022446
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java
##
@@ -355,4 +356,41 @@ public void clear()
rgoers commented on pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-664793002
@shawjef3 Based on our comments, what do you want to do with this PR?
This is an automated message from the
carterkozak closed pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rgoers commented on pull request #131:
URL: https://github.com/apache/logging-log4j2/pull/131#issuecomment-665439353
Closing due to the comments by @carterkozak 2 years ago and no response
since.
This is an automated message
carterkozak commented on pull request #390:
URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-664675299
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
garydgregory commented on pull request #244:
URL: https://github.com/apache/logging-log4j2/pull/244#issuecomment-665353745
Wel, it looks like the PR is/was ready to go now it's stale.
This is an automated message from the Apa
rgoers commented on pull request #195:
URL: https://github.com/apache/logging-log4j2/pull/195#issuecomment-664813872
Closing since ThrowableProxy was completely refactored and the change I see
here has been made to the source.
--
rgoers closed pull request #128:
URL: https://github.com/apache/logging-log4j2/pull/128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
remkop commented on a change in pull request #208:
URL: https://github.com/apache/logging-log4j2/pull/208#discussion_r461938239
##
File path:
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java
##
@@ -355,4 +356,41 @@ public void clear()
carterkozak commented on pull request #329:
URL: https://github.com/apache/logging-log4j2/pull/329#issuecomment-665417612
I had forgotten about this change. I'm a little bit afraid of changes to
ThrowableProxy because there are a number of cases when multiple classes with
the same fully qu
rgoers commented on pull request #171:
URL: https://github.com/apache/logging-log4j2/pull/171#issuecomment-665438604
Do we want to apply this? I'm not really sure why one would want to log
directly to Lucene instead of to Solr or ElasticSearch.
rgoers closed pull request #131:
URL: https://github.com/apache/logging-log4j2/pull/131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
201 - 300 of 7264 matches
Mail list logo
