[GitHub] qub1n closed pull request #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-31 Thread GitBox
qub1n closed pull request #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46 This is an automated message from the Apache Git Service. To respond to th

[GitHub] qub1n commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-31 Thread GitBox
qub1n commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-459339084 I made new pull request (47) on proper branch, please close it. --

[GitHub] rgoers merged pull request #248: Add Log4j to SLF4J Adapter to the BOM

2019-02-02 Thread GitBox
rgoers merged pull request #248: Add Log4j to SLF4J Adapter to the BOM URL: https://github.com/apache/logging-log4j2/pull/248 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rgoers commented on issue #246: [LOG4J2-2523] adding support for request related lookup web module

2019-02-02 Thread GitBox
rgoers commented on issue #246: [LOG4J2-2523] adding support for request related lookup web module URL: https://github.com/apache/logging-log4j2/pull/246#issuecomment-460022526 This code can only be applied to 3.0 as it contains Lambdas. --

[GitHub] rgoers merged pull request #213: LOG4J2-2025: JUL bridge handler (incl. unit test and site doc)

2019-02-02 Thread GitBox
rgoers merged pull request #213: LOG4J2-2025: JUL bridge handler (incl. unit test and site doc) URL: https://github.com/apache/logging-log4j2/pull/213 This is an automated message from the Apache Git Service. To respond to t

[GitHub] tzachi-dar opened a new pull request #3: Gzip files

2019-02-03 Thread GitBox
tzachi-dar opened a new pull request #3: Gzip files URL: https://github.com/apache/logging-chainsaw/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] tzachi-dar closed pull request #3: Gzip files

2019-02-03 Thread GitBox
tzachi-dar closed pull request #3: Gzip files URL: https://github.com/apache/logging-chainsaw/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL ab

[GitHub] tzachi-dar opened a new pull request #4: Allow to read gzip files.

2019-02-03 Thread GitBox
tzachi-dar opened a new pull request #4: Allow to read gzip files. URL: https://github.com/apache/logging-chainsaw/pull/4 Signed-off-by: Tzachi Dar This is an automated message from the Apache Git Service. To respond to the m

[GitHub] cakofony opened a new pull request #254: Fix WriterAppender.Builder break

2019-02-03 Thread GitBox
cakofony opened a new pull request #254: Fix WriterAppender.Builder break URL: https://github.com/apache/logging-log4j2/pull/254 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349277 ## File path: log4j-core/src/main/java/org/apache/logging/log4j

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349408 ## File path: log4j-core/src/main/java/org/apache/logging/log4j

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349431 ## File path: log4j-core/src/main/java/org/apache/logging/log4j

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349281 ## File path: log4j-core/src/main/java/org/apache/logging/log4j

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349447 ## File path: log4j-core/src/main/java/org/apache/logging/log4j

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349578 ## File path: log4j-core/src/test/java/org/apache/logging/log4j

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349792 ## File path: log4j-spring-cloud-config/log4j-spring-cloud-conf

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349622 ## File path: log4j-core/src/test/java/org/apache/logging/log4j

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349683 ## File path: log4j-spring-cloud-config/log4j-spring-cloud-conf

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253349779 ## File path: log4j-spring-cloud-config/log4j-spring-cloud-conf

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-03 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253350097 ## File path: log4j-core/src/main/java/org/apache/logging/log4j

[GitHub] cakofony opened a new pull request #255: Fix WriterAppender.Builder break

2019-02-04 Thread GitBox
cakofony opened a new pull request #255: Fix WriterAppender.Builder break URL: https://github.com/apache/logging-log4j2/pull/255 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] jvz commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-04 Thread GitBox
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253626894 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/co

[GitHub] jvz commented on a change in pull request #4: Allow to read gzip files.

2019-02-04 Thread GitBox
jvz commented on a change in pull request #4: Allow to read gzip files. URL: https://github.com/apache/logging-chainsaw/pull/4#discussion_r253627481 ## File path: src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java ## @@ -314,6 +315,10 @@ public void

[GitHub] jvz commented on a change in pull request #4: Allow to read gzip files.

2019-02-04 Thread GitBox
jvz commented on a change in pull request #4: Allow to read gzip files. URL: https://github.com/apache/logging-chainsaw/pull/4#discussion_r253627807 ## File path: src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java ## @@ -403,8 +409,16 @@ public void

[GitHub] jvz commented on a change in pull request #4: Allow to read gzip files.

2019-02-04 Thread GitBox
jvz commented on a change in pull request #4: Allow to read gzip files. URL: https://github.com/apache/logging-chainsaw/pull/4#discussion_r253627642 ## File path: src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java ## @@ -403,8 +409,16 @@ public void

[GitHub] jvz commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-04 Thread GitBox
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253647508 ## File path: log4j-spring-cloud-config/log4j-spring-cloud-config-

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-04 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253682942 ## File path: log4j-spring-cloud-config/log4j-spring-cloud-conf

[GitHub] rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-04 Thread GitBox
rgoers commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253682942 ## File path: log4j-spring-cloud-config/log4j-spring-cloud-conf

[GitHub] rgoers merged pull request #255: Fix WriterAppender.Builder break

2019-02-04 Thread GitBox
rgoers merged pull request #255: Fix WriterAppender.Builder break URL: https://github.com/apache/logging-log4j2/pull/255 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] tzachi-dar commented on issue #4: Allow to read gzip files.

2019-02-04 Thread GitBox
tzachi-dar commented on issue #4: Allow to read gzip files. URL: https://github.com/apache/logging-chainsaw/pull/4#issuecomment-460542989 Opened issue. https://issues.apache.org/jira/browse/CHAINSAW-67 Please review again. --

[GitHub] tzachi-dar commented on a change in pull request #4: Allow to read gzip files.

2019-02-04 Thread GitBox
tzachi-dar commented on a change in pull request #4: Allow to read gzip files. URL: https://github.com/apache/logging-chainsaw/pull/4#discussion_r253759166 ## File path: src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java ## @@ -403,8 +409,16 @@ publ

[GitHub] jvz commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-05 Thread GitBox
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253973540 ## File path: log4j-spring-cloud-config/log4j-spring-cloud-config-

[GitHub] jvz commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-02-05 Thread GitBox
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r253974505 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/co

[GitHub] jvz commented on issue #4: Allow to read gzip files.

2019-02-05 Thread GitBox
jvz commented on issue #4: Allow to read gzip files. URL: https://github.com/apache/logging-chainsaw/pull/4#issuecomment-460829107 I'll merge this tomorrow. I need to add a changelog entry as well. I cut my thumb last night which makes typing difficult at the moment. --

[GitHub] cakofony merged pull request #254: Fix WriterAppender.Builder break

2019-02-06 Thread GitBox
cakofony merged pull request #254: Fix WriterAppender.Builder break URL: https://github.com/apache/logging-log4j2/pull/254 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] jvz merged pull request #4: [CHAINSAW-67] Allow to read gzip files.

2019-02-07 Thread GitBox
jvz merged pull request #4: [CHAINSAW-67] Allow to read gzip files. URL: https://github.com/apache/logging-chainsaw/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] tzachi-dar opened a new pull request #5: Allow chainsaw to read a directory containing more than one file

2019-02-10 Thread GitBox
tzachi-dar opened a new pull request #5: Allow chainsaw to read a directory containing more than one file URL: https://github.com/apache/logging-chainsaw/pull/5 On linux it is common to use logrotate to handle log files. Logrotate trunks the files as they reach a certain size and als

[GitHub] PPazderski opened a new pull request #256: (doc) Clarify Default Rollover Strategy

2019-02-11 Thread GitBox
PPazderski opened a new pull request #256: (doc) Clarify Default Rollover Strategy URL: https://github.com/apache/logging-log4j2/pull/256 I got surprised by the rollover rename strategy because I haven't read the manual carefully enough. This pull request may help to improve the manual

[GitHub] rgoers commented on issue #256: (doc) Clarify Default Rollover Strategy

2019-02-11 Thread GitBox
rgoers commented on issue #256: (doc) Clarify Default Rollover Strategy URL: https://github.com/apache/logging-log4j2/pull/256#issuecomment-462360483 Looks OK to me. This is an automated message from the Apache Git Service. To

[GitHub] jvz commented on issue #5: Allow chainsaw to read a directory containing more than one file

2019-02-13 Thread GitBox
jvz commented on issue #5: Allow chainsaw to read a directory containing more than one file URL: https://github.com/apache/logging-chainsaw/pull/5#issuecomment-463248104 Thanks for the contribution. Can you file a jira ticket for this? --

[GitHub] tzachi-dar commented on issue #5: Allow chainsaw to read a directory containing more than one file

2019-02-13 Thread GitBox
tzachi-dar commented on issue #5: Allow chainsaw to read a directory containing more than one file URL: https://github.com/apache/logging-chainsaw/pull/5#issuecomment-463249189 https://issues.apache.org/jira/browse/CHAINSAW-68 ---

[GitHub] ewcchan opened a new pull request #14: Missing curly brackets at value gitUserName annotation

2019-02-13 Thread GitBox
ewcchan opened a new pull request #14: Missing curly brackets at value gitUserName annotation URL: https://github.com/apache/logging-log4j-audit/pull/14 @jvz Would you please review and merge as applicable? This is an autom

[GitHub] ewcchan commented on issue #14: Missing curly brackets at value gitUserName annotation

2019-02-13 Thread GitBox
ewcchan commented on issue #14: Missing curly brackets at value gitUserName annotation URL: https://github.com/apache/logging-log4j-audit/pull/14#issuecomment-463484170 @jvz sure. could you please let me know the jira access info as I am not too familiar with the project. :) --

[GitHub] jvz commented on issue #14: Missing curly brackets at value gitUserName annotation

2019-02-14 Thread GitBox
jvz commented on issue #14: Missing curly brackets at value gitUserName annotation URL: https://github.com/apache/logging-log4j-audit/pull/14#issuecomment-463715146 Jira: https://issues.apache.org/jira/browse/CHAINSAW Thanks! ---

[GitHub] ptogher opened a new pull request #257: Allow access to the backlog state of the disruptor to improve program…

2019-02-20 Thread GitBox
ptogher opened a new pull request #257: Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257 …atic reconfiguration of async appenders. This change is to help support programmatically switching async appenders.

[GitHub] ptogher closed pull request #258: Test branch

2019-02-20 Thread GitBox
ptogher closed pull request #258: Test branch URL: https://github.com/apache/logging-log4j2/pull/258 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL ab

[GitHub] ptogher opened a new pull request #258: Test branch

2019-02-20 Thread GitBox
ptogher opened a new pull request #258: Test branch URL: https://github.com/apache/logging-log4j2/pull/258 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] ptogher opened a new pull request #259: Test build

2019-02-20 Thread GitBox
ptogher opened a new pull request #259: Test build URL: https://github.com/apache/logging-log4j2/pull/259 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the U

[GitHub] ptogher commented on issue #257: Allow access to the backlog state of the disruptor to improve program…

2019-02-20 Thread GitBox
ptogher commented on issue #257: Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257#issuecomment-465580102 I am not sure if the build errors are due to my changes. I get the same errors if i do a clean master build.

[GitHub] ptogher closed pull request #259: Test build

2019-02-20 Thread GitBox
ptogher closed pull request #259: Test build URL: https://github.com/apache/logging-log4j2/pull/259 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL abo

[GitHub] ptogher commented on issue #257: Allow access to the backlog state of the disruptor to improve program…

2019-02-20 Thread GitBox
ptogher commented on issue #257: Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257#issuecomment-465615775 The problem appears to be the revapi.json, or the reference version. The deprecated methods have been remove

[GitHub] ptogher commented on issue #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program…

2019-02-21 Thread GitBox
ptogher commented on issue #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257#issuecomment-466060684 Have raised a Jira, if that helps... LOG4J2-2552 ---

[GitHub] ptogher closed pull request #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program…

2019-03-01 Thread GitBox
ptogher closed pull request #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257 This is an automated message from the Apache Git Ser

[GitHub] ptogher opened a new pull request #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program…

2019-03-01 Thread GitBox
ptogher opened a new pull request #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257 …atic reconfiguration of async appenders. This change is to help support programmatically switching async

[GitHub] ulrichenslin opened a new pull request #260: JEP223 version detection fix for JDK 9 and up

2019-03-01 Thread GitBox
ulrichenslin opened a new pull request #260: JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260 Fix version detection for JDK 9 and up This is an automated message from the Ap

[GitHub] jvz commented on issue #260: JEP223 version detection fix for JDK 9 and up

2019-03-01 Thread GitBox
jvz commented on issue #260: JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-468745650 Can you add a jira issue for this as well? https://issues.apache.org/jira/browse/LOG4J2 -

[GitHub] remkop commented on issue #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program…

2019-03-01 Thread GitBox
remkop commented on issue #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257#issuecomment-468825843 Hi @ptogher, sorry I haven't had a chance to look at this earlier. The information you are

[GitHub] ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-01 Thread GitBox
ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-468891113 Jira LOG4J2-2561 added for this PR. This is an au

[GitHub] ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-01 Thread GitBox
ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-468892671 Added test for the detection testing. @remkop Thanks for the advise on reseting the java.version. I missed

[GitHub] remkop commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-01 Thread GitBox
remkop commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-468892909 update: looking at this on my phone, I missed that the PR also includes a test. Looks good to me.

[GitHub] remkop commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-01 Thread GitBox
remkop commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-468892963 Oh, you just added that? Ok, thanks! This is an automat

[GitHub] cakofony commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-02 Thread GitBox
cakofony commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261825957 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLa

[GitHub] ulrichenslin commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-02 Thread GitBox
ulrichenslin commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261837959 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStri

[GitHub] rgoers commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-02 Thread GitBox
rgoers commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261841957 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayo

[GitHub] rgoers commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-02 Thread GitBox
rgoers commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261841957 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayo

[GitHub] rgoers commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-02 Thread GitBox
rgoers commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261841957 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayo

[GitHub] [logging-log4j2] ulrichenslin commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-03 Thread GitBox
ulrichenslin commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261934297 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStri

[GitHub] [logging-log4j2] ptogher commented on issue #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program…

2019-03-04 Thread GitBox
ptogher commented on issue #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257#issuecomment-469190129 Ooh, many thanks, That's really useful. I missed this when i was looking for a solution. Complet

[GitHub] [logging-log4j2] ptogher closed pull request #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program…

2019-03-04 Thread GitBox
ptogher closed pull request #257: LOG4J2-2552 Allow access to the backlog state of the disruptor to improve program… URL: https://github.com/apache/logging-log4j2/pull/257 This is an automated message from the Apache Git Ser

[GitHub] [logging-log4j2] cakofony commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-04 Thread GitBox
cakofony commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r262025574 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/util/ConstantsTest.java

[GitHub] [logging-log4j2] cakofony commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-04 Thread GitBox
cakofony commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r262024621 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/layout/AbstractStringLa

[GitHub] [logging-log4j2] ulrichenslin commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-04 Thread GitBox
ulrichenslin commented on a change in pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r262054233 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/util/ConstantsTest.java

[GitHub] [logging-log4j2] rgoers closed pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config

2019-03-04 Thread GitBox
rgoers closed pull request #253: Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config URL: https://github.com/apache/logging-log4j2/pull/253 This is an automated message from the Apache

[GitHub] [logging-log4j2] ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-05 Thread GitBox
ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-469579852 The tests on the CI is failing, but the failures are not related to the changes made in this PR. How do w

[GitHub] [logging-log4j2] ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-07 Thread GitBox
ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-470827502 @jvz Thanks for approving the PR. To get this ported to 2.11, do I just create another PR with the same chan

[GitHub] [logging-log4net] Shazwazza commented on issue #40: This fixes the Mutex name in the RollingFileAppender

2019-03-10 Thread GitBox
Shazwazza commented on issue #40: This fixes the Mutex name in the RollingFileAppender URL: https://github.com/apache/logging-log4net/pull/40#issuecomment-471407630 Hi, sorry for the delay, i still have this starred in my inbox and will get back to it soon hopefully --

[GitHub] [logging-log4j2] cakofony opened a new pull request #261: Reduce AsyncLogger.actualAsyncLog to 34 bytes to allow inlining

2019-03-14 Thread GitBox
cakofony opened a new pull request #261: Reduce AsyncLogger.actualAsyncLog to 34 bytes to allow inlining URL: https://github.com/apache/logging-log4j2/pull/261 New code, which may be inlined unless there are properties configured on the logger: ``` public void actualAsyncLog(RingBuff

[GitHub] [logging-log4j2] jvz commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-15 Thread GitBox
jvz commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-473386436 That's one simple way to do it. I don't recall if I've merged any backported commits myself, though many of the other devel

[GitHub] [logging-log4j2] jvz edited a comment on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-15 Thread GitBox
jvz edited a comment on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-473386436 That's one simple way to do it. I don't recall if I've merged any backported commits myself, though many of the othe

[GitHub] [logging-log4j2] rgoers commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-15 Thread GitBox
rgoers commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-473435199 I'd appreciate a new PR. I have tried various options like cherry picking but never had much luck. I usually end up doin

[GitHub] [logging-log4j2] ulrichenslin opened a new pull request #262: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up (release-…

2019-03-18 Thread GitBox
ulrichenslin opened a new pull request #262: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up (release-… URL: https://github.com/apache/logging-log4j2/pull/262 …2.x) Same as previous PR, but now on release-2.x : https://github.com/apache/logging-log4j2/pull/260 Fix

[GitHub] [logging-log4j2] ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-03-18 Thread GitBox
ulrichenslin commented on issue #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260#issuecomment-474084137 @rgoers @jvz New for release 2 PR on : https://github.com/apache/logging-log4j2/pull/262

[GitHub] [logging-log4j2] rgoers merged pull request #262: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up (release-…

2019-03-18 Thread GitBox
rgoers merged pull request #262: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up (release-… URL: https://github.com/apache/logging-log4j2/pull/262 This is an automated message from the Apache Git Service. To resp

[GitHub] [logging-log4j2] cakofony opened a new pull request #263: Fix jackson layout performance regression introduced with LOG4J2-2341

2019-03-20 Thread GitBox
cakofony opened a new pull request #263: Fix jackson layout performance regression introduced with LOG4J2-2341 URL: https://github.com/apache/logging-log4j2/pull/263 This makes two changes to the previous fix: 1. Special casing applies only to LogEvents which implement Message, whe

[GitHub] [logging-log4j2] cakofony commented on a change in pull request #263: Fix jackson layout performance regression introduced with LOG4J2-2341

2019-03-20 Thread GitBox
cakofony commented on a change in pull request #263: Fix jackson layout performance regression introduced with LOG4J2-2341 URL: https://github.com/apache/logging-log4j2/pull/263#discussion_r267623037 ## File path: log4j-layout-jackson/src/main/java/org/apache/logging/log4j/jackson/

[GitHub] [logging-log4j2] cakofony commented on a change in pull request #263: Fix jackson layout performance regression introduced with LOG4J2-2341

2019-03-20 Thread GitBox
cakofony commented on a change in pull request #263: Fix jackson layout performance regression introduced with LOG4J2-2341 URL: https://github.com/apache/logging-log4j2/pull/263#discussion_r267623037 ## File path: log4j-layout-jackson/src/main/java/org/apache/logging/log4j/jackson/

[GitHub] [logging-log4j2] cakofony commented on issue #263: Fix jackson layout performance regression introduced with LOG4J2-2341

2019-03-20 Thread GitBox
cakofony commented on issue #263: Fix jackson layout performance regression introduced with LOG4J2-2341 URL: https://github.com/apache/logging-log4j2/pull/263#issuecomment-475111938 Any idea why we have a second unreferenced`AbstractJacksonLayout` in the `org.apache.logging.log4j.jackson.l

[GitHub] [logging-log4j2] cakofony closed pull request #261: Reduce AsyncLogger.actualAsyncLog to 34 bytes to allow inlining

2019-03-21 Thread GitBox
cakofony closed pull request #261: Reduce AsyncLogger.actualAsyncLog to 34 bytes to allow inlining URL: https://github.com/apache/logging-log4j2/pull/261 This is an automated message from the Apache Git Service. To respond t

[GitHub] [logging-log4j2] cakofony commented on issue #263: Fix jackson layout performance regression introduced with LOG4J2-2341

2019-03-25 Thread GitBox
cakofony commented on issue #263: Fix jackson layout performance regression introduced with LOG4J2-2341 URL: https://github.com/apache/logging-log4j2/pull/263#issuecomment-476314525 Closing this out, @rgoers is including a fix with LOG4J2-913 --

[GitHub] [logging-log4j2] cakofony closed pull request #263: Fix jackson layout performance regression introduced with LOG4J2-2341

2019-03-25 Thread GitBox
cakofony closed pull request #263: Fix jackson layout performance regression introduced with LOG4J2-2341 URL: https://github.com/apache/logging-log4j2/pull/263 This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4net] msallin commented on issue #45: Fix performance issue LOG4NET-429 that was introduced by LOG4NET-205

2019-04-02 Thread GitBox
msallin commented on issue #45: Fix performance issue LOG4NET-429 that was introduced by LOG4NET-205 URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-478906413 This blocks our team for years now... Could we contribute somehow?

[GitHub] [logging-log4net] msallin removed a comment on issue #45: Fix performance issue LOG4NET-429 that was introduced by LOG4NET-205

2019-04-02 Thread GitBox
msallin removed a comment on issue #45: Fix performance issue LOG4NET-429 that was introduced by LOG4NET-205 URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-478906413 This blocks our team for years now... Could we contribute somehow?

[GitHub] [logging-log4net] msallin commented on issue #45: Fix performance issue LOG4NET-429 that was introduced by LOG4NET-205

2019-04-02 Thread GitBox
msallin commented on issue #45: Fix performance issue LOG4NET-429 that was introduced by LOG4NET-205 URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-478910675 @davebfid can we support somehow, to bring this forward? --

[GitHub] [logging-log4j-audit] andrei-ivanov opened a new pull request #15: LOG4J2-2551: normalize event name when creating the AuditMessage

2019-04-02 Thread GitBox
andrei-ivanov opened a new pull request #15: LOG4J2-2551: normalize event name when creating the AuditMessage URL: https://github.com/apache/logging-log4j-audit/pull/15 This is an automated message from the Apache Git Servic

[GitHub] [logging-log4j-audit] andrei-ivanov opened a new pull request #16: Log4j2-2579

2019-04-02 Thread GitBox
andrei-ivanov opened a new pull request #16: Log4j2-2579 URL: https://github.com/apache/logging-log4j-audit/pull/16 This PR is based on #15, assuming that will get merged first This is an automated message from the Apache Git

[GitHub] [logging-log4j2] pferrot opened a new pull request #265: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (master branch)

2019-04-02 Thread GitBox
pferrot opened a new pull request #265: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (master branch) URL: https://github.com/apache/logging-log4j2/pull/265 This PR introduces the ability to specify a custom end-of-line string for the JSON layout, which therefore addresses the iss

[GitHub] [logging-log4j2] pferrot opened a new pull request #264: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (2.x branch)

2019-04-02 Thread GitBox
pferrot opened a new pull request #264: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (2.x branch) URL: https://github.com/apache/logging-log4j2/pull/264 This PR introduces the ability to specify a custom end-of-line string for the JSON layout, which therefore addresses the issue

[GitHub] [logging-log4j-audit] andrei-ivanov opened a new pull request #17: LOG4J2-2580

2019-04-02 Thread GitBox
andrei-ivanov opened a new pull request #17: LOG4J2-2580 URL: https://github.com/apache/logging-log4j-audit/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j-audit] andrei-ivanov opened a new pull request #18: LOG4J2-2578

2019-04-02 Thread GitBox
andrei-ivanov opened a new pull request #18: LOG4J2-2578 URL: https://github.com/apache/logging-log4j-audit/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j-audit] rgoers merged pull request #18: LOG4J2-2578

2019-04-03 Thread GitBox
rgoers merged pull request #18: LOG4J2-2578 URL: https://github.com/apache/logging-log4j-audit/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

<    14   15   16   17   18   19   20   21   22   23   >