rmannibucau opened a new pull request #246: [LOG4J2-2523] adding support for
request related lookup web module
URL: https://github.com/apache/logging-log4j2/pull/246
This is an automated message from the Apache Git Service
jvz commented on a change in pull request #8: LOG4J2-2433 Coroutines Support
URL: https://github.com/apache/logging-log4j-kotlin/pull/8#discussion_r243640542
##
File path:
log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/ThreadContextContext.kt
##
@@ -0,0 +
jvz commented on a change in pull request #8: LOG4J2-2433 Coroutines Support
URL: https://github.com/apache/logging-log4j-kotlin/pull/8#discussion_r243640779
##
File path:
log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/ThreadContextContext.kt
##
@@ -0,0 +
rocketraman commented on a change in pull request #8: LOG4J2-2433 Coroutines
Support
URL: https://github.com/apache/logging-log4j-kotlin/pull/8#discussion_r243708005
##
File path:
log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/ThreadContextContext.kt
##
rocketraman commented on a change in pull request #8: LOG4J2-2433 Coroutines
Support
URL: https://github.com/apache/logging-log4j-kotlin/pull/8#discussion_r243708005
##
File path:
log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/ThreadContextContext.kt
##
jvz commented on issue #8: LOG4J2-2433 Coroutines Support
URL:
https://github.com/apache/logging-log4j-kotlin/pull/8#issuecomment-449533982
That sounds better to me!
On Fri, Dec 21, 2018 at 16:47, Raman Gupta wrote:
> *@rocketraman* commented on this pull request.
> --
dpsenner commented on issue #42: Enhance the filter to support filter the
exception type name.
URL: https://github.com/apache/logging-log4net/pull/42#issuecomment-449557098
There is a newer pull request with the same title. Can this pull request be
closed because it is superseded by #43?
dpsenner commented on a change in pull request #43: Enhance the filter to
support filter the exception type name.
URL: https://github.com/apache/logging-log4net/pull/43#discussion_r243731680
##
File path: src/Filter/ExceptionTypeFilter.cs
##
@@ -0,0 +1,54 @@
+using log4ne
dpsenner commented on a change in pull request #43: Enhance the filter to
support filter the exception type name.
URL: https://github.com/apache/logging-log4net/pull/43#discussion_r243731528
##
File path: src/Filter/ExceptionTypeFilter.cs
##
@@ -0,0 +1,54 @@
+using log4ne
dpsenner commented on a change in pull request #43: Enhance the filter to
support filter the exception type name.
URL: https://github.com/apache/logging-log4net/pull/43#discussion_r243731399
##
File path: src/Filter/ExceptionTypeFilter.cs
##
@@ -0,0 +1,54 @@
+using log4ne
dpsenner commented on a change in pull request #43: Enhance the filter to
support filter the exception type name.
URL: https://github.com/apache/logging-log4net/pull/43#discussion_r243731442
##
File path: src/Filter/ExceptionTypeFilter.cs
##
@@ -0,0 +1,54 @@
+using log4ne
dpsenner commented on a change in pull request #43: Enhance the filter to
support filter the exception type name.
URL: https://github.com/apache/logging-log4net/pull/43#discussion_r243731610
##
File path: src/Filter/ExceptionTypeFilter.cs
##
@@ -0,0 +1,54 @@
+using log4ne
dpsenner commented on a change in pull request #43: Enhance the filter to
support filter the exception type name.
URL: https://github.com/apache/logging-log4net/pull/43#discussion_r243731739
##
File path: tests/src/Filter/ExceptionTypeFilterTest.cs
##
@@ -0,0 +1,118 @@
+/*
dpsenner commented on issue #29: Parameterless LogManager.GetLogger
URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-449654609
log4net still targets netstandard-1.3 and not netstandard-2.0, therefore the
answer is no. A workaround that works for netstandard-1.3 would be a
Xantier opened a new pull request #9: Update README.md
URL: https://github.com/apache/logging-log4j-kotlin/pull/9
Add correct, available version of API dep.
This is an automated message from the Apache Git Service.
To respond
outofcoffee commented on issue #9: Update README.md
URL:
https://github.com/apache/logging-log4j-kotlin/pull/9#issuecomment-450564750
Confirmed that, without this change, the dependency cannot be resolved:
```
> Could not find org.apache.logging.log4j:log4j-api-kotlin:1.0.
cakofony opened a new pull request #247: LOG4J2-2527: ListAppender getters
return immutable snapshots
URL: https://github.com/apache/logging-log4j2/pull/247
Provides a bit more thread safety to ListAppender. The class
is marked not-thread-safe, however this functionality is
important
garydgregory commented on issue #247: LOG4J2-2527: ListAppender getters return
immutable snapshots
URL: https://github.com/apache/logging-log4j2/pull/247#issuecomment-450567817
Why not use a CopyOnWriteArrayList?
This is an a
cakofony commented on issue #247: LOG4J2-2527: ListAppender getters return
immutable snapshots
URL: https://github.com/apache/logging-log4j2/pull/247#issuecomment-450568096
> Why not use a CopyOnWriteArrayList?
Two reasons:
1. I expect more appends than gets. This implementation i
cakofony edited a comment on issue #247: LOG4J2-2527: ListAppender getters
return immutable snapshots
URL: https://github.com/apache/logging-log4j2/pull/247#issuecomment-450568096
> Why not use a CopyOnWriteArrayList?
Two reasons:
1. I expect more appends than gets. This implement
jvz closed pull request #9: Update README.md
URL: https://github.com/apache/logging-log4j-kotlin/pull/9
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a for
cakofony commented on issue #247: LOG4J2-2527: ListAppender getters return
immutable snapshots
URL: https://github.com/apache/logging-log4j2/pull/247#issuecomment-450579188
Merged
This is an automated message from the Apache
cakofony closed pull request #247: LOG4J2-2527: ListAppender getters return
immutable snapshots
URL: https://github.com/apache/logging-log4j2/pull/247
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance
cakofony closed pull request #245: [LOG4J2-2522] Make MapMessageLookup.lookup
usable with MapMessage again
URL: https://github.com/apache/logging-log4j2/pull/245
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
dermot-hardy opened a new pull request #248: Add Log4j to SLF4J Adapter to the
BOM
URL: https://github.com/apache/logging-log4j2/pull/248
This is an automated message from the Apache Git Service.
To respond to the message, p
rbarbey commented on issue #221: [LOG4J2-2134] Stackoverflow at
AwaitCompletionReliabilityStrategy.
URL: https://github.com/apache/logging-log4j2/pull/221#issuecomment-453025941
With the latest version 2.11.1 I'm running into this issue as well. Will
there be a patch release which includes
cakofony opened a new pull request #249: Fix MapMessage -> StringMapMessage API
breaks
URL: https://github.com/apache/logging-log4j2/pull/249
Note: This updates MapPatternConverter and MapMessageLookup to use
MapMessage JAVA format, which is slightly different from the original
output
cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks
URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453138694
Are we okay with adding quotes to map values here?
This is an automa
travisspencer opened a new pull request #250: LOG4J2-2530 Generalize check for
MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250
This fixes LOG4J2-2530 by generalizing the check for `MapMessage` to catch
not only `StringMapMessage` objects but also `StructuredMapMessgage` o
cakofony commented on a change in pull request #250: LOG4J2-2530 Generalize
check for MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250#discussion_r246808988
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MapPatternConverter.java
#
cakofony commented on a change in pull request #250: LOG4J2-2530 Generalize
check for MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250#discussion_r246809840
##
File path:
log4j-samples/log4j-samples-loggerProperties/src/main/java/org/apache/logging/log4j/lookup/Map
travisspencer commented on a change in pull request #250: LOG4J2-2530
Generalize check for MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250#discussion_r246810327
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MapPatternConverter.java
travisspencer commented on a change in pull request #250: LOG4J2-2530
Generalize check for MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250#discussion_r246816556
##
File path:
log4j-samples/log4j-samples-loggerProperties/src/main/java/org/apache/logging/log4j/looku
travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API
breaks
URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453150465
We have customers that parse these log messages from the DB. Would be nice
to not change the format.
-
cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks
URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453151292
That makes sense, thanks for the quick reply! Another potential solution
would be to implement `MapFormat.JAVA_UNQUOTED` which exactl
cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks
URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453151485
Closing this pr, @travisspencer is taking care of the fix :-)
This i
travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API
breaks
URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453151808
Sure! I'm here to help :)
This is an automated message from t
cakofony closed pull request #249: Fix MapMessage -> StringMapMessage API breaks
URL: https://github.com/apache/logging-log4j2/pull/249
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API
breaks
URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453230516
ecd05cb225423418f1db91526ed444d8f1ced55f is what you had in mind? If so, and
if there's nothing more to change, I'll squash all
cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks
URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453231196
Looks great, thank you!
This is an automated message from the Apache
cakofony commented on issue #250: LOG4J2-2530 Generalize check for MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250#issuecomment-453252227
Would you mind adding tests to make sure we don't reintroduce this
regression? The implementation looks great :-)
travisspencer commented on issue #250: LOG4J2-2530 Generalize check for
MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250#issuecomment-453257755
Will do that and the paperwork tomorrow or over the weekend.
On Thu, Jan 10, 2019, 10:01 PM Carter Kozak Would you mind ad
mprusakov-rbc opened a new pull request #251: Remove garbage creation
introduced by LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251
After upgrading to 2.11.1 we have started seeing garbage being generated
here:
Stack Trace TLABs Total TLAB Size(bytes) Pressure
cakofony commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453604081
Thank you for reporting! I'm surprised that this wasn't caught by
`GcFreeMixedSyncAyncLoggingTest`, we should fix the bug which
remkop commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453690349
Yes, that is worrisome. Would be great if we can make the test fail, to
confirm that the patch fixes the issue.
garydgregory commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453748280
+1 having a failing test, otherwise we are almost guaranteeing the
regression will come back :-(
Gary
On Fri
cakofony commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453748782
This issue is a bit difficult to test test for because it requires several
threads to log. There's allocation if a ThreadLocal `
cakofony edited a comment on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453748782
This issue is a bit difficult to test for because it requires several
threads to log. There's allocation if a ThreadLocal
garydgregory commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453756721
Can't this be testing with a single thread? Maybe we need to add a package
private methods to ease testing?
--
travisspencer commented on issue #250: LOG4J2-2530 Generalize check for
MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250#issuecomment-453835541
- Tests added
- Paperwork sent in
- CI server is green
- Commits are squashed
This PR can be merged and the issue
cakofony closed pull request #250: LOG4J2-2530 Generalize check for MapMessage
URL: https://github.com/apache/logging-log4j2/pull/250
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a fo
mprusakov-rbc commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453951428
First of all, thank you for spending time looking at my patch,
I can confirm that I have tested it by patching this o
Shortfinga opened a new pull request #252: Fixed message length with TLS and
Syslog // fixes LOG4J2-2532
URL: https://github.com/apache/logging-log4j2/pull/252
LOG4J2-2532
Length must not be part of syslog message.
Thi
cakofony commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-454037264
> Can't this be testing with a single thread?
I don't believe we can, the issue is that changes in ThreadLocal map size
(
Shortfinga commented on issue #252: Fixed message length with TLS and Syslog //
fixes LOG4J2-2532
URL: https://github.com/apache/logging-log4j2/pull/252#issuecomment-454041336
Can you point me to the chapter in RFC5424 where this "feature" is
mentioned? Also can you tell me how I can disab
jvz commented on issue #251: Remove garbage creation introduced by LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-454063127
The `@PerformanceSensitive` annotation can be used to mark the code as
something that should be looked at. We don't have any tooling a
rgoers commented on issue #252: Fixed message length with TLS and Syslog //
fixes LOG4J2-2532
URL: https://github.com/apache/logging-log4j2/pull/252#issuecomment-454093120
It isn't documented correctly. The only doc for it is at
http://logging.apache.org/log4j/2.x/log4j-core/apidocs/org/ap
remkop commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-454170132
Carter, thanks for the clarification. I don’t object to merging the fix
first.
-
cakofony commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-454192344
I've filed this ticket for tracking:
https://issues.apache.org/jira/browse/LOG4J2-2533
cakofony commented on issue #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-454194537
Thank you for your contribution @mprusakov-rbc!
This is an auto
cakofony merged pull request #251: Remove garbage creation introduced by
LOG4J2-2301
URL: https://github.com/apache/logging-log4j2/pull/251
As this is a foreign pull request (from a fork), the diff has been
sent to your commit mailing list, comm...@logging.apache.org
davebfid opened a new pull request #44: Performance fix for lookup up windows
username
URL: https://github.com/apache/logging-log4net/pull/44
This should fix LOG4NET-429 and I think it is a better approach than
everything else which has been suggested.
The approach is when the user
dpsenner commented on issue #44: Performance fix for lookup up windows username
URL: https://github.com/apache/logging-log4net/pull/44#issuecomment-455457526
Please rebase your changes onto develop.
This is an automated messag
wangzhongkuo commented on issue #144: [LOG4J2-2211] Update StrSubstitutor.java
URL: https://github.com/apache/logging-log4j2/pull/144#issuecomment-455979957
1. I think the point is
org.apache.logging.log4j.core.lookup.Interpolator#lookup
```
/**
* Resolves the specified v
davebfid commented on issue #44: Performance fix for lookup up windows username
URL: https://github.com/apache/logging-log4net/pull/44#issuecomment-456439328
I'll submit a new pull request based on develop later today
This is
davebfid closed pull request #44: Performance fix for lookup up windows username
URL: https://github.com/apache/logging-log4net/pull/44
This is an automated message from the Apache Git Service.
To respond to the message, plea
davebfid opened a new pull request #45: Fix performance issue LOG4NET-429 that
was introduced by LOG4NET-205
URL: https://github.com/apache/logging-log4net/pull/45
This pull request fixes the performance issue raised as LOG4NET-429. I
think it is a better solution than the potential fixes
dpsenner commented on issue #45: Fix performance issue LOG4NET-429 that was
introduced by LOG4NET-205
URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-456495556
Thanks for rebasing. Looks like now there are some syntax glitches that fail
the build.
-
dpsenner commented on issue #45: Fix performance issue LOG4NET-429 that was
introduced by LOG4NET-205
URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-456497811
I like the exhaustive information backing up the contribution, awesome!
--
dpsenner edited a comment on issue #45: Fix performance issue LOG4NET-429 that
was introduced by LOG4NET-205
URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-456497811
I like the exhaustive information backing up the contribution, awesome! The
repository history is going
tzachi-dar opened a new pull request #2: update jsch to version 0.1.55 to allow
it to connect to existing raspberry pi installation.
URL: https://github.com/apache/logging-chainsaw/pull/2
Without this, security negations would fail.
Signed-off-by: Tzachi Dar
---
davebfid commented on issue #45: Fix performance issue LOG4NET-429 that was
introduced by LOG4NET-205
URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-456938500
Somewhat struggling to see how a ThreadContextTest would fail for a UserName
change
-
tzachi-dar commented on issue #2: update jsch to version 0.1.55 to allow it to
connect to existing raspberry pi installation.
URL: https://github.com/apache/logging-chainsaw/pull/2#issuecomment-456994166
Opened https://issues.apache.org/jira/browse/CHAINSAW-66
(I hope this is what you me
dpsenner commented on issue #45: Fix performance issue LOG4NET-429 that was
introduced by LOG4NET-205
URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-457132165
Indeed an interesting fail. I just started a build of the develop branch to
see if that fails too and another
jvz merged pull request #2: update jsch to version 0.1.55 to allow it to
connect to existing raspberry pi installation.
URL: https://github.com/apache/logging-chainsaw/pull/2
This is an automated message from the Apache Git
jvz commented on a change in pull request #1: Update index.apt with
alternatives software
URL: https://github.com/apache/logging-chainsaw/pull/1#discussion_r250683803
##
File path: src/site/apt/index.apt
##
@@ -54,3 +54,12 @@ Tutorial and User Manual
Chainsaw alr
jvz commented on issue #1: Update index.apt with alternatives software
URL: https://github.com/apache/logging-chainsaw/pull/1#issuecomment-457265304
Sorry for not getting back sooner (we had an infra migration that made
GitHub usage easier). Could you update the description of Lilith? Other
rgoers opened a new pull request #253: Log4 j2 913 - Add support for HTTP/S
configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253
For your initial review. I still need to update the web site and look into
spring cloud push notification
davebfid commented on issue #45: Fix performance issue LOG4NET-429 that was
introduced by LOG4NET-205
URL: https://github.com/apache/logging-log4net/pull/45#issuecomment-457560621
Will be a few days before I get chance but I should be able to look into it.
I'll also edit the commit messa
jvz merged pull request #1: Update index.apt with alternatives software
URL: https://github.com/apache/logging-chainsaw/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jvz commented on issue #1: Update index.apt with alternatives software
URL: https://github.com/apache/logging-chainsaw/pull/1#issuecomment-457709307
Thanks for the contribution! Merged to master. No ticket added since this is
a quick documentation update.
--
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251124832
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251125731
##
File path:
log4j-spring-cloud-config/log4j-spring-cloud-config-
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251121558
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251123552
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251124362
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251124090
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251122471
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251124132
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251120883
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251124000
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251126010
##
File path:
log4j-spring-cloud-config/log4j-spring-cloud-config-
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251121335
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/co
jvz commented on a change in pull request #253: Log4 j2 913 - Add support for
HTTP/S configuration monitoring. Support Spring Cloud Config
URL: https://github.com/apache/logging-log4j2/pull/253#discussion_r251125345
##
File path:
log4j-spring-cloud-config/log4j-spring-cloud-config-
qub1n opened a new pull request #46: '(doc)' make the method
RollingFileAppender.RollFile() virtual.
URL: https://github.com/apache/logging-log4net/pull/46
I need to post process rolled file by archiver and I can hardly achieve it
without making this method virtual.
--
dpsenner commented on issue #46: '(doc)' make the method
RollingFileAppender.RollFile() virtual.
URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458574137
Would it be more appropriate to add an invocation of an emty but virtual
PostRollFile method?
qub1n commented on issue #46: '(doc)' make the method
RollingFileAppender.RollFile() virtual.
URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458575271
Yes following empty method would be sufficient.
protected virtual void OnFileRolled(string filename){}
dpsenner commented on issue #46: '(doc)' make the method
RollingFileAppender.RollFile() virtual.
URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458578245
I propose to add both oldFile and newFile to the method arguments. Is there
a reasoning why the pull request is not
qub1n commented on issue #46: '(doc)' make the method
RollingFileAppender.RollFile() virtual.
URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458581571
Is there a reasoning why the pull request is not based onto develop?
-> No, it was just the default option on GitHub
qub1n opened a new pull request #47: '(doc)' make the method
RollingFileAppender.RollFile() virtual.
URL: https://github.com/apache/logging-log4net/pull/47
I need to post process rolled file by archiver and I can hardly achieve it
without having some virtual method like this.
1701 - 1800 of 7264 matches
Mail list logo
