[GitHub] [logging-parent] dependabot[bot] opened a new pull request #2: Bump apache from 23 to 24

2021-07-19 Thread GitBox
dependabot[bot] opened a new pull request #2: URL: https://github.com/apache/logging-parent/pull/2 Bumps [apache](https://github.com/apache/maven-apache-parent) from 23 to 24. Commits See full diff in https://github.com/apache/maven-apache-parent/commits";>compare view

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r672627108 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,163 @@ +/* + * Lice

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r672632995 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,163 @@ +/* + * Lice

[GitHub] [logging-log4j2] vy opened a new pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-19 Thread GitBox
vy opened a new pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551 This PR aims to supersede #543. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [logging-log4j2] vy commented on pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
vy commented on pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#issuecomment-882880077 @rocketraman, I have pushed my changes to #551. I had already started working on the ticket before you had submitted your PR, hence I wanted to stick to that. Nevertheless, cred

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r672651484 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,163 @@ +/* + * Lice

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r672652484 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,76 @@ +/* + * Licen

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r672653256 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined event templ

[GitHub] [logging-log4j2] rocketraman commented on pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
rocketraman commented on pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#issuecomment-882885332 > @rocketraman, I have pushed my changes to #551. I had already started working on the ticket before you had submitted your PR, hence I wanted to stick to that. #551 ha

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-19 Thread GitBox
rocketraman commented on a change in pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#discussion_r672657984 ## File path: log4j-layout-template-json/src/main/resources/GcpLayout.json ## @@ -0,0 +1,67 @@ +{ + "timestamp": { +"$resolver": "timestamp"

[GitHub] [logging-log4j2] rocketraman closed pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
rocketraman closed pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] vy commented on pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-19 Thread GitBox
vy commented on pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#issuecomment-882905913 @rocketraman, sorry for the mess. I very well see your point for _commit credit_. I will base #551 on top of #543. -- This is an automated message from the Apache Git Service.

[GitHub] [logging-log4j2] vy commented on a change in pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-19 Thread GitBox
vy commented on a change in pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#discussion_r672678885 ## File path: log4j-layout-template-json/src/main/resources/GcpLayout.json ## @@ -0,0 +1,67 @@ +{ + "timestamp": { +"$resolver": "timestamp", +"p

[GitHub] [logging-log4j2] vy commented on a change in pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-19 Thread GitBox
vy commented on a change in pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#discussion_r672688480 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,221 @@ +/* + * Lice

[GitHub] [logging-log4j2] vy commented on pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-19 Thread GitBox
vy commented on pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#issuecomment-882917321 @rocketraman, thanks so much again. I will do necessary git magic tomorrow to make your commits in #543 visible. -- This is an automated message from the Apache Git Service. T

[GitHub] [logging-log4j2] vy merged pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
vy merged pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy closed pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
vy closed pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on a change in pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
vy commented on a change in pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#discussion_r672678885 ## File path: log4j-layout-template-json/src/main/resources/GcpLayout.json ## @@ -0,0 +1,67 @@ +{ + "timestamp": { +"$resolver": "timestamp", +"p

[GitHub] [logging-log4j2] vy commented on pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
vy commented on pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#issuecomment-882917321 @rocketraman, thanks so much again. I will do necessary git magic tomorrow to make your commits in #543 visible. -- This is an automated message from the Apache Git Service. T

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r672627108 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,163 @@ +/* + * Lice

[GitHub] [logging-log4j2] vy commented on pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
vy commented on pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#issuecomment-882880077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [logging-log4j2] rocketraman commented on pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
rocketraman commented on pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#issuecomment-882885332 > @rocketraman, I have pushed my changes to #551. I had already started working on the ticket before you had submitted your PR, hence I wanted to stick to that. #551 ha

[GitHub] [logging-log4j2] rocketraman closed pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
rocketraman closed pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
rocketraman commented on a change in pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#discussion_r672657984 ## File path: log4j-layout-template-json/src/main/resources/GcpLayout.json ## @@ -0,0 +1,67 @@ +{ + "timestamp": { +"$resolver": "timestamp"

[GitHub] [logging-log4j2] vy closed pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
vy closed pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy merged pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
vy merged pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on a change in pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
vy commented on a change in pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#discussion_r672678885 ## File path: log4j-layout-template-json/src/main/resources/GcpLayout.json ## @@ -0,0 +1,67 @@ +{ + "timestamp": { +"$resolver": "timestamp", +"p

[GitHub] [logging-log4j2] vy commented on pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
vy commented on pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#issuecomment-882917321 @rocketraman, thanks so much again. I will do necessary git magic tomorrow to make your commits in #543 visible. -- This is an automated message from the Apache Git Service. T

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r672627108 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,163 @@ +/* + * Lice

[GitHub] [logging-log4j2] vy commented on pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
vy commented on pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#issuecomment-882880077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [logging-log4j2] rocketraman closed pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
rocketraman closed pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] rocketraman commented on pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
rocketraman commented on pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#issuecomment-882885332 > @rocketraman, I have pushed my changes to #551. I had already started working on the ticket before you had submitted your PR, hence I wanted to stick to that. #551 ha

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
rocketraman commented on a change in pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551#discussion_r672657984 ## File path: log4j-layout-template-json/src/main/resources/GcpLayout.json ## @@ -0,0 +1,67 @@ +{ + "timestamp": { +"$resolver": "timestamp"

[GitHub] [logging-log4j2] vy closed pull request #551: LOG4J2-3116 Add GCP logging layout

2021-07-20 Thread GitBox
vy closed pull request #551: URL: https://github.com/apache/logging-log4j2/pull/551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy merged pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
vy merged pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] rocketraman commented on pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-20 Thread GitBox
rocketraman commented on pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#issuecomment-883433350 > @rocketraman, sorry for the mess. I very well see your point for _commit credit_. I will base #551 on top of #543. I appreciate that @vy. I see you've merged th

[GitHub] [logging-log4j2] birdayz commented on pull request #488: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-07-22 Thread GitBox
birdayz commented on pull request #488: URL: https://github.com/apache/logging-log4j2/pull/488#issuecomment-884983516 Can we get this merged? We're hitting the same issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [logging-log4cxx] rm5248 merged pull request #66: LOGCXX-528

2021-07-22 Thread GitBox
rm5248 merged pull request #66: URL: https://github.com/apache/logging-log4cxx/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [logging-log4j2] vy commented on pull request #488: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-07-23 Thread GitBox
vy commented on pull request #488: URL: https://github.com/apache/logging-log4j2/pull/488#issuecomment-885588725 Thanks so much @jacobrshields! Tests also look great too. I have merged your changes into `release-2.x`. I will port this to `master` too. Looking forward to your next contribut

[GitHub] [logging-log4j2] vy closed pull request #488: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-07-23 Thread GitBox
vy closed pull request #488: URL: https://github.com/apache/logging-log4j2/pull/488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] jacobrshields commented on pull request #488: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-07-23 Thread GitBox
jacobrshields commented on pull request #488: URL: https://github.com/apache/logging-log4j2/pull/488#issuecomment-885980318 @vy Thank you for merging this in, I appreciate it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] rgoers closed pull request #217: [LOG4J2-1571] Fixed Appenders section in Extending Log4j

2018-11-20 Thread GitBox
rgoers closed pull request #217: [LOG4J2-1571] Fixed Appenders section in Extending Log4j URL: https://github.com/apache/logging-log4j2/pull/217 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] hanabi1224 opened a new pull request #28: Parameterless log manager get logger

2018-11-21 Thread GitBox
hanabi1224 opened a new pull request #28: Parameterless log manager get logger URL: https://github.com/apache/logging-log4net/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] hanabi1224 closed pull request #28: Parameterless log manager get logger

2018-11-21 Thread GitBox
hanabi1224 closed pull request #28: Parameterless log manager get logger URL: https://github.com/apache/logging-log4net/pull/28 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] hanabi1224 opened a new pull request #29: Parameterless LogManager.GetLogger

2018-11-21 Thread GitBox
hanabi1224 opened a new pull request #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29 A parameterless LogManager.GetLogger() method to simplify common usage: private static readonly ILog logger = LogManager.GetLogger(System.Reflection.Met

[GitHub] dpsenner commented on issue #29: Parameterless LogManager.GetLogger

2018-11-21 Thread GitBox
dpsenner commented on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440941624 Hi hanabi, thanks for your contribution. While your short form looks handy, it also adds a public api that relies on examining the call st

[GitHub] hanabi1224 commented on issue #29: Parameterless LogManager.GetLogger

2018-11-22 Thread GitBox
hanabi1224 commented on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440953697 @dpsenner Thank you for your reply, that is good if it comes with a CA rule to warn if people copy that line across classes but forget to repla

[GitHub] hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger

2018-11-22 Thread GitBox
hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440953697 @dpsenner Thank you for your reply, that is good if it comes with a CA rule to warn if people copy that line across classes but forget t

[GitHub] hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger

2018-11-22 Thread GitBox
hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440953697 @dpsenner Thank you for your reply, that is good if it comes with a CA rule to warn if people copy that line across classes but forget t

[GitHub] hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger

2018-11-22 Thread GitBox
hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440953697 @dpsenner Thank you for your reply, that is good if it comes with a CA rule to warn if people copy that line across classes but forget t

[GitHub] hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger

2018-11-22 Thread GitBox
hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440953697 @dpsenner Thank you for your reply, that is good if it comes with a CA rule to warn if people copy that line across classes but forget t

[GitHub] dpsenner commented on issue #29: Parameterless LogManager.GetLogger

2018-11-22 Thread GitBox
dpsenner commented on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440972914 Essentially, what you are looking for is a static method that gets a logger based on your project's / company's guidelines. The following would g

[GitHub] hanabi1224 commented on issue #29: Parameterless LogManager.GetLogger

2018-11-22 Thread GitBox
hanabi1224 commented on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440985741 @dpsenner thanks, will do This is an automated message from the Apache Git Se

[GitHub] rgoers closed pull request #239: Strings.toRootUpperCase add static

2018-11-23 Thread GitBox
rgoers closed pull request #239: Strings.toRootUpperCase add static URL: https://github.com/apache/logging-log4j2/pull/239 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] rgoers closed pull request #237: (doc) fix method name in configuration doc

2018-11-23 Thread GitBox
rgoers closed pull request #237: (doc) fix method name in configuration doc URL: https://github.com/apache/logging-log4j2/pull/237 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] rgoers closed pull request #216: Fix for LOG4J2-2453: Added dependency to log4j-slf4j18-impl

2018-11-23 Thread GitBox
rgoers closed pull request #216: Fix for LOG4J2-2453: Added dependency to log4j-slf4j18-impl URL: https://github.com/apache/logging-log4j2/pull/216 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jziolkow commented on issue #29: Parameterless LogManager.GetLogger

2018-11-28 Thread GitBox
jziolkow commented on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-442603147 On this subject, the following method is no longer available in v.2.0.8: ``` public static ILog GetLogger(string name) {

[GitHub] jziolkow edited a comment on issue #29: Parameterless LogManager.GetLogger

2018-11-28 Thread GitBox
jziolkow edited a comment on issue #29: Parameterless LogManager.GetLogger URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-442603147 On this subject, the following method is no longer available in v.2.0.8: ``` public static ILog GetLogger(string name)

[GitHub] garydgregory opened a new pull request #242: New iso date time formats

2018-12-02 Thread GitBox
garydgregory opened a new pull request #242: New iso date time formats URL: https://github.com/apache/logging-log4j2/pull/242 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] garydgregory commented on issue #242: New iso date time formats

2018-12-02 Thread GitBox
garydgregory commented on issue #242: New iso date time formats URL: https://github.com/apache/logging-log4j2/pull/242#issuecomment-443557358 Oops, need a PR vs. release-2.x, not master. This is an automated message from the A

[GitHub] garydgregory closed pull request #242: New iso date time formats

2018-12-02 Thread GitBox
garydgregory closed pull request #242: New iso date time formats URL: https://github.com/apache/logging-log4j2/pull/242 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] garydgregory opened a new pull request #243: ISO date time formats with time zone offsets

2018-12-02 Thread GitBox
garydgregory opened a new pull request #243: ISO date time formats with time zone offsets URL: https://github.com/apache/logging-log4j2/pull/243 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] remkop commented on issue #243: ISO date time formats with time zone offsets

2018-12-02 Thread GitBox
remkop commented on issue #243: ISO date time formats with time zone offsets URL: https://github.com/apache/logging-log4j2/pull/243#issuecomment-443574580 I don't see anything related to time zones in this PR. Am I missing something?

[GitHub] garydgregory closed pull request #243: ISO date time formats with time zone offsets

2018-12-03 Thread GitBox
garydgregory closed pull request #243: ISO date time formats with time zone offsets URL: https://github.com/apache/logging-log4j2/pull/243 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] garydgregory opened a new pull request #244: New iso date time formats

2018-12-03 Thread GitBox
garydgregory opened a new pull request #244: New iso date time formats URL: https://github.com/apache/logging-log4j2/pull/244 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] garydgregory commented on issue #243: ISO date time formats with time zone offsets

2018-12-03 Thread GitBox
garydgregory commented on issue #243: ISO date time formats with time zone offsets URL: https://github.com/apache/logging-log4j2/pull/243#issuecomment-443786004 Closing, messed up. This is an automated message from the Apache

[GitHub] remkop commented on a change in pull request #244: New iso date time formats

2018-12-03 Thread GitBox
remkop commented on a change in pull request #244: New iso date time formats URL: https://github.com/apache/logging-log4j2/pull/244#discussion_r238464830 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java ## @@ -183,16 +

[GitHub] garydgregory commented on a change in pull request #244: New iso date time formats

2018-12-04 Thread GitBox
garydgregory commented on a change in pull request #244: New iso date time formats URL: https://github.com/apache/logging-log4j2/pull/244#discussion_r238757885 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java ## @@ -1

[GitHub] remkop commented on a change in pull request #244: New iso date time formats

2018-12-04 Thread GitBox
remkop commented on a change in pull request #244: New iso date time formats URL: https://github.com/apache/logging-log4j2/pull/244#discussion_r238865790 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java ## @@ -183,16 +

[GitHub] garydgregory commented on a change in pull request #244: New iso date time formats

2018-12-04 Thread GitBox
garydgregory commented on a change in pull request #244: New iso date time formats URL: https://github.com/apache/logging-log4j2/pull/244#discussion_r23901 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java ## @@ -1

[GitHub] Shazwazza opened a new pull request #40: This fixes the Mutex name in the RollingFileAppender

2018-12-06 Thread GitBox
Shazwazza opened a new pull request #40: This fixes the Mutex name in the RollingFileAppender URL: https://github.com/apache/logging-log4net/pull/40 This fixes the Mutex name in the RollingFileAppender and the FileAppender to use the ApplicationUniqueId since the base file path isn't enoug

[GitHub] rocketraman opened a new pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman opened a new pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7 Add support for coroutines by fixing [LOG4J-2518](https://issues.apache.org/jira/browse/LOG4J2-2518) and [LOG4J2-2433](https://issues.apache.org/j

[GitHub] jvz commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
jvz commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239852037 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt ## @@ -1

[GitHub] rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239856567 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt #

[GitHub] rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239859451 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt #

[GitHub] jvz commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
jvz commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239870832 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt ## @@ -1

[GitHub] jvz commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
jvz commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445290342 Looks like a test failure in `LoggerCoroutinesTest`? This is an automated

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445291009 Hmm, that's odd. Works for me here. Let me see what is different on the build machine. ---

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445305670 @jvz There is an issue with this because a suspending function can't be converted to a Java `Supplier` without losing the suspensio

[GitHub] rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445305670 @jvz There is an issue with this because a suspending function can't be converted to the Java-based Log4j2 `Supplier` witho

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445312780 @jvz One approach is to do the message construction in the Kotlin code before delegating to log4j2. For example: ``` in

[GitHub] rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445312780 @jvz One approach is to do the message construction in the Kotlin code before delegating to log4j2. For example: ```

[GitHub] rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445312780 @jvz One approach is to do the message construction in the Kotlin code before delegating to log4j2. For example: ```

[GitHub] rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445312780 @jvz One approach is to do the message construction in the Kotlin code before delegating to log4j2. For example: ```

[GitHub] rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239916623 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt #

[GitHub] jvz commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
jvz commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445338376 If you identify an awkward API in log4j-api, we can always work on improving that upstream and later using it in version 1.1.x. Feel

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445343651 > Now if we could use some sort of compiler feature or macros to implement the caller info, then we can safely inline a lot of thin

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445347915 > As per my other comment, this seems to work fine with the inlining Nope, my mistake, caller information does break with inl

[GitHub] rocketraman opened a new pull request #8: LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman opened a new pull request #8: LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/8 Add support for coroutines by fixing LOG4J2-2433. ThreadContext support is added to integrate the thread-local ThreadContext with coroutines context. Su

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445393134 New pull https://github.com/apache/logging-log4j-kotlin/pull/8 submitted without the inlining, until we've decided how to handle th

[GitHub] dpsenner commented on issue #40: This fixes the Mutex name in the RollingFileAppender

2018-12-10 Thread GitBox
dpsenner commented on issue #40: This fixes the Mutex name in the RollingFileAppender URL: https://github.com/apache/logging-log4net/pull/40#issuecomment-445966741 Hi Shazwazza, thanks for your valuable contribution. Unfortunately it does not pass the continuous integration. Please rebase

[GitHub] pctimhk opened a new pull request #41: Enhance the filter to support filter the exception type name.

2018-12-10 Thread GitBox
pctimhk opened a new pull request #41: Enhance the filter to support filter the exception type name. URL: https://github.com/apache/logging-log4net/pull/41 I cannot perform the test in my visual studio 2013 environment. The feature is not yet test.

[GitHub] dpsenner commented on issue #41: Enhance the filter to support filter the exception type name.

2018-12-10 Thread GitBox
dpsenner commented on issue #41: Enhance the filter to support filter the exception type name. URL: https://github.com/apache/logging-log4net/pull/41#issuecomment-446103902 Please rebase your changes onto develop. Jenkins will pick up the task and build your contribution. It will also run

[GitHub] pctimhk opened a new pull request #42: Enhance the filter to support filter the exception type name.

2018-12-11 Thread GitBox
pctimhk opened a new pull request #42: Enhance the filter to support filter the exception type name. URL: https://github.com/apache/logging-log4net/pull/42 I cannot perform the test in my visual studio 2013 environment. The feature is not yet test.

[GitHub] pctimhk closed pull request #41: Enhance the filter to support filter the exception type name.

2018-12-11 Thread GitBox
pctimhk closed pull request #41: Enhance the filter to support filter the exception type name. URL: https://github.com/apache/logging-log4net/pull/41 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] dpsenner commented on issue #42: Enhance the filter to support filter the exception type name.

2018-12-12 Thread GitBox
dpsenner commented on issue #42: Enhance the filter to support filter the exception type name. URL: https://github.com/apache/logging-log4net/pull/42#issuecomment-446563976 The contribution does not build against the netstandard-1.3 target. -

[GitHub] pctimhk opened a new pull request #43: Enhance the filter to support filter the exception type name.

2018-12-12 Thread GitBox
pctimhk opened a new pull request #43: Enhance the filter to support filter the exception type name. URL: https://github.com/apache/logging-log4net/pull/43 Enhance the filter to support netstandard-1.3. This is an automated m

[GitHub] sullis opened a new pull request #13: maven-compiler-plugin 3.8.0

2018-12-13 Thread GitBox
sullis opened a new pull request #13: maven-compiler-plugin 3.8.0 URL: https://github.com/apache/logging-log4j-audit/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] jvz closed pull request #13: maven-compiler-plugin 3.8.0

2018-12-14 Thread GitBox
jvz closed pull request #13: maven-compiler-plugin 3.8.0 URL: https://github.com/apache/logging-log4j-audit/pull/13 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] lesiak opened a new pull request #245: [LOG4J2-2522] Make MapMessageLookup.lookup usable with MapMessage again

2018-12-17 Thread GitBox
lesiak opened a new pull request #245: [LOG4J2-2522] Make MapMessageLookup.lookup usable with MapMessage again URL: https://github.com/apache/logging-log4j2/pull/245 This is an automated message from the Apache Git Service.

<    12   13   14   15   16   17   18   19   20   21   >