[GitHub] [logging-log4j2] vy merged pull request #510: Replace try finally statement with try with resources statement

2021-06-24 Thread GitBox
vy merged pull request #510: URL: https://github.com/apache/logging-log4j2/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on pull request #514: Java 8 Improvements:

2021-06-24 Thread GitBox
vy commented on pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-867733647 @rgoers, I see that you have already approved this PR, yet did not merge it. Later on, @arturobernalg force-pushed new changes. In order to avoid double work, I will appreciate

[GitHub] [logging-log4j2] arturobernalg commented on pull request #514: Java 8 Improvements:

2021-06-24 Thread GitBox
arturobernalg commented on pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-867740270 > @rgoers, I see that you have already approved this PR, yet did not merge it. Later on, @arturobernalg force-pushed new changes. In order to avoid double work, I wil

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #529: Remove redundant variable which are immediately returned.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #529: URL: https://github.com/apache/logging-log4j2/pull/529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #530: Remove unused import.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #530: URL: https://github.com/apache/logging-log4j2/pull/530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #531: Simplify conditional expression.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #531: URL: https://github.com/apache/logging-log4j2/pull/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #532: Replace loop with bulk method.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #532: URL: https://github.com/apache/logging-log4j2/pull/532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #533: Make Local variable and parameter final.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #533: URL: https://github.com/apache/logging-log4j2/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] vy merged pull request #514: Java 8 Improvements:

2021-06-24 Thread GitBox
vy merged pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy merged pull request #533: Make Local variable and parameter final.

2021-06-24 Thread GitBox
vy merged pull request #533: URL: https://github.com/apache/logging-log4j2/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on a change in pull request #532: Replace loop with bulk method.

2021-06-24 Thread GitBox
vy commented on a change in pull request #532: URL: https://github.com/apache/logging-log4j2/pull/532#discussion_r658172667 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/TypeUtil.java ## @@ -53,9 +54,7 @@ private TypeUtil() { public static List

[GitHub] [logging-log4j2] vy merged pull request #531: Simplify conditional expression.

2021-06-24 Thread GitBox
vy merged pull request #531: URL: https://github.com/apache/logging-log4j2/pull/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #532: Replace loop with bulk method.

2021-06-24 Thread GitBox
arturobernalg commented on a change in pull request #532: URL: https://github.com/apache/logging-log4j2/pull/532#discussion_r658178940 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/TypeUtil.java ## @@ -53,9 +54,7 @@ private TypeUtil() { public

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #532: Replace loop with bulk method.

2021-06-24 Thread GitBox
carterkozak commented on a change in pull request #532: URL: https://github.com/apache/logging-log4j2/pull/532#discussion_r658181865 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/TypeUtil.java ## @@ -53,9 +54,7 @@ private TypeUtil() { public st

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #534: Make Local variable and parameter final.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #534: URL: https://github.com/apache/logging-log4j2/pull/534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #535: Make Local variable and parameter final.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #535: URL: https://github.com/apache/logging-log4j2/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #536: Make Local variable and parameter final.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #536: URL: https://github.com/apache/logging-log4j2/pull/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #537: Lambda improvements:

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #537: URL: https://github.com/apache/logging-log4j2/pull/537 * Use comparator Reverse * Replace anonymous class for lambda. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #538: Resolve references inside javadoc.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #538: URL: https://github.com/apache/logging-log4j2/pull/538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port

2021-06-25 Thread GitBox
sman-81 commented on a change in pull request #528: URL: https://github.com/apache/logging-log4j2/pull/528#discussion_r658542585 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java ## @@ -166,9 +172,7 @@ private static String createManager

[GitHub] [logging-log4j2] vy merged pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port

2021-06-25 Thread GitBox
vy merged pull request #528: URL: https://github.com/apache/logging-log4j2/pull/528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port

2021-06-25 Thread GitBox
vy commented on pull request #528: URL: https://github.com/apache/logging-log4j2/pull/528#issuecomment-868304938 Thanks so much for the fix @sman-81! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #539: Replace "==" and equals by 'Objects.equals()' expression

2021-06-25 Thread GitBox
arturobernalg opened a new pull request #539: URL: https://github.com/apache/logging-log4j2/pull/539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #540: Fix Typo.

2021-06-26 Thread GitBox
arturobernalg opened a new pull request #540: URL: https://github.com/apache/logging-log4j2/pull/540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #540: Fix Typo.

2021-06-26 Thread GitBox
rgoers commented on a change in pull request #540: URL: https://github.com/apache/logging-log4j2/pull/540#discussion_r659177952 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/RewriteAppenderBuilder.java ## @@ -50,7 +50,7 @@ /** - * Build an A

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #540: Fix Typo.

2021-06-26 Thread GitBox
arturobernalg commented on a change in pull request #540: URL: https://github.com/apache/logging-log4j2/pull/540#discussion_r659180244 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/RewriteAppenderBuilder.java ## @@ -50,7 +50,7 @@ /** - * Bui

[GitHub] [logging-log4j2] rgoers merged pull request #540: Fix Typo.

2021-06-26 Thread GitBox
rgoers merged pull request #540: URL: https://github.com/apache/logging-log4j2/pull/540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4j2] jvz commented on pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port

2021-06-26 Thread GitBox
jvz commented on pull request #528: URL: https://github.com/apache/logging-log4j2/pull/528#issuecomment-869065479 @vy your cherry pick broke master. Can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] jvz commented on pull request #514: Java 8 Improvements:

2021-06-26 Thread GitBox
jvz commented on pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-869065572 @vy the cherry pick to master here also broke the build, but I fixed that one -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [logging-log4j2] vy commented on pull request #514: Java 8 Improvements:

2021-06-27 Thread GitBox
vy commented on pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-869214104 Apologies for the mess and thanks so much @jvz! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [logging-log4j2] vy commented on pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port

2021-06-27 Thread GitBox
vy commented on pull request #528: URL: https://github.com/apache/logging-log4j2/pull/528#issuecomment-869214491 [The associated GitHub Actions run](/apache/logging-log4j2/actions/runs/970729092) has succeeded. What is exactly broken? -- This is an automated message from the Apache Git

[GitHub] [logging-log4j2] jvz commented on pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port

2021-06-27 Thread GitBox
jvz commented on pull request #528: URL: https://github.com/apache/logging-log4j2/pull/528#issuecomment-869215875 Ralph figured it out earlier today. It was in the wrong package in master. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [logging-log4j2] arturobernalg commented on pull request #514: Java 8 Improvements:

2021-06-27 Thread GitBox
arturobernalg commented on pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-869375875 Sorry for the mess guys @vy @jvz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [logging-log4j2] bbodnar opened a new pull request #541: suggested fix for LOG4J2-3114

2021-07-01 Thread GitBox
bbodnar opened a new pull request #541: URL: https://github.com/apache/logging-log4j2/pull/541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[GitHub] [logging-log4j2] sman-81 opened a new pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2021-07-01 Thread GitBox
sman-81 opened a new pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542 Hi, I've a specialized abbreviator named `DynamicWordAbbreviator` to address the specific requirement of this feature request. Javadoc added and JUnit test updated to cover the new feature. --

[GitHub] [logging-log4j2] rocketraman opened a new pull request #543: Google Cloud structured logging via JsonTemplate

2021-07-01 Thread GitBox
rocketraman opened a new pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-log4j2] sman-81 closed pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2021-07-02 Thread GitBox
sman-81 closed pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [logging-log4j2] sman-81 opened a new pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-02 Thread GitBox
sman-81 opened a new pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544 …rter for performance ~3x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [logging-log4j2] erohana commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-02 Thread GitBox
erohana commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-873185579 is this feature ready for use ? and from what version ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] TheYoBots opened a new pull request #545: Add markdown links to README.md file

2021-07-03 Thread GitBox
TheYoBots opened a new pull request #545: URL: https://github.com/apache/logging-log4j2/pull/545 No functional change, just a doc change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [logging-log4j2] vy commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-05 Thread GitBox
vy commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-873875205 @erohana, as pointed in [the JIRA ticket](https://issues.apache.org/jira/browse/LOG4J2-3004), this PR will be shipped with `2.15.0`, which is yet to be released. This said, you

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-05 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r663706396 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined event templ

[GitHub] [logging-log4j2] erohana commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-05 Thread GitBox
erohana commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-873889810 i need to create a custom exception resolver to filter the exception stacktrace, we use spring framework for our application, and spring framework stacktraces are huge so I

[GitHub] [logging-log4j2] vy commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-05 Thread GitBox
vy commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-873897779 @erohana, would [`exception[RootCause].stringified.truncation.pointMatcher{Strings,Regexes}`](https://github.com/apache/logging-log4j2/blob/release-2.x/src/site/asciidoc/manual/j

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-05 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r663937566 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,76 @@ +/*

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-05 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r664023128 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,76 @@ +/*

[GitHub] [logging-log4j2] erohana commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-05 Thread GitBox
erohana commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-874256372 i tried to use this feature, but it doesn't; filter the stacktrace, it rather filter out anything after the match. for example if I have the following stacktace : A

[GitHub] [logging-log4j2] erohana commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-05 Thread GitBox
erohana commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-874259320 checkl this example https://logging.paluch.biz/stack-trace-filter.html this is exactly what i want -- This is an automated message from the Apache Git Service. To respo

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-05 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r664090889 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,76 @@ +/* + * Licen

[GitHub] [logging-log4j2] vy commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-05 Thread GitBox
vy commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-874282674 @erohana, mind creating a Log4j JIRA ticket? Please share the example and the link(s) too. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #546: Bump tomcat-catalina from 8.5.20 to 10.0.8

2021-07-05 Thread GitBox
dependabot[bot] opened a new pull request #546: URL: https://github.com/apache/logging-log4j2/pull/546 Bumps tomcat-catalina from 8.5.20 to 10.0.8. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tom

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #517: Bump tomcat-catalina from 8.5.20 to 10.0.7

2021-07-05 Thread GitBox
dependabot[bot] closed pull request #517: URL: https://github.com/apache/logging-log4j2/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #517: Bump tomcat-catalina from 8.5.20 to 10.0.7

2021-07-05 Thread GitBox
dependabot[bot] commented on pull request #517: URL: https://github.com/apache/logging-log4j2/pull/517#issuecomment-874442546 Superseded by #546. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-06 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r663706396 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined event templ

[GitHub] [logging-log4j2] erohana commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-06 Thread GitBox
erohana commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-873889810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [logging-log4j2] vy commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-07-06 Thread GitBox
vy commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-873897779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-06 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r663937566 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,76 @@ +/*

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #517: Bump tomcat-catalina from 8.5.20 to 10.0.7

2021-07-06 Thread GitBox
dependabot[bot] commented on pull request #517: URL: https://github.com/apache/logging-log4j2/pull/517#issuecomment-874442546 Superseded by #546. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #517: Bump tomcat-catalina from 8.5.20 to 10.0.7

2021-07-06 Thread GitBox
dependabot[bot] closed pull request #517: URL: https://github.com/apache/logging-log4j2/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] vy commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-07 Thread GitBox
vy commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r665369902 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private final

[GitHub] [logging-log4j2] vy commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-07 Thread GitBox
vy commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r665369902 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private final

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-07 Thread GitBox
carterkozak commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r665376798 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ priva

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-07 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r665428126 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,76 @@ +/*

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-07 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r665452441 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined event templ

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-07 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r665463979 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined eve

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-07 Thread GitBox
sman-81 commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r665523971 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private f

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-07 Thread GitBox
sman-81 commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r665525580 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private f

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-07 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r665463979 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined eve

[GitHub] [logging-log4j2] vy commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-08 Thread GitBox
vy commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r665938957 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined event templ

[GitHub] [logging-log4j2] vy commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-08 Thread GitBox
vy commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r665949982 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private final

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-08 Thread GitBox
sman-81 commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r665971913 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private f

[GitHub] [logging-log4j2] vy commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-08 Thread GitBox
vy commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r666004260 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private final

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-08 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r666194573 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined eve

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-08 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r666196134 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java ## @@ -0,0 +1,76 @@ +/*

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-08 Thread GitBox
sman-81 commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r666251291 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private f

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #66: LOGCXX-528

2021-07-08 Thread GitBox
rm5248 opened a new pull request #66: URL: https://github.com/apache/logging-log4cxx/pull/66 Fix a few compile issues that happen with C++11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] sman-81 opened a new pull request #547: LOG4J2-3121: log4j2 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsException

2021-07-09 Thread GitBox
sman-81 opened a new pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547 …e MBean re-initialization due to InstanceAlreadyExistsException -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #547: LOG4J2-3121: log4j2 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlready

2021-07-09 Thread GitBox
garydgregory commented on a change in pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547#discussion_r667002497 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/Server.java ## @@ -389,7 +389,15 @@ private static void registerAppend

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #547: LOG4J2-3121: log4j2 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExist

2021-07-09 Thread GitBox
sman-81 commented on a change in pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547#discussion_r667014500 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/Server.java ## @@ -389,7 +389,15 @@ private static void registerAppenders(f

[GitHub] [logging-log4j2] vy commented on pull request #547: LOG4J2-3121: log4j2 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsException

2021-07-09 Thread GitBox
vy commented on pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547#issuecomment-877256537 @sman-81, given this addresses a bug, I'd appreciate a change in `changes.xml` too. (You can use `dev="ggregory"`.) -- This is an automated message from the Apache Git Service

[GitHub] [logging-log4j2] sman-81 edited a comment on pull request #547: LOG4J2-3121: log4j2 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsExce

2021-07-09 Thread GitBox
sman-81 edited a comment on pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547#issuecomment-877267982 > @sman-81, given this addresses a bug, I'd appreciate a change in `changes.xml` too. (You can use `dev="ggregory"`.) Done. I'm still new to the process 😎 I

[GitHub] [logging-log4j2] sman-81 commented on pull request #547: LOG4J2-3121: log4j2 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsException

2021-07-09 Thread GitBox
sman-81 commented on pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547#issuecomment-877267982 > @sman-81, given this addresses a bug, I'd appreciate a change in `changes.xml` too. (You can use `dev="ggregory"`.) Done. I'm still new to the process 😎 I'm not sure

[GitHub] [logging-log4j2] rschmitt commented on pull request #480: Master java11

2021-07-09 Thread GitBox
rschmitt commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-877472722 Just to confirm: does this mean that the next version of log4j2 will drop support for JDK8? -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [logging-log4j2] remkop commented on pull request #480: Master java11

2021-07-09 Thread GitBox
remkop commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-877473666 My understanding is that we will use the Java 11 compiler to generate Java-8 bytecode, so Log4j2 can be used with Java 8 at runtime. -- This is an automated message from t

[GitHub] [logging-log4j2] garydgregory commented on pull request #480: Master java11

2021-07-09 Thread GitBox
garydgregory commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-877474665 > My understanding is that we will use the Java 11 compiler to generate Java-8 bytecode, so Log4j2 can be used with Java 8 at runtime. I do not think so, 2.x wil

[GitHub] [logging-log4j2] remkop commented on pull request #480: Master java11

2021-07-09 Thread GitBox
remkop commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-877475258 My bad, thanks Gary! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [logging-log4j2] rgoers commented on pull request #480: Master java11

2021-07-09 Thread GitBox
rgoers commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-877526559 Yup, Gary is correct. The 2.x releases will remain on Java 8. The 3.0 releases will require Java 11. Ralph > On Jul 9, 2021, at 11:52 AM, Remko Popma ***@***.**

[GitHub] [logging-log4j2] vy commented on pull request #547: LOG4J2-3121 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsException

2021-07-10 Thread GitBox
vy commented on pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547#issuecomment-877685229 @garydgregory, I have resolved the merge conflict. Would you mind squashing & merging this, please? (Cherry-picking into `master` would be great.) -- This is an automated mess

[GitHub] [logging-log4j2] garydgregory merged pull request #547: LOG4J2-3121 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsException

2021-07-10 Thread GitBox
garydgregory merged pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [logging-log4j2] garydgregory commented on pull request #547: LOG4J2-3121 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsException

2021-07-10 Thread GitBox
garydgregory commented on pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547#issuecomment-877713591 Hi @vy I brought this PR into the `release-2.x` branch but I cannot get Eclipse to build anything in master. I'll put some time in to investigate but it might be a

[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #547: LOG4J2-3121 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsExcepti

2021-07-10 Thread GitBox
garydgregory edited a comment on pull request #547: URL: https://github.com/apache/logging-log4j2/pull/547#issuecomment-877713591 Hi @vy I brought this PR into the `release-2.x` branch but I cannot get Eclipse to build anything in master. I'll put some time in to investigate but it migh

[GitHub] [logging-log4j2] rschmitt commented on pull request #480: Master java11

2021-07-10 Thread GitBox
rschmitt commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-877734105 Where can I read more about the plans for 3.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [logging-log4j2] rgoers commented on pull request #480: Master java11

2021-07-11 Thread GitBox
rgoers commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-877755799 You would have to wade through the developers mailing list. We've talked about creating confluence pages but never done it. -- This is an automated message from the Apache

[GitHub] [logging-log4j2] sman-81 opened a new pull request #548: LOG4J2-2885: Added support for US-style date patterns and micro/nano seconds

2021-07-13 Thread GitBox
sman-81 opened a new pull request #548: URL: https://github.com/apache/logging-log4j2/pull/548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[GitHub] [logging-log4j2] sman-81 opened a new pull request #549: LOG4J2-2955: More precise file size expression parsing; fail-fast behavior for invalid expressions

2021-07-14 Thread GitBox
sman-81 opened a new pull request #549: URL: https://github.com/apache/logging-log4j2/pull/549 …avior for invalid expressions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-14 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r669797036 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined eve

[GitHub] [logging-log4j2] MetzIlya opened a new pull request #550: add gflog for comparison

2021-07-14 Thread GitBox
MetzIlya opened a new pull request #550: URL: https://github.com/apache/logging-log4j2/pull/550 More about gflog library - https://deltix.io/gflog.html Library github - https://github.com/epam/GFLog Test results ``` java -jar log4j-perf/target/benchmarks.jar ".*FileAppenderBe

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-15 Thread GitBox
sman-81 commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r670376745 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ private f

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-07-15 Thread GitBox
carterkozak commented on a change in pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#discussion_r670399057 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamePatternConverter.java ## @@ -29,6 +32,11 @@ */ priva

[GitHub] [logging-log4j2] rocketraman commented on a change in pull request #543: LOG4J2-3116 Google Cloud structured logging via JsonTemplate

2021-07-15 Thread GitBox
rocketraman commented on a change in pull request #543: URL: https://github.com/apache/logging-log4j2/pull/543#discussion_r670640279 ## File path: src/site/asciidoc/manual/json-template-layout.adoc.vm ## @@ -410,6 +410,15 @@ artifact, which contains the following predefined eve

<    11   12   13   14   15   16   17   18   19   20   >