mglazer opened a new pull request #508:
URL: https://github.com/apache/logging-log4j2/pull/508
This particular case fails quite often in integration tests
where you have multiple separate threads potentially creating
and destroying the singleton LoggerContext independently.
Sinc
carterkozak merged pull request #508:
URL: https://github.com/apache/logging-log4j2/pull/508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
garydgregory commented on a change in pull request #504:
URL: https://github.com/apache/logging-log4j2/pull/504#discussion_r645655510
##
File path: log4j-1.2-api/src/main/java/org/apache/log4j/Category.java
##
@@ -507,11 +508,27 @@ public void log(final String fqcn, final Prior
carterkozak commented on pull request #506:
URL: https://github.com/apache/logging-log4j2/pull/506#issuecomment-854839601
Can you describe why this is necessary? I had thought that java 8+
"effectively final" variables were equivalent at runtime, but I may be mistaken.
--
This is an auto
arturobernalg commented on pull request #506:
URL: https://github.com/apache/logging-log4j2/pull/506#issuecomment-854854147
> runtime
HI @carterkozak
The idea behind this is keep the code simple, avoid possible programing
errors by changes the reference or reassigned the variable.
carterkozak commented on pull request #505:
URL: https://github.com/apache/logging-log4j2/pull/505#issuecomment-854874004
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
carterkozak closed pull request #505:
URL: https://github.com/apache/logging-log4j2/pull/505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
carterkozak commented on pull request #507:
URL: https://github.com/apache/logging-log4j2/pull/507#issuecomment-854982427
rebased and committed directly. Conflict is my own fault for merging another
fix with a release note!
--
This is an automated message from the Apache Git Service.
To
carterkozak closed pull request #507:
URL: https://github.com/apache/logging-log4j2/pull/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
rgoers commented on pull request #506:
URL: https://github.com/apache/logging-log4j2/pull/506#issuecomment-855148181
I just looked at the style guidelines and was surprised to see that it
doesn't say anything about final. I know Gary had a thing about making stuff
final. For the most part
arturobernalg opened a new pull request #509:
URL: https://github.com/apache/logging-log4j2/pull/509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
arturobernalg closed pull request #509:
URL: https://github.com/apache/logging-log4j2/pull/509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this serv
arturobernalg opened a new pull request #510:
URL: https://github.com/apache/logging-log4j2/pull/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
arturobernalg opened a new pull request #511:
URL: https://github.com/apache/logging-log4j2/pull/511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
arturobernalg opened a new pull request #512:
URL: https://github.com/apache/logging-log4j2/pull/512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
arturobernalg opened a new pull request #513:
URL: https://github.com/apache/logging-log4j2/pull/513
Fix the number of {}-placeholders in the string literal argument does not
match the number of other arguments to the logging call.
--
This is an automated message from the Apache Git Serv
arturobernalg opened a new pull request #514:
URL: https://github.com/apache/logging-log4j2/pull/514
Since log4j supports jdk versions > 8 the idea is to use Lambda's and
method references.
* Replaced Anonymous type with method reference
* Replace Lambda with method reference
vy commented on a change in pull request #504:
URL: https://github.com/apache/logging-log4j2/pull/504#discussion_r646334274
##
File path: log4j-1.2-api/src/main/java/org/apache/log4j/Category.java
##
@@ -507,11 +508,27 @@ public void log(final String fqcn, final Priority
prior
vy commented on pull request #504:
URL: https://github.com/apache/logging-log4j2/pull/504#issuecomment-855669846
@garydgregory @carterkozak @rgoers Thanks for the review. Will merge this
and port to `master`.
--
This is an automated message from the Apache Git Service.
To respond to the
vy merged pull request #504:
URL: https://github.com/apache/logging-log4j2/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy commented on pull request #507:
URL: https://github.com/apache/logging-log4j2/pull/507#issuecomment-855764044
Darn! Good catch @carterkozak! :clap: LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
vy commented on pull request #503:
URL: https://github.com/apache/logging-log4j2/pull/503#issuecomment-857129855
Hey @nvoxland, thanks for the contribution. I have my concerns if Log4j
should have a Liquibase-specific module in the first place. Let me elaborate on
that a bit.
Certai
markdemich commented on pull request #48:
URL: https://github.com/apache/logging-log4net/pull/48#issuecomment-857599126
Is there a reason this is not merged? I'm having this issue. I have
multiple development app_pools in IIS that are attempting to write to the same
log file and creating
nvoxland commented on pull request #503:
URL: https://github.com/apache/logging-log4j2/pull/503#issuecomment-857912131
From Liquibase's standpoint, as a library we try hard not to introduce
dependencies on external libraries such as log4j. Therefore, we build off the
java.util.Logger but d
vy commented on pull request #503:
URL: https://github.com/apache/logging-log4j2/pull/503#issuecomment-858579063
I perfectly understand your conservative attitude for adding dependencies to
your project and share them. This said, dependencies increase re-usability and
independent evolution
nvoxland commented on pull request #503:
URL: https://github.com/apache/logging-log4j2/pull/503#issuecomment-858686682
Yes, I will keep the rest of the team up on this discussion.
I think that making log4j-api a required part of our API or standard logging
implementation is a no-go.
rgoers commented on pull request #503:
URL: https://github.com/apache/logging-log4j2/pull/503#issuecomment-858745835
I don't necessarily object to Log4j providing integrations with third party
components. But if something like liquibase chooses to provide its own logging
API then it should
chenrui333 opened a new pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516
It would be good to add some stale action to handle the stale PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chenrui333 opened a new pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
rgoers commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860839914
I'm not sure I agree with this. It seems too simplistic. Sometimes PRs are
good but we are slow to apply them. Prior to every release I review all the
PRs and close those I
rgoers edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860839914
I'm not sure I agree with this. It seems too simplistic. Sometimes PRs are
good but we are slow to apply them. Prior to every release I review all the
PRs and close
rgoers commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860841886
Can you please explain why we want to do this? To be honest, I don't find
much value in dependabot in the first place. All it really tells me is what the
most current versio
chenrui333 commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860848911
> Can you please explain why we want to do this? To be honest, I don't find
much value in dependabot in the first place. All it really tells me is what the
most current
chenrui333 edited a comment on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860848911
> Can you please explain why we want to do this? To be honest, I don't find
much value in dependabot in the first place. All it really tells me is what the
most c
chenrui333 commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535
yeah, you can add some labels of having stale bot ignoring the `in progress`
PRs.
--
This is an automated message from the Apache Git Service.
To respond to the messag
chenrui333 edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535
yeah, you can add some labels of having stale bot ignoring the `in progress`
PRs.
We actually have some more complicated flow in the homebrew side,
https:/
chenrui333 edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535
yeah, you can add some labels of having stale bot ignoring the `in progress`
PRs.
We actually have some more complicated flow in the homebrew side,
https:/
chenrui333 edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535
yeah, you can add some labels of having stale bot ignoring the `in progress`
PRs.
We actually have some more complicated flow in the homebrew side,
https:/
rgoers commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860868545
Thanks but that didn't really answer my question. What does enabling it for
actions and dockerfiles do? What is the benefit?
--
This is an automated message from the Apach
chenrui333 commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860950452
> Thanks but that didn't really answer my question. What does enabling it
for actions and dockerfiles do? What is the benefit?
Like I said, the benefit would be mo
rgoers commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861036923
dependency changes of what? I understand that the line specifying Maven lets
the plugin know to look at the pom.xml to look for dependencies. I have no idea
what it means to
jvz commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861085384
We have a Docker file for building that we don't really use for anything. I
think we do a pretty good job of updating dependencies normally, but a
Dependabot config for Maven p
jvz commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861097008
I think the best stale not setting would be notifying PR authors when they
have merge conflicts to fix the issue. I don't think we get enough PRs to worry
about closing old one
jvz edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861097008
I think the best stale bot setting would be notifying PR authors when they
have merge conflicts to fix the issue. I don't think we get enough PRs to worry
about closing
rgoers commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861141743
@jvz We already have that. This PR adds configuration for docker and
actions. Before deciding whether to accept the PR I need to know exactly what
that configuration causes
vy closed pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861282409
Thanks so much for letting us know of this feature, much appreciated
@chenrui333! Please don't get demotivated by the questions from the rest of us.
This is a part of the deal w
garydgregory commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861434403
We use Dependabot in Apache Commons, super useful IMO, you get a PR and
GitHub build to go along with a dependency change which gives you more
confidence that a de
garydgregory commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861443297
I agree with Ralph, staleness is not interesting here. The work I put in
here very much sporadic so the age of a PR rarely matters,.what matters more
are conflicts.
rgoers commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861608370
@garydgregory We use dependabot here as well, although it isn't nearly as
useful as it is in Commons, especially since it doesn't update changes.xml. The
issue here isn't de
rgoers edited a comment on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861608370
@garydgregory We use dependabot here as well, although it isn't nearly as
useful as it is in Commons, especially since it doesn't update changes.xml. The
issue here i
vy commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861819840
I am in favor of this change due to:
1. `find . -name Dockerfile` acknowledges that we have `Dockerfile` usages
in the code base. It is a good practice to make sure that the e
rgoers commented on pull request #515:
URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861835683
Ok. At least now I have an idea of what these are supposed to do. However,
looking at the Dockerfile I see no versions of anything. If it is just checking
the "uses" declara
dependabot[bot] opened a new pull request #517:
URL: https://github.com/apache/logging-log4j2/pull/517
Bumps tomcat-catalina from 8.5.20 to 10.0.7.
[ from 1 to
2.1.0.
Release notes
Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java'
dependabot[bot] opened a new pull request #519:
URL: https://github.com/apache/logging-log4j2/pull/519
Bumps openjdk from 8 to 16.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=openjdk&package-manager=docker&
vy merged pull request #518:
URL: https://github.com/apache/logging-log4j2/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy commented on pull request #519:
URL: https://github.com/apache/logging-log4j2/pull/519#issuecomment-862125632
@chenrui333, can we fix this to OpenJDK 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
vy commented on pull request #495:
URL: https://github.com/apache/logging-log4j2/pull/495#issuecomment-863830426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
rgoers commented on pull request #525:
URL: https://github.com/apache/logging-log4j2/pull/525#issuecomment-864159417
While I don't see anything wrong with this, this is another case where I
don't really find any advantage to the new code.
--
This is an automated message from the Apache G
sman-81 closed pull request #520:
URL: https://github.com/apache/logging-log4j2/pull/520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
hpple opened a new pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521
Hi!
This comment looks outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
arturobernalg commented on pull request #525:
URL: https://github.com/apache/logging-log4j2/pull/525#issuecomment-864242637
> While I don't see anything wrong with this, this is another case where I
don't really find any advantage to the new code.
HI @rgoers
IMO it's more readabl
unclesam123 commented on pull request #495:
URL: https://github.com/apache/logging-log4j2/pull/495#issuecomment-863813230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Fo
unclesam123 edited a comment on pull request #495:
URL: https://github.com/apache/logging-log4j2/pull/495#issuecomment-863813230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
arturobernalg opened a new pull request #525:
URL: https://github.com/apache/logging-log4j2/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
sman-81 opened a new pull request #522:
URL: https://github.com/apache/logging-log4j2/pull/522
@vy I've reiterated the fix using your suggestions.
It also contains a unit test.
NameUtil.md5 is gone from the implementation, as I see no use in it and its
presence complicates testing.
arturobernalg opened a new pull request #526:
URL: https://github.com/apache/logging-log4j2/pull/526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
rgoers commented on a change in pull request #481:
URL: https://github.com/apache/logging-log4j2/pull/481#discussion_r654555057
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/DefaultErrorHandler.java
##
@@ -84,14 +75,24 @@ public void error(final
arturobernalg opened a new pull request #524:
URL: https://github.com/apache/logging-log4j2/pull/524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
arturobernalg opened a new pull request #523:
URL: https://github.com/apache/logging-log4j2/pull/523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
sman-81 closed pull request #522:
URL: https://github.com/apache/logging-log4j2/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
sman-81 commented on pull request #522:
URL: https://github.com/apache/logging-log4j2/pull/522#issuecomment-864378237
>
>
> Something is very wrong with this PR. It has merge conflicts and impacts
way too many files.
My fix for LOG4J2-3107 changes two files and adds one. The
vy commented on pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521#issuecomment-864389997
@hpple, thanks for reminding us about that detail. Actually the comment
still applies, though the wording needs to be improved indeed: _"The precise
clock is not enabled by defa
hpple commented on pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521#issuecomment-864412200
@vy
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vy commented on pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521#issuecomment-864414040
@hpple, thanks so much for the contribution and the prompt response! Merging
it right away.
--
This is an automated message from the Apache Git Service.
To respond to the mess
vy merged pull request #521:
URL: https://github.com/apache/logging-log4j2/pull/521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
rm5248 opened a new pull request #9:
URL: https://github.com/apache/logging-chainsaw/pull/9
Add in a JSON receiver that can parse ECS log messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Noobgam commented on a change in pull request #481:
URL: https://github.com/apache/logging-log4j2/pull/481#discussion_r655495097
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/DefaultErrorHandler.java
##
@@ -84,14 +75,24 @@ public void error(fina
rm5248 merged pull request #9:
URL: https://github.com/apache/logging-chainsaw/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
NgSekLong opened a new pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527
(doc)
**TimeBasedTriggeringPolicy** modulate default is `false` is not in the doc
which might caused confusion.
Would like to suggest adding the default as false in the doc for cl
vy commented on pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527#issuecomment-865649894
Thanks for the improvement @NgSekLong! Keep them coming! (I will cherry-pick
this onto `release-2.x` too.)
--
This is an automated message from the Apache Git Service.
To resp
vy merged pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy commented on pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527#issuecomment-865649894
Thanks for the improvement @NgSekLong! Keep them coming! (I will cherry-pick
this onto `release-2.x` too.)
--
This is an automated message from the Apache Git Service.
To resp
Noobgam commented on a change in pull request #481:
URL: https://github.com/apache/logging-log4j2/pull/481#discussion_r655495097
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/DefaultErrorHandler.java
##
@@ -84,14 +75,24 @@ public void error(fina
vy merged pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
rm5248 merged pull request #9:
URL: https://github.com/apache/logging-chainsaw/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
sman-81 opened a new pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528
My fix for LOG4J2-3107 changes two files and adds one. The change is now
targeted at the release-2.x branch not master.
Hope you find it useful.
--
This is an automated message from the Apac
sman-81 commented on pull request #522:
URL: https://github.com/apache/logging-log4j2/pull/522#issuecomment-866121545
Hello @rgoers, I have submitted a corrected PR this afternoon, that goes
against the release branch not master.
Have a good evening.
--
This is an automated message fr
chenrui333 commented on pull request #519:
URL: https://github.com/apache/logging-log4j2/pull/519#issuecomment-866413135
> @chenrui333, can we fix this to OpenJDK 11?
yeah, we can totally pin the version in the dependabot for what version we
preferred.
--
This is an automated mess
chenrui333 commented on pull request #519:
URL: https://github.com/apache/logging-log4j2/pull/519#issuecomment-866413428
> I don't think it matters. As I said before you committed this, I don't
believe we use the Dockerfile for anything. If we did this already wouldn't be
working since we
vy commented on a change in pull request #528:
URL: https://github.com/apache/logging-log4j2/pull/528#discussion_r658042296
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -166,9 +172,7 @@ private static String createManagerName(
vy merged pull request #525:
URL: https://github.com/apache/logging-log4j2/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy merged pull request #523:
URL: https://github.com/apache/logging-log4j2/pull/523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy merged pull request #526:
URL: https://github.com/apache/logging-log4j2/pull/526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy merged pull request #524:
URL: https://github.com/apache/logging-log4j2/pull/524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy commented on a change in pull request #511:
URL: https://github.com/apache/logging-log4j2/pull/511#discussion_r658051704
##
File path:
log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/StringEncodingBenchmark.java
##
@@ -52,11 +53,11 @@
private static final St
1401 - 1500 of 7264 matches
Mail list logo
