[GitHub] [logging-log4j2] jacobrshields opened a new pull request #488: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-05-02 Thread GitBox
jacobrshields opened a new pull request #488: URL: https://github.com/apache/logging-log4j2/pull/488 [LOG4J2-2816](https://issues.apache.org/jira/browse/LOG4J2-2816) # Problem If `RingBufferLogEventTranslator#translateTo` throws an exception for any reason, Disruptor's `RingBu

[GitHub] [logging-log4j2] jacobrshields commented on pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions (3.x)

2021-05-02 Thread GitBox
jacobrshields commented on pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487#issuecomment-830916668 Thanks for the quick response, Gary. To clarify, the build passes locally. The failure is on the CI build. I would expect the CI build to work regardless of my own Ma

[GitHub] [logging-log4j2] jacobrshields closed pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions (3.x)

2021-05-02 Thread GitBox
jacobrshields closed pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [logging-log4j2] jacobrshields edited a comment on pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions (3.x)

2021-05-02 Thread GitBox
jacobrshields edited a comment on pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487#issuecomment-830916668 Thanks for the quick response, Gary. To clarify, the build passes locally. The failure is on the CI build. I would expect the CI build to work independently of

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #17: Kotlin provided scope

2021-05-02 Thread GitBox
rocketraman commented on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830980096 @jvz No idea why CI is failing but its not limited to this branch. The other PRs I recently submitted failed with the same error. -- This is an automated message

[GitHub] [logging-log4j-kotlin] rocketraman edited a comment on pull request #17: Kotlin provided scope

2021-05-02 Thread GitBox
rocketraman edited a comment on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830980096 @jvz No idea why CI is failing but its not limited to this branch. The other PRs I recently submitted failed with the same non-error. -- This is an automa

[GitHub] [logging-log4j-kotlin] rocketraman opened a new pull request #19: Add caching for logger lookups via interface mixin

2021-05-02 Thread GitBox
rocketraman opened a new pull request #19: URL: https://github.com/apache/logging-log4j-kotlin/pull/19 I realized the mixin was super-slow because the property delegate creates a new logger every time it is used. See https://issues.apache.org/jira/browse/LOG4J2-3086. The only workar

[GitHub] [logging-log4j2] perry2of5 commented on pull request #469: Fix windows build on master

2021-05-03 Thread GitBox
perry2of5 commented on pull request #469: URL: https://github.com/apache/logging-log4j2/pull/469#issuecomment-831688545 I'm going to cancel this. The fix is unwieldly and not well thought out. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [logging-log4j2] perry2of5 closed pull request #469: Fix windows build on master

2021-05-03 Thread GitBox
perry2of5 closed pull request #469: URL: https://github.com/apache/logging-log4j2/pull/469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [logging-log4j2] klaren opened a new pull request #489: LOG4J2-3087: Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-04 Thread GitBox
klaren opened a new pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489 [LOG4J2-2816](https://issues.apache.org/jira/browse/LOG4J2-2816) There is a "race" when constructing a `JsonTemplateLayout` that can produce invalid JSON. In the constructor of `Forma

[GitHub] [logging-log4j-kotlin] jvz commented on a change in pull request #19: Add caching for logger lookups via interface mixin

2021-05-04 Thread GitBox
jvz commented on a change in pull request #19: URL: https://github.com/apache/logging-log4j-kotlin/pull/19#discussion_r625951333 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/LoggingFactory.kt ## @@ -75,3 +81,5 @@ private fun unwrapCompanionC

[GitHub] [logging-log4j2] vy commented on a change in pull request #489: LOG4J2-3087: Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-04 Thread GitBox
vy commented on a change in pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489#discussion_r626058209 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutTimestampTest.java ## @@ -0,0 +1,4

[GitHub] [logging-log4j2] vy opened a new pull request #490: LOG4J2-3051 Add CaseConverterResolver to JsonTemplateLayout

2021-05-04 Thread GitBox
vy opened a new pull request #490: URL: https://github.com/apache/logging-log4j2/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [logging-log4j2] perry2of5 opened a new pull request #491: Fix windows build master

2021-05-04 Thread GitBox
perry2of5 opened a new pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491 This pull fixes the windows build. I have tested on windows 10 using maven 3.6.3 and Zulu's OpenJDK 11 build. It adds an annotation @DisableOnWindows to prevent the FileOutputTest test f

[GitHub] [logging-log4j2] raphw opened a new pull request #492: Use java.home property to determine what JDK distribution to use during a test.

2021-05-04 Thread GitBox
raphw opened a new pull request #492: URL: https://github.com/apache/logging-log4j2/pull/492 Observed when investigating https://github.com/mockito/mockito/issues/2282 on my setup where only JAVA_HOME was adjusted which is used by Maven and IDE but not the unit test. -- This is an autom

[GitHub] [logging-log4j2] klaren commented on a change in pull request #489: LOG4J2-3087 Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-05 Thread GitBox
klaren commented on a change in pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489#discussion_r626321001 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutTimestampTest.java ## @@ -0,0

[GitHub] [logging-log4j2] klaren commented on a change in pull request #489: LOG4J2-3087 Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-05 Thread GitBox
klaren commented on a change in pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489#discussion_r626324379 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/TimestampResolverTest.java ## @@ -0,0 +

[GitHub] [logging-log4j2] vy commented on a change in pull request #491: Fix windows build master

2021-05-06 Thread GitBox
vy commented on a change in pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491#discussion_r627141733 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutNullEventDelimiterTest.java ## @@

[GitHub] [logging-log4j2] vy commented on a change in pull request #489: LOG4J2-3087 Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-06 Thread GitBox
vy commented on a change in pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489#discussion_r627151010 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/TimestampResolverTest.java ## @@ -0,0 +1,51

[GitHub] [logging-log4j2] vy commented on a change in pull request #489: LOG4J2-3087 Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-06 Thread GitBox
vy commented on a change in pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489#discussion_r627151272 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutTimestampTest.java ## @@ -0,0 +1,4

[GitHub] [logging-log4j2] klaren commented on a change in pull request #489: LOG4J2-3087 Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-06 Thread GitBox
klaren commented on a change in pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489#discussion_r627202154 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/TimestampResolverTest.java ## @@ -0,0 +

[GitHub] [logging-log4j2] vy commented on a change in pull request #489: LOG4J2-3087 Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-06 Thread GitBox
vy commented on a change in pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489#discussion_r627215342 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/TimestampResolverTest.java ## @@ -0,0 +1,51

[GitHub] [logging-log4j2] vy merged pull request #489: LOG4J2-3087 Fix race in JsonTemplateLayout where a timestamp could end up unquoted

2021-05-06 Thread GitBox
vy merged pull request #489: URL: https://github.com/apache/logging-log4j2/pull/489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] perry2of5 commented on a change in pull request #491: Fix windows build master

2021-05-06 Thread GitBox
perry2of5 commented on a change in pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491#discussion_r627532583 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutNullEventDelimiterTest.java ###

[GitHub] [logging-log4j2] perry2of5 commented on a change in pull request #491: Fix windows build master

2021-05-06 Thread GitBox
perry2of5 commented on a change in pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491#discussion_r627535489 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/junit/DisableOnWindows.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Sof

[GitHub] [logging-log4j2] perry2of5 commented on a change in pull request #491: Fix windows build master

2021-05-06 Thread GitBox
perry2of5 commented on a change in pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491#discussion_r627556604 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/junit/DisableOnWindows.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Sof

[GitHub] [logging-log4j2] perry2of5 commented on a change in pull request #491: Fix windows build master

2021-05-06 Thread GitBox
perry2of5 commented on a change in pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491#discussion_r627662403 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/junit/DisableOnWindows.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Sof

[GitHub] [logging-log4j2] vy commented on a change in pull request #491: Fix windows build master

2021-05-07 Thread GitBox
vy commented on a change in pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491#discussion_r627976020 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutNullEventDelimiterTest.java ## @@

[GitHub] [logging-log4j2] perry2of5 commented on a change in pull request #491: LOG4J2-3088 LOG4J2-3089 Fix windows build master

2021-05-07 Thread GitBox
perry2of5 commented on a change in pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491#discussion_r628334682 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutNullEventDelimiterTest.java ###

[GitHub] [logging-log4j2] perry2of5 commented on a change in pull request #491: LOG4J2-3088 LOG4J2-3089 Fix windows build master

2021-05-07 Thread GitBox
perry2of5 commented on a change in pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491#discussion_r628334915 ## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutNullEventDelimiterTest.java ###

[GitHub] [logging-chainsaw] rm5248 opened a new pull request #7: Resize rows when editing so you can see what you're typing

2021-05-07 Thread GitBox
rm5248 opened a new pull request #7: URL: https://github.com/apache/logging-chainsaw/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [logging-chainsaw] rm5248 opened a new pull request #8: Disable OSX integration on anything that is not OSX

2021-05-07 Thread GitBox
rm5248 opened a new pull request #8: URL: https://github.com/apache/logging-chainsaw/pull/8 Chainsaw crashes on Linux(Debian 10, GNOME) when the OSX integration code runs. Simply check to see if we are on OSX before initializing. -- This is an automated message from the Apache Git Servi

[GitHub] [logging-chainsaw] rm5248 merged pull request #6: column LINE location is not correct.

2021-05-08 Thread GitBox
rm5248 merged pull request #6: URL: https://github.com/apache/logging-chainsaw/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [logging-chainsaw] rm5248 merged pull request #8: Disable OSX integration on anything that is not OSX

2021-05-08 Thread GitBox
rm5248 merged pull request #8: URL: https://github.com/apache/logging-chainsaw/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [logging-chainsaw] rm5248 merged pull request #7: Resize rows when editing so you can see what you're typing

2021-05-08 Thread GitBox
rm5248 merged pull request #7: URL: https://github.com/apache/logging-chainsaw/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [logging-log4j2] vy merged pull request #490: LOG4J2-3051 Add CaseConverterResolver to JsonTemplateLayout

2021-05-10 Thread GitBox
vy merged pull request #490: URL: https://github.com/apache/logging-log4j2/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j-kotlin] rocketraman commented on a change in pull request #19: Add caching for logger lookups via interface mixin

2021-05-10 Thread GitBox
rocketraman commented on a change in pull request #19: URL: https://github.com/apache/logging-log4j-kotlin/pull/19#discussion_r629518466 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/LoggingFactory.kt ## @@ -75,3 +81,5 @@ private fun unwrapCo

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #17: Kotlin provided scope

2021-05-10 Thread GitBox
rocketraman commented on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-837335446 @jvz Not sure what was up with the CI system before, but it seems to be working now. I added a couple of extra commits on this branch. -- This is an automated me

[GitHub] [logging-log4j-kotlin] jvz commented on pull request #17: Kotlin provided scope

2021-05-10 Thread GitBox
jvz commented on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-837368339 I'm not blocking you from merging this. Feel free :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [logging-log4j-kotlin] rocketraman merged pull request #17: Kotlin provided scope

2021-05-10 Thread GitBox
rocketraman merged pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4j-kotlin] rocketraman closed pull request #14: Upgrade Kotlin to v1.4

2021-05-10 Thread GitBox
rocketraman closed pull request #14: URL: https://github.com/apache/logging-log4j-kotlin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #14: Upgrade Kotlin to v1.4

2021-05-10 Thread GitBox
rocketraman commented on pull request #14: URL: https://github.com/apache/logging-log4j-kotlin/pull/14#issuecomment-837386965 Closing this in favor of https://github.com/apache/logging-log4j-kotlin/pull/17, to maintain compatibility with older versions of Kotlin for as long as possible.

[GitHub] [logging-log4j-kotlin] rocketraman closed pull request #19: Add caching for logger lookups via interface mixin

2021-05-10 Thread GitBox
rocketraman closed pull request #19: URL: https://github.com/apache/logging-log4j-kotlin/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #483: Bump tomcat-catalina from 8.5.20 to 10.0.5

2021-05-12 Thread GitBox
dependabot[bot] commented on pull request #483: URL: https://github.com/apache/logging-log4j2/pull/483#issuecomment-840277247 Superseded by #493. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #483: Bump tomcat-catalina from 8.5.20 to 10.0.5

2021-05-12 Thread GitBox
dependabot[bot] closed pull request #483: URL: https://github.com/apache/logging-log4j2/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #493: Bump tomcat-catalina from 8.5.20 to 10.0.6

2021-05-12 Thread GitBox
dependabot[bot] opened a new pull request #493: URL: https://github.com/apache/logging-log4j2/pull/493 Bumps tomcat-catalina from 8.5.20 to 10.0.6. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tom

[GitHub] [logging-log4net] DHirani opened a new pull request #75: Update README.md

2021-05-14 Thread GitBox
DHirani opened a new pull request #75: URL: https://github.com/apache/logging-log4net/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [logging-log4net] DHirani closed pull request #75: Update README.md

2021-05-14 Thread GitBox
DHirani closed pull request #75: URL: https://github.com/apache/logging-log4net/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [logging-log4net] DHirani commented on pull request #75: Update README.md

2021-05-14 Thread GitBox
DHirani commented on pull request #75: URL: https://github.com/apache/logging-log4net/pull/75#issuecomment-841059442 good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [logging-log4j-site] sebbASF opened a new pull request #1: Delete log4j-1.2.17/.svn directory

2021-05-14 Thread GitBox
sebbASF opened a new pull request #1: URL: https://github.com/apache/logging-log4j-site/pull/1 Should not have been committed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [logging-log4j-site] rgoers merged pull request #1: Delete log4j-1.2.17/.svn directory

2021-05-14 Thread GitBox
rgoers merged pull request #1: URL: https://github.com/apache/logging-log4j-site/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #422: Bump spring-ws-core from 2.1.4.RELEASE to 3.0.10.RELEASE

2021-05-18 Thread GitBox
dependabot[bot] commented on pull request #422: URL: https://github.com/apache/logging-log4j2/pull/422#issuecomment-843731890 Superseded by #494. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #494: Bump spring-ws-core from 2.1.4.RELEASE to 3.1.1

2021-05-18 Thread GitBox
dependabot[bot] opened a new pull request #494: URL: https://github.com/apache/logging-log4j2/pull/494 Bumps [spring-ws-core](https://github.com/spring-projects/spring-ws) from 2.1.4.RELEASE to 3.1.1. Commits https://github.com/spring-projects/spring-ws/commit/5c5b8e3f0acd596e

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #422: Bump spring-ws-core from 2.1.4.RELEASE to 3.0.10.RELEASE

2021-05-18 Thread GitBox
dependabot[bot] closed pull request #422: URL: https://github.com/apache/logging-log4j2/pull/422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4j2] vy opened a new pull request #495: LOG4J2-3075 Fix formatting of nanoseconds in JsonTemplateLayout.

2021-05-21 Thread GitBox
vy opened a new pull request #495: URL: https://github.com/apache/logging-log4j2/pull/495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [logging-log4j2] vy merged pull request #495: LOG4J2-3075 Fix formatting of nanoseconds in JsonTemplateLayout.

2021-05-24 Thread GitBox
vy merged pull request #495: URL: https://github.com/apache/logging-log4j2/pull/495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] porshkevich opened a new pull request #496: Allow JsonLayout output JSON `null` for ContextMap

2021-05-24 Thread GitBox
porshkevich opened a new pull request #496: URL: https://github.com/apache/logging-log4j2/pull/496 For now JsonLayout write string "null" to result output if ContextMap contains values equals Java Null. But JSON have own `null` concept. I change ContextDataSerializer for write normal JS

[GitHub] [logging-log4j2] vy commented on pull request #496: Allow JsonLayout output JSON `null` for ContextMap

2021-05-24 Thread GitBox
vy commented on pull request #496: URL: https://github.com/apache/logging-log4j2/pull/496#issuecomment-847283919 Thanks for the contribution @porshkevich, much appreciated. Please try to target `release-2.x` branch next time. (I will merge your changes and cherry-pick them onto `release-2.

[GitHub] [logging-log4j2] vy merged pull request #496: Allow JsonLayout output JSON `null` for ContextMap

2021-05-24 Thread GitBox
vy merged pull request #496: URL: https://github.com/apache/logging-log4j2/pull/496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] porshkevich commented on pull request #496: Allow JsonLayout output JSON `null` for ContextMap

2021-05-24 Thread GitBox
porshkevich commented on pull request #496: URL: https://github.com/apache/logging-log4j2/pull/496#issuecomment-847342776 Thanks for fast merge. I will take into account your wishes for the future. `JsonTemplateLayout` It's like a novelty. I missed his appearance a bit. When projects

[GitHub] [logging-log4j2] vy merged pull request #491: LOG4J2-3088 LOG4J2-3089 Fix windows build master

2021-05-27 Thread GitBox
vy merged pull request #491: URL: https://github.com/apache/logging-log4j2/pull/491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #497: log4j-api - Minor improvements:

2021-05-30 Thread GitBox
arturobernalg opened a new pull request #497: URL: https://github.com/apache/logging-log4j2/pull/497 * Remove Unused import * Unnecessary interface modifier * Replace array whit empty parameter * Inline variable * Simplify "if else" -- This is an automated message from the Apa

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #498: Replace assert calls with simpler but equivalent calls.

2021-05-30 Thread GitBox
arturobernalg opened a new pull request #498: URL: https://github.com/apache/logging-log4j2/pull/498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #499: Make field 'final'

2021-05-30 Thread GitBox
arturobernalg opened a new pull request #499: URL: https://github.com/apache/logging-log4j2/pull/499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] vy commented on a change in pull request #497: log4j-api - Minor improvements:

2021-05-31 Thread GitBox
vy commented on a change in pull request #497: URL: https://github.com/apache/logging-log4j2/pull/497#discussion_r642304654 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableThreadContextStack.java ## @@ -231,13 +230,10 @@ public boolean equals(final Ob

[GitHub] [logging-log4j2] arturobernalg commented on pull request #497: log4j-api - Minor improvements:

2021-05-31 Thread GitBox
arturobernalg commented on pull request #497: URL: https://github.com/apache/logging-log4j2/pull/497#issuecomment-851324163 > Thanks for your contribution @arturobernalg! Really appreciated! If you address the small remarks I have raised, I can merge your changes. HI @vy Thank yo

[GitHub] [logging-log4j2] vy commented on a change in pull request #498: Replace assert calls with simpler but equivalent calls.

2021-05-31 Thread GitBox
vy commented on a change in pull request #498: URL: https://github.com/apache/logging-log4j2/pull/498#discussion_r642319968 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTempCompressedFilePatternTest.java ## @@ -147,8 +148

[GitHub] [logging-log4j2] arturobernalg commented on pull request #498: Replace assert calls with simpler but equivalent calls.

2021-05-31 Thread GitBox
arturobernalg commented on pull request #498: URL: https://github.com/apache/logging-log4j2/pull/498#issuecomment-851352035 > Thanks so much for these improvements @arturobernalg! I have requested two changes for using `Set`-based comparison. If you don't feel like fixing them, let me know

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-05-31 Thread GitBox
arturobernalg opened a new pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg commented on pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-05-31 Thread GitBox
arturobernalg commented on pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851630497 > What is the benefit of this change? The current code seems pretty clear and efficient. HI @rgoers Don't you think it's more easy to read and understand wh

[GitHub] [logging-log4j2] arturobernalg edited a comment on pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-05-31 Thread GitBox
arturobernalg edited a comment on pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851630497 > What is the benefit of this change? The current code seems pretty clear and efficient. HI @rgoers Don't you think it's more easy to read and unders

[GitHub] [logging-log4j2] rgoers commented on pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-05-31 Thread GitBox
rgoers commented on pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851704246 If I thought it was is easier or would result in a performance gain I wouldn't have asked the question. -- This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4j2] vy merged pull request #498: Replace assert calls with simpler but equivalent calls.

2021-06-01 Thread GitBox
vy merged pull request #498: URL: https://github.com/apache/logging-log4j2/pull/498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-06-01 Thread GitBox
vy commented on pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851889225 @rgoers, from a performance perspective, I indeed don't expect any difference. This said, I agree with @arturobernalg on readability. If that is okay with you, I want to merge t

[GitHub] [logging-log4j2] vy commented on pull request #499: Make field 'final'

2021-06-01 Thread GitBox
vy commented on pull request #499: URL: https://github.com/apache/logging-log4j2/pull/499#issuecomment-851891854 Thanks @arturobernalg! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [logging-log4j2] vy merged pull request #499: Make field 'final'

2021-06-01 Thread GitBox
vy merged pull request #499: URL: https://github.com/apache/logging-log4j2/pull/499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] rgoers commented on pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-06-01 Thread GitBox
rgoers commented on pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851929320 Unless code is really unreadable I really don't care about cosmetic changes. Gary loves to rename variables to me more "clear". To me, beauty is in the eye of the beholder.

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #501: Remove unused imports

2021-06-01 Thread GitBox
arturobernalg opened a new pull request #501: URL: https://github.com/apache/logging-log4j2/pull/501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] vy merged pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-06-01 Thread GitBox
vy merged pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy merged pull request #497: log4j-api - Minor improvements:

2021-06-01 Thread GitBox
vy merged pull request #497: URL: https://github.com/apache/logging-log4j2/pull/497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy merged pull request #501: Remove unused imports

2021-06-01 Thread GitBox
vy merged pull request #501: URL: https://github.com/apache/logging-log4j2/pull/501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #502: Improvements:

2021-06-01 Thread GitBox
arturobernalg opened a new pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502 * Use Standard Charset object * Remove Unnecessary enum modifier * Make final var * Avoid String concat loop. Use StringBuilder * Remove Unnecessary interface modifier * Simpli

[GitHub] [logging-log4j2] nvoxland opened a new pull request #503: Liquibase 4.x Compatibility

2021-06-02 Thread GitBox
nvoxland opened a new pull request #503: URL: https://github.com/apache/logging-log4j2/pull/503 ## Overview Liquibase 3.6 as well as 4.0 introduced API compatibility issues with the current log4j-liquibase codebase. See liquibase/liquibase#1777 This updates the code to be comp

[GitHub] [logging-log4j2] nvoxland commented on pull request #503: Liquibase 4.x Compatibility

2021-06-02 Thread GitBox
nvoxland commented on pull request #503: URL: https://github.com/apache/logging-log4j2/pull/503#issuecomment-853355519 With the new Log4j2Logger implementation, the messages coming through in the test class look like ` liquibase.ext.logging.log4j2.Log4j2LoggerTest liquibase.logging.core.Ab

[GitHub] [logging-log4j2] vy commented on a change in pull request #502: Improvements:

2021-06-03 Thread GitBox
vy commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644751295 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static FileExtension

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #502: Improvements:

2021-06-03 Thread GitBox
rgoers commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644304021 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static FileExten

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #502: Improvements:

2021-06-03 Thread GitBox
arturobernalg commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644923664 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static Fi

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #502: Improvements:

2021-06-03 Thread GitBox
arturobernalg commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644924254 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java ## @@ -72,13 +72,13 @@ private final DatePatt

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #502: Improvements:

2021-06-03 Thread GitBox
arturobernalg commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644925648 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/tools/picocli/CommandLine.java ## @@ -4402,8 +4401,10 @@ public static IS

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #502: Improvements:

2021-06-03 Thread GitBox
arturobernalg commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644927470 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncQueueFullPolicyFactory.java ## @@ -81,9 +81,9 @@ private stati

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #502: Improvements:

2021-06-03 Thread GitBox
arturobernalg commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644928246 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/Rfc1349TrafficClass.java ## @@ -39,7 +39,7 @@ private final in

[GitHub] [logging-log4j2] vy merged pull request #502: Improvements:

2021-06-04 Thread GitBox
vy merged pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #502: Improvements:

2021-06-04 Thread GitBox
rgoers commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644304021 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static FileExten

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #502: Improvements:

2021-06-04 Thread GitBox
arturobernalg commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644923664 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static Fi

[GitHub] [logging-log4j2] vy commented on a change in pull request #502: Improvements:

2021-06-04 Thread GitBox
vy commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644751295 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static FileExtension

[GitHub] [logging-log4j2] vy merged pull request #502: Improvements:

2021-06-04 Thread GitBox
vy merged pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy opened a new pull request #504: LOG4J2-3080 Use SimpleMessage in Log4j 1 Category whenever possible

2021-06-04 Thread GitBox
vy opened a new pull request #504: URL: https://github.com/apache/logging-log4j2/pull/504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [logging-log4j2] carterkozak opened a new pull request #505: Fix incorrect LogManager accessor used by LOG4J2-2940

2021-06-04 Thread GitBox
carterkozak opened a new pull request #505: URL: https://github.com/apache/logging-log4j2/pull/505 The `getContext()` accessor with no args has been used as a fallback for Log4jLoggerFactory slf4j implementations for a while, but it's much more likely to be used now that LOG4J2-2940 is

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #506: Make Local variable and parameter final

2021-06-04 Thread GitBox
arturobernalg opened a new pull request #506: URL: https://github.com/apache/logging-log4j2/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] carterkozak opened a new pull request #507: LOG4J2-3102: AsyncAppender background thread is a daemon

2021-06-04 Thread GitBox
carterkozak opened a new pull request #507: URL: https://github.com/apache/logging-log4j2/pull/507 https://issues.apache.org/jira/browse/LOG4J2-3102 We didn't preserve the daemon flag in https://github.com/apache/logging-log4j2/pull/452/files#diff-6b30d73942796a35c3bcf93d46127d03cb69

<    9   10   11   12   13   14   15   16   17   18   >