[GitHub] [logging-log4j2] vy commented on pull request #470: [LOG4J2-3028] OutputStreamManager#flushBuffer always clears the buffer.

2021-03-01 Thread GitBox
vy commented on pull request #470: URL: https://github.com/apache/logging-log4j2/pull/470#issuecomment-787803000 @jkozlowski, thanks so much for the contribution! Would you mind updating the `changes.xml` too, please? That is, ```xml OutputStreamManager does not clear buffer

[GitHub] [logging-log4j2] jkozlowski commented on pull request #470: [LOG4J2-3028] OutputStreamManager#flushBuffer always clears the buffer.

2021-03-01 Thread GitBox
jkozlowski commented on pull request #470: URL: https://github.com/apache/logging-log4j2/pull/470#issuecomment-787872163 @vy should be done now This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [logging-log4j2] jkozlowski commented on pull request #470: [LOG4J2-3028] OutputStreamManager#flushBuffer always clears the buffer.

2021-03-01 Thread GitBox
jkozlowski commented on pull request #470: URL: https://github.com/apache/logging-log4j2/pull/470#issuecomment-787941498 Hmm, there were merge conflicts, so I merged develop and now builds aren't green; I wonder if it's an actual issue or a flake? -

[GitHub] [logging-log4j2] carterkozak commented on pull request #470: [LOG4J2-3028] OutputStreamManager#flushBuffer always clears the buffer.

2021-03-01 Thread GitBox
carterkozak commented on pull request #470: URL: https://github.com/apache/logging-log4j2/pull/470#issuecomment-787966215 It looks like a build flake, I'll take care of the merge in the next hour This is an automated message

[GitHub] [logging-log4j2] carterkozak commented on pull request #470: [LOG4J2-3028] OutputStreamManager#flushBuffer always clears the buffer.

2021-03-01 Thread GitBox
carterkozak commented on pull request #470: URL: https://github.com/apache/logging-log4j2/pull/470#issuecomment-788031443 @vy Yep, I've taken care of merging this :-) This is an automated message from the Apache Git Service.

[GitHub] [logging-log4j2] carterkozak closed pull request #470: [LOG4J2-3028] OutputStreamManager#flushBuffer always clears the buffer.

2021-03-01 Thread GitBox
carterkozak closed pull request #470: URL: https://github.com/apache/logging-log4j2/pull/470 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [logging-log4j2] vy opened a new pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-01 Thread GitBox
vy opened a new pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [logging-log4j2] vy commented on pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-01 Thread GitBox
vy commented on pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471#issuecomment-788212187 @rgoers, would you mind reviewing the changes, please? Note that I don't create a new `HashSet` for each internal call, which has used to be the case. According to tests, this s

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-01 Thread GitBox
carterkozak commented on a change in pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471#discussion_r585008161 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java ## @@ -538,24 +536,28 @@ private static void appe

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-01 Thread GitBox
carterkozak commented on a change in pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471#discussion_r585008161 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java ## @@ -538,24 +536,28 @@ private static void appe

[GitHub] [logging-log4j2] Marcono1234 commented on a change in pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-01 Thread GitBox
Marcono1234 commented on a change in pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471#discussion_r585119540 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java ## @@ -448,7 +450,7 @@ static String deepToString

[GitHub] [logging-log4j2] vy commented on pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-02 Thread GitBox
vy commented on pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471#issuecomment-788765792 @carterkozak, would you mind skimming through the changes one last time, please? If you approve, I am gonna merge this into `release-2.x` and will get busy with porting it to `m

[GitHub] [logging-log4j2] vy commented on a change in pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-02 Thread GitBox
vy commented on a change in pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471#discussion_r585384100 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java ## @@ -538,24 +536,28 @@ private static void appendArray(f

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-02 Thread GitBox
carterkozak commented on a change in pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471#discussion_r585530427 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java ## @@ -180,13 +182,29 @@ public void testDeep

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #53: Smart pointer support

2021-03-02 Thread GitBox
ams-tschoening commented on a change in pull request #53: URL: https://github.com/apache/logging-log4cxx/pull/53#discussion_r585597348 ## File path: src/cmake/boost-fallback/boost-std-configuration.h.cmake ## @@ -0,0 +1,94 @@ +#ifndef BOOST_STD_CONFIGURATION_H +#define BOOST_ST

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #53: Smart pointer support

2021-03-02 Thread GitBox
ams-tschoening commented on a change in pull request #53: URL: https://github.com/apache/logging-log4cxx/pull/53#discussion_r585600144 ## File path: src/main/cpp/domconfigurator.cpp ## @@ -331,10 +321,12 @@ void DOMConfigurator::parseErrorHandler(Pool& p, AppenderMap& a

[GitHub] [logging-log4j2] radut opened a new pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-03 Thread GitBox
radut opened a new pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472 This PR adds ability to register custom resolvers for JsonTemplateLayout This is an automated message from the Apache Git Service. T

[GitHub] [logging-log4j2] vy commented on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-04 Thread GitBox
vy commented on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-790522511 Hey @radut! This feature is something definitely on my radar, see [LOG4J2-3004](https://issues.apache.org/jira/browse/LOG4J2-3004). The reason we haven't made resolver registry

[GitHub] [logging-log4j2] vy closed pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-04 Thread GitBox
vy closed pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] vy merged pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

2021-03-04 Thread GitBox
vy merged pull request #471: URL: https://github.com/apache/logging-log4j2/pull/471 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] radut commented on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-04 Thread GitBox
radut commented on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-790543060 `JsonTemplateLayout` is a good idea, you could define specific constants like `"@version": 1`(number) or lets say `"source" : "log4j"`(string). What I am looking for is rewri

[GitHub] [logging-log4j2] radut edited a comment on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-04 Thread GitBox
radut edited a comment on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-790543060 `JsonTemplateLayout` is a good idea, you could define specific constants like `"@version": 1`(number) or lets say `"source" : "log4j"`(string). What I am looking for i

[GitHub] [logging-log4j2] vy commented on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-04 Thread GitBox
vy commented on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-790586776 > `JsonTemplateLayout` is a good idea, you could define specific constants like `"@version": 1`(number) or lets say `"source" : "log4j"`(string). What I am looking for is rewrit

[GitHub] [logging-log4j2] radut commented on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-04 Thread GitBox
radut commented on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-790592929 stringified doesn't seem to be working(or at least, not as I expect it to): log4j2.xml ``` ``` ``` ThreadContext.push("tcVal2", 2); `

[GitHub] [logging-log4j2] radut edited a comment on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-04 Thread GitBox
radut edited a comment on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-790592929 stringified doesn't seem to be working(or at least, not as I expect it to): log4j2.xml ``` ``` ```json template { "mdc" : { "$res

[GitHub] [logging-log4j2] vy commented on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-05 Thread GitBox
vy commented on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-791330965 So, I guess, both of us are right. 1. Yes, `JsonTemplateLayout` can serialize any object type, not only strings. `JTL` accesses to the thread context data using `LogEvent

[GitHub] [logging-log4j2] vy commented on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-05 Thread GitBox
vy commented on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-791402442 I think this shortcoming has already been raised in the past, see [LOG4J2-1648](https://issues.apache.org/jira/browse/LOG4J2-1648). Apparently such a feature would have other im

[GitHub] [logging-log4j2] radut commented on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-06 Thread GitBox
radut commented on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-792049028 @vy this `ObjectThreadContextMap` worked. Altough is there any way to still have this in a webApp ? I didn't tried yet in a spring boot application, but there the `javax.s

[GitHub] [logging-log4j2] vy commented on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-07 Thread GitBox
vy commented on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-792336434 Yes, just set both of the `log4j2.is.webapp` and `log4j2.enable.threadlocals` system properties to `true`. This

[GitHub] [logging-log4j2] vy edited a comment on pull request #472: Allow custom resolvers to be registered for JsonTemplateLayout

2021-03-07 Thread GitBox
vy edited a comment on pull request #472: URL: https://github.com/apache/logging-log4j2/pull/472#issuecomment-792336434 Yes, just set `log4j2.is.webapp` to `false` and `log4j2.enable.threadlocals` to `true`. This is an autom

[GitHub] [logging-log4cxx] rm5248 merged pull request #53: Smart pointer support

2021-03-08 Thread GitBox
rm5248 merged pull request #53: URL: https://github.com/apache/logging-log4cxx/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rmannibucau opened a new pull request #473: ensure EncodingPatternConverter#handlesThrowable is implemented

2021-03-09 Thread GitBox
rmannibucau opened a new pull request #473: URL: https://github.com/apache/logging-log4j2/pull/473 Giess the title is enough to understand what happens ;). Long story short the handlesThrowable() logic to skip forced (by default) append of the exception does not work as soon as encoding

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #464: Bump tomcat-catalina from 8.5.20 to 10.0.2

2021-03-10 Thread GitBox
dependabot[bot] closed pull request #464: URL: https://github.com/apache/logging-log4j2/pull/464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #474: Bump tomcat-catalina from 8.5.20 to 10.0.4

2021-03-10 Thread GitBox
dependabot[bot] opened a new pull request #474: URL: https://github.com/apache/logging-log4j2/pull/474 Bumps tomcat-catalina from 8.5.20 to 10.0.4. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tom

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #464: Bump tomcat-catalina from 8.5.20 to 10.0.2

2021-03-10 Thread GitBox
dependabot[bot] commented on pull request #464: URL: https://github.com/apache/logging-log4j2/pull/464#issuecomment-796434534 Superseded by #474. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #54: Logcxx 515

2021-03-11 Thread GitBox
rm5248 opened a new pull request #54: URL: https://github.com/apache/logging-log4cxx/pull/54 Added macros and documentation no how to utilize [fmt](https://fmt.dev/latest/index.html) with log4cxx. This intentionally does not utilize fmt within log4cxx, to avoid dependencies that are

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #55: [LOGCXX-322] Fix crashing on exit from multithreaded application

2021-03-12 Thread GitBox
rm5248 opened a new pull request #55: URL: https://github.com/apache/logging-log4cxx/pull/55 By turning the `LogManager::repositorySelector` into a std::shared_ptr as part of the smart pointer conversion, it is now possible to know when the `LogManager::repositorySelector` is valid or not

[GitHub] [logging-log4j2] carterkozak opened a new pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-16 Thread GitBox
carterkozak opened a new pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475 This allows LoggerContext lookups to avoid searching for the calling class to discover a classloader when the ContextSelector implementation is declared to be agnostic to the class loader

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-16 Thread GitBox
carterkozak commented on a change in pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#discussion_r595570063 ## File path: log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java ## @@ -47,8 +47,12 @@ protected Logger newLogger

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #54: [Logcxx-515] Add fmt support

2021-03-21 Thread GitBox
ams-tschoening commented on pull request #54: URL: https://github.com/apache/logging-log4cxx/pull/54#issuecomment-803595060 I get the following warning in Visual Studio when building everything: ``` CMake Warning at src/examples/cpp/CMakeLists.txt:15 (find_package): By not pro

[GitHub] [logging-log4cxx] rm5248 merged pull request #55: [LOGCXX-322] Fix crashing on exit from multithreaded application

2021-03-21 Thread GitBox
rm5248 merged pull request #55: URL: https://github.com/apache/logging-log4cxx/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-21 Thread GitBox
rgoers commented on a change in pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#discussion_r598352032 ## File path: log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java ## @@ -47,8 +47,12 @@ protected Logger newLogger(fina

[GitHub] [logging-log4cxx] rm5248 commented on pull request #54: [Logcxx-515] Add fmt support

2021-03-21 Thread GitBox
rm5248 commented on pull request #54: URL: https://github.com/apache/logging-log4cxx/pull/54#issuecomment-803674989 > Or should we make looking for that package simply [silent](https://cmake.org/cmake/help/latest/command/find_package.html)? > > ``` > find_package(fmt QUIET) > `

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-21 Thread GitBox
rgoers commented on a change in pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#discussion_r598352032 ## File path: log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java ## @@ -47,8 +47,12 @@ protected Logger newLogger(fina

[GitHub] [logging-log4cxx] rm5248 merged pull request #54: [Logcxx-515] Add fmt support

2021-03-22 Thread GitBox
rm5248 merged pull request #54: URL: https://github.com/apache/logging-log4cxx/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-22 Thread GitBox
carterkozak commented on a change in pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#discussion_r598688410 ## File path: log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java ## @@ -47,8 +47,12 @@ protected Logger newLogger

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-22 Thread GitBox
carterkozak commented on a change in pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#discussion_r598920010 ## File path: log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java ## @@ -47,8 +47,12 @@ protected Logger newLogger

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-22 Thread GitBox
carterkozak commented on a change in pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#discussion_r598992139 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/BasicAsyncLoggerContextSelector.java ## @@ -0,0 +1,85 @@ +/* + * Lice

[GitHub] [logging-log4j2] carterkozak commented on pull request #455: Simplify StackLocator to avoid some lambda allocation

2021-03-22 Thread GitBox
carterkozak commented on pull request #455: URL: https://github.com/apache/logging-log4j2/pull/455#issuecomment-804312697 Closing this out in favor of broader changes in #475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [logging-log4j2] carterkozak closed pull request #455: Simplify StackLocator to avoid some lambda allocation

2021-03-22 Thread GitBox
carterkozak closed pull request #455: URL: https://github.com/apache/logging-log4j2/pull/455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [logging-log4j2] vy opened a new pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-03-22 Thread GitBox
vy opened a new pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476 This change set aims to replace statically bound JSON template resolver factories with plugins. Along this pursuit, following side kicks are introduced: * Added `PluginUtil` class. * Updated

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-22 Thread GitBox
rgoers commented on a change in pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#discussion_r599073899 ## File path: log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java ## @@ -47,8 +47,12 @@ protected Logger newLogger(fina

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-22 Thread GitBox
rgoers commented on a change in pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#discussion_r599073899 ## File path: log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java ## @@ -47,8 +47,12 @@ protected Logger newLogger(fina

[GitHub] [logging-log4j2] vy commented on pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-03-23 Thread GitBox
vy commented on pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476#issuecomment-804710313 Note that this issue addresses the request in #472. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [logging-log4j2] henryw374 opened a new pull request #477: MapMessage put methods should not mandate String values

2021-03-23 Thread GitBox
henryw374 opened a new pull request #477: URL: https://github.com/apache/logging-log4j2/pull/477 the underlying Map is typed so the put methods on MapMessage can also be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] carterkozak opened a new pull request #478: LOG4J2-3054: BasicContextSelector takes the default context into account

2021-03-23 Thread GitBox
carterkozak opened a new pull request #478: URL: https://github.com/apache/logging-log4j2/pull/478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [logging-log4j2] carterkozak commented on pull request #478: LOG4J2-3054: BasicContextSelector takes the default context into account

2021-03-23 Thread GitBox
carterkozak commented on pull request #478: URL: https://github.com/apache/logging-log4j2/pull/478#issuecomment-805317341 Incoming test case, will conflict with the other branch I'm working on, however I'd prefer to merge this first and avoid duplicating bugs in the new BasicAsyncLoggerCon

[GitHub] [logging-log4j2] carterkozak edited a comment on pull request #478: LOG4J2-3054: BasicContextSelector takes the default context into account

2021-03-23 Thread GitBox
carterkozak edited a comment on pull request #478: URL: https://github.com/apache/logging-log4j2/pull/478#issuecomment-805317341 Test case conflicts with the other branch I'm working on, however I'd prefer to merge this first and avoid duplicating bugs in the new BasicAsyncLoggerContextSel

[GitHub] [logging-log4j2] carterkozak closed pull request #478: LOG4J2-3054: BasicContextSelector takes the default context into account

2021-03-23 Thread GitBox
carterkozak closed pull request #478: URL: https://github.com/apache/logging-log4j2/pull/478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [logging-log4j2] carterkozak commented on pull request #478: LOG4J2-3054: BasicContextSelector takes the default context into account

2021-03-23 Thread GitBox
carterkozak commented on pull request #478: URL: https://github.com/apache/logging-log4j2/pull/478#issuecomment-805390676 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [logging-log4j2] carterkozak closed pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-23 Thread GitBox
carterkozak closed pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [logging-log4j2] carterkozak commented on pull request #475: LOG4J2-2940: Context selectors are aware of ClassLoader dependency

2021-03-23 Thread GitBox
carterkozak commented on pull request #475: URL: https://github.com/apache/logging-log4j2/pull/475#issuecomment-805416177 Merged support for `isClassLoaderDependent` into release-2.x and master. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [logging-log4j2] carterkozak opened a new pull request #479: LOG4J2-2940 StackWalker optimization and avoidance

2021-03-23 Thread GitBox
carterkozak opened a new pull request #479: URL: https://github.com/apache/logging-log4j2/pull/479 This adds a new `BasicAsyncLoggerContextSelector` to allow fully asynchronous logging without the overhead of classloader lookups, as well as an improvement to walk the stack at most once rat

[GitHub] [logging-log4j2] carterkozak commented on pull request #479: LOG4J2-2940 StackWalker optimization and avoidance

2021-03-24 Thread GitBox
carterkozak commented on pull request #479: URL: https://github.com/apache/logging-log4j2/pull/479#issuecomment-806164744 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [logging-log4j2] carterkozak closed pull request #479: LOG4J2-2940 StackWalker optimization and avoidance

2021-03-24 Thread GitBox
carterkozak closed pull request #479: URL: https://github.com/apache/logging-log4j2/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [logging-log4j2] vy commented on pull request #477: MapMessage put methods should not mandate String values

2021-03-25 Thread GitBox
vy commented on pull request #477: URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-806455867 @henryw374, I have mentioned about your PR in the dev mailing list, there is [a discussion going on](https://mail-archives.apache.org/mod_mbox/logging-dev/202103.mbox/%3CCAP7pH7

[GitHub] [logging-log4j2] henryw374 commented on pull request #477: MapMessage put methods should not mandate String values

2021-03-25 Thread GitBox
henryw374 commented on pull request #477: URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-806502079 Thanks. I'll look in the forum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [logging-log4j2] henryw374 commented on pull request #477: MapMessage put methods should not mandate String values

2021-03-25 Thread GitBox
henryw374 commented on pull request #477: URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-806511345 I've sent a subscribe message to the list now. To add a bit more info, there is a constructor of MapMessage which takes a single map arg : ``` pu

[GitHub] [logging-log4j2] pgomulka commented on pull request #140: [LOG4J2-2171] adding log4j2.forceTCLOnly option

2021-03-25 Thread GitBox
pgomulka commented on pull request #140: URL: https://github.com/apache/logging-log4j2/pull/140#issuecomment-806713000 @jvz @rmannibucau any reason why this wasn't merged into release-2.x? at the moment in 2.x `LoaderUtil#getClassloaders` does not take into account security manager and

[GitHub] [logging-log4j2] rmannibucau commented on pull request #140: [LOG4J2-2171] adding log4j2.forceTCLOnly option

2021-03-25 Thread GitBox
rmannibucau commented on pull request #140: URL: https://github.com/apache/logging-log4j2/pull/140#issuecomment-806718786 @pgomulka no reason, a lot of master should get released soon (like SPI improvements, this, probably https://github.com/apache/logging-log4j2/pull/473 too and so on) so

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #56: Added some documentation on how to use filters

2021-03-26 Thread GitBox
rm5248 opened a new pull request #56: URL: https://github.com/apache/logging-log4cxx/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #57: Updated documentation on building log4cxx

2021-03-26 Thread GitBox
rm5248 opened a new pull request #57: URL: https://github.com/apache/logging-log4cxx/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [logging-log4cxx] rm5248 merged pull request #56: Added some documentation on how to use filters

2021-03-26 Thread GitBox
rm5248 merged pull request #56: URL: https://github.com/apache/logging-log4cxx/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [logging-log4cxx] rm5248 merged pull request #57: Updated documentation on building log4cxx

2021-03-26 Thread GitBox
rm5248 merged pull request #57: URL: https://github.com/apache/logging-log4cxx/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #58: Check for ABI changes

2021-03-27 Thread GitBox
rm5248 opened a new pull request #58: URL: https://github.com/apache/logging-log4cxx/pull/58 Add some new options to check for ABI changes between an old, known version of the ABI and the newest build version of the ABI. -- This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4j2] rgoers opened a new pull request #480: Master java11

2021-03-28 Thread GitBox
rgoers opened a new pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480 Moves master to Java11. 1. Removes all -java9 modules. 2. Required version upgrades to lots of stuff. 3. Log4j-api and Log4j-plugins are true JPMS modules. Not much else is yet. Getti

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #480: Master java11

2021-03-29 Thread GitBox
carterkozak commented on a change in pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#discussion_r603666062 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/StackLocator.java ## @@ -16,75 +16,23 @@ */ package org.apache.logging.lo

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #480: Master java11

2021-03-29 Thread GitBox
carterkozak commented on a change in pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#discussion_r603671718 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/time/internal/SystemClock.java ## @@ -16,13 +16,19 @@ */ package org.apa

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #59: Logcxx-521

2021-03-29 Thread GitBox
rm5248 opened a new pull request #59: URL: https://github.com/apache/logging-log4cxx/pull/59 Link with ODBC library if found on OSX and Linux. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #480: Master java11

2021-03-29 Thread GitBox
rgoers commented on a change in pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#discussion_r603718254 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/time/internal/SystemClock.java ## @@ -16,13 +16,19 @@ */ package org.apache.l

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #480: Master java11

2021-03-29 Thread GitBox
rgoers commented on a change in pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#discussion_r603718254 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/time/internal/SystemClock.java ## @@ -16,13 +16,19 @@ */ package org.apache.l

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #480: Master java11

2021-03-29 Thread GitBox
rgoers commented on a change in pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#discussion_r603790813 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/util/StackLocator.java ## @@ -16,75 +16,23 @@ */ package org.apache.logging.log4j.u

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #59: Logcxx-521

2021-03-30 Thread GitBox
ams-tschoening commented on a change in pull request #59: URL: https://github.com/apache/logging-log4cxx/pull/59#discussion_r603874214 ## File path: src/main/include/CMakeLists.txt ## @@ -67,12 +67,17 @@ include(CheckCXXSymbolExists) include(CheckIncludeFiles) include(CheckIn

[GitHub] [logging-log4cxx] rm5248 commented on pull request #59: Logcxx-521

2021-03-30 Thread GitBox
rm5248 commented on pull request #59: URL: https://github.com/apache/logging-log4cxx/pull/59#issuecomment-810618371 Dang... not sure how those spaces keep creeping in. I'll look into making a pre-commit hook to check for those, it should help reduce those errors. Should be fixed now thou

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #59: Logcxx-521

2021-03-31 Thread GitBox
ams-tschoening commented on pull request #59: URL: https://github.com/apache/logging-log4cxx/pull/59#issuecomment-810923318 > Dang... not sure how those spaces keep creeping in.[...] `.editorconfig` is the root cause most likely, that contains spaces for shell scripts and `CMakeLists

[GitHub] [logging-log4cxx] rm5248 merged pull request #59: Logcxx-521

2021-03-31 Thread GitBox
rm5248 merged pull request #59: URL: https://github.com/apache/logging-log4cxx/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [logging-log4j2] perry2of5 commented on pull request #480: Master java11

2021-04-01 Thread GitBox
perry2of5 commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-812102267 Building on windows, Zulu Java 11, Maven 3.6.3, I see this warning in log4j-api, log4j-plugins, and others: [WARNING] * Required filename-based automodules detected: [

[GitHub] [logging-log4j2] rgoers commented on pull request #480: Master java11

2021-04-01 Thread GitBox
rgoers commented on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-812125020 @perry2of5 Thanks. That is likely related to why I couldn't get the log4j-osgi to run its tests. I'll have to figure out what that warning means and fix it. -- This is an

[GitHub] [logging-log4j2] rgoers edited a comment on pull request #480: Master java11

2021-04-01 Thread GitBox
rgoers edited a comment on pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480#issuecomment-812125020 @perry2of5 Thanks. That is likely related to why I couldn't get the log4j-osgi module to run its tests. I'll have to figure out what that warning means and fix it.

[GitHub] [logging-log4cxx] rm5248 opened a new pull request #60: Turn the threadname into a thread_local variable

2021-04-01 Thread GitBox
rm5248 opened a new pull request #60: URL: https://github.com/apache/logging-log4cxx/pull/60 Every time a LoggingEvent is created, part of the information that is stored in the LoggingEvent is the name of the thread that the log is from. By turning this into a `thread_local` variable and

[GitHub] [logging-log4j2] Noobgam opened a new pull request #481: Fix integer overflow in DefaultErrorHandler

2021-04-02 Thread GitBox
Noobgam opened a new pull request #481: URL: https://github.com/apache/logging-log4j2/pull/481 When configured incorrectly, the ErrorHandler::error method will be called very often. As an example of such behavior, you can try stopping the appender manually. This will result in `Erro

[GitHub] [logging-log4j2] carterkozak commented on pull request #481: Fix integer overflow in DefaultErrorHandler

2021-04-02 Thread GitBox
carterkozak commented on pull request #481: URL: https://github.com/apache/logging-log4j2/pull/481#issuecomment-812636274 Thank you for reporting, great find! Would you mind filing jira issue for tracking [here](https://issues.apache.org/jira/browse/LOG4J2)? -- This is an automated messa

[GitHub] [logging-log4j2] Noobgam commented on pull request #481: LOG4J2-3004 Fix integer overflow in DefaultErrorHandler

2021-04-02 Thread GitBox
Noobgam commented on pull request #481: URL: https://github.com/apache/logging-log4j2/pull/481#issuecomment-812639094 Sure https://issues.apache.org/jira/browse/LOG4J2-3060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] rgoers merged pull request #480: Master java11

2021-04-02 Thread GitBox
rgoers merged pull request #480: URL: https://github.com/apache/logging-log4j2/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [logging-log4j2] vy merged pull request #476: LOG4J2-3004 Add plugin support to JsonTemplateLayout.

2021-04-03 Thread GitBox
vy merged pull request #476: URL: https://github.com/apache/logging-log4j2/pull/476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #414: Bump maven-core from 3.6.0 to 3.6.3

2021-04-04 Thread GitBox
dependabot[bot] commented on pull request #414: URL: https://github.com/apache/logging-log4j2/pull/414#issuecomment-813110469 Superseded by #482. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #482: Bump maven-core from 3.6.0 to 3.8.1

2021-04-04 Thread GitBox
dependabot[bot] opened a new pull request #482: URL: https://github.com/apache/logging-log4j2/pull/482 Bumps [maven-core](https://github.com/apache/maven) from 3.6.0 to 3.8.1. Commits https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d";>05c21c6 [ma

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #414: Bump maven-core from 3.6.0 to 3.6.3

2021-04-04 Thread GitBox
dependabot[bot] closed pull request #414: URL: https://github.com/apache/logging-log4j2/pull/414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4cxx] rm5248 commented on pull request #60: Turn the threadname into a thread_local variable

2021-04-06 Thread GitBox
rm5248 commented on pull request #60: URL: https://github.com/apache/logging-log4cxx/pull/60#issuecomment-814452988 That is actually a much simpler implementation. I didn't think about doing it that way, as I was thinking about having a fallback method of having a map of thread<->name. T

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #474: Bump tomcat-catalina from 8.5.20 to 10.0.4

2021-04-06 Thread GitBox
dependabot[bot] commented on pull request #474: URL: https://github.com/apache/logging-log4j2/pull/474#issuecomment-814555147 Superseded by #483. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

<    7   8   9   10   11   12   13   14   15   16   >