szpak opened a new pull request #461:
URL: https://github.com/apache/logging-log4j2/pull/461
Random trivial change as I was reading that file. It renders much greatly.
This is an automated message from the Apache Git Service.
vy commented on pull request #461:
URL: https://github.com/apache/logging-log4j2/pull/461#issuecomment-762897201
Thanks @szpak! I will see if we can backport this to `release-2.x` as well.
This is an automated message from th
vy merged pull request #461:
URL: https://github.com/apache/logging-log4j2/pull/461
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy commented on pull request #461:
URL: https://github.com/apache/logging-log4j2/pull/461#issuecomment-762900591
Fits to `release-2.x` like a glove. :+1:
This is an automated message from the Apache Git Service.
To respond t
ldd200888 opened a new pull request #6:
URL: https://github.com/apache/logging-chainsaw/pull/6
When adding columnName, LINE is after MILLIS_DELTA:
```
columnNames.add(ChainsawConstants.CLASS_COL_NAME);
columnNames.add(ChainsawConstants.METHOD_COL_NAME);
columnNames.ad
fluffynuts commented on pull request #72:
URL: https://github.com/apache/logging-log4net/pull/72#issuecomment-764895685
I'm not sold yet; right now, it adds complexity and risk: it's a way for
third-party code to intercept logging when that third-party code takes a guess
that an appender u
fluffynuts closed pull request #72:
URL: https://github.com/apache/logging-log4net/pull/72
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fluffynuts edited a comment on pull request #72:
URL: https://github.com/apache/logging-log4net/pull/72#issuecomment-764895685
I'm not sold yet; right now, it adds complexity and risk: it's a way for
third-party code to intercept logging when that third-party code takes a guess
that an app
fluffynuts edited a comment on pull request #72:
URL: https://github.com/apache/logging-log4net/pull/72#issuecomment-764895685
I'm not sold yet; right now, it adds complexity and risk: it's a way for
third-party code to intercept logging when that third-party code takes a guess
that an app
fluffynuts closed pull request #72:
URL: https://github.com/apache/logging-log4net/pull/72
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fluffynuts commented on pull request #72:
URL: https://github.com/apache/logging-log4net/pull/72#issuecomment-764895685
I'm not sold yet; right now, it adds complexity and risk: it's a way for
third-party code to intercept logging when that third-party code takes a guess
that an appender u
vy merged pull request #458:
URL: https://github.com/apache/logging-log4j2/pull/458
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy merged pull request #458:
URL: https://github.com/apache/logging-log4j2/pull/458
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fabricc opened a new pull request #462:
URL: https://github.com/apache/logging-log4j2/pull/462
When using arrays in a configuration file the parameter type is used to
identify which plugin should be used and therefore it is reserved. For this
reason, the type of EventTemplateAdditionalFiel
vy commented on a change in pull request #462:
URL: https://github.com/apache/logging-log4j2/pull/462#discussion_r565372164
##
File path:
log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutAdditionalFieldTestProperties.java
###
perry2of5 opened a new pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463
Add context-param to prevent auto-shutdown of log4j in Servlet 3.0
environment. Add ServletContextListener to shutdown log4j which should probably
be used as the first listener in an applicatio
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-769333626
This pull request provides a workaround for LOG4J2-1606 and LOG4J2-2624.
This is an automated message fro
jftai1 commented on pull request #462:
URL: https://github.com/apache/logging-log4j2/pull/462#issuecomment-769876336
Please had my vote on fixing this issue...
I am hoping to use this feature in a server which has a log4j2.properties
configuration and a cannot alter the format.
jftai1 edited a comment on pull request #462:
URL: https://github.com/apache/logging-log4j2/pull/462#issuecomment-769876336
Please had my vote on fixing this issue...
I am hoping to use this feature in a server which has a log4j2.properties
configuration and a cannot alter the form
vy commented on pull request #462:
URL: https://github.com/apache/logging-log4j2/pull/462#issuecomment-769884311
> Please had my vote on fixing this issue...
I will make sure this will be available in 2.14.1 which we will release in a
couple of weeks.
> I am hoping to use this
Fabricc commented on a change in pull request #462:
URL: https://github.com/apache/logging-log4j2/pull/462#discussion_r567292483
##
File path:
log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutAdditionalFieldTestProperties.java
##
rm5248 opened a new pull request #51:
URL: https://github.com/apache/logging-log4cxx/pull/51
Remove the old build tools(ant, maven, autotools) as these have at this
point been superseded by the cmake/doxygen process that we merged in #49
---
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771056049
Matt, I submitted a signed Apache ICLA to the secretary. I am happy to work
on updating the documentation. Tim
PS: Should we link the issues to this? Or is it too l
jvz commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771077498
Ok, I got the ICLA (I'm also the secretary coincidentally). You can link the
issue to this, yes. You can update the title, too. We generally note issues in
`src/changes/changes
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771079985
How do I link the issues? Do I need to modify the PR in some way? Same
question on updating src/changes/changes.xml. Thank you.
-
jvz commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771100956
The changes.xml file is fairly self-explanatory, but you don't need to edit
it. For linking this, you can just edit the title of the PR to include the
LOG4J2 Jira issue id.
-
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-77653
Thank you. I added "LOG4J2-1606, LOG4J2-2624" to the title but it doesn't
seem to have linked to the JIRA issues. Perhaps there is a lag until a job
runs. Let me know if
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771238403
Sorry...I didn't realize pushing to my fork would trigger any changes here.
Obviously I'm not very familiar with github or working on this project. From
the documentation
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771282217
What developer name should I use in changes.xml? Do I need an official
apache developer name? Should I just put in "jvz" to make things move along
quickly?
---
jvz commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771770678
In the changes, you can put `mattsicker` (my apache id), and add `due-to`
with your name. That latter part is what gets generated as the "Thanks to Name"
in the changelog (deve
jvz commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771771266
As for auto-linking, that's handled by some ASF/GitHub bot that integrates
things. If you see entries added to the Jira history of an issue, that's one
area it links things.
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-772007764
I updated the changes.xml as you described squashed the update into the "add
notes about LOG4J-2626..." commit and pushed to Github. I am not aware of any
other tasks I n
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771238403
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jvz commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-771770678
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dependabot[bot] opened a new pull request #464:
URL: https://github.com/apache/logging-log4j2/pull/464
Bumps tomcat-catalina from 8.5.20 to 10.0.2.
[ methods if they configured the web app entirely
with XML. Now
perry2of5 commented on pull request #463:
URL: https://github.com/apache/logging-log4j2/pull/463#issuecomment-773492809
You are very welcome. I was getting tired of telling junior staff not to use
Spring's SmartLifecycle.stop() methods if they configured the web app entirely
with XML. Now
rgoers merged pull request #450:
URL: https://github.com/apache/logging-log4j2/pull/450
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgoers commented on pull request #447:
URL: https://github.com/apache/logging-log4j2/pull/447#issuecomment-774571763
@carterkozak are you waiting on something before committing this?
This is an automated message from the Apac
carterkozak commented on pull request #447:
URL: https://github.com/apache/logging-log4j2/pull/447#issuecomment-774574156
Still planning to write a fix for the issue when I have more time, happy to
merge this as is if you like.
-
rgoers commented on pull request #437:
URL: https://github.com/apache/logging-log4j2/pull/437#issuecomment-774580435
I am going to merge this but it would be more appropriate in 2.15.0 so I
will hold off until after the 2.14.1 release.
-
rgoers merged pull request #424:
URL: https://github.com/apache/logging-log4j2/pull/424
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
solaristhesun commented on pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#issuecomment-777325037
What ist the status on this? I am getting the following errors:
w: Runtime JAR files in the classpath should have the same version. These
files were found
solaristhesun edited a comment on pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#issuecomment-777325037
What ist the status on this? I am getting the following errors:
```
w: Runtime JAR files in the classpath should have the same version. These
fil
rocketraman commented on pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#issuecomment-777474336
> So it looks to me as if it is not working in kotlin 1.4 despite someone
saying it _should_. What steps are necessary to get it working in 1.4.
See my last
mikaello commented on pull request #14:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/14#issuecomment-777526127
Sorry for not replying! I tried to figure out how to avoid distributing the
stdlib as a transitive dependency, but I struggled a bit, and after a while I
surrendered
rm5248 commented on pull request #51:
URL: https://github.com/apache/logging-log4cxx/pull/51#issuecomment-778782446
I'll merge shortly if there are no comments.
This is an automated message from the Apache Git Service.
To res
roberttaylor426 opened a new pull request #465:
URL: https://github.com/apache/logging-log4j2/pull/465
I noticed a typo in the docs, and then realised the same typo existed in a
bunch of places.
This is an automated message
rgoers commented on pull request #465:
URL: https://github.com/apache/logging-log4j2/pull/465#issuecomment-778815708
Just a note that since this is against master it will not affect the current
log4j documentation on the release-2.x branch. A separate PR will be needed for
that.
rm5248 opened a new pull request #52:
URL: https://github.com/apache/logging-log4cxx/pull/52
Add a message handler function that is used for Qt so that log messages from
Qt can be routed through log4cxx.
Note that this is built as a separate library - this is intentional, as many
pe
ams-tschoening commented on pull request #51:
URL: https://github.com/apache/logging-log4cxx/pull/51#issuecomment-779133161
I couldn't find any mail with your requested review, but mails have changed
for me, so they might have been dropped for some reason. Anyway, the only thing
I've recog
rm5248 commented on pull request #51:
URL: https://github.com/apache/logging-log4cxx/pull/51#issuecomment-779470636
No, I actually forgot to remove those. Those have now been removed.
This is an automated message from the Ap
vy commented on pull request #465:
URL: https://github.com/apache/logging-log4j2/pull/465#issuecomment-780111442
Thanks so much @roberttaylor426, appreciated it! I will merge it right away.
As @rgoers noted, these changes will not be visible in the website, which is
pointing to the d
vy merged pull request #465:
URL: https://github.com/apache/logging-log4j2/pull/465
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy commented on pull request #465:
URL: https://github.com/apache/logging-log4j2/pull/465#issuecomment-780115790
Cherry-picked onto `release-2.x` with some extra little effort.
This is an automated message from the Apache Git
rm5248 merged pull request #51:
URL: https://github.com/apache/logging-log4cxx/pull/51
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rm5248 merged pull request #52:
URL: https://github.com/apache/logging-log4cxx/pull/52
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vy opened a new pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory commented on a change in pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#discussion_r577568161
##
File path: log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
##
@@ -80,59 +80,61 @@
* Logs an exception or error that has be
garydgregory commented on a change in pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#discussion_r577568701
##
File path: log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
##
@@ -292,12 +294,12 @@
/**
* Logs a message at the {@l
vy commented on a change in pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#discussion_r577592796
##
File path: log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
##
@@ -80,59 +80,61 @@
* Logs an exception or error that has been caught
Marcono1234 commented on pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#issuecomment-780923693
Thanks! Though as pointed out in LOG4J2-3021, the documentation for
`Logger.throwing(...)` would now be incorrect for the `java.util.logging`
implementation which logs
Marcono1234 edited a comment on pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#issuecomment-780923693
Thanks! ~~Though as pointed out in LOG4J2-3021, the documentation for
`Logger.throwing(...)` would now be incorrect for the `java.util.logging`
implementation wh
Marcono1234 edited a comment on pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#issuecomment-780923693
Thanks! ~~Though as pointed out in LOG4J2-3021, the documentation for
`Logger.throwing(...)` would now be incorrect for the `java.util.logging`
implementation wh
rm5248 opened a new pull request #53:
URL: https://github.com/apache/logging-log4cxx/pull/53
This PR should switch log4cxx over to using smart pointers(either
std::shared_ptr or boost:shared_ptr) as appropriate. It also uses
synchronization as defined by the C++ standard(std::mutex) or bo
vy opened a new pull request #467:
URL: https://github.com/apache/logging-log4j2/pull/467
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vy commented on pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#issuecomment-781412257
> Would it make sense to change these methods (in Log4j 3.x?) to log at
`DEBUG` level? As mentioned in the Jira report descriptions logging at `ERROR`
will likely cause redundan
vy merged pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy commented on pull request #467:
URL: https://github.com/apache/logging-log4j2/pull/467#issuecomment-781450999
Except the tests belong to `log4j-jackson-layout*` modules, I have removed
the following tests in `log4j-core-its`:
- HttpAppenderTest.java (was already disabled)
- Jso
carterkozak opened a new pull request #468:
URL: https://github.com/apache/logging-log4j2/pull/468
I've applied some refactors I wrote a while ago:
https://github.com/palantir/assertj-automation
Separated into two commits, first migrates from other asserts to assertj,
and a second which
carterkozak commented on a change in pull request #468:
URL: https://github.com/apache/logging-log4j2/pull/468#discussion_r579498048
##
File path: log4j-1.2-api/src/test/java/org/apache/log4j/CategoryTest.java
##
@@ -78,23 +78,23 @@ public void testForcedLog() {
catego
rgoers commented on a change in pull request #468:
URL: https://github.com/apache/logging-log4j2/pull/468#discussion_r579613637
##
File path:
log4j-1.2-api/src/test/java/org/apache/log4j/CallerInformationTest.java
##
@@ -57,9 +57,9 @@ public void testMethodLogger() throws Exce
carterkozak commented on a change in pull request #468:
URL: https://github.com/apache/logging-log4j2/pull/468#discussion_r579657898
##
File path:
log4j-1.2-api/src/test/java/org/apache/log4j/CallerInformationTest.java
##
@@ -57,9 +57,9 @@ public void testMethodLogger() throws
carterkozak commented on a change in pull request #468:
URL: https://github.com/apache/logging-log4j2/pull/468#discussion_r579658494
##
File path: log4j-1.2-api/src/test/java/org/apache/log4j/CategoryTest.java
##
@@ -78,23 +78,23 @@ public void testForcedLog() {
catego
carterkozak commented on a change in pull request #468:
URL: https://github.com/apache/logging-log4j2/pull/468#discussion_r579683174
##
File path: log4j-1.2-api/src/test/java/org/apache/log4j/CategoryTest.java
##
@@ -78,23 +78,23 @@ public void testForcedLog() {
catego
vy closed pull request #467:
URL: https://github.com/apache/logging-log4j2/pull/467
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy commented on pull request #467:
URL: https://github.com/apache/logging-log4j2/pull/467#issuecomment-784045170
Closing the PR – see JIRA ticket for details.
This is an automated message from the Apache Git Service.
To respo
perry2of5 opened a new pull request #469:
URL: https://github.com/apache/logging-log4j2/pull/469
This pull fixes the build on Windows.
This is an automated message from the Apache Git Service.
To respond to the message, plea
jkozlowski opened a new pull request #470:
URL: https://github.com/apache/logging-log4j2/pull/470
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
carterkozak commented on a change in pull request #470:
URL: https://github.com/apache/logging-log4j2/pull/470#discussion_r583283312
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/OutputStreamManager.java
##
@@ -278,10 +278,13 @@ protected synchr
ams-tschoening commented on a change in pull request #53:
URL: https://github.com/apache/logging-log4cxx/pull/53#discussion_r583546475
##
File path: src/main/cpp/domconfigurator.cpp
##
@@ -331,10 +321,12 @@ void DOMConfigurator::parseErrorHandler(Pool& p,
AppenderMap& a
ams-tschoening commented on a change in pull request #53:
URL: https://github.com/apache/logging-log4cxx/pull/53#discussion_r583548541
##
File path: src/cmake/boost-fallback/boost-std-configuration.h.cmake
##
@@ -0,0 +1,94 @@
+#ifndef BOOST_STD_CONFIGURATION_H
+#define BOOST_ST
ams-tschoening commented on a change in pull request #53:
URL: https://github.com/apache/logging-log4cxx/pull/53#discussion_r583550738
##
File path: src/cmake/boost-fallback/boost-std-configuration.h.cmake
##
@@ -0,0 +1,94 @@
+#ifndef BOOST_STD_CONFIGURATION_H
+#define BOOST_ST
ams-tschoening commented on a change in pull request #53:
URL: https://github.com/apache/logging-log4cxx/pull/53#discussion_r583593578
##
File path: src/cmake/boost-fallback/boost-std-configuration.h.cmake
##
@@ -0,0 +1,94 @@
+#ifndef BOOST_STD_CONFIGURATION_H
+#define BOOST_ST
Marcono1234 commented on pull request #466:
URL: https://github.com/apache/logging-log4j2/pull/466#issuecomment-786832118
> To further consult to the rest of the developers, would you mind moving
this discussion to [the dev mailing
list](https://logging.apache.org/log4j/2.x/mail-lists.html
tschettler opened a new pull request #73:
URL: https://github.com/apache/logging-log4net/pull/73
This refactors type activation into an `ActivationProvider` class, which
provides wrapper methods for the `IActivator` interface. The default
`IActivator` implementation (`DefaultActivator`) de
vy commented on pull request #470:
URL: https://github.com/apache/logging-log4j2/pull/470#issuecomment-787799822
@carterkozak, I am joining to the party late, sorry. What is the status of
this PR? Can we merge it?
This is an
vy edited a comment on pull request #470:
URL: https://github.com/apache/logging-log4j2/pull/470#issuecomment-787799822
@carterkozak, I am joining to the party late, sorry. What is the status of
this PR? Can we merge it? (Note that the volunteer to merge might need to port
this to `master`
1001 - 1100 of 7264 matches
Mail list logo
