quaff closed pull request #214:
URL: https://github.com/apache/logging-log4j2/pull/214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
quaff opened a new pull request #363:
URL: https://github.com/apache/logging-log4j2/pull/363
according to
https://github.com/apache/logging-log4j2/blob/d304e034dfd3e3e5ca115b6b6e6f22d72d606850/log4j-core/src/main/java/org/apache/logging/log4j/core/config/composite/CompositeConfiguration.jav
vy commented on pull request #362:
URL: https://github.com/apache/logging-log4j2/pull/362#issuecomment-635907456
Thanks for the patch @gagoman! `release-2.x` builds are failing right now
due to some other problem. Once they got fixed, I will merge the PR.
-
vy commented on pull request #363:
URL: https://github.com/apache/logging-log4j2/pull/363#issuecomment-635958350
@jvz, you appear to be the one who has committed these unit tests in the
first place. How come they were not failing given the wrong property was used?
(Sorry for the short-sigh
rgoers commented on pull request #363:
URL: https://github.com/apache/logging-log4j2/pull/363#issuecomment-636038992
The test is in the API module and is only testing the property name
resolution. The CompositeConfiguration is in Core so these properties can't be
used for anything in this
rgoers edited a comment on pull request #363:
URL: https://github.com/apache/logging-log4j2/pull/363#issuecomment-636038992
The test is in the API module and is only testing the property name
resolution. The CompositeConfiguration is in Core so these properties can't be
used for anything i
jvz commented on pull request #363:
URL: https://github.com/apache/logging-log4j2/pull/363#issuecomment-636063853
Yeah, looks like a typo, but the test still works because it was testing the
name mangling.
This is an automat
remkop commented on a change in pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#discussion_r432747196
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
##
@@ -60,36 +60,44 @@
private DisruptorUtil() {
stepan2271 commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-636316106
> I put some comments on the mechanics of the proposed changes, but I
actually have a bigger question:
>
> what problem are we trying to solve?
> Can you explai
stepan2271 edited a comment on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-636316106
> I put some comments on the mechanics of the proposed changes, but I
actually have a bigger question:
>
> what problem are we trying to solve?
> Can you
stepan2271 edited a comment on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-636316106
> I put some comments on the mechanics of the proposed changes, but I
actually have a bigger question:
>
> what problem are we trying to solve?
> Can you
remkop commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-636318316
Understood, thanks for the clarification!
This is an automated message from the Apache Git Service.
To respo
stepan2271 commented on a change in pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#discussion_r432846623
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
##
@@ -60,36 +60,44 @@
private DisruptorUtil()
stepan2271 commented on a change in pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#discussion_r432847711
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
##
@@ -60,36 +60,44 @@
private DisruptorUtil()
stepan2271 commented on a change in pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#discussion_r432847711
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
##
@@ -60,36 +60,44 @@
private DisruptorUtil()
stepan2271 commented on a change in pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#discussion_r432847711
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
##
@@ -60,36 +60,44 @@
private DisruptorUtil()
remkop commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-636391507
Thanks for making those changes.
The system properties used in Log4j2 are documented in this section in the
Configuration page of the manual:
https://github.com/apach
stepan2271 commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-636477083
> Thanks for making those changes.
>
> The system properties used in Log4j2 are documented in this section in the
Configuration page of the manual:
https://github
stepan2271 commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-636522533
Last two builds failed in spite of the fact that my last commits were to
documentation only:(
This is a
remkop commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-637158687
Thank you for the contribution, @stepan2271 !
This is an automated message from the Apache Git Service.
To r
pm-cfs opened a new pull request #24:
URL: https://github.com/apache/logging-log4cxx/pull/24
# Summary
This PR implements the mapfilter for log4cxx.
# Changes
Added implementation of mapfilter
_NOTES:_ the original mapfilter in log4j is a plugin; therefore, it uses a
dif
ams-tschoening commented on pull request #24:
URL: https://github.com/apache/logging-log4cxx/pull/24#issuecomment-637996750
Thanks for the PR, just for reference, this is the thread referred to:
http://mail-archives.apache.org/mod_mbox/logging-dev/202005.mbox/%3CCAAWxiMAKcN1iM0Aj_g0U
ams-tschoening commented on a change in pull request #24:
URL: https://github.com/apache/logging-log4cxx/pull/24#discussion_r434354711
##
File path: src/main/include/log4cxx/filter/mapfilter.h
##
@@ -19,26 +19,87 @@
#include
+#if defined(_MSC_VER)
+ #pragma warning
pm-cfs commented on a change in pull request #24:
URL: https://github.com/apache/logging-log4cxx/pull/24#discussion_r434634258
##
File path: src/main/include/log4cxx/filter/mapfilter.h
##
@@ -19,26 +19,87 @@
#include
+#if defined(_MSC_VER)
+ #pragma warning ( push )
rm5248 commented on a change in pull request #24:
URL: https://github.com/apache/logging-log4cxx/pull/24#discussion_r436224245
##
File path: src/main/include/log4cxx/filter/mapfilter.h
##
@@ -19,26 +19,87 @@
#include
+#if defined(_MSC_VER)
+ #pragma warning ( push )
pm-cfs commented on a change in pull request #24:
URL: https://github.com/apache/logging-log4cxx/pull/24#discussion_r436245461
##
File path: src/main/include/log4cxx/filter/mapfilter.h
##
@@ -19,26 +19,87 @@
#include
+#if defined(_MSC_VER)
+ #pragma warning ( push )
ams-tschoening opened a new pull request #25:
URL: https://github.com/apache/logging-log4cxx/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
ams-tschoening merged pull request #24:
URL: https://github.com/apache/logging-log4cxx/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ams-tschoening merged pull request #25:
URL: https://github.com/apache/logging-log4cxx/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
gagoman commented on pull request #362:
URL: https://github.com/apache/logging-log4j2/pull/362#issuecomment-640276744
Awesome, thanks! Please let me know if any changes or rebase to other branch
is required.
This is an autom
stepan2271 commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-641302933
Thanks, @remkop! Should I do smth to fix build? Seems like the build fails,
but it is unrelated to my changes.
```
[INFO] Results:
[INFO]
[ERROR
vy opened a new pull request #364:
URL: https://github.com/apache/logging-log4j2/pull/364
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vy merged pull request #364:
URL: https://github.com/apache/logging-log4j2/pull/364
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
qoomon commented on pull request #10:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/10#issuecomment-646098077
any release schedule?
This is an automated message from the Apache Git Service.
To respond to the messa
baldapps opened a new pull request #26:
URL: https://github.com/apache/logging-log4cxx/pull/26
The method getThreshold wasn't const so it wasn't possible to call
getThreshold on a const object and const cast was needed.
This
ams-tschoening commented on pull request #26:
URL: https://github.com/apache/logging-log4cxx/pull/26#issuecomment-647131780
Thanks for fixing! As this is a minor change, I won't update `changes.xml`
for now.
This is an autom
ams-tschoening merged pull request #26:
URL: https://github.com/apache/logging-log4cxx/pull/26
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
baldapps opened a new pull request #27:
URL: https://github.com/apache/logging-log4cxx/pull/27
Const was missing for method getDatePattern and a const_cast was needed if
the object instance was const.
This is an automated me
ams-tschoening merged pull request #27:
URL: https://github.com/apache/logging-log4cxx/pull/27
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ams-tschoening commented on pull request #27:
URL: https://github.com/apache/logging-log4cxx/pull/27#issuecomment-647949577
Tests succeeded for me again, thanks!
This is an automated message from the Apache Git Service.
To re
rm5248 opened a new pull request #28:
URL: https://github.com/apache/logging-log4cxx/pull/28
When building log4cxx with CMake, the BUILD_SHARED_LIBS option must be
defined before finding APR and APR-util, as those use this variable.
ams-tschoening merged pull request #28:
URL: https://github.com/apache/logging-log4cxx/pull/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ams-tschoening commented on pull request #28:
URL: https://github.com/apache/logging-log4cxx/pull/28#issuecomment-649309850
As I'm still [unable](issues.apache.org/jira/browse/LOGCXX-510) to build
using CMAKE myself, I'll simply continue to trust that those changes make
sense. Thanks for f
Hoffs opened a new pull request #365:
URL: https://github.com/apache/logging-log4j2/pull/365
The lower lookup example has extra opening bracket that renders the
configuration invalid.
This is an automated message from the Ap
rgoers commented on pull request #365:
URL: https://github.com/apache/logging-log4j2/pull/365#issuecomment-650489261
This looks fine. I assume the same problem exists on the release-2.x branch.
This is an automated message fr
shawjef3 opened a new pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366
The purpose of this is to make it possible to improve performance. Getting
the StackTraceElement for a message is somewhat expensive. Creating it manually
is tedious and no one should do it, but
rgoers commented on pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-650650281
This change is modifying the signatures of virtually all the Messages, which
will break some existing users. What's more, clients who want to set the source
manually already
garydgregory commented on pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-650650605
The breaking could be less using default methods FWIW...
This is an automated message from the Apache
rgoers commented on pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-650652949
That is true, but it seems odd to add the StackTraceElement to things like
traceEntry & traceExit and then ALSO add them to Messages. The location
information isn't logicall
rgoers edited a comment on pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-650652949
That is true, but it seems odd to add the StackTraceElement to things like
traceEntry & traceExit and then ALSO add them to Messages. The location
information isn't l
garydgregory commented on pull request #366:
URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-650743832
Yeah, I do not have a use case for that, I just wanted to mention it for
completeness sake as well as guidance for contributing: don't break binary
compatibility o
turbanoff opened a new pull request #367:
URL: https://github.com/apache/logging-log4j2/pull/367
It's known that writing to a `volatile` field has performance impact.
It's true even if code initializes field with _default_ value.
This PR cleans such redundant initialization and improv
sullis opened a new pull request #368:
URL: https://github.com/apache/logging-log4j2/pull/368
https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/
Dependabot v2 can detect:
1) outdated Maven plugins
2) outdated Java libraries
-
gagoman commented on pull request #362:
URL: https://github.com/apache/logging-log4j2/pull/362#issuecomment-651456762
@vy sorry for a ping. Any chance to get this merged?
This is an automated message from the Apache Git Servi
vy commented on pull request #362:
URL: https://github.com/apache/logging-log4j2/pull/362#issuecomment-651978776
Hey @gagoman! We already have the Jackson version upgrade along with another
change (#335) waiting for its last review by @rgoers. Nevertheless, your
changes include a test, whi
vy merged pull request #362:
URL: https://github.com/apache/logging-log4j2/pull/362
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy commented on pull request #367:
URL: https://github.com/apache/logging-log4j2/pull/367#issuecomment-652000782
Hey @turbanoff! Thanks for the heads up and PR, appreciated! I will need
some time to wrap my mind around the change set and approve it -- unless some
other committer steps forw
rgoers commented on pull request #367:
URL: https://github.com/apache/logging-log4j2/pull/367#issuecomment-652152990
I've looked at the linked documentation and am fine with this in principle.
I have not looked to see if leaving any of the fields uninitialized would cause
problems, but I f
vy merged pull request #368:
URL: https://github.com/apache/logging-log4j2/pull/368
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] opened a new pull request #369:
URL: https://github.com/apache/logging-log4j2/pull/369
Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.6.2 to 2.7.0.
Release notes
Sourced from https://github.com/xmlunit/xmlunit/releases";>xmlunit-core's
releases.
dependabot[bot] opened a new pull request #370:
URL: https://github.com/apache/logging-log4j2/pull/370
Bumps [jetty-util](https://github.com/eclipse/jetty.project) from
8.2.0.v20160908 to 9.4.30.v20200611.
Commits
https://github.com/eclipse/jetty.project/commit/271836e4c1f4612
dependabot[bot] opened a new pull request #371:
URL: https://github.com/apache/logging-log4j2/pull/371
Bumps [jctools-core](https://github.com/JCTools/JCTools) from 1.2.1 to 3.0.0.
Release notes
Sourced from https://github.com/JCTools/JCTools/releases";>jctools-core's
releases.
dependabot[bot] opened a new pull request #372:
URL: https://github.com/apache/logging-log4j2/pull/372
Bumps `mongodb3.version` from 3.12.4 to 3.12.5.
Updates `mongodb-driver` from 3.12.4 to 3.12.5
Release notes
Sourced from https://github.com/mongodb/mongo-java-driver/releases"
dependabot[bot] opened a new pull request #373:
URL: https://github.com/apache/logging-log4j2/pull/373
Bumps
[maven-resources-plugin](https://github.com/apache/maven-resources-plugin) from
3.0.2 to 3.1.0.
Commits
https://github.com/apache/maven-resources-plugin/commit/0e3e280
dependabot[bot] opened a new pull request #375:
URL: https://github.com/apache/logging-log4j2/pull/375
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.
Release notes
Sourced from https://github.com/junit-team/junit4/releases";>junit's
releases.
JUnit 4
dependabot[bot] opened a new pull request #374:
URL: https://github.com/apache/logging-log4j2/pull/374
Bumps
[build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin)
from 1.12 to 3.2.0.
Release notes
Sourced from https://github.com/mojohaus/build-helper-
dependabot[bot] opened a new pull request #376:
URL: https://github.com/apache/logging-log4j2/pull/376
Bumps `springVersion` from 3.2.18.RELEASE to 5.2.7.RELEASE.
Updates `spring-aop` from 3.2.18.RELEASE to 5.2.7.RELEASE
Release notes
Sourced from https://github.com/spring-proje
dependabot[bot] opened a new pull request #377:
URL: https://github.com/apache/logging-log4j2/pull/377
Bumps
[maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin)
from 3.0.0 to 3.1.1.
Commits
https://github.com/apache/maven-checkstyle-plugin/commit/104b
dependabot[bot] opened a new pull request #378:
URL: https://github.com/apache/logging-log4j2/pull/378
Bumps [wiremock](https://github.com/tomakehurst/wiremock) from 2.19.0 to
2.27.0.
Commits
https://github.com/tomakehurst/wiremock/commit/d597aafdc3c6821b564781594205212d43d9f8
vy opened a new pull request #379:
URL: https://github.com/apache/logging-log4j2/pull/379
Note that this change set updates the Maven Wrapper scripts too.
An example successful run is accessible
[here](/vy/log4j2/actions/runs/153931860).
rgoers commented on pull request #379:
URL: https://github.com/apache/logging-log4j2/pull/379#issuecomment-652640840
Assuming you have tested this I don't see any issues.
This is an automated message from the Apache Git Servi
dependabot[bot] opened a new pull request #380:
URL: https://github.com/apache/logging-log4j2/pull/380
Bumps commons-compress from 1.18 to 1.20.
[. The log calls
are delegated to the super class only when a filter is
vy merged pull request #379:
URL: https://github.com/apache/logging-log4j2/pull/379
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] opened a new pull request #382:
URL: https://github.com/apache/logging-log4j2/pull/382
Bumps [wiremock](https://github.com/tomakehurst/wiremock) from 2.19.0 to
2.27.1.
Commits
https://github.com/tomakehurst/wiremock/commit/2b5087207a8989f3fd989982573305d59f3c75
dependabot[bot] commented on pull request #378:
URL: https://github.com/apache/logging-log4j2/pull/378#issuecomment-653331800
Superseded by #382.
This is an automated message from the Apache Git Service.
To respond to the mes
dependabot[bot] closed pull request #378:
URL: https://github.com/apache/logging-log4j2/pull/378
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
janmaterne opened a new pull request #383:
URL: https://github.com/apache/logging-log4j2/pull/383
added some links to JavaDoc
enhance some examples
fix some references
This is an automated message from the Apache Git Se
janmaterne opened a new pull request #384:
URL: https://github.com/apache/logging-log4j2/pull/384
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
carterkozak commented on pull request #367:
URL: https://github.com/apache/logging-log4j2/pull/367#issuecomment-653778469
This isn't something I had considered but it makes sense, thanks for the
contribution and for teaching me something new! I'll have to look into writing
an error-prone p
rgoers commented on pull request #381:
URL: https://github.com/apache/logging-log4j2/pull/381#issuecomment-653789389
Now that I look at this I find what was originally implemented rather odd.
The setLevel() and setParent() methods throw exceptions and yet the setFilter
method is still allo
ebourg commented on pull request #381:
URL: https://github.com/apache/logging-log4j2/pull/381#issuecomment-653805579
I agree that `setLevel()` shouldn't throw an exception. It could maybe just
log a one time warning, but that's not worth breaking the application just
because log4j was plug
stepan2271 commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-654344619
Build is fixed after merge with master. @remkop could you please merge,
since I don`t have write access
remkop commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-654504395
@carterkozak Could you also review this PR?
This is an automated message from the Apache Git Service.
To res
carterkozak commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-654509230
Sure thing, I’ll take a look tomorrow :-)
This is an automated message from the Apache Git Service.
To
carterkozak commented on a change in pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#discussion_r451167275
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java
##
@@ -60,36 +60,46 @@
private DisruptorUtil(
carterkozak commented on pull request #361:
URL: https://github.com/apache/logging-log4j2/pull/361#issuecomment-655161965
Curious if anyone has suggestions for backporting documentation to the 2.x
branch? It's difficult manually transforming between adoc and rst.
-
fluffynuts commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-656884829
Hi
I'll be honest: friction to getting a PR merged in as a non-Apache dev is
really daunting. I keep putting it off, but I'm not sure if I'm ever going to
get arou
fluffynuts edited a comment on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-656884829
Hi
I'll be honest: friction to getting a PR merged in as a non-Apache dev is
really daunting. I keep putting it off, but I'm not sure if I'm ever going to
g
rgoers commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-656930447
Ironically, I was just looking at the BUILDING.md file. I occasionally use
my Windows VM to test the build of Log4j but nothing more than that. I haven't
done anything with
rgoers merged pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rm5248 commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-657059780
For Ralph: If you don't know, Microsoft does provide development VMs that
already have the tools installed so you don't need to download Visual Studio
and .NET:
https://deve
vy commented on pull request #383:
URL: https://github.com/apache/logging-log4j2/pull/383#issuecomment-657102850
Thanks so much @janmaterne! Merged.
This is an automated message from the Apache Git Service.
To respond to the
vy merged pull request #383:
URL: https://github.com/apache/logging-log4j2/pull/383
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vy merged pull request #384:
URL: https://github.com/apache/logging-log4j2/pull/384
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
101 - 200 of 7264 matches
Mail list logo
