Re: [PR] A way to disable the optimization for filling the stack traces [logging-log4j2]

2025-05-03 Thread via GitHub
ppkarwasz commented on PR #3638: URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2848474770 > I see 2 implementations of `StackLocator`, with the newer one relying on `StackWalker`. It is [available on Android](https://developer.android.com/reference/java/lang/StackWalk

Re: [PR] Added reference to `android-log4j2` repo to the F.A.Q. [logging-log4j2]

2025-05-03 Thread via GitHub
neboskreb closed pull request #3643: Added reference to `android-log4j2` repo to the F.A.Q. URL: https://github.com/apache/logging-log4j2/pull/3643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-03 Thread via GitHub
vy commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2072434647 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java: ## @@ -323,10 +325,19 @@ public void start() { LOGGER.info("Star

Re: [I] Allow disabling the optimization for filling the stack traces [logging-log4j2]

2025-05-03 Thread via GitHub
vy commented on issue #3639: URL: https://github.com/apache/logging-log4j2/issues/3639#issuecomment-2848726871 @ppkarwasz, @neboskreb, I have the impression that #3638 addressing this issue is merged. Can we close this issue? -- This is an automated message from the Apache Git Service. T

Re: [PR] Adjust GcpLayout JSON to latest format [logging-log4j2]

2025-05-03 Thread via GitHub
vy commented on code in PR #3586: URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2072437500 ## src/changelog/.2.x.x/3586_improve_GcpLayout.xml: ## @@ -0,0 +1,10 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/n

Re: [I] Allow disabling the optimization for filling the stack traces [logging-log4j2]

2025-05-03 Thread via GitHub
neboskreb commented on issue #3639: URL: https://github.com/apache/logging-log4j2/issues/3639#issuecomment-2848743878 Though the risk that `SecurityManager` is removed from the runtime remains, the immediate problem on Android is fixed. So I believe yes, #3638 can be happily closed. --

Re: [PR] Improve implementations of `LogEvent.toImmutable()` and `ReusableMessage.memento()` [logging-log4j2]

2025-05-03 Thread via GitHub
vy commented on code in PR #3171: URL: https://github.com/apache/logging-log4j2/pull/3171#discussion_r2072427609 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/async/RingBufferLogEventTest.java: ## @@ -222,25 +223,31 @@ void testSerializationDeserialization() {

Re: [PR] Lock Antora dependencies [logging-parent]

2025-05-03 Thread via GitHub
vy commented on code in PR #367: URL: https://github.com/apache/logging-parent/pull/367#discussion_r2072430211 ## .github/workflows/deploy-site-reusable.yaml: ## @@ -115,6 +105,12 @@ jobs: git config user.name "ASF Logging Services RM" git config user.email

Re: [PR] Adapt `merge-dependabot` to RTC [logging-log4j2]

2025-05-03 Thread via GitHub
vy commented on code in PR #3603: URL: https://github.com/apache/logging-log4j2/pull/3603#discussion_r2072430665 ## .github/workflows/add-dependabot-changelog.yaml: ## Review Comment: I prefer this to be made a part of `logging-parent` first. If we you can make that happen

Re: [PR] Disable (temporarily) Dependabot updates [logging-log4j2]

2025-05-03 Thread via GitHub
vy commented on PR #3624: URL: https://github.com/apache/logging-log4j2/pull/3624#issuecomment-2848716749 @ppkarwasz, what is long-term solution to this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Adjust GcpLayout JSON to latest format [logging-log4j2]

2025-05-03 Thread via GitHub
vy commented on PR #3586: URL: https://github.com/apache/logging-log4j2/pull/3586#issuecomment-2848731381 @ViliusS, @ppkarwasz, I think we better proceed with the current state of this PR – I've approved it. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [I] Allow disabling the optimization for filling the stack traces [logging-log4j2]

2025-05-03 Thread via GitHub
ppkarwasz commented on issue #3639: URL: https://github.com/apache/logging-log4j2/issues/3639#issuecomment-2848815544 @vy, sure! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] Allow disabling the optimization for filling the stack traces [logging-log4j2]

2025-05-03 Thread via GitHub
ppkarwasz closed issue #3639: Allow disabling the optimization for filling the stack traces URL: https://github.com/apache/logging-log4j2/issues/3639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Adjust GcpLayout JSON to latest format [logging-log4j2]

2025-05-03 Thread via GitHub
ppkarwasz merged PR #3586: URL: https://github.com/apache/logging-log4j2/pull/3586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Disable (temporarily) Dependabot updates [logging-log4j2]

2025-05-03 Thread via GitHub
ppkarwasz commented on PR #3624: URL: https://github.com/apache/logging-log4j2/pull/3624#issuecomment-2848821155 > what is long-term solution to this problem? The main problem to solve is how to trigger a build on the commit with the changelog. I haven't test any of these, which is wh

Re: [PR] Adapt `merge-dependabot` to RTC [logging-log4j2]

2025-05-03 Thread via GitHub
ppkarwasz commented on PR #3603: URL: https://github.com/apache/logging-log4j2/pull/3603#issuecomment-2848823194 Maybe it is easier to write it in TypeScript and reference it from `logging-parent`. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Enforce RTC [logging-log4j-samples]

2025-05-03 Thread via GitHub
ppkarwasz merged PR #320: URL: https://github.com/apache/logging-log4j-samples/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

Re: [I] DefaultRolloverStrategy creating rolled over log files more than the configured limit [logging-log4j2]

2025-05-03 Thread via GitHub
github-actions[bot] closed issue #3475: DefaultRolloverStrategy creating rolled over log files more than the configured limit URL: https://github.com/apache/logging-log4j2/issues/3475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH