gdziadkiewicz commented on code in PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#discussion_r1836828847
##
.github/workflows/build.yaml:
##
@@ -47,11 +55,20 @@ jobs:
with:
node-version: 20
- - name: Build and test
-env:
-
ppkarwasz commented on issue #2769:
URL:
https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2468934317
@jaykataria,
> Hi @ppkarwasz, had a general question about how Pull Requests and Code
reviews work in this repo, do I have to reach out to folks to drive it or,
github-actions[bot] commented on PR #3195:
URL: https://github.com/apache/logging-log4j2/pull/3195#issuecomment-2468966307
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
jaykataria commented on issue #2769:
URL:
https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2468973925
Hi @ppkarwasz , it would be awesome I can contribute more, let me see the
steps to become a contributor, this is awesome thanks a lot 🙂
--
This is an automated messa
ppkarwasz opened a new pull request, #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199
Removes weak references to `Logger`s in `LoggerRepository`. The usage of
weak references in `LoggerRepository` might cause `null` to be returned by
`LogManager.getLogger()` of all Log4j Core
ppkarwasz commented on PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2468593620
The weak reference to `MessageFactory` might require additional
explanations. Unlike a weak reference to `Logger`, it will not cause `null` to
be returned by `LoggerContext#getLo
vy commented on issue #3196:
URL:
https://github.com/apache/logging-log4j2/issues/3196#issuecomment-2467547812
@centic9, #2936 is probably fixed your problem. Could you check if you can
still reproduce the problem using `2.25.0-SNAPSHOT`, please?
--
This is an automated message from the
github-actions[bot] merged PR #283:
URL: https://github.com/apache/logging-parent/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
vy commented on code in PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#discussion_r1837099466
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java:
##
@@ -43,7 +41,7 @@
@NullMarked
public class LoggerRegistry {
-private final Map
ppkarwasz commented on code in PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#discussion_r1837111329
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java:
##
@@ -43,7 +41,7 @@
@NullMarked
public class LoggerRegistry {
-private fi
gdziadkiewicz commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2468412716
> > > @gdziadkiewicz can you test how just using "dotnet test" as a single
step would look like? @fluffynuts do you have an idea why the windows output is
much longer? (the ma
gdziadkiewicz commented on code in PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#discussion_r1836834683
##
.github/workflows/build-dotnet-solo.yaml:
##
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor lic
FreeAndNil commented on code in PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#discussion_r1836837063
##
.github/workflows/build-dotnet-solo.yaml:
##
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor licens
ppkarwasz commented on issue #3143:
URL:
https://github.com/apache/logging-log4j2/issues/3143#issuecomment-2468608905
@anuragagarwal561994,
The bug was introduced in #2961 and it only affects Log4j API 2.24.1 and all
the implementations that use `LoggerRegistry`.
Regarding the
jaykataria commented on issue #2769:
URL:
https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2468909929
Hi @ppkarwasz, had a general question about how Pull Requests and Code
reviews work in this repo, do I have to reach out to folks to drive it or,
someone volunteering
vy commented on code in PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#discussion_r1837128394
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java:
##
@@ -43,7 +41,7 @@
@NullMarked
public class LoggerRegistry {
-private final Map
vy commented on code in PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#discussion_r1837128394
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java:
##
@@ -43,7 +41,7 @@
@NullMarked
public class LoggerRegistry {
-private final Map
ppkarwasz commented on issue #3172:
URL:
https://github.com/apache/logging-log4j2/issues/3172#issuecomment-2469764544
> I am not sure why the bot didn't mark this as "waiting for maintainer" -
not sure if it pops up for you?
The workflow is in
[`labeler.yaml`](https://github.com/apa
ppkarwasz commented on issue #3176:
URL:
https://github.com/apache/logging-log4j2/issues/3176#issuecomment-2469764936
> @ppkarwasz what should be done with this ticket? see last comment.
>
> Of course, the Script builders and AbstractScript constructor can be
modified...
Since
ppkarwasz commented on issue #3173:
URL:
https://github.com/apache/logging-log4j2/issues/3173#issuecomment-2469768022
> One other thing I noticed in my testing, the DefaultMergeStrategy uses the
root node of the first configuration to merge all the others - this results in
the first config
ppkarwasz commented on issue #3159:
URL:
https://github.com/apache/logging-log4j2/issues/3159#issuecomment-2469785110
I am seriously considering deprecating `AsyncWaitStrategyFactoryConfig`. I
will discuss it with the other maintainers (especially @remkop, who introduced
it), but it could
ppkarwasz commented on issue #3159:
URL:
https://github.com/apache/logging-log4j2/issues/3159#issuecomment-2469793900
> I am not sure why the bot didn't mark this as "waiting for maintainer" -
not sure if it pops up for you?
You are a `CONTRIBUTOR` now! :wink:
The labels are prett
tarekahf commented on issue #22:
URL:
https://github.com/apache/logging-chainsaw/issues/22#issuecomment-2469608764
I used Java 11 and it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
tarekahf opened a new issue, #28:
URL: https://github.com/apache/logging-chainsaw/issues/28
I managed to use Chainsaw successfully to read a text based log file with
the following configuration XML. The only problem that the file is loaded one
line at a time and it is extremely slow. Any id
ppkarwasz commented on code in PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#discussion_r1837508024
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java:
##
@@ -43,7 +41,7 @@
@NullMarked
public class LoggerRegistry {
-private fi
ppkarwasz commented on PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2469657752
In order to preserve backward compatibility and allow `Logger`s to be
garbage-collected, I will:
- [ ] Copy `LoggerContext` to an internal package of `log4j-core`.
- [ ]
ppkarwasz commented on issue #2962:
URL:
https://github.com/apache/logging-log4j2/issues/2962#issuecomment-2469688771
We should probably abstain as much as possible from using helper methods in
`log4j-api`, because these give a rather unnatural dependency of `log4j-core`
on a recent versio
27 matches
Mail list logo
