Re: [PR] Port date & time formatter rewrite to `main` (logging-log4j2)

2024-11-07 Thread via GitHub
vy merged PR #3150: URL: https://github.com/apache/logging-log4j2/pull/3150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Port `%xEx` performance regression fix to `main` (logging-log4j2)

2024-11-07 Thread via GitHub
vy merged PR #3154: URL: https://github.com/apache/logging-log4j2/pull/3154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] Date and time patterns should follow `DateTimeFormatter` (logging-log4j2)

2024-11-07 Thread via GitHub
ppkarwasz commented on issue #1416: URL: https://github.com/apache/logging-log4j2/issues/1416#issuecomment-2462212820 Fixed by #3150. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Port date & time formatter rewrite to `main` (logging-log4j2)

2024-11-07 Thread via GitHub
ppkarwasz commented on PR #3150: URL: https://github.com/apache/logging-log4j2/pull/3150#issuecomment-2462210988 Fixes #1416. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Date and time patterns should follow `DateTimeFormatter` (logging-log4j2)

2024-11-07 Thread via GitHub
ppkarwasz closed issue #1416: Date and time patterns should follow `DateTimeFormatter` URL: https://github.com/apache/logging-log4j2/issues/1416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]

2024-11-07 Thread via GitHub
JoeyJoeJoeJrShabadoo closed issue #423: [Feature request] Please add vcpkg feature to enable Qt support URL: https://github.com/apache/logging-log4cxx/issues/423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]

2024-11-07 Thread via GitHub
JoeyJoeJoeJrShabadoo commented on issue #423: URL: https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2463119545 Closing the issue as completed. Thank you for the implementation, I appreciate it. -- This is an automated message from the Apache Git Service. To respond to th

Re: [I] Make RollingFileAppender.RollOverRenameFiles virtual (logging-log4net)

2024-11-07 Thread via GitHub
FreeAndNil commented on issue #205: URL: https://github.com/apache/logging-log4net/issues/205#issuecomment-2463304818 @FerdinandStapenhorst 3.0.3 was released. https://github.com/apache/logging-log4net/releases/tag/rel/3.0.3 -- This is an automated message from the Apache Git Servi

Re: [PR] Bump jackson.version from 2.18.0 to 2.18.1 [logging-log4j-transform]

2024-11-07 Thread via GitHub
github-actions[bot] merged PR #141: URL: https://github.com/apache/logging-log4j-transform/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump picocli.version from 4.7.5 to 4.7.6 [logging-log4j-transform]

2024-11-07 Thread via GitHub
github-actions[bot] merged PR #140: URL: https://github.com/apache/logging-log4j-transform/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[PR] Fix example in thread-context.adoc under "Initializing thread context" (logging-log4j2)

2024-11-07 Thread via GitHub
MaxAller opened a new pull request, #3186: URL: https://github.com/apache/logging-log4j2/pull/3186 Example uses undefined variables; this change updates the variables used to match the variables defined. Ref: * https://github.com/apache/logging-log4j2/discussions/3178 * https://

Re: [PR] Bump mongodb.version from 5.2.0 to 5.2.1 (logging-log4j2)

2024-11-07 Thread via GitHub
github-actions[bot] merged PR #3179: URL: https://github.com/apache/logging-log4j2/pull/3179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Port date & time formatter rewrite to `main` (logging-log4j2)

2024-11-07 Thread via GitHub
vy commented on code in PR #3150: URL: https://github.com/apache/logging-log4j2/pull/3150#discussion_r1832638724 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/plugins/LegacyPluginTest.java: ## @@ -1,55 +0,0 @@ -/* - * Licensed to the Apache Software Found

Re: [PR] Bump mongodb.version from 4.11.4 to 5.2.1 (logging-log4j2)

2024-11-07 Thread via GitHub
github-actions[bot] merged PR #3181: URL: https://github.com/apache/logging-log4j2/pull/3181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.apache.kafka:kafka-clients from 3.8.1 to 3.9.0 in /log4j-parent (logging-log4j2)

2024-11-07 Thread via GitHub
github-actions[bot] merged PR #3184: URL: https://github.com/apache/logging-log4j2/pull/3184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[I] Log4J JDBC appender org.apache.logging.log4j.core.appender.db.jdbc.JdbcDatabaseManager.class provides no rollback if there is an sqlException (logging-log4j2)

2024-11-07 Thread via GitHub
arpithav620 opened a new issue, #3185: URL: https://github.com/apache/logging-log4j2/issues/3185 ## Description Hi, I am using log4J to log all errors in my application to database . I have configured exact column mappings in log4j.xml and whenever logger.error() is invoked it will lo

Re: [PR] Bump ch.qos.logback:logback-classic from 1.4.14 to 1.5.12 (logging-log4j2)

2024-11-07 Thread via GitHub
github-actions[bot] merged PR #3180: URL: https://github.com/apache/logging-log4j2/pull/3180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
JWT007 commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2461681124 Hi @ppkarwasz hmmm I am not sure - what is the real impact? How many really create the SocketPerformancePreferences programmatically? :/ I think *if* someone i

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2461735723 Hi @JWT007, > How many really create the `SocketPerformancePreferences` programmatically? :/ IIRC, you are using the plugin builders quite a lot. Do you plan t

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
JWT007 commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2461852204 @ppkarwasz in my special case we won't support the SocketAppender at all so this wouldn't affect me at all :) Hmm ok binary compatibility sure - but only for those progr

Re: [PR] Port date & time formatter rewrite to `main` (logging-log4j2)

2024-11-07 Thread via GitHub
ppkarwasz commented on code in PR #3150: URL: https://github.com/apache/logging-log4j2/pull/3150#discussion_r1832419271 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/plugins/LegacyPluginTest.java: ## @@ -1,55 +0,0 @@ -/* - * Licensed to the Apache Softwar

Re: [PR] Add a tool to manipulate plugin descriptors [logging-log4j-transform]

2024-11-07 Thread via GitHub
ppkarwasz merged PR #139: URL: https://github.com/apache/logging-log4j-transform/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
JWT007 commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463526420 you could just deprecate the old signatures and add new ones for "with***"? the method lookup above would need to prefer the non-deprecated variants though. -- This is a

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463776430 > > you could just deprecate the old signatures and add new ones for "with***"? > > the method lookup above would need to prefer the non-deprecated variants though.

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463782755 >I would just annotate those three methods with a custom @SuppressWarnings and make the annotation processor ignore them. Okay sounds good let me do that then! I

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463719507 > you could just deprecate the old signatures and add new ones for "with***"? the method lookup above would need to prefer the non-deprecated variants though.

Re: [PR] Add missing setter in builder classes (logging-log4j2)

2024-11-07 Thread via GitHub
jaykataria commented on PR #3174: URL: https://github.com/apache/logging-log4j2/pull/3174#issuecomment-2463751224 I am rebasing changes for #2769, based on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Improve asyncappender's handling of extremely rare contention [logging-log4cxx]

2024-11-07 Thread via GitHub
swebb2066 merged PR #427: URL: https://github.com/apache/logging-log4cxx/pull/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463841345 I thought rather to keep the methods as they are and add logic to `PluginProcessor` to issue a **WARNING** instead of an error in this case: ```java // This set

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463842919 @ppkarwasz , that makes more sense let me do that! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463793557 Hi @ppkarwasz , seems like the @SuppressWarnings annotation won't work, what do you recommend among these: >1.Add a configuration option to the processor to change

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463796814 > Hi @ppkarwasz , seems like the @SuppressWarnings annotation won't work, what do you recommend among these: Can you elaborate on that? You should be able to check if

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463807705 @ppkarwasz >I would just annotate those three methods with a custom @SuppressWarnings and make the annotation processor ignore them. I am sorry for the c

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-07 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2463940680 Hi @ppkarwasz, I have updated the code, it is late here in my time zone, so have not written the unit tests yet, but just leaving the code here, so that you can peruse