Re: [PR] Fix extended stack trace (i.e., `%xEx`) rendering performance regression (logging-log4j2)

2024-11-02 Thread via GitHub
alan0428a commented on PR #3123: URL: https://github.com/apache/logging-log4j2/pull/3123#issuecomment-2452916460 Also the current way of using `Throwable` as a key for the map in metadata might be memeory expensive? https://github.com/alan0428a/logging-log4j2/blob/1e154d446fe9d5604628196

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-02 Thread via GitHub
FreeAndNil commented on PR #204: URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2453040472 @gdziadkiewicz can you test how just using "dotnet test" as a single step would look like? @fluffynuts do you have an idea why the windows output is much longer? (the macos an

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-02 Thread via GitHub
FreeAndNil commented on code in PR #204: URL: https://github.com/apache/logging-log4net/pull/204#discussion_r1826597969 ## .github/workflows/build.yaml: ## @@ -19,6 +19,10 @@ name: build on: workflow_dispatch: + push: +branches: + - main Review Comment: log4n

[I] StringMatchFilter would return NPE if configured programmatically with 'null' text. (logging-log4j2)

2024-11-02 Thread via GitHub
JWT007 opened a new issue, #3153: URL: https://github.com/apache/logging-log4j2/issues/3153 StringMatchFilter (Log4j 2.24.1) When parsing from XML I *think* if the "text" attribute is missing it will be populated with an empty string due to the Builder field: ``` @PluginBuil

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-02 Thread via GitHub
gdziadkiewicz commented on PR #204: URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2452918572 Local run in my fork: https://github.com/gdziadkiewicz/logging-log4net/actions/runs/11637652589 -- This is an automated message from the Apache Git Service. To respond to th

[I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]

2024-11-02 Thread via GitHub
JoeyJoeJoeJrShabadoo opened a new issue, #423: URL: https://github.com/apache/logging-log4cxx/issues/423 Hi everybody, first thanks a lot for your effort to maintain this terrific piece of software. There's one thing I'd love to have in addition: Would it be possible to add a feature

Re: [PR] Fix extended stack trace (i.e., `%xEx`) rendering performance regression (logging-log4j2)

2024-11-02 Thread via GitHub
alan0428a commented on PR #3123: URL: https://github.com/apache/logging-log4j2/pull/3123#issuecomment-2452911580 Current way of using `Throwable` as a key for the metadata map might also be memory expensive. And this impacts to all render I guess. https://github.com/alan0428a/logging-log

[I] Missing/Faulty Logic in AbstractConfiguration for addLoggerAppender / addLoggerFilter / setLoggerAdditive (logging-log4j2)

2024-11-02 Thread via GitHub
JWT007 opened a new issue, #3155: URL: https://github.com/apache/logging-log4j2/issues/3155 AbstractConfiguration (Log4j 2.24.1) It *seems* there is some missing/faulty logic in the AbstractConfiguration for the methods `addLoggerAppender`, `addLoggerFilter`, `setLoggerAdditive`.

Re: [I] Performance regression in `2.25.0-SNAPSHOT` (logging-log4j2)

2024-11-02 Thread via GitHub
vy closed issue #3106: Performance regression in `2.25.0-SNAPSHOT` URL: https://github.com/apache/logging-log4j2/issues/3106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Performance regression in `2.25.0-SNAPSHOT` (logging-log4j2)

2024-11-02 Thread via GitHub
vy commented on issue #3106: URL: https://github.com/apache/logging-log4j2/issues/3106#issuecomment-2453136689 Fixed by #3123. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] Port `%xEx` performance regression fix to `main` (logging-log4j2)

2024-11-02 Thread via GitHub
vy opened a new pull request, #3154: URL: https://github.com/apache/logging-log4j2/pull/3154 Ports #3123 to `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-02 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2453254128 Hi @vy and @ppkarwasz, If this issue has not been picked up yet, can I contribute to this, do I have to be assigned to this issue or I can just start working on

Re: [PR] Fix extended stack trace (i.e., `%xEx`) rendering performance regression (logging-log4j2)

2024-11-02 Thread via GitHub
vy commented on PR #3123: URL: https://github.com/apache/logging-log4j2/pull/3123#issuecomment-2453090095 > in my profiling, the `String.format()` still takes a lot of time after we wrap it with `Lazy` object. > ... > The test script is actually not fair. > ... > I found that cur

Re: [PR] Fix extended stack trace (i.e., `%xEx`) rendering performance regression (logging-log4j2)

2024-11-02 Thread via GitHub
vy commented on PR #3123: URL: https://github.com/apache/logging-log4j2/pull/3123#issuecomment-2453102637 I can confirm that with the `ClassResourceInfo` and `ThrowableExtendedStackTraceRenderer#loadClass()` fixes @alan0428a tipped, `2.25.0-SNAPSHOT` shows an (almost) identical performance

Re: [PR] Fix extended stack trace (i.e., `%xEx`) rendering performance regression (logging-log4j2)

2024-11-02 Thread via GitHub
vy merged PR #3123: URL: https://github.com/apache/logging-log4j2/pull/3123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Fix extended stack trace (i.e., `%xEx`) rendering performance regression (logging-log4j2)

2024-11-02 Thread via GitHub
vy commented on PR #3123: URL: https://github.com/apache/logging-log4j2/pull/3123#issuecomment-2453091705 > Also the current way of using `Throwable` as a key for the map in metadata might be memory expensive? What do you mean by this? What would be your suggestion instead? -- This

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-02 Thread via GitHub
ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2453312300 @jaykataria, Thank you for your help. I have assigned you to the issue. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]

2024-11-02 Thread via GitHub
swebb2066 commented on issue #423: URL: https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453320270 Thank you. I am happy you find the library useful. I added a [PR to vcpkg](https://github.com/microsoft/vcpkg/pull/41928) -- This is an automated message from the Ap

[PR] Turn on the CI build for PRs (logging-log4net)

2024-11-02 Thread via GitHub
gdziadkiewicz opened a new pull request, #204: URL: https://github.com/apache/logging-log4net/pull/204 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub