Re: [I] Configuration System Initialization Failure with PublishTrimmed in .NET 8 (logging-log4net)

2024-10-10 Thread via GitHub
FreeAndNil commented on issue #165: URL: https://github.com/apache/logging-log4net/issues/165#issuecomment-2406623392 @hhxdestiny nobody said otherwise. In case you have a sample application which reproduces the problem, feel free to reopen (or create a new issue). -- This is an autom

[I] log4j2.script.enableLanguages or log4j2.scriptEnableLanguages? (logging-log4j2)

2024-10-10 Thread via GitHub
martin-dorey-hv opened a new issue, #3079: URL: https://github.com/apache/logging-log4j2/issues/3079 ## Description Yeah, it doesn't functionally matter. I know. Now. If the rule is to follow camelCaseNames, then shouldn't new source set a good example? ## Configuratio

Re: [I] Configuration System Initialization Failure with PublishTrimmed in .NET 8 (logging-log4net)

2024-10-10 Thread via GitHub
hhxdestiny commented on issue #165: URL: https://github.com/apache/logging-log4net/issues/165#issuecomment-2406600025 The problem still exists on 3.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] (Closeable)ThreadContext putAll removes entire context (logging-log4j2)

2024-10-10 Thread via GitHub
vy closed issue #2946: (Closeable)ThreadContext putAll removes entire context URL: https://github.com/apache/logging-log4j2/issues/2946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fix Android-related issues in Log4j Core (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz commented on PR #3071: URL: https://github.com/apache/logging-log4j2/pull/3071#issuecomment-2404871719 @vy, I added a FAQ entry in https://github.com/apache/logging-log4j2/pull/3071/commits/fbd4ea0c048ec66902f2dd6e13318636cb99966c. Since this PR can not be tested, unt

Re: [PR] Fix Android-related issues in Log4j Core (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz merged PR #3071: URL: https://github.com/apache/logging-log4j2/pull/3071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Error using log4j2 api/core libraries with Android (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz closed issue #3056: Error using log4j2 api/core libraries with Android URL: https://github.com/apache/logging-log4j2/issues/3056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix key removal issues in Thread Context (logging-log4j2)

2024-10-10 Thread via GitHub
vy merged PR #3050: URL: https://github.com/apache/logging-log4j2/pull/3050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] Reload of key/trustsore when re-establishing a connection (logging-log4j2)

2024-10-10 Thread via GitHub
MichaelMorrisEst commented on issue #3074: URL: https://github.com/apache/logging-log4j2/issues/3074#issuecomment-2404863957 Hi @vy, thanks for the feedback > @MichaelMorrisEst, this is something crossed my mind while working on #2767, but I am not sure about the implications of trying

Re: [I] RollingFileAppender rotates files incorrectly on ext4 due to filesystem timestamp caching (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz commented on issue #3068: URL: https://github.com/apache/logging-log4j2/issues/3068#issuecomment-2405009206 That commit is a fix to [LOG4J2-1906](https://issues.apache.org/jira/browse/LOG4J2-1906) and is probably related to #2297, where a regression occurred. Anyway I beli

[I] ScriptPatternSelector properties example throws "No type attribute provided for component patternMatch" (logging-log4j2)

2024-10-10 Thread via GitHub
martin-dorey-hv opened a new issue, #3078: URL: https://github.com/apache/logging-log4j2/issues/3078 Problem is at https://github.com/apache/logging-log4j2/blame/f7c26cd7710fdace463a370e85d0971107c91d8b/src/site/antora/modules/ROOT/examples/manual/pattern-layout/script-pattern-selector/log4j

Re: [PR] Upgrades JUnit to version `5.11.2` (logging-log4j2)

2024-10-10 Thread via GitHub
vy commented on code in PR #3069: URL: https://github.com/apache/logging-log4j2/pull/3069#discussion_r1794839740 ## log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/junit/package-info.java: ## @@ -20,7 +20,7 @@ * @see org.junit.rules.TestRule */ @Export -@Ve

Re: [PR] Use a random `${test:logging.path}` (logging-log4j2)

2024-10-10 Thread via GitHub
vy commented on code in PR #2954: URL: https://github.com/apache/logging-log4j2/pull/2954#discussion_r1794842040 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/TempLoggingDirectory.java: ## @@ -135,6 +132,29 @@ private PathHolder createLoggingPath(final Ext

Re: [I] Reload of key/trustsore when re-establishing a connection (logging-log4j2)

2024-10-10 Thread via GitHub
vy commented on issue #3074: URL: https://github.com/apache/logging-log4j2/issues/3074#issuecomment-2404633198 > If, during the retry, the key/truststore are reloaded, then the latest certs would always be used in re-establishing the connection and would effectively remove the need to trig

[I] Reload of key/trustsore when re-establishing a connection (logging-log4j2)

2024-10-10 Thread via GitHub
MichaelMorrisEst opened a new issue, #3074: URL: https://github.com/apache/logging-log4j2/issues/3074 https://github.com/apache/logging-log4j2/pull/2767 introduces functionality to enable reloading key/trustore when the certs are renewed. However a manual step of triggering a reconfiguratio

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-10 Thread via GitHub
vy merged PR #3073: URL: https://github.com/apache/logging-log4j2/pull/3073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] [MS22] Native Compilation Support #2 (logging-log4j2)

2024-10-10 Thread via GitHub
grobmeier closed issue #2831: [MS22] Native Compilation Support #2 URL: https://github.com/apache/logging-log4j2/issues/2831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [MS22] Native Compilation Support #2 (logging-log4j2)

2024-10-10 Thread via GitHub
grobmeier commented on issue #2831: URL: https://github.com/apache/logging-log4j2/issues/2831#issuecomment-2404572665 Thanks you looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Bump ch.qos.logback:logback-core from 1.5.8 to 1.5.9 (logging-log4j2)

2024-10-10 Thread via GitHub
github-actions[bot] merged PR #3075: URL: https://github.com/apache/logging-log4j2/pull/3075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Fix key removal issues in Thread Context (logging-log4j2)

2024-10-10 Thread via GitHub
vy commented on code in PR #3050: URL: https://github.com/apache/logging-log4j2/pull/3050#discussion_r1795242183 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/map/UnmodifiableArrayBackedMap.java: ## @@ -350,82 +351,59 @@ public UnmodifiableArrayBackedMap copyAndRe

Re: [PR] Fix key removal issues in Thread Context (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz commented on code in PR #3050: URL: https://github.com/apache/logging-log4j2/pull/3050#discussion_r1795248638 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/map/UnmodifiableArrayBackedMap.java: ## @@ -350,82 +351,59 @@ public UnmodifiableArrayBackedMap co

Re: [PR] Fix key removal issues in Thread Context (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz commented on code in PR #3050: URL: https://github.com/apache/logging-log4j2/pull/3050#discussion_r1795248098 ## log4j-api-test/src/test/java/org/apache/logging/log4j/CloseableThreadContextTest.java: ## @@ -244,4 +246,71 @@ public void pushAllWillPushAllValues() {

[I] Configuration type doesn't have MarkerFilter element (logging-log4j2)

2024-10-10 Thread via GitHub
IMurzich opened a new issue, #3077: URL: https://github.com/apache/logging-log4j2/issues/3077 ## Description log4j.xml from https://github.com/apache/logging-log4j2/blob/2.x/src/site/antora/modules/ROOT/examples/manual/markers/log4j2.xml doesn't validate: Multiple annotations foun

Re: [PR] Bump actions/upload-artifact from 4.4.1 to 4.4.2 [logging-parent]

2024-10-10 Thread via GitHub
vy commented on code in PR #264: URL: https://github.com/apache/logging-parent/pull/264#discussion_r1795248026 ## .github/workflows/scorecards-analysis-reusable.yaml: ## @@ -47,7 +47,7 @@ jobs: publish_results: true - name: "Upload artifact" -uses: ac

Re: [PR] Bump actions/upload-artifact from 4.4.1 to 4.4.2 [logging-parent]

2024-10-10 Thread via GitHub
vy merged PR #264: URL: https://github.com/apache/logging-parent/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logg

Re: [I] Configuration type doesn't have MarkerFilter element [logging-log4j-tools]

2024-10-10 Thread via GitHub
ppkarwasz commented on issue #152: URL: https://github.com/apache/logging-log4j-tools/issues/152#issuecomment-2405713770 @IMurzich, Thank You for the report. I moved it to `logging-log4j-tools`, since the problem is caused by our `log4j-docgen` generator. The meta-definition of the

Re: [PR] Change BOM activation and stop managing dependencies [logging-parent]

2024-10-10 Thread via GitHub
vy commented on code in PR #265: URL: https://github.com/apache/logging-parent/pull/265#discussion_r1795881367 ## pom.xml: ## @@ -1018,6 +944,83 @@ + + + + bom + + + + + .logging-parent-bom-activator + + + + +

Re: [PR] Change BOM activation and stop managing dependencies [logging-parent]

2024-10-10 Thread via GitHub
vy commented on PR #265: URL: https://github.com/apache/logging-parent/pull/265#issuecomment-2405734305 > That makes me wonder if we can omit `` and use the defaults. @ppkarwasz, I prefer not to – it keeps `properties`, `profiles`, etc. all redundant (and potentially dangerous) stuff

Re: [PR] Change BOM activation and stop managing dependencies [logging-parent]

2024-10-10 Thread via GitHub
vy merged PR #265: URL: https://github.com/apache/logging-parent/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logg

Re: [I] `log4j-bom` leaks non-Log4j dependencies (logging-log4j2)

2024-10-10 Thread via GitHub
vy closed issue #3066: `log4j-bom` leaks non-Log4j dependencies URL: https://github.com/apache/logging-log4j2/issues/3066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Change BOM activation and stop managing dependencies [logging-parent]

2024-10-10 Thread via GitHub
ppkarwasz commented on code in PR #265: URL: https://github.com/apache/logging-parent/pull/265#discussion_r1795863187 ## pom.xml: ## @@ -1018,6 +944,83 @@ + + + + bom + + + + + .logging-parent-bom-activator + + + +

Re: [I] RollingFileAppender rotates files incorrectly on ext4 due to filesystem timestamp caching (logging-log4j2)

2024-10-10 Thread via GitHub
kelunik commented on issue #3068: URL: https://github.com/apache/logging-log4j2/issues/3068#issuecomment-2404403858 @rgoers Do you remember why you changed from modified time to creation time in https://github.com/apache/logging-log4j2/commit/e392c79274ab5cd545d59d7e8fa3b744c7367d16?

Re: [I] Upgrade JUnit to 5.11.0 (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz closed issue #2843: Upgrade JUnit to 5.11.0 URL: https://github.com/apache/logging-log4j2/issues/2843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Upgrade JUnit to 5.11.0 (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz closed issue #2843: Upgrade JUnit to 5.11.0 URL: https://github.com/apache/logging-log4j2/issues/2843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Upgrades JUnit to version `5.11.2` (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz merged PR #3069: URL: https://github.com/apache/logging-log4j2/pull/3069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Refactor parts of `log4j-core-test` to migrate to JUnit5 (logging-log4j2)

2024-10-10 Thread via GitHub
ninetteadhikari commented on PR #3061: URL: https://github.com/apache/logging-log4j2/pull/3061#issuecomment-2404427110 > > Please note the log4j-core-test module contains over 150 files and this PR updates the tests for 40 of them. Further PRs will be made to update the rest of the tests.

[PR] Change BOM activation and stop managing dependencies [logging-parent]

2024-10-10 Thread via GitHub
vy opened a new pull request, #265: URL: https://github.com/apache/logging-parent/pull/265 This PR implements following changes * Activate `flatten-bom` execution of `flatten-maven-plugin` using a `.logging-parent-bom-activator` file * Remove following managed dependencies to avoid

Re: [PR] Fix Android-related issues in Log4j Core (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz commented on PR #3071: URL: https://github.com/apache/logging-log4j2/pull/3071#issuecomment-2405372546 The [CI build 11273365001](https://github.com/apache/logging-log4j2/actions/runs/11273365001) confirms that a simple application on Android functions correctly with Log4j Core.

Re: [PR] Enable automatic Android tests [logging-log4j-samples]

2024-10-10 Thread via GitHub
ppkarwasz merged PR #198: URL: https://github.com/apache/logging-log4j-samples/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

Re: [PR] Change BOM activation and stop managing dependencies [logging-parent]

2024-10-10 Thread via GitHub
ppkarwasz commented on code in PR #265: URL: https://github.com/apache/logging-parent/pull/265#discussion_r1795804436 ## pom.xml: ## @@ -1018,6 +944,83 @@ + + + + bom + + + + + .logging-parent-bom-activator + + + +

[I] Configuration type doesn't have MarkerFilter element [logging-log4j-tools]

2024-10-10 Thread via GitHub
IMurzich opened a new issue, #152: URL: https://github.com/apache/logging-log4j-tools/issues/152 ## Description log4j.xml from https://github.com/apache/logging-log4j2/blob/2.x/src/site/antora/modules/ROOT/examples/manual/markers/log4j2.xml doesn't validate: Multiple annotations f

Re: [PR] Change BOM activation and stop managing dependencies [logging-parent]

2024-10-10 Thread via GitHub
vy commented on code in PR #265: URL: https://github.com/apache/logging-parent/pull/265#discussion_r1795820838 ## pom.xml: ## @@ -1018,6 +944,83 @@ + + + + bom + + + + + .logging-parent-bom-activator + + + + +

[PR] Add manual integration test workflow [logging-log4j-samples]

2024-10-10 Thread via GitHub
ppkarwasz opened a new pull request, #199: URL: https://github.com/apache/logging-log4j-samples/pull/199 Add an `integration-test.yaml` workflow that starts all the available tests for a given Log4j version. This workflow can be started manually, after we close a Staging Maven Reposi

Re: [PR] Enable automatic Android tests [logging-log4j-samples]

2024-10-10 Thread via GitHub
vy commented on code in PR #198: URL: https://github.com/apache/logging-log4j-samples/pull/198#discussion_r1794882604 ## log4j-samples-android/gradlew: ## @@ -17,67 +17,101 @@ # ## -## -## Gradle s

Re: [PR] Upgrades JUnit to version `5.11.2` (logging-log4j2)

2024-10-10 Thread via GitHub
ppkarwasz commented on code in PR #3069: URL: https://github.com/apache/logging-log4j2/pull/3069#discussion_r1794892058 ## log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/junit/package-info.java: ## @@ -20,7 +20,7 @@ * @see org.junit.rules.TestRule */ @Expo

[PR] Adds `maven-args` option to workflows [logging-parent]

2024-10-10 Thread via GitHub
ppkarwasz opened a new pull request, #266: URL: https://github.com/apache/logging-parent/pull/266 We add `maven-args` option to the: * `build-reusable.yaml` workflow. * `merge-dependabot-reusable.yaml` workflow. This parameter sets the [`MAVEN_ARGS`](https://maven.apache.

Re: [PR] Adds `maven-args` option to workflows [logging-parent]

2024-10-10 Thread via GitHub
ppkarwasz commented on PR #266: URL: https://github.com/apache/logging-parent/pull/266#issuecomment-2406063935 These changes were successfully used in [CI run 11281357268](https://github.com/apache/logging-log4j-samples/actions/runs/11281357268) to run the integration tests against `2.24.0`