ppkarwasz commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3066741660
> @ppkarwasz, consider users having their custom instant formatters, some
might even be relying on `{Fixed,Fast}DateFormat`. They will get excited about
`NamedInstantPattern`, wi
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2203224449
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Founda
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2200247276
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (A
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3061510068
@ppkarwasz, consider users having their custom instant formatters, some
might even be relying on `{Fixed,Fast}DateFormat`. They will get excited about
`NamedInstantPattern`, will try to
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2200140855
##
log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/instant/InstantPatternLegacyFormatter.java:
##
@@ -46,7 +46,10 @@ final class InstantPatternLe
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2197893975
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Founda
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2197874778
##
log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/instant/InstantPatternLegacyFormatter.java:
##
@@ -46,7 +46,10 @@ final class InstantPa
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2197547461
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (A
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196942219
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,40 +109,19 @@ private static String readPattern(@Nullab
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196829985
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,40 +109,19 @@ private static String readPattern(@Nullab
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196798155
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,40 +109,19 @@ private static String readPattern(@Nullable fina
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196109011
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,40 +109,19 @@ private static String readPattern(@Nullab
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196059297
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,40 +109,19 @@ private static String readPattern(@Nullable fina
ppkarwasz commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3053765302
> In its current state, deprecated formatters are an island – no
programmatic connections from anywhere. We can safely delete them, yet keep the
legacy formatters configuration k
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3053423599
> > @ashr123, no, absolutely not. They should not be used anywhere in Log4j.
In `2.25.0` we put great effort into deprecating them – see [the release
notes](https://logging.apache.org/l
ppkarwasz commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3053034368
> > @vy should I use `FixedDateFormat.FixedFormat#getPattern` in case of
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` is `true`?
>
> @ashr123, no, absolutely not. Th
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052709896
@vy so what should I do? use
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` as I did before? (which
@ppkarwasz doesn't like)
--
This is an automated message from the Apache
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052700892
> @vy should I use `FixedDateFormat.FixedFormat#getPattern` in case of
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` is `true`?
@ashr123, no, absolutely not. They should not
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052681117
@ppkarwasz can you add the JavaDoc yourself? I'm using another computer and
I have a bit of trouble regarding the signature
--
This is an automated message from the Apache Git Se
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194983126
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundatio
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194969525
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedDatePattern.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194968468
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundat
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194962920
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedDatePattern.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundatio
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194921907
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullable
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194912642
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullab
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052379119
@vy should I use `FixedDateFormat.FixedFormat` in case of
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` is `true`?
--
This is an automated message from the Apache Git Servi
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052340939
> @vy ok, no problem, what else should I do for this PR to be approved?
Nothing more, AFAICT. (Note that the changelog needs to be updated after the
rename.)
--
This is an auto
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052324132
@vy ok, no problem, what else should I do for this PR to be approved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052319657
> > 2. Shall we rename the class from `NamedDatePattern` to
`NamedInstantPattern` in line with our recent wordsmithing efforts in _"instant
formatting"_?
>
> That could be a sens
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194755794
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullable
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194740184
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullab
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194372738
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullable
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194345347
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullab
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2193884497
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullable
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2193385465
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedDatePattern.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundatio
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2193258551
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullab
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2193258551
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullab
ppkarwasz commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3049959107
Hi @vy,
> > So should we expose the class (and bump the version) or hide the class
from the public API. I am slightly pending towards hiding the class.
>
> 1. Is thi
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2192887860
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy if you want I saw that you've edited 0ef914b, so
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3047888098
@ppkarwasz, I have two questions:
> So should we expose the class (and bump the version) or hide the class
from the public API. I am slightly pending towards hiding the class.
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2191829119
##
src/changelog/.2.x.x/exported_named_patterns_into_public_enum.xml:
##
@@ -0,0 +1,8 @@
+
+http://www.w3.org/2001/XMLSchema-instance";
+ xmlns="https://logging
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2191738856
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@ashr123, thanks so much for the prompt reaction. Please
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java’s convention is to distinguish b
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java convention is to distinguish bet
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java convention is to distinguish bet
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java convention is to distinguish bet
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java convention is to distinguish bet
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java convention is to distinguish bet
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java convention is to distinguish bet
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java convention is to distinguish bet
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
@vy:
1. Java convention is to distinguish bet
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182528443
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
I thought the whole point of this exercise is to allow us
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182418054
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
> Disclosing legacy patterns in the binary footpri
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182036233
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##
Review Comment:
Disclosing legacy patterns in the binary footprint will m
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3018677701
@ppkarwasz I see…
From my perspective this PR have 2 purposes:
1. Introduce mechanism for internal reuse and maintain named-patterns more
easly
2. optionally, let other dev
github-actions[bot] commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3018299167
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
56 matches
Mail list logo
