Re: [PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-04 Thread via GitHub
ppkarwasz commented on code in PR #3510: URL: https://github.com/apache/logging-log4j2/pull/3510#discussion_r1980118488 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/StringMatchFilterTest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

Re: [PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-04 Thread via GitHub
ppkarwasz commented on code in PR #3510: URL: https://github.com/apache/logging-log4j2/pull/3510#discussion_r1980124736 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/StringMatchFilterTest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

Re: [PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-03 Thread via GitHub
JWT007 commented on code in PR #3510: URL: https://github.com/apache/logging-log4j2/pull/3510#discussion_r1978203879 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/StringMatchFilterTest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-03 Thread via GitHub
JWT007 commented on code in PR #3510: URL: https://github.com/apache/logging-log4j2/pull/3510#discussion_r1978214026 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/StringMatchFilterTest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-03 Thread via GitHub
vy commented on code in PR #3510: URL: https://github.com/apache/logging-log4j2/pull/3510#discussion_r1977412636 ## log4j-core/src/main/java/org/apache/logging/log4j/core/filter/StringMatchFilter.java: ## @@ -26,232 +27,551 @@ import org.apache.logging.log4j.plugins.Plugin; im

Re: [PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-03 Thread via GitHub
ppkarwasz commented on code in PR #3510: URL: https://github.com/apache/logging-log4j2/pull/3510#discussion_r1977280688 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/StringMatchFilterTest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

Re: [PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-02 Thread via GitHub
JWT007 commented on PR #3510: URL: https://github.com/apache/logging-log4j2/pull/3510#issuecomment-2692717716 NOTE: This PR replaces the 2.x PR #3510 (#3509) for the main 3.x branch. A cherry pick was not possible due to missing API. -- This is an automated message from the Apache Git S

Re: [PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-02 Thread via GitHub
github-actions[bot] commented on PR #3510: URL: https://github.com/apache/logging-log4j2/pull/3510#issuecomment-2692713476 Job Requested goals Build Tool Version Build Outcome Build ScanĀ® build-

[PR] Update StringMatchFilter builder API (#3509) [logging-log4j2]

2025-03-02 Thread via GitHub
JWT007 opened a new pull request, #3510: URL: https://github.com/apache/logging-log4j2/pull/3510 #3509 --- Fix StringMatchFilter Validation * Guard against NPEs * added private constructor to builder * added getText() accessor * add JVerify nullability annotations * adde