ppkarwasz commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1937852187
> @rocketraman, we (almost) always use `Squash and Commit` in Log4j. You
could have done the same for this PR. That is, your PR would appear as a single
commit in `main`. Does
vy commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1937845625
> My preference is generally to sacrifice the GitHub PR cleanliness in favor
of a clean commit history, as the former is transient and the latter is forever.
@rocketraman, we (
rocketraman commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1485358300
##
src/changelog/1.5.0/.release.xml:
##
Review Comment:
All good, the website docs for the tool help add the missing context.
--
This is an autom
rocketraman commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1937349716
> @rocketraman, I would appreciate it if you don't force-push. This renders
all historical conversations detached, since associated commits don't exist
anymore.
@vy
rocketraman merged PR #65:
URL: https://github.com/apache/logging-log4j-kotlin/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-uns
vy commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1485292007
##
src/changelog/1.5.0/.release.xml:
##
Review Comment:
It indeed is not _obvious_. For one, it is set up by `logging-parent` (the
parent of `org.apache.logg
vy commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1937159660
@rocketraman, I would appreciate it if you don't force-push. This renders
all historical conversations detached, since associated commits don't exist
anymore.
--
This is an automa
rocketraman commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1485129153
##
log4j-api-kotlin/src/test/kotlin/org.apache.logging.log4j.kotlin/ThreadContextTest.kt:
##
Review Comment:
Right, I misinterpreted your original co
rocketraman commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1484888098
##
src/changelog/1.5.0/.release.xml:
##
Review Comment:
That's what I thought but when I pushed to the branch without it, the build
failed. I feel l
vy commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1484758241
##
src/changelog/1.5.0/add-coroutine-context-convenience-functions.xml:
##
Review Comment:
This files needs to go into `.1.x.x` folder containing the changelo
rocketraman commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1936213971
> You need to look at the end of the BND report:
@ppkarwasz Thank you, my brain was confused between MAJOR/MINOR so I was
looking at the wrong place in the report. Hav
ppkarwasz commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1935428059
@rocketraman,
You need to look at the end of the BND report:
```
[ERROR] * org.apache.logging.log4j.kotlinPACKAGE
MINOR 1.4.1 1.4.
rocketraman commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1935069351
@vy Have made the updates you suggested, please re-review.
Regarding the build, I have no idea what is going on there. Seems to be
something related to bnd/OSGi. Not s
vy commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1933914103
@rocketraman, the CI is failing, could you also fix the build too, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
vy commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1482725233
##
src/site/index.adoc:
##
Review Comment:
Shouldn't we instead write the docs as as follows?
1. Encourage the usage of `withLoggingContext()` and
`withAd
rocketraman opened a new pull request, #65:
URL: https://github.com/apache/logging-log4j-kotlin/pull/65
We were already able to create logging context for coroutines, but it was
more verbose than it should be
(https://github.com/apache/logging-log4j-kotlin/issues/64). Create some
convenien
16 matches
Mail list logo
