Re: [PR] Fix plugin subclassing in Log4j Docgen [logging-log4j-tools]

2024-05-07 Thread via GitHub
vy merged PR #120: URL: https://github.com/apache/logging-log4j-tools/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [PR] Fix plugin subclassing in Log4j Docgen [logging-log4j-tools]

2024-05-07 Thread via GitHub
vy commented on code in PR #120: URL: https://github.com/apache/logging-log4j-tools/pull/120#discussion_r1592413854 ## log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/generator/internal/TypeLookup.java: ## @@ -42,18 +44,106 @@ private TypeLookup(final Iterable plugi

Re: [PR] Fix plugin subclassing in Log4j Docgen [logging-log4j-tools]

2024-05-07 Thread via GitHub
ppkarwasz commented on code in PR #120: URL: https://github.com/apache/logging-log4j-tools/pull/120#discussion_r1592068351 ## log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/generator/internal/TypeLookup.java: ## @@ -42,18 +44,106 @@ private TypeLookup(final Iterable

[PR] Fix plugin subclassing in Log4j Docgen [logging-log4j-tools]

2024-05-07 Thread via GitHub
vy opened a new pull request, #120: URL: https://github.com/apache/logging-log4j-tools/pull/120 This change fixes #117, which misses `loggers > logger` entry. ### Why is the entry missing? `log4j-core-plugins.xml` contains two entries for `LoggerConfig`: 1. `` 2. ``