jvz commented on PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-2040478427
I think that's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jvz closed pull request #1943: Create metrics API proof of concept
URL: https://github.com/apache/logging-log4j2/pull/1943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
ppkarwasz commented on PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-2039486315
@jvz,
I think we could choose an approach similar to
[`RxJavaHooks`](https://github.com/ReactiveX/RxJava/wiki/Plugins) to provide
instrumentation hooks **without** affecti
ppkarwasz commented on PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-1817175595
> What sort of event would be published here that could correspond to a
counter? That's a push-based mechanism itself.
For me an event is just any kind of object: in this c
jvz commented on PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-1806617623
Looking through https://opentelemetry.io/docs/specs/otel/logs/ and OTel in
general, it seems like we should have support for some of this directly. I
don't think we need to implement a
jvz commented on code in PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#discussion_r1390085402
##
log4j-core/src/main/java/org/apache/logging/log4j/core/metrics/MetricManager.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
jvz commented on PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-1806615678
What sort of event would be published here that could correspond to a
counter? That's a push-based mechanism itself.
--
This is an automated message from the Apache Git Service.
To r
jvz commented on code in PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#discussion_r1385665022
##
log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncQueueFullPolicyFactory.java:
##
@@ -64,17 +79,22 @@ public class AsyncQueueFullPolicyFactory {
jvz commented on code in PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#discussion_r1385662440
##
log4j-core/src/main/java/org/apache/logging/log4j/core/metrics/MetricManager.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
vy commented on code in PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#discussion_r1385473711
##
log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncQueueFullPolicyFactory.java:
##
@@ -64,17 +79,22 @@ public class AsyncQueueFullPolicyFactory {
jvz commented on PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-1799712810
Or to be more specific, instead of creating yet another global variable, I
had to refactor some code to apply inversion of control a little bit. If we
were adapting Log4j to work via S
jvz commented on PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-1799681779
The builder updates are related to adding dependency-injected values. I did
not include any concrete implementations of the metrics API yet, but I updated
some areas that are supposed
rgoers commented on PR #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-1793637486
This PR has me very confused. I do see the new metrics package but the vast
majority of this PR seems to have nothing to do with metrics. Could you please
separate out the builder
jvz opened a new pull request, #1943:
URL: https://github.com/apache/logging-log4j2/pull/1943
Related to #1344, this demonstrates a proof of concept metrics API to begin
using. This implements the metric added in #1927, though I think we should be
defining several more metrics beyond that.
14 matches
Mail list logo
