Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2058762386 @remkop, > @ppkarwasz I don't think there is a garbage-free way to do Reactive streams. I would keep this simple and not worry about any garbage-free use cases. Tha

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz closed pull request #2442: Add support for thread context map propagation URL: https://github.com/apache/logging-log4j2/pull/2442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
remkop commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2058746052 > Is there any usage for context propagation in the "garbage-free world"? My guess is that switching threads using Reactive streams or similar provides too much garbage for it to be

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2058655973 @remkop, Is there any usage for context propagation in the "garbage-free world"? My guess is that switching threads using Reactive streams or similar provides too much gar

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1566981486 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-15 Thread via GitHub
rgoers commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1566715733 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-15 Thread via GitHub
vy commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1566341055 ## src/changelog/.2.x.x/add_extended_thread_context.xml: ## @@ -0,0 +1,7 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="http://logging.apache.org/lo

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-15 Thread via GitHub
vy commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1566341055 ## src/changelog/.2.x.x/add_extended_thread_context.xml: ## @@ -0,0 +1,7 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="http://logging.apache.org/lo

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
rgoers commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1563689177 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
jvz commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1563251355 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2051349123 I realized now that in this PR I assume that the `Object` returned by `saveMap` will be used **only** once in a `restoreMap` call. This assumption might be too restrictive for co

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2051291811 > Son of a gun, I forgot to hit submit so none of my comments have been viewable. It happens to me all the time or even I hit it, but a network problem prevents the commen

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1562164031 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-11 Thread via GitHub
ppkarwasz commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1562087991 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/DefaultThreadContextMap.java: ## @@ -231,4 +231,21 @@ public boolean equals(final Object obj) {

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1552486927 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[PR] Add support for thread context map propagation (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz opened a new pull request, #2442: URL: https://github.com/apache/logging-log4j2/pull/2442 Adds a new `ExtendedThreadContext` SPI class to help external libraries with an efficient propagation of the `ThreadContextMap`. Currently integrators can retrieve and set the context m