Re: [PR] Add TZ offset check [logging-log4cxx]

2025-01-28 Thread via GitHub
rm5248 merged PR #464: URL: https://github.com/apache/logging-log4cxx/pull/464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [PR] Add TZ offset check [logging-log4cxx]

2025-01-28 Thread via GitHub
swebb2066 commented on code in PR #464: URL: https://github.com/apache/logging-log4cxx/pull/464#discussion_r1931488146 ## src/main/cpp/simpledateformat.cpp: ## @@ -599,38 +599,29 @@ class RFC822TimeZoneToken : public PatternToken else

Re: [PR] Add TZ offset check [logging-log4cxx]

2025-01-28 Thread via GitHub
swebb2066 commented on PR #464: URL: https://github.com/apache/logging-log4cxx/pull/464#issuecomment-2618155332 I now see that a character literal in a wchar_t context is a wchar_t. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Add TZ offset check [logging-log4cxx]

2025-01-27 Thread via GitHub
swebb2066 commented on code in PR #464: URL: https://github.com/apache/logging-log4cxx/pull/464#discussion_r1931487787 ## src/main/cpp/simpledateformat.cpp: ## @@ -599,38 +599,29 @@ class RFC822TimeZoneToken : public PatternToken else

Re: [PR] Add TZ offset check [logging-log4cxx]

2025-01-27 Thread via GitHub
swebb2066 commented on code in PR #464: URL: https://github.com/apache/logging-log4cxx/pull/464#discussion_r1931487787 ## src/main/cpp/simpledateformat.cpp: ## @@ -599,38 +599,29 @@ class RFC822TimeZoneToken : public PatternToken else

[PR] Add TZ offset check [logging-log4cxx]

2025-01-27 Thread via GitHub
rm5248 opened a new pull request, #464: URL: https://github.com/apache/logging-log4cxx/pull/464 Add a TZ offset check to make sure that our timezone is in a reasonable range. Also clean up the SimpleDateFormatter slightly to make the code more clear. -- This is an automated message from